LP#1798187 - Support CRLF and LF format for item status import files Testing Plan: Before patch, try to import a file in CRLF end of line format that includes leading and trailing spaces, empty lines, lines of just spaces or barcodes with spaces. The import will fail to load those items and will stop processing when it hits certain situations. After patch, try to import a file in CRLF EOL format that includes barcodes with trailing spaces, leading spaces, barcodes with spaces, and/or empty lines. The import will load all barcodes. Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1775639: Refresh required to see Patron Credit reload patron data when applying a payment if the payment will change the patron's credit forward balance. To test ------- [1] Bill a patron, then make sure that the "Convert Change to Patron Credit" checkbox is checked. Pay bill with more than the total balance. Note that the Credit Available amount in the billing summary does not change. Refresh the page. [2] Bill a patron, then use the patron credit added in step 1 to pay off the bill. Note that again, the Credit Available amount does not change. [3] Apply the patch and repeats steps 1 and 2. This time, the Credit Available field should get updated. Signed-off-by: a. bellenir <abelleni@grpl.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical Statistical categories will be alphabetized first by library and then by category. The entires within each category will also be alphabetized. Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Cesar Velez <cesar.velez@EquinoxInitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1440890: add vandelay_queue to the types of containers retrieved by batch edit To test ------- [1] Perform a batch bibliographic record import, then add the import queue to a new bucket. [2] In the web staff client, go to Cataloging | Batch Edit. [3] Note that the bucket created in step 1 does _not_ appear in the bucket selector on the batch edit page. [4] In the web staff client, go to the record bucket and hit the Batch edit button. [5] Note that the bucket created in step 1 does _not_ appear in the bucket selector on the batch edit page. [6] Apply the patch and repeat steps 2-3. This time, the bucket should appear in the selector. [7] Repeat steps 4-5. This time, the bucket should appear in the selector (and be the active choice). Signed-off-by: Rogan Hamby <rhamby@esilibrary.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1760599: Only show merge records action when multiple bucket records selected To test: 1) Create a bucket. 2) Select one record from your bucket. Right-click on your record or click on the Actions drop-down. 3) Note that "Merge Selected Records" is clickable. 4) Apply this commit. 5) Repeat steps 2-3. Note that "Merge Selected Records" is no longer clickable, unless you select two or more records. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1790896: Receipt Errors with invalid emails The attempt at belt-and-suspenders checking for a valid email for use in the has_email template field sadly causes the JS to trip over said suspenders if there is a value in the field but it doesn't contain a '@'. The raw return from "".match() (either an array or null) is enough to do the right thing when converted into a Boolean and doesn't cause the same problems. To test ------- [1] Set up a patron record with an invalid email address, e.g., one that lacks the '@' character. [2] Check out an item the patron, then from the Items Out tab, print an item receipt. [3] Note that nothing happens and an error is logged in the browser console. [4] Apply the patch and repeat step 2. This time, a receipt should be generated. Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Lp 1768987: Use FindBin in 24-sql-gettext-unique.t. Use FindBin in the 24-sql-gettext-unique.t test file so that it can be run from directories other than Open-ILS/src/perlmods. To test ------- [1] Apply the patch. [2] From the root of the Evergreen checkout, run prove Open-ILS/src/perlmods/t/24-sql-gettext-unique.t [3] Verify that the tests pass. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Docs: Fix list formatting in recent release notes Single list items that wrap across multiple lines accidentally start each line with a bullet. This commit removes the extra bullets. Signed-off-by: Remington Steed <rjs7@calvin.edu>
LP#1796942 Treat VISA SIP payments as credit card Treat sip_payment_type 01 (VISA) as a credit_card_payment. Previously, we only handled payment type 02 (credit card) and 01 fell through to be treated as a cash_payment. Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1704819 Fine generator avoids int() rounding Avoid using the Perl int() function for rounding in the fine generator, since it can have unexpected outcomes. For example: $ perl -e 'print "230 = " . int(100 * 2.30) . "\n"' 230 = 229 Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1816679 Match Set Type selector options Provide a canned set of options for Vandelay => Create/Modify Match Set => Match Set Type of 'biblio', 'autority', and 'serial'. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1693580 Authority create/update API repairs Fixes issues with the authority record create and update open-ils.cat API calls, where internal function calls were not passed the correct values. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Pearl <dpearl@cwmars.org>
LP1693580 Marc editor notify and API changes 1. Indicate in the interface when a bib/auth MARC record edit failed or succeeded. 2. Handle permission failures on MARC edit by displaying the permission override dialog. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Pearl <dpearl@cwmars.org>
LP1735754 - WGAC Compliance for Advanced Search In compliance with WGAC standards, the html valign attributes have been removed from Open-ILS/src/templates/opac/parts/advanced/search.tt2 Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Docs: fix uneven lengths of code delimiter blocks This continues the work that Dan Scott started, fixing more unmatching start/end lines around code blocks, as revealed by the sad-looking HTML output of asciidoctor. This commit also fixes a few heading underlines of the wrong length. Signed-off-by: Remington Steed <rjs7@calvin.edu>
LP#1029601: Prevent duplicate holds from double clicks Double clicking on hold submit buttons causes multiple holds to be generated. This commits adds code to disable the Submit button(s) after the first click, so subsequent clicks don't "work" in unintended ways. Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com>
lp1538678 MARC edit warning prompt translateable strings - Define "There is unsaved data in this record." as a translateable string. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Changes to be committed: modified: Open-ILS/src/templates/staff/cat/share/marcedit_strings.tt2 modified: Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js Signed-off-by: Bill Erickson <berickxx@gmail.com>
lp1538678 Apply Warning Prompt when leaving dirty MARC editor - Check for unsaved user input when leaving the Create New MARC Record UI, and warn if it exists. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Changes to be committed: modified: services/marcedit.js Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1817601 MARC Flat Text Editor Monospace Font Use a fixed width font in the MARC flat text editor, consistent with the fonts used for the non-flat-text editor. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>