LP#1635386 Clarify and simplify row highlighting code The existing code had a few functional problems for me. In the process of fixing them, I decided it best to also apply a number of small refactorings. Here is a list of changes in rough order of significance: -Made the new CSS classes test and apply once per row rather than once per cell -Fixed the test case for overdues: we now just look for no checkin-time + no lost/long-overdue stop-fines (matches XUL test) -Made the color and icon tests totally consistent, and also simplified where possible -Made the widened configuration header style (to accommodate status column) functional again (it was using old 'statusicon' class) -Made row highlight colors '!important' to avoid bad interactions with alternating row color styles -Changed status-cell (and statusCell) to status-column (and statusColumn) for a little extra clarity -Changed nested function name from 'rowClass()' to 'apply()' for greater code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead have 'rowClass.apply()') -Removed some unused variable assignments from grid.js -Cleaned up a few field attributes for necessity and consistency Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1635386: Improve contrast for colors used in Bills interface The contrast between cell contents and background colors did not meet WCAG standards. This commit provides adequate contrast to meet AA level of WCAG standards. The red and dark red background colors are similar to what we saw in the XUL client. The orange for long overdue is much lighter. Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
lp1635386 Items Column & Styles for Bill Item Status - CSS classes for red, dark red, and orange eg-grid-cells. - New parameter for eg-grid 'rowClass' to take an object with a function to set the class of a cell, allowing such customizations as coloring based on item fields. - Implementation of 'rowClass' on the Patron Bills interface to display colors indicating current Fines Stop reason, based on XUL client. - New parameter for eg-grid 'statusCell' to take an object with a function to programattically add status icons to a new "Status Icon" column. Said column requires a boolean in the object in order to display. - Implementation of 'statusCell' on the Patron Bills interface to display glyphicons based on if the bill is for a circ that is lost, overdue, or long overdue. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Changes to be committed: modified: Open-ILS/src/templates/staff/circ/patron/t_bills_list.tt2 modified: Open-ILS/src/templates/staff/css/style.css.tt2 modified: Open-ILS/src/templates/staff/share/t_autogrid.tt2 modified: Open-ILS/web/js/ui/default/staff/circ/patron/bills.js modified: Open-ILS/web/js/ui/default/staff/services/grid.js Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1699838: Stamping upgrade script for default pickup lib YAOUS Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1699838 Scale back settings for staff-based hold placement For now, we will add just one new setting to optionally restore the old behavior. In the absence of a 'preferred pickup location', the staff form will default to the staff workstation OU. Also, add setting to seed data. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Conflicts: Open-ILS/src/sql/Pg/950.data.seed-values.sql
LP1699838 - add YOUSes for defaulting hold pickup locs Add a YAOUS... err make that two, to control how staff-placed holds default the pickup library. Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1693036: Simplify template, cleanup preview data This commit corrects a few minor problems, and also attempts to simplify and cleanup the template. The changes include: - Adding the missing "ident_type2" field to the template and JS - Adding missing sample data for "county" - Moving "postal code" closer to the standard location (at the end of the address) - Fixing typos, and making "Claims..." labels more consistent - Minor cleanup of the sample data - Removing template comments that list available variables, because this template is simpler than most, intended to print everything Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1693036: follow-up: fix printing of daytime phone number This patch corrects how the 'day_phone' field should be referred to in the print template. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
lp1693036 Patron Editor Print Data - Add Print button to Patron Editor. - Add Patron Data print template. - Add additional print template dummy data needed for Patron Data template. - Implement print functionality for Patron registration/edit data. Signed-off-by: Kyle Huckins <khuckins@catalyte.io>/ Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1758322: Fix lp1731960_test_preserving_bookbag_entries test A typo inserted the incorrect record number for the lp1731960_test_preserving_bookbag_entries. This patch fixes the typo. Thanks to Jason Boyer for spotting the problem! Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1731960: Stamping upgrade script for preserve book bags on bib merge Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1731960-preserving book bag entries with new values during bib merge The asset.merge_record_assets() removes bib records from containers when merging and deleting the record as appropriate but bib containers with the btype of 'bookbag' (used as reading lists) should instead be updated to the new bib record. Includes Pgtap test. Signed-off-by: Rogan Hamby <rhamby@equinoxinitiative.org> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Conflicts: Open-ILS/src/sql/Pg/999.functions.global.sql
LP#1755502 Fix hold user test Now that we are fleshing this field, we need to dig a little deeper for the 'id' to test if we are the same user. To test ------- [1] Set up a patron with a hold request and with a item on the hold shelf that fills the hold. [2] Check out the item to patron. Note that you will get a ITEM_ON_HOLDS_SHELF alert, even though the item is on hold for that patron. Cancel the alert. [3] Apply the patch and repeat step 2. This time, the checkout will proceed. [4] Set up another patron with a hold request and an item on the hold shelf, then checkout it at to a _different_ patron. Verify that the ITEM_ON_HOLDS_SHELF alert appears. This patch also fixes test failures caught by the 19-lp1306666-abort-transit-copy-status.t live test. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1728147: more tweaks to grid * Make paths to expire_time and cut_in_line more concise * Add SMS Carrier column back * Tweak labels of the patron first and last name columns * Ensure that the "Call Number" column continues to be sortable by normalized call number label. Note that due to a quirk of egGrid, which doesn't currently have a way to specify that a column always be retrieved by a fielder query but /not/ be directly available as a displayable column, we also need a "Call Number Label" column at the moment. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1728147: correct fleshing of staff hold column This patch fixes the test (ahr.usr is fleshed, but not ahr.requestor) and ensures that the value is cached correctly. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1728147: Add patron's first/last name and Alias column These were also missing from the Holds Pull grid. This patch also corrects the determination of whether a hold was staff-placed or not. Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>