LP1896285 Batch mark item missing serialized Process batches of items one at a time when marking them lost to avoid sending too many parallel requests to the server. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1896285 Add new items avoids looping settings lookup Refactor AngJS volcopy item add actions so it makes the minumum necessary settings API calls for default copy status. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1896285 Patron search add to bucket serialize Add a batch of patrons to a bucket one patron at a time to avoid overwhelming the server with bucket item create requests and potentially exhausing the open-ils.actor service. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1778522 Precat item creation should be more intentional Precat items can be created before all of the info is entered. The dialog autofocuses the title field, so a double barcode scan will populate the title field and createt the precat without giving an opportunity to fill in the other fields. This prevents form submission unless you click the Precat Checkout button. To test: 1. Try to check out a barcode that doesn't exist to any patron 2. On the precat dialog, enter a value into the title field 3. Note the precat is created 4. Apply patch 5. Repeat steps 1-3 and note the precat isn't created until the Precat Checkout button is clicked Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1887852 Pending patron passwords aren't initially set to phone # If a patron self registers with a phone # and the org unit setting to use the phone for the password is true, when the pending patron stage loads the password is initially random instead of the last 4 digits of the phone #. This branch sets the password to the last 4 digits of the phone when the patron stage loads if the phone is set and the org unit setting to use the phone # for the password is true. To test: 1. Set org unit settings for allow patron self-registration and show day_phone on registration to true 2. Go to the OPAC and request a library card (include phone #) 3. Login to the staff client, Circulation->Pending Patrons and load the patron 4. Note the password is random 5. Load patch and repeat steps 3-4 6. Note the password is the last 4 digits of the phone # Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Mike Risher <mrisher@catalyte.io> Signed-off-by: Jason Stephenson <jason@sigio.com>
LP1904220: Fix Booking Service Check Instead of trying to tell AppService which router we want to talk to and confusing it, just tell it we want to talk to a router and let it do its thing. Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1900184 Patron password use phone not working An early return statement in extract_hold_notify() was removed in 7e92293 and added back in ddf5b4b3, so props set at the end of that function used in future comparisons never get set. This re-removes the return statement and sets the local notify variable to default string values so the rest of the function can play out. To test: 1. Set org unit setting: "Patron: password from phone #" to TRUE at the top context location 2. Circulation->Register Patron 3. Type 123-456-7890 into the Daytime Phone field and press tab 4. Note: the password field isn't updated to the last 4 digits 5. Apply patch and repeat steps 6. Note: the password field updates to the last 4 digits Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Garry Collum <gcollum@gmail.com>
Revert "Repair Permission Seed Data" This reverts commit 46a5f66a146e1916900fb2de605413bf83aea972. The original commit was mistakenly backported too far, these permissions do not apply to 3.5. Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
LP#1508208: live_t/ test for this branch Includes timing information for the checkin, but pass/fail is not predicated on it. Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1508208: Only look at holds that age protection allows When hold capture is attempted, we look at (currently) the first 100 holds ordered by Best Hold Sort Selection Order. If a very long list of holds are targetting an age-protected item then op capture may not have a chance to see a viable hold for that copy. This commit attempts to take into account the age protection currently set for the copy by restricting the holds to just those where the hold-copy-map proximity is less than or equal to the maximum proximity allowed by the age protection. This works now because we store the hold proximity in the hold copy map, where we did not before. Being based on the hold-copy-map proximity, which is calculated proximity, means this is an approximation and the final hold capture logic may still reject some holds for the copy. Likewise, this does not entirely eliminate the possibility that there may be a better hold to capture the copy for if the in-range set of holds is very, very long, but this should allow hold capture to proceed if even imperfectly. If no age protection is set for the copy, the current behavior (looking at all holds) is maintained. Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1325704: Update Items-Out YAOUS descrip for web client Three settings refer to the "top" and "bottom" lists on the XUL client Items Out screen. With the web client, these have become three named tabs. This commit updates the setting descriptions in the seed data so they reflect the new design. I also attempted to make the meaning of the values more clear by labeling the two subsettings as "A" and "B". Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1893463: Protect against null emails Unique indexes on nullable columns will allow multiple conceptually unique rows if the nullable columns are, in fact, NULL because NULL does not equal itself. This commit uses COALESCE to make sure that the nullable email column in the reporter.schedule table gets a value of the empty string for the purposes of the unique index. The upgrade script now also takes this into account and ignores the email column. Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>