LP1830432 Uniqify reported org IDs / sandbox tweaks Err on the side of caution and ensure the org family selector always reports a unique list of org unit IDs. Sandbox language tweaks. Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1830432: Make the org-family-select reusable This commit removes Bill Erickson's automagic org unit select with +Ancestors and +Descendants checkboxes from the admin-page component, and gives it a component of its own, called <eg-org-family-select>. This commit also makes it compatible with [(ngModel)], reactive forms, and any custom Angular validators you might want to throw at it. Examples of all three are available in the sandbox. Also includes some component tests. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1830394: remove console noise from the holdings editor This patch removes browser console noise that occurs (among other places) when moving a working item to the completed list in the holdings editor TypeError: "$scope.working.MultiMap[keys[i]] is undefined" hasMulti https://evergreen.example.org/js/ui/default/staff/cat/volcopy/app.js:1203 ... To test ------- [1] Open the holdings editor to add or edit an item, then open the browser debug console. [2] Make a change and move the item from working to complete. Note that the error message above shows up repeated in the console log. [3] Apply the patch and repeat steps 1 and 2. This time, the errors should not appear. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1831781: tweaks to eg-help-popover - Wrap the image in a button; this removes the need for setting tabindex and makes the cursor display as a pointer when it is over the popover. - Add aria-label attributes - add some usage comments Thanks to Jane Sandberg for the feedback that inspired this patch. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP#1831781: add eg-help-popover Angular component Usage: <eg-help-popover helpLink="https://youtu.be/dQw4w9WgXcQ" helptext="Helpful msg. Optional link."></eg-help-popover> Additional placement attributes accepted. Basically wraps ng-bootstrap's https://ng-bootstrap.github.io/#/components/popover/examples#basic To test ------- [1] Go to the Angular sandbox page (/eg2/en-US/staff/sandbox) and verify functioning of the popovers, which display question marks. Sponsored-by: MassLNC Sponsored-by: Georgia Public Library Service Sponsored-by: Indiana State Library Sponsored-by: CW MARS Sponsored-by: King County Library System Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Correct False Positive on Offline Test Now that we have filenames with hashes in them the likelyhood of finding the numbers 4, 0, and 4 not as an http status are much higher, leading to a false negative on tests that look at the http status code. Looking for the string ' 404 ' narrows the search to actual 404 errors (at least until we have a file that's exactly 404 bytes long in the offline interface). Signed-off-by: Jason Boyer <JBoyer@library.in.gov> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
lp1735835 Transfer Bucket Contents to Pending - Add new option in Copy/Record buckets to transfer select items to Pending Copy/Records. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> modified: Open-ILS/src/templates/staff/cat/bucket/copy/t_view.tt2 modified: Open-ILS/src/templates/staff/cat/bucket/record/t_view.tt2 modified: Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js modified: Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1759343 Clean up data seed values 1) Add missing translation wrapper for new annotatepayment setting. 2) While we are at it, try to stem the proliferation of workstation setting INSERT chunks. (More could be done here...) Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1759343 Fix annotate payment setting name This setting was added to the database with the 'eg.' prefix, but in the code it was not used. The end effect was that the setting likely worked, but was not saved in the way expected. This makes the setting name in the code match the DB. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1833080: have eg-bool recognize IDL bool string values This patch updates eg-bool so that it can format both true Boolean and IDL bool string values (i.e., 't' or 'f'). Prior to this patch, IDL bool values would always be rendered as 'Yes'. This patch relaxes the type restriction on the value setter and getter; unfortunately, there's no way to overload the setter or making it accept (say) boolean|string.A This patch also supplies some unit sets. To test ------- [1] View an Angular grid that has Boolean fields. The Copy Status server admin page is a good one. [2] Note that the boolean values are all rendered as "Yes". [3] Apply the patch and repeat step 1. This time, false values should be displayed as "No". [4] Verify that 'npm run test' for the Angular app passes. Sponsored-by: PaILS Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1823041 Confirm dialog returns true/false repairs The new Observable-driven confirm dialogs return true or false depending on the user response (or nothing if dismissed), so the calling code needs to verify the user confirmed the request before continuing. Removed an unused confirm dialog import for clarity. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1823041 Observable dialogs repairs and cleanup Fixes a few instances where dialog.open() calls did not return Observables. Replace a number of calls to the now deprecated dialog.dismiss() with calls to dialog.close(). Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1823041 Remove unintentially merged code blocks A chunk of Angular code which was removed before merging this LP was added back during the rebase/merge process. This removes the errant code. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1823041: Converting new dialogs to observables Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1823041 Angular dialogs return observables Dialog.open() now returns an observable to the caller. This allows dialogs to pass 0 or more success events, error events, and close events each as descrete actions to the caller. Existing dialogs are updated to expect an Observable response to .open(). Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>