LP#1334693 ./configure avoid osrf_config without core Avoid the check for and use of osrf_config during Evergreen ./configure when run with --disable-core. This allows the staff client to be built and, in general, for make_release to be run on a machine that does not have opensrf installed (or has multiple versions). Signed-off-by: Bill Erickson <berick@esilibrary.com>
LP#1303544 Trim junk from the ISBN in record summary When asserting that we are publishing an ISBN, move the "(pbk.)" and similar such matter outside of the schema.org <span property="isbn"> element. See "The walking dead" in the sample dataset for an example. Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1326983: excluded fulfilled holds when adding hold_request.shelf_expires_soon events This patch adjusts the example A/T filter for the hold_request.shelf_expires_soon hook to exclude hold requests that are already marked as fulfilled. This saves time creating events that would immediately be marked as invalid per the HoldIsAvailable validator. It also addresses an issue for large databases that have lots of fulfilled holds wherein hold_request.shelf_expires_soon events can fail to be added at all due to a cstore timeout. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1296937: move the $force_bc parameter of ->charged_items() to an implementation method Argubably, the $force_bc parameter of OpenILS::SIP::Patron->charged_items() method exists solely as an implementation convenience for the renew-all code. Consequently, this patch removes the $force_bc parameter from the public interface for charged_items() and spins it off into a new implementation method. This patch should be applied at the same time that a reversion of SIPServer commit c97d64412bc is applied. Note that a user who upgrades SIPServer without upgrading Evergreen to a version that contains this patch will end up in a situation where the code that counts active loans for the patron information response will fetch the loans using $force_bc set to true; this works only by coincidence. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jeff Godin <jgodin@tadl.org>
LP#1321017: Order constituent records by quality Previously, in some cases (often needlessly) we ordered constituent records within a metarecord by a combination of type/form/blvl. This is not only of little use, but also expensive. Instead, order them by the bib's calculated quality, which takes type/form/blvl into account already. Also, use the new metabib.record_sorter to find the title tie-breaker instead of using the view-of-a-view-of-a-view mrd compatability shim. The net result is several orders of magnitude speed increase for constituent record retrieval. In particular, this resolves a problem where doing a SIP2 patron information lookup and requesting a list of holds could cause a timeout if the patron has one or more metarecord holds. This patch also causes the format filter parameter of the following methods to be ignored: open-ils.search.biblio.metarecord_to_records* open-ils.search.biblio.metarecord.mods_slim.batch.retrieve* open-ils.search.biblio.metarecord.mods_slim.retrieve* Since the only use of the format filter was in JSPac code, and since the record attributes mechanism has changed considerably, this removal should be considered intentional. Note that this patch includes a squash of a minor follow-up by Galen Charlton to remove variables made unused by the original patch. Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> (for minor follow-up by Galen) Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1310751: Reorder query-building wrapper for QueryParser In order to make sure that the transparent boolean pushdown does not cause filters and modifiers to end up deeply embedded in the query tree, we put them at the front. This is a short-term fix. Long-term, we need to make use of the floating subquery syntax ( {{ ... }} ) available in QueryParser, which is designed to address the semantic separation between what the user types into the search box, and the various UI widgets that can add query clauses. Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1322303 cleanse backdate for checkin overdue voiding Passing raw backdates, particularly from offline transactions, which have a space between the date and time, to DateTime::Format::ISO8601->parse_datetime results in "Invalid date format:" errors. Pass the date through the cleanse routine first. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Ben Shum <bshum@biblio.org>
LP#1314920 change the desc for the org hiding setting so that it references physical_loc instead of ol Signed-off-by: Jason Etheridge <jason@esilibrary.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remove buggy, unused function get_leaders_from_usergroup Recent editing and testing of get_leaders_from_usergroup() uncovered an unrelated bug which renders the function useless (it returns all group members, not just the leader). It wasn't previously caught because Evergreen has no apparent references to this function. This commit removes the unused function. Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu>