Add ngSanitize for AngJS icon ARIA attributes Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1818086 Accessible text for AngJS status icons Adds screenreader-only text and title attributes (for tooltips) to the glyphicons used in the patron bills status column. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1865062 Add Credit Card Approval Code to Payment Receipt Makes approval code available to Bill Payment print template (when relevant). Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Llewellyn Marshall <lbmarshallv.ncdcr@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP#1772955: Only include xacts with balance in summary This commit adds a new view and IDL definition that shows the total owed/paid/balance for transactions that have a balance other than 0. This new view is used in the patron summary bar, and access is provided wherever the all-open-transactions version is available in case we want to move to the new one elsewhere. Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
LP1774892 stripe elements This commmit changes the OPAC to use https://js.stripe.com/v3/ instead of https://js.stripe.com/v2/ for processing payments through Stripe. Additionally, it disables the "internal" credit card form in the staff client when Stripe is the payment processor (or if the processor is not set at all), as that does not currently work. It also does not replace Business::Stripe's use of the "Charges API" with the newer "Payment Intents" API on the backend, but credit card details are still not sent to the Evergreen server. Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP 1772053: Cleanup Dan's code. Mostly whitespace cleanup, but I did restore a line or two that appear to have been accidentally deleted. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP 1772053: Add Missing Fields to Print Templates Almost complete implementation for LP1772053. To be done: items relating to call numbers, prefixes and suffixes for Hold Pull Lists and Transit Slips. Signed-off-by: Daniel Pearl <dpearl@cwmars.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1781274 Fix floating point issue preventing transactions from closing Paying multiple bills with a single payment can lead to some transactions not closing because of floating point math inaccuracies. This branch resolves the issue by limiting pending payment amounts to 2 decimal places. The bug can be reproduced using grocery bills as follows. Retrieve a patron that owes no money. Add a billing of $.90 Add a billing of $.10 Select both billings Enter $1 in payment received and Apply the payment Click on History in the billings screen. Turn on the Total Billed and Transaction Finish Time column and note that the $.10 bill has zero balance owed, but does not have a transaction finish time. To test: Use the steps above to reproduce, noting the lack of Transaction Finish Time. Apply the patch. Use the same steps above and note that the post patch payments resulted in both transactions getting a Transaction Finish Time. Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
LP#1811132: add Debit Card payment type Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Ruth Frasur <rfrasur@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
lp1792995 wrong row details shown on billing grid When using the bill grid, if one right clicks on a row and views full details one is taken to the first selected row. Make the UI show full details for the row being right clicked on. If no row is clicked on show first selected item's details. Signed-off-by: Mike Risher <mrisher@catalyte.io> Changes to be committed: modified: Open-ILS/web/js/ui/default/staff/circ/patron/bills.js modified: Open-ILS/web/js/ui/default/staff/services/grid.js Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1841089 Apply button in Patron Bill History screen is in confusing location It's possible to miss the apply button for the date range in bill history because it's located before the datepickers. The interface also allows invalid date ranges. This removes the apply button and watches the start and finish dates in the bill history and payment history controllers. If it's not first init and they are valid date objects in a valid date range, the grid refreshes with the new date range query. If start > finish they are set equal to each other to force a valid range. To test: 1. Apply patch 2. Bring up a patron with bills and payments (or add bills and payments) 3. Under the Bills tab click History 4. Change the date range and observe that the grid refreshes 5. Try to set the start date past the finish date and vice versa Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1759343 Fix annotate payment setting name This setting was added to the database with the 'eg.' prefix, but in the code it was not used. The end effect was that the setting likely worked, but was not saved in the way expected. This makes the setting name in the code match the DB. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1759343: Bills Annotation Persistance Make the Annotate option on the patron Bills page persistant and a workstation setting. Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1775639: Refresh required to see Patron Credit reload patron data when applying a payment if the payment will change the patron's credit forward balance. To test ------- [1] Bill a patron, then make sure that the "Convert Change to Patron Credit" checkbox is checked. Pay bill with more than the total balance. Note that the Credit Available amount in the billing summary does not change. Refresh the page. [2] Bill a patron, then use the patron credit added in step 1 to pay off the bill. Note that again, the Credit Available amount does not change. [3] Apply the patch and repeats steps 1 and 2. This time, the Credit Available field should get updated. Signed-off-by: a. bellenir <abelleni@grpl.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1790896: Receipt Errors with invalid emails The attempt at belt-and-suspenders checking for a valid email for use in the has_email template field sadly causes the JS to trip over said suspenders if there is a value in the field but it doesn't contain a '@'. The raw return from "".match() (either an array or null) is enough to do the right thing when converted into a Boolean and doesn't cause the same problems. To test ------- [1] Set up a patron record with an invalid email address, e.g., one that lacks the '@' character. [2] Check out an item the patron, then from the Items Out tab, print an item receipt. [3] Note that nothing happens and an error is logged in the browser console. [4] Apply the patch and repeat step 2. This time, a receipt should be generated. Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1776020 Add pref names to bills and items-out receipt templates Add support (with inline docs) for pref_.* name fields in Bills Current/Historical/Payment templates and the patron Items Out template. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1782631: Stop Styling Grocery Bills as Overdues Only checking for the lack of a value in the checkin_time field causes grocery bills to still trigger the bill colorizing feature, but because they have no stop_fines reason they're colored the same as an overdue item. This patch requires the presence of a due_date field before coloring a bill row. Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1635386: Restore to xul colors and remove colors from class names This commit restores the xul display where overdue items were highlighted in red and long overdue items were highlighted in orange. Also removes the colors from the class names since people may decide to use totally different colors or style the rows in different ways. Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1635386 Clarify and simplify row highlighting code The existing code had a few functional problems for me. In the process of fixing them, I decided it best to also apply a number of small refactorings. Here is a list of changes in rough order of significance: -Made the new CSS classes test and apply once per row rather than once per cell -Fixed the test case for overdues: we now just look for no checkin-time + no lost/long-overdue stop-fines (matches XUL test) -Made the color and icon tests totally consistent, and also simplified where possible -Made the widened configuration header style (to accommodate status column) functional again (it was using old 'statusicon' class) -Made row highlight colors '!important' to avoid bad interactions with alternating row color styles -Changed status-cell (and statusCell) to status-column (and statusColumn) for a little extra clarity -Changed nested function name from 'rowClass()' to 'apply()' for greater code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead have 'rowClass.apply()') -Removed some unused variable assignments from grid.js -Cleaned up a few field attributes for necessity and consistency Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
lp1635386 Items Column & Styles for Bill Item Status - CSS classes for red, dark red, and orange eg-grid-cells. - New parameter for eg-grid 'rowClass' to take an object with a function to set the class of a cell, allowing such customizations as coloring based on item fields. - Implementation of 'rowClass' on the Patron Bills interface to display colors indicating current Fines Stop reason, based on XUL client. - New parameter for eg-grid 'statusCell' to take an object with a function to programattically add status icons to a new "Status Icon" column. Said column requires a boolean in the object in order to display. - Implementation of 'statusCell' on the Patron Bills interface to display glyphicons based on if the bill is for a circ that is lost, overdue, or long overdue. Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Changes to be committed: modified: Open-ILS/src/templates/staff/circ/patron/t_bills_list.tt2 modified: Open-ILS/src/templates/staff/css/style.css.tt2 modified: Open-ILS/src/templates/staff/share/t_autogrid.tt2 modified: Open-ILS/web/js/ui/default/staff/circ/patron/bills.js modified: Open-ILS/web/js/ui/default/staff/services/grid.js Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dawn Dale <ddale@georgialibraries.org>