LP #1906859: Create carousels from items To test carousel creation from item buckets: 1. Create an item bucket 2. Add a variety of items to your bucket 3. Select all items 4. Open the buckets menu 5. Under items, select "Create Carousel from Bucket" 6. Give your new carousel a name 7. Go to Local Admin > Carousels and confirm that a carousel now appears. 8. Open the record bucket for the new carousel and confirm that it contains all the titles for the items. To test carousel creation from item status: 1. Scan items into item status 2. Select all items 3. Open the actions menu 4. Select "Create Carousel from Selected Items" 5. Repeat steps 6-8 above Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Andrea Buntz Neiman <abneiman@EquinoxOLI.org> Signed-off-by: Katie Greenleaf Martin <kgm@sparkpa.org> Signed-off-by: Blake <blake@mobiusconsortium.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#2056204: support "Form of item" in MARC editor for electronic resources This patch adds mappings to the Angular and AngularJS MARC editors so that the "Form" (form of item) fixed field positions in the 006 and 008 fields are recognized and (in the case of the 008) editable via the "Form" input when the record type is "m" (electronic resources/computer files). Release-note: Fixes problem where "Form" value could not be saved in MARC editor for electronic resources. To test ------- [1] Open a bib record of type 'm' (electronic resource) in the Angular MARC editor. [2] Change the form value with the input labeled "Form". [3] Note that the corresponding position in the 008 is not updated. [4] Apply the patch and repeat steps 1-3. This type, the change should stick. [5] Bonus: do the same testing in the AngularJS MARC editor. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2034617: improve how AngularJS handles logout BroadcastChannel messages This patch reduces the risk that if there are multiple tabs of the AngularJS staff client open, that logging out from one of them will cause a storm of logout messages on the eg.auth BroadcastChannel. If the open staff client tabs are all AngularJS, the result of that storm can freeze the user's browser. However, if one or more of the tabs are running the Angular client, the Angular tabs can _also_ make repeated open-ils.auth.session.delete calls at a high rate of speed, thereby degrading the availability of the open-ils.auth service. Testing involves opening up 4 or 5 tabs running the staff client, with at least three or four of them running the AngularJS client. It is strongly recommended that testing of this patch be done only on personal, isolated test Evergreen systems. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
LP#2054128: OPAC autosuggest now gets closed when input loses focus This patch ensure that the autosuggest list goes away when the basic search box in the OPAC loses focus. Otherwise, it can obscure controls that the user is trying to interact with. To test ------- [1] Enter a search term in the OPAC and observe that the dropdown of suggestions appears. [2] Tab or click away from the input. Note that the dropdown remains open. [3] Apply the patch and repeat steps 2 and 3. This time, the dropdown should get closed. Release-note: Close autosuggest dropdown in the public catalog when it loses focus. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP#2053035: return ability to submit OPAC basic search via enter This patch fixes an issue with the current autosuggest implementation that prevented submitting the form while focus is on the main text input. To test ------- [1] Apply patch. Do the following tests using both keyboard and mouse navigation. [2] Verify that submitting a search without selecting any of the suggested terms works. [3] Verify that submitting a search after selecting one of the suggestions works. [4] Verify that submitting the search after using the keyboard to navigate the selections, but ultimately not choosing any of them, works. [5] Run automated tests, e.g., by running npx jasmine Open-ILS/web/opac/tests/autosuggest.spec.module.js Release-note: Restore ability to submit basic OPAC search by hitting enter in search input. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: blake <blake@mobiusconsortium.org>
LP#1939154: allow clearing default pickup lib in AngularJS patron editor This patch adds a "Clear Default Hold Pickup Location" button to enable removing that user-setting. This works around an issue with the AngularJS OU selector where it doesn't pass an event to signify to calling code that the user has de-selected any OUs. To test ------- [1] Apply the patch. [2] Use the AngularJS editor to add and clear the default pickup library for a patron. [3] Verify that the changes are saved and displayed as expected. Release-note: Enable clearing the default pickup location in the patron editor. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
LP#1980273: ensure patron alerts are displayed in AngularJS patron summary This patch ensures that any staff alerts on a patron record are included in the itemized display in the patron summary when selecting a patron from search results (as opposed to fully opening the patron record). To test ------- [1] Set up a patron with a note that display an alert to staff. [2] Perform a search for the patron. [3] From search results, select but do not open the patron. (E.g., single-click the row rather than double-click it). [4] Note that the patron's name is set to red in the patron summary but that the list of alerts is not displayed below the patron name. [5] Open the patron (e.g., by double-clicking it). The patron summary will now itemize the list. [6] Apply the patch and perform steps 2 and 3. This time, the alerts should be itemized in the patron summary. Release-note: Ensure alerts are displayed in the patron summary when selecting a record from patron search results. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP2047714 - Fix tab defaults in Traditional catalog Redirects default tab choices of staff_view, added-content, bibnotes, cnbrowse to catalog when viewing the traditional staff catalog. Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1739638 AngularJS CSV Download Progress Bar Won't Close Delays text preparation for printing or CSV generation until after the progress dialog opens, preventing the dialog from remaining open if the data resolves before it opens and triggers the close action prematurely. To test: - open a populated AngularJS grid - refresh the page (behavior is more likely after refresh) - click Download Full CSV or Print Full Grid on the toolbar - note the progress dialog doesn't close - apply patch, repeat steps, and note the dialog closes Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1912840 added type aware comparator for eg grid. String columns are sorted while lower case. Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP#1998605 Prevent Checked Out Items from Being Marked Missing - Remove mark missing actions from the patron items out grids. - The circ.mark_item... service will not allow a checkin attempt on a checked out item if it's being marked missing. - Keep the promise chain alive in AngularJS when marking multiple items missing and one fails (consistent with the behavior in Angular). To test: - Patron items out grids should not display missing actions. - Item status (both detail and list view) should not allow checked out items to be marked missing. - While checked out items shouldn't typically appear on the pull list, holds shelf, or patron holds grids, if stale data is there (ex. multiple tabs), checked out items will not be marked missing. Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
lp1187993: Replace dojo autocomplete with accessible autocomplete This autocomplete uses vanilla javascript to implement the Combobox With List Autocomplete pattern from the Aria Authoring Practices. This commit uses ES modules. It makes use of some bootstrap styles. It should be compatible with both bootsrap 4 and 5. It theoretically works on the non-bootstrap TPAC as well, but will likely need some design work to be satisfying in that interface. Otherwise, this autocomplete JS uses the same APIs as the previous interface did. Also included is a small test suite and an eslint configuration. Use Nodejs 18.18.0 Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
LP#2037128 Print Selected Rows on Grids Adds an option to both the Angular and AngularJS grids to print just the selected rows. Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1944717 Double-click on Patron Notes This adds the ability to double-click on patron messages in the staff client to open them in a modal in order to make it easier to read and edit the messages. When opening an archived message, the ability to edit is disabled. This also adds a View Note action to the Archived Notes grid. LP1944717 Double-click on patron messages Adds ability to double-click on patron messages to open them in the Edit modal. This makes it easier to read and edit the full messages. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> LP1944717 Undo the ability to edit an archived note The first commit added the ability to open an archived note in the edit modal but that was determined not to be idea. This commit removes that ability. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> LP1944717 Read-only view for archived notes This adds the ability to double-click on an aerchived patron note to open it in a read-only modal. Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> LP1944717 Add view note action to patron archived notes Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: rfrasur <rfrasur@library.in.gov> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1818086 Accessible text for AngJS status icons Adds screenreader-only text and title attributes (for tooltips) to the glyphicons used in the patron bills status column. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1965326 Move Hatch Printing to Printer Settings * Hatch printing can now be enabled / disabled directly in the Printer Settings UI. * Workstation menu for 'Print Service ("Hatch")' removed since it duplicates the same logic. * "Printer Settings" relabled to "Hatch (Print Service) Printer Settings" Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
LP1994057 Add Survey Responses to Patron Data Print Template This adds the most recent survey responses for each answered patron survey to the default patron print data template. It also updates the existing strings to be translatable. Adds seed data and release note Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: blake <blake@mobiusconsortium.org> Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
LP#2036840: fix incorrectly initialized fund dropdown in legacy acq This patch fixes an issue where the selector for editing the fund of a line item copy can fail to be properly initialized if you are doing a legacy search for line items (as opposed to doing a legacy search for a purchase order, then navigating to the line item). To test ------- [1] Create a line item (attached to a PO) with at least one copy that has a fund associated with it. Ensure that the line item remains in an editable state such as 'new'. [2] In the legacy search interface for acquisitions, do a line item search (not a PO search) to bring up the line item. [3] Click the copies link on the line item. [4] Note that the fund drop-down for that line item does not have the assigned fund selected, nor does it list any funds. Note that attempt to change the value via the batch updater's fund drop-down doesn't work. Note that attempting to save changes to the line item copy (e.g., to the notes field) doesn't work. [5] Apply the patch and repeat steps 2 through 4. This time, the fund selector should be correctly initialized and functioning and that changes to the line item copy can be saved. Sponsored-by: Evergreen Indiana Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>