LP1873286: Fix Bad End Tags Fix self-closing tags used in non-void HTML and non-empty XHTML tags. These tags now cause errors with jQuery version 3.5.0 and were technically wrong from the start. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1510641 Always show actions selector in PO view Ensure the actions selector is always visible for PO's, even when no lineitems are present. This allows printing and history view (and potentially future actions) for PO's that only contain direct charges. The custom Add Brief Record button is no longer present, since the same action is accessible from the actions selector. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
LP#1440114 Blanket PO finalize from PO view Adds new "Finalize Blanket Order" button to purchase page for PO's that are activated and have at least on blanket charge. Finalizing the PO disencumbers all blanket charges and marks the PO as complete. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1350371 detect dupe PO name on edit When changing the name of an existing PO, if the selected name collides w/ another PO at or below the ordering agency, a warning is shown to the user, including a link to the matching PO, and the name change is aborted. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Support PO activation w/o loading items Allow for the activation of purchase orders without requiring that bibs and items be loaded. (Currently, if bibs and items are not manually loaded, they are loaded during PO activation). Adds a new link next to the existing PO Activate link for "Activate Withoug Loading Items". Apart from the fact that there are no underlying bibs/copies, such a PO behaves the same as any other PO. Signed-off-by: Bill Erickson <berick@esilibrary.com> Conflicts: Open-ILS/src/templates/acq/po/view.tt2 Open-ILS/web/js/ui/default/acq/po/view_po.js Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Acq: several interface improvements Several usability improvements throughout Acq, including: * A logical re-ordering of the main "actions" dropdown in several Acq interfaces (selection lists, purchase orders, acq search results, MARC federated search interface, etc). * "Actions" dropdown also has its options enabled/disabled depending what interface you're seeing it through, and redundant entries are removed from the per-lineitem secondary dropdown. * Add to Purchase Order dialog added to "actions" dropdown * Middle layer support for adding many line items to a PO at once * Create/add to Purchase Order operations can no longer steal line items from current POs * Create invoice from / link to invoice now work in new tab * Receive/unreceive now by selected lineitem instead of whole PO * Claim policy application works more simply now * Invoices interface auto-populates "# Invoiced" column with number of invoicable copies, and copies the "billed cost" column to the "amount paid" column if the latter doesn't have anything in it yet. * You can now only cancel specific lineitems when they're actually on a PO and have the state of 'on-order'. * Avoid double-activation of POs at UI level * Disable invoice and cancel options for whole pending POs * Disable zero-copy checkbox for activated POs * Disable new misc charges (acq.invoice_item) for activated POs Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com> Signed-off-by: Bill Erickson <berick@esilibrary.com>
I18N: Make everything in tt2 files translatable. Simply wrap everything that should be translatable inside l(). Also fixes bug #1088388 Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Conflicts: Open-ILS/src/templates/acq/common/li_table.tt2 Open-ILS/src/templates/acq/invoice/view.tt2 Open-ILS/src/templates/acq/search/unified.tt2 Open-ILS/src/templates/vandelay/inc/item_attrs.tt2 Signed-off-by: Dan Scott <dscott@laurentian.ca>
ACQ scroll back to top of lineitem info page When displaying the lineitem "info" page (li attributes, marc record), be sure to scroll to the top of the page instead of relying on the previous scroll location. In particular, if you last viewed a LI toward the bottom of the page, returned (causes scroll down), then go back into the info page, the page will be scrolled to the bottom. The solution is a little funkier than I'd hoped. The scroll-to point has to be a node that is a) within the scrolling dojo div and b). non- visible when scrollIntoView is called. Since the top-level page div may be different, depending on who is loading li_table, we rely on the caller to place an id=oils-scroll-to-top div in the page for general top-scrolling. (Note, also, window.scrollTo does not work when it's the div and not the full page that needs scrolling). Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
ACQ return-to-[search/invoice] buttons repair With changes in place to support newer version of xulrunner, several buttons no longer work in the staff client. These include: Return to Search in PO and Selection List pages Return to Invoice in PO and Selection List pages Return in lineitem worksheet page This fix avoids using document.referrer (which is no longer available) with an explicit 'source' CGI parameter, which contains the path and params of the source page. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
ACQ : lineitem recovers focus from various interfaces 1. When viewing an invoice then clicking on the title link for a lineitem, the user is taken away to the copy grid within the PO page for the lineitem.This adds a "Return to Invoice" button in the copy grid which takes the user back to the invoice, focused on the lineitem in question. 2. Adds a "Return to Search" button for PL/PO pages to return to the lineitem in question when the PL or PO links are selected for a lineitem in a set of search results. 3. Adds a "Return to Invoice" button to PO/Picklist pages with lineitem focus when the page was accessed from the invoice UI. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Control PO activation for zero-copy lineitems By default, prevent activation of POs when any lineitems are present that have no copies attached. This adds a new option in the PO UI called "Allow activation with zero-copy lineitems", which will allow the activation to continue even when zero-copy lineitems exist. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
More self-closing cleanup All div and span tags in tt2, js, html, and xhtml files. Ignored .xml files, as they are not (to my knowledge) served as text/html. Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Remove /default/ from template paths The original goal of having a /default/ component to the template path was to support alternate skins. However, Template Toolkit supports alternate skins through a more elegant mechanism of providing template overlays via template path configuration. In other words, skin files will be differentiated by the location of their root path and not because they live in a different skin directory inside the main template root. Because of this, the /default/ component in the template path serves no purpose and generally just gets in the way. As a part of this, EGWeb.pm no longer inserts the skin name into the template file path. Signed-off-by: Bill Erickson <berick@esilibrary.com>