LP#1552778: copy some date/time utils from OpenSRF As preparation for subsequent bugfixes, this patch copies several date/time routines from OpenSRF::Utils to a new module, OpenILS::Utils::DateTime. Specifically, the routines copied over are: * clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601) * gmtime_ISO8601() * interval_to_seconds() * seconds_to_interval() This move will allow us to fix bugs in this core routines without requiring a mandatory OpenSRF upgrade. Furthermore, with the exception of interval_to_seconds() (and in only one place), none of those routines are used by OpenSRF itself. To test ------- [1] Apply the patch. [2] Verify that unit tests pass. [3] Verify that all Perl services start correctly. [4] Verify that date/time and interval calculations continue to work as expected, particularly in circulation. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Lp#1718459: Remove Debian 7 Wheezy Installation Support Remove references to Debian 7 Wheezy in the installation and upgrade documentation. Remove debian-wheezy* targets from Open-ILS/src/extras/Makefile.install and the supporting Makefiles. Remove the example Apache 2.2 configuration files, since the supported distributions all ship with Apache 2.4. Move the eg_startup.in file from Open-ILS/example/apache to Open-ILS/examples/apache_24. Remove references to eg_wheezy_installer.sh in Perl live test comments. Remove Open-ILS/web/js/ui/default/staff/README.install, which is out of date and entirely aimed at Debian 7 Wheezy. To test: Simply install on a supported distribution other than Debian 7 Wheezy and do the usual tests. Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Ben Shum <ben@evergreener.net>
LP#1689656 Add test for manual adjustment of negative balance Without the fix in LP#1689656, this test fails. Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1686194 Account for adjustments when generating fines Fine generation stops at a predetermined 'max fines' amount, but this does not account for possible adjustments which lower the effective fine amount. This situation is common in cases where lost items are returned, and the library wants to generate additional overdues upon that event. With this commit, fine generation will pull in any adjustments applied to overdue fines, and use those to offset the current total fine when checking for max fines. Also includes test for this condition. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1670407 Add tests for xact_finish close/re-open Since this bug came about due to negative balance changes (and it was easier), this commit extends the existing negative balances test suite to include basic tests for checking both xact_finish conditions. One of these tests fails without the fix from the previous commit. Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP 1198465: More tests for conditional negative balances This commit adds the remaining test cases documented by Kathy Lussier on this wiki page: http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases Test cases included in this commit are: 6. Restores Overdue Fines Appropriately, No Previous "Voids", Patron Will Not Owe On Lost Item Return 7. Restores Overdue Fines Appropriately, No Previous "Voids", Patron Will Still Owe On Lost Item Return 9. Restore Overdue Fines Appropriately, Previous Voids, Negative Balance Allowed 13. Prohibit negative balances on lost materials bills ONLY 14. Prohibit negative balances on overdue bills ONLY Note that test case 5 is omitted because it is a duplicate of case 2, and case 11 is included but commented out because it is unclear how best to handle the situation. Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>
LP 1198465: Initial tests for conditional negative balances This is a first commit of work-in-progress for testing the conditional negative balances features. It covers 9 of the 14 test cases listed here (as of today): http://evergreen-ils.org/dokuwiki/doku.php?id=qa:billing_test_cases TODO: - The test is currently an SQL setup file plus a Perl live test file. One simple improvement would be to switch the setup process to cstore calls within the Perl test file. This would be both more contained and more robust. - A second step to more advanced and useful tests would be to use higher-level API calls to create portions of the setup rather than doing everthing manually. However, some test conditions cannot be reasonably setup with the normal API calls (e.g. bills of a specific age, or bills using a legacy format no longer generated by current code), so certain areas will likely always require direct manipulation. Signed-off-by: Daniel Wells <dbw2@calvin.edu> Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <bshum@biblio.org>