LP#1617556 - Remove openils_dojo.js references Somewhere along the way, openils_dojo.js was removed, but references remained. This removes them, hopefully helping to speed up page loads. Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com>
LP1880726: Support eg2 cookie If there is a stale "ses" cookie hanging around when a staff member logs into the Angular client, it will be sent to the batch MARC edit handler along with the active "eg.auth.token" cookie. We should check for and prefer the latter in this particular code. Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1880726 MARC Batch edit Angular port Angular port of the MARC Batch Edit interface. Under the covers, each bib record is now modified within its own transaction to avoid long-running transactions that can potentially lock database rows needed by other processes. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1440890: add vandelay_queue to the types of containers retrieved by batch edit To test ------- [1] Perform a batch bibliographic record import, then add the import queue to a new bucket. [2] In the web staff client, go to Cataloging | Batch Edit. [3] Note that the bucket created in step 1 does _not_ appear in the bucket selector on the batch edit page. [4] In the web staff client, go to the record bucket and hit the Batch edit button. [5] Note that the bucket created in step 1 does _not_ appear in the bucket selector on the batch edit page. [6] Apply the patch and repeat steps 2-3. This time, the bucket should appear in the selector. [7] Repeat steps 4-5. This time, the bucket should appear in the selector (and be the active choice). Signed-off-by: Rogan Hamby <rhamby@esilibrary.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1552778: copy some date/time utils from OpenSRF As preparation for subsequent bugfixes, this patch copies several date/time routines from OpenSRF::Utils to a new module, OpenILS::Utils::DateTime. Specifically, the routines copied over are: * clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601) * gmtime_ISO8601() * interval_to_seconds() * seconds_to_interval() This move will allow us to fix bugs in this core routines without requiring a mandatory OpenSRF upgrade. Furthermore, with the exception of interval_to_seconds() (and in only one place), none of those routines are used by OpenSRF itself. To test ------- [1] Apply the patch. [2] Verify that unit tests pass. [3] Verify that all Perl services start correctly. [4] Verify that date/time and interval calculations continue to work as expected, particularly in circulation. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1705731: background batch MARC edits now report status less verbosely Rather than repeatedly inserting and fetching potentially very large arrays of per-record status statements from the anon cache, batch MARC edits that are run in the background now report counts. This patch changes how open-ils.cat.container.template_overlay.background populates the anonymous cache; note that streaming status updates if calling open-ils.cat.container.template_overlay instead are *not* changed. To test ------- [1] Set up a MARC Batch Edit run using a reasonably large bucket as a source records. [2] Verify that progress is reported correctly during the run. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1545226 - Fix MARC Batch Editor status screen. This patch does the following: - The html table was broken, fixed the markup. - Added some styling to the table. - Added a row with total records info. - Fixed the progress bar popup; it now displays percentage completion and has a title so it is wide enough to do so - Added color to failed row (red), and to completion text (green). To test: [1] In the staff interface (both XUL and web), perform a MARC Batch Edit on a bucket that contains at least a few bib records. [2] Verify that the progress dialog now displays the percentage completion of the batch edit; verify that there is now a row displaying the total number of records. Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
fix user session management for MARC Batch Edit The Javascript in the hardcoded page templates was not checking the XUL stash for the session key when run from the staff client; this is now needed as a result of the XULRunner updates introdued by commit adee850f. As a consequence, the list of the user's record buckets was not retrieved, and attempts to run a batch edit would spin without updating any records. This fixes LP#1048707 and LP#1054277. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
mod_perl expects child_init return values So add in Apache2::Const::OK returns on all of them. [LFW: Added the same change to AutoSuggest.pm for consistency's sake.] Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Call set_audit_info and clear_audit_info DB funcs Set whenever we can (including automatically via pcrud) Clear whenever we disconnect (hopefully) from a location we set from. Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Make bucket content retrieval authoritative LP#492036, we neeed all bucket methods to be authoritative. Some already were, this finishes the job. Signed-off-by: Mike Rylander <mrylander@gmail.com>
Always use BinaryEncodeing => "UTF-8" with MARC::File::XML git-svn-id: svn://svn.open-ils.org/ILS/trunk@20250 dcc99617-32d9-48b4-a31d-7c20da2025e4
Make Evergreen Perl modules installable via Module::Build to match OpenSRF Build.PL gives us an install-time check on dependencies; right now the required versions are not set, but we can update these easily to start catching some of the problematic modules that have tripped sites up in the past. Build.PL really seems to want a top-level "OpenILS.pm" so add a placeholder accordingly. Adjust references to /src/perlmods/ to /src/perlmods/lib/ even though a number of the affected scripts are probably cruft. Use autoconf to provide the default paths in O:WWW:Web and O:WWW:Method; next step is probably to teach autoconf to ask Build.PL to do that for us to make the OpenILS Perl modules more independent. git-svn-id: svn://svn.open-ils.org/ILS/trunk@19340 dcc99617-32d9-48b4-a31d-7c20da2025e4