LP2019974 Open Non-Cataloged Circs View * Make open non-cataloged circs available as a cstore/pcrud-accessible DB view. * Migrate the public API to cstore retrieval * Migrate one of the browser client calls to pcrud * Minor code tidying Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1904036 Noncat batch retrieval API Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1635737 Due date DST noncat thinko fix Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1635737 Apply DST-aware timezone to context dates Do our best to enforce the rule required by OpenSRF's interval_to_seconds that when a context date is in use, and you care about DST awareness, you must set the timezone to a DST-aware value, e.g., 'America/New_York'. In most situations, 'local' will suffice for this, as the server is typically configured with a DST-aware timezone in its environment. However, we will look for an org unit setting called 'lib.timezone' and use that where we can. See LP#1705524 for info on that setting. Signed-off-by: Mike Rylander <mrylander@gmail.com> Conflicts: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/NonCat.pm Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1635737 Use new OpenSRF interval_to_seconds() context Use the optional context for interval_to_seconds() to account for the variable length of duration components. For example, "1 day" may be shorter or longer than 24 hours during a time change event, "1 month" may be shorter or longer depending on which month it is currently, etc. Also, remove some timestamp munging, as that happens within interval_to_seconds() already. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com> Conflicts: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1552778: copy some date/time utils from OpenSRF As preparation for subsequent bugfixes, this patch copies several date/time routines from OpenSRF::Utils to a new module, OpenILS::Utils::DateTime. Specifically, the routines copied over are: * clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601) * gmtime_ISO8601() * interval_to_seconds() * seconds_to_interval() This move will allow us to fix bugs in this core routines without requiring a mandatory OpenSRF upgrade. Furthermore, with the exception of interval_to_seconds() (and in only one place), none of those routines are used by OpenSRF itself. To test ------- [1] Apply the patch. [2] Verify that unit tests pass. [3] Verify that all Perl services start correctly. [4] Verify that date/time and interval calculations continue to work as expected, particularly in circulation. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Revert "LP#1635737 Use new OpenSRF interval_to_seconds() context" This reverts commit 04a101312b0a42d34108c8d78997a3960241363a.
LP#1635737 Use new OpenSRF interval_to_seconds() context Use the optional context for interval_to_seconds() to account for the variable length of duration components. For example, "1 day" may be shorter or longer than 24 hours during a time change event, "1 month" may be shorter or longer depending on which month it is currently, etc. Also, remove some timestamp munging, as that happens within interval_to_seconds() already. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Mike Rylander <mrylander@gmail.com>
LP#1187035 Remove OpenILS::Utils::Editor part 2. * Address 2 places where we were calling $e->request with a CStoreEditor for a storage method. Since CStoreEditor assumes all calls go to open-ils.cstore, these would have failed. * While we're in a cleaning mood, remove some obsolete commented code. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Jeff Godin <jgodin@tadl.org>
LP#1187035 Remove OpenILS::Utils::Editor OpenILS::Utils::Editor is obsolete, yet still referenced in a number of places. Let's remove it. Signed-off-by: Jeff Godin <jgodin@tadl.org> Signed-off-by: Bill Erickson <berick@esilibrary.com>
Post-2.5-m1 whitespace fixup This is an attempt at an automated whitespace cleanup for the m1 milestone of version 2.5. It was created using the following commands (run from Open-ILS/src/perlmods/lib): find . -name "*.pm" \ -exec sh -c 'sed "/<</s/\t/ /g" < {} \ | expand -t 4 > {}.fixed ; \ cp --no-preserve=mode,ownership {}.fixed {}; \ rm {}.fixed' \; Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Remington Steed <rjs7@calvin.edu>
Make Evergreen Perl modules installable via Module::Build to match OpenSRF Build.PL gives us an install-time check on dependencies; right now the required versions are not set, but we can update these easily to start catching some of the problematic modules that have tripped sites up in the past. Build.PL really seems to want a top-level "OpenILS.pm" so add a placeholder accordingly. Adjust references to /src/perlmods/ to /src/perlmods/lib/ even though a number of the affected scripts are probably cruft. Use autoconf to provide the default paths in O:WWW:Web and O:WWW:Method; next step is probably to teach autoconf to ask Build.PL to do that for us to make the OpenILS Perl modules more independent. git-svn-id: svn://svn.open-ils.org/ILS/trunk@19340 dcc99617-32d9-48b4-a31d-7c20da2025e4