LP#2043508 fix misconfigured delete dialogs and add dialogs where they were missing. Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
LP1850473: manual and automated eslint fixes Automatic fixes from `npm run lint -- --fix` Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1917092: Filter shelving location grid to non-deleted by default To test: 1) Go to Admin > Local admin > Shelving locations editor. 2) Note that there is a filter enabled: Deleted = No. 3) Check through the grid entries to confirm that no deleted locations exist in the grid. 4) Remove the filter. 5) Note that the deleted entries are now available to you if you need them. Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Elizabeth Thomsen <et@noblenet.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
lp1857911 follow-up: remove console.log Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
lp1857911 follow-up tweaks * AdminPage component -> Return button if page was invoked with gridFilters * AdminPage component -> options to hide delete and edit actions * Stat cat admin pages -> disable edit and delete for stat cat entries to match behavior of legacy interfaces, until we discuss something better * AdminPage component -> stock delete confirmation for AdminPage component * Stat cat admin pages -> custom delete confirmation prompts for stat cats * AdminPage component -> sticky org selector options for org fields in fmEditor * AdminPage component -> option for new record org fields to follow context org * Stat cat admin pages -> enable org field follows context org featuer * orgFamilySelect -> persistKey support * Stat cat admin pages -> use a persistKey for main org selector Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
lp1857911 angularized stat cat admin interfaces * for stat cats and stat cat entries in the IDL, make sure we have pcrud controller enabled and pcrud permissions set. Also set config_field for "entries" so that the AdminPage component can link them out to their own admin pages * item and patron stat cat admin pages * lp1857911 release notes Leverages the BasicAdminPage component, with some tweaks. Changes to the BasicAdminPage and AdminPage components all default to off, so should not affect existing interfaces: * add an option to hide the Clear Filters action from subordinate admin pages (when you follow config fields) * add an option to propagate recordLabel to the fmEditor component, and also use said label within the admin page * add an option to propagate orgDefaultAllowed to the fmEditor component For the stat cat and entry admin pages specifically, we leverage these to: * hide Clear Filters so that we don't let the user get into a situation where they try to create a new stat cat entry but have a blank and unsettable stat cat field (because we mark that field as read-only in the fmEditor) * default the Owner field for new stat cats and entries to the workstation library * use Item and Patron instead of Asset and Actor in various labels (at least until we're ready to make that change wholesale in the IDL) Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP2002435: Add optional undelete action to basic admin page By default, this undelete action is only enabled on the shelving location editor. Also, only show admin page delete button if everything selected is deleteable Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1843970: Refactor Coded Value Map grid to use eg-admin-page Also adds a new @Input to eg-admin-page that accepts arbitrary columns based on <ng-template>s Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP#1904244: AdminPageComponent: move onRowActivate subscription to markup This allows extenders of this interface to set their own non-default handlers. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1919483: Fix the queries for secondary admin pages To test, go to the following screens, and make sure that their secondary admin pages don't show errors and filter properly. * Authority Control Set * Authority Thesaurus * Course list * Hard due dates * MARC import remove fields * MARC Search/Facet fields * Z39.50 servers Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1873322: Angular Admin Pages default to workstation OU To test: 1) Apply this patch. 2) Log in using a workstation at a particular org unit. 3) Open some of the following admin pages: Local Admin > Address Alerts Local Admin > Carousels Local Admin > Group Penalty Thresholds Local Admin > Course Reserves List > Terms Tab Server Admin > Billing Types Server Admin > Call Number/Volume Suffixes Server Admin > Copy Tags Server Admin > Hard Due Date Configuration Acquisitions Admin > Cancel Reason Configuration Acquisitions Admin > Claim Policies Booking Admin > Resource Types Booking Admin > Resource Attribute Values 4) Verify that these pages automatically open to your workstation's org unit. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
LP 1857351: set basic admin interface field order using route Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1846042 Angular grid filter dropdown improvements Add an explicit Close button to filter dropdowns to cover cases where the user wishes to close the dropdown without making any changes and clicking-away is not supported. Othor minor repairs. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP#1846042: turn on grid filtering for Angular admin pages This WIP patch enables grid filters for Angular administration pages. TODO: 1. Enable for pages that override or do not use the default AdminPageComponent 2. Reconcile with the gridFilter URL parameter that booking (e.g.) uses. 3. Reconcile the top-level org unit filter widget with grid column org unit filters. Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1847800 Admin grid filter display, default fields, IDL repairs * Indicate in the UI when grid filters are applied via URL and offer a way for the user to clear the filters. * When grid filters are applied, use them as the basis for the "Default New Record" object which seeds the fm-editor. In other words, apply default values to the fm-editor to match the grid filters. * Repair some IDL thinkos and add more 'selector' values. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1847800 Admin grids support config_field links For IDL fields which have config_field=true, the value in the admin grid is rendered as a link to the grid for the linked field. Additionally, the link contains a gridFilter so the destination grid only displays rows related to the selected field. Adds config_field=true values for z39.50 source and two links for hard due date and hard due date values. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP#1847800 / LP#1834687: secondary admin pages: config_field attribute in IDL Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1840287 Floating group admin minor code tweaks * Added grid sorting to both group and group member grids. * Avoid using the defaultNewRecord in fm-editor directly, by cloning it as needed, so that subsequent new records (within a single parent component instance) do not pick up values from the previously created record. * Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields' to better explain how the value will be passed along. * Replace access of fieldmapper innards (thing.a[0]) with field names (thing.id()) * Remove unused <eg-string /> entries. * Avoid unnecessary newlines in translatable strings. * Remove unused @Inputs() and unnecessary functions * Remove unneccessary TreeModule import * Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the title when present. * Various 'ng lint' repairs. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
lp1840287 Edit Floating Group Members Add functionality so that when editing a floating group, one is taken to a page where one can edit a given floating group as well as all its linked members. New functionality: - eg-admin-page can hide grid fields - fm-editor can create a record with fields defaulting to values Signed-off-by: Mike Risher <mrisher@catalyte.io> Changes to be committed: modified: Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.html new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.ts new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group-routing.module.ts new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.html new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.ts new file: Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.module.ts modified: Open-ILS/src/eg2/src/app/staff/admin/server/routing.module.ts modified: Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html modified: Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.ts Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1830973 Angular 8 updates Update package.json versions and perform the angular 7 to angular 8 migration steps. Update some configs to match supported options in newer versions of typescript and tslint. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>