LP1850473 Fix button type lint errors Sets the type attribute on buttons where it was previously missing. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1615714 Accessible names for Material Icons Adds ARIA labels or hidden text, as appropriate, to ensure that Material Icons are announced to screen reader users in a sensible way rather than having the icon keyword read as if it were normal text. In buttons containing an icon with no text, both ARIA labels and title attributes are used so that the tooltip matches the button's accessible name. This helps sighted users of dictation software identify the button's name. The icon keyword is hidden from screen readers with the aria-hidden attribute. In buttons with both an icon and text, the icon keyword is hidden from screen readers. Where icons appeared in inline text rather than a button or link, a visually-hidden span has been added to mirror the existing title attribute (tooltip), unless the icon was purely decorative. As part of this cleanup, several <a click()> elements were identified that had not already been addressed in other bug reports related to keyboard navigation support. These have been changed to <button>, and button types have been specified throughout. Other small role and alt text errors identified by the Axe linter have also been corrected. Note that this branch does not include labels for the grid flair icons (bug 1818086) or the grid actions toolbar (bug 1833726), which are being addressed separately. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Steven Mayo <smayo@georgialibraries.org>
LP2000482 Angular 15 and Bootstrap 5 upgrade Includes numerous markup and CSS adjustments to cope with Bootstrap 5. This patch is a squash of patches authored by Bill Erickson and Stephanie Leary. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1824709: Allow comboboxes inputs to have IDs This adds a new input, domId, for the combobox component. A good way to test: 1) Download the Wave accessibility checker. 2) Go to one of the following screens: - Admin > Local > Course Reserves > Choose a course > Associate item from catalog - Admin > Local > Course Reserves > Choose a course > Associate brief record - MARC Batch Import - MARC Batch Import/Export > Inspect Queue - Staff Catalog Add to bucket - Staff catalog conjoined items - Hold cancel dialog 3) Right click and select "WAVE this page" 4) On the Details tab of WAVE, notice that there are several "Missing form label" errors. 5) Apply this patch. 6) Run WAVE again; notice that the number of missing form label errors has decreased. Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Garry Collum <gcollum@gmail.com>
LP1959048: manual ng lint fixes Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1959048: Run ng lint --fix Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1941764 Import from queue propagate form inputs When importing records from an existing Vandelay queue, ensure the selected queue, its match set, its match bucket, and its holdings import profile are propagated into the import form. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#1444644 Copy Import Development Work Two new options for importing holdings have been added to MARC Batch Import/Export: 1) Auto-overlay On-order Cataloguing Copies This is similar to "Auto-overlay In-process Acquisitions Copies," but for copies that were not created from an acquisitions workflow. Holdings information in the incoming record will be used to overlay any existing On Order copies for the matching record which belong to the owning library defined in the Holdings Import Profile. The Holdings Import Profile is also used to match incoming to existing copies, if possible; otherwise, On Order copies are overlaid in the order they were created. The call number will also be overlaid if the incoming record provides one. 2) Use Org Unit Matching in Copy to Determine Best Match When there are multiple potential matching records, this feature allows the user to automatically select the record which has the most copies at libraries near the importing library in the org tree. That is, starting at the importing library, it climbs the org tree, gradually expanding the scope at which it checks for holdings on matching records; once holdings are found, the record with the most holdings at that scope is selected for overlay. If there are no matching records with holdings, then the default best match overlay is attempted. Two new permissions are added to control the use of these new features. Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop> Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1823367 Re-fix Copy to Item name changes Most of these changes already exist in the AngularJS client, so let's bring them over to Angular to keep with current practice. Also, fix two pesky "Volume" labels which didn't make the previous commit. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1779158 Import field id/class mismatch fix Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP1779158 Cache new queues / display active queues * Only list active (non-complete) queues in the Vandelay queue selector combobox. * Display an alert message when the user attempts to create a queue whose name collides with an existing queue for the user. * Be sure newly created queues are added to the local cache of queues in the Vandelay service. * Remove unused activeQueue list from vandelay.service to avoid having to maintain 2 separate queue caches. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1779158 Vandelay UI accessibilty/usability improvements * Associate <input>'s with their labels in the import and export forms * Hide the MARC removal groups selector when record type is authority. * Disable ACQ copy overlay option when record type is authority. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1800481 Vandelay import form templates Support saving MARC Import form values as named templates. Values are stored as (by defualt) workstation settings. A template may be selected as the default and templates may be deleted. Includes release notes update angular vandelay. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1779158 Ang6 Vandelay UI Port Port of the MARC Import/Export UI from a Dojo-driven interface to a Angular(6) interface. Includes an additional UI called "Recent Imports" which displays Vandelay session tracker information for both active sessions and those within the selected time frame. Active sessions are updated regularly to display progress to the user. Includes grid persist key workstation settings. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Dan Wells <dbw2@calvin.edu>