LP#2000270: (follow-up) fix lint This patch also adds a "FIXME" to better signal an area where the patch author was uncertain of how to properly signal to Angular Forms when the OU selector has an invalid value. Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP#2000270 Staff catalog lets staff pick invalid pickup locations Added new check to the hold component that disables the 'Place Hold(s)' button if the pickup location is empty or from the list of orgs that are shown but not valid pickup locations. Also modified the org-select component to check if the org it has selected is supposed to be disabled. When the org-selector is required, it will have the relevant class applied and have a little green or red slice. NOTE: The validity is applied in a somewhat hacky way that doesn't appear to be the official Angular way. It might not signal properly if used in a form. Steps to test: [1] In the staff client, go to Cataloging -> Search the Catalog [2] Search for something attempt to Place a Hold on it [3] Click on the Pickup Location input [4] Use the arrows and press tab to select an illegal pickup lib [5] Note the color on the input and the transparency of the button [6] Select a valid pickup location [7] Select a valid user for the hold [8] Note the color on the input and transparency of the button Release-Note: Prevents holds with an invalid pickup location selected from being placed in the angular catalog Signed-off-by: Steven Mayo <smayo@georgialibraries.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org>
LP2043899 Revised org select field labels Reverses course on the new label strategy introduced in bug 1999158, which proved incompatible with some components with user-configurable labels (e.g. patron edit). Rather than introducing a <label> tag by default, we now use the more familiar ARIA label strategy in places where the field does not have a visible label. We will need to revisit these, as all form fields should have visible labels per WCAG, but the ARIA label serves to resolve the immediate problem for screen reader users. Affects all uses of <eg-org-select> and <eg-org-family-select>. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1999158 Form labels for eg-org-select component Adds input directives to <eg-org-select> to support <label> tags with various options. Label tags are included alongside inputs unless explicitly suppressed. Where a visible label would disrupt the current layout, the "visually-hidden" CSS class may be used to hide the label visually while leaving it available to screen readers. All current instances of <eg-org-select> have been updated. Where labels already existed, those with specific layout requirements have been adjusted only to add missing "for" attributes, and the component's automatic output is suppressed with "visually-hidden". While this sometimes results in two <label> tags being present in the DOM, this is valid and doesn't cause any issues. Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1904036 org-select rejects invalid free text Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1904036 org-select gets required option Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1904036 Org select name option and improved domId Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
LP1929741 ACQ Selection List & PO Angluar Port New selection list UI New PO UI New Lineitem worksheet UI with stub print template New PO print UI with stub print template New brief record UI Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
LP1771636 Org Select Combined Org Names Option Adds an option to the staff client workstation settings page for "Include Full Library Names in Library Selector?". When enabled, Angular org unit selectors display the full branch in addition to the branch short code. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
LP1739277 Angular org selector style callback Allow the caller of an <eg-org-select> to pass a function which is called against each org unit in the list to determine what CSS class(es) should be applied to the org unit label in the list. Includes sandbox example. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1908743 Org select now supports disabled org unit Org units specified as disabled in <eg-org-select /> are now visible, but disabled when the typeahead displays. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1894131 Sticky catalog holdings org select Adds a workstation setting to make the org selector in the catalog holdings tab sticky. Also repairs some logic errors in the org select persistKey loading. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
LP#1850547: eg-org-select: allow applyOrg[Id] to clear the org unit Sponsored-by: Evergreen Community Development Initiative Sponsored-by: Georgia Public Library Service Sponsored-by: Indiana State Library Sponsored-by: C/W MARS Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1889113 Angular org select persistKey support * Support reading and writing org-select values using server settings. * Adds a new @Input fallbackOrg[Id] which is used in cases where no persisted value is found. * Adds a new @Otput called componentLoaded which fires once when the selector has completed all of it's load time work. * Improvid code documentation. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP1857350 Org selector sorts by display value When displaying the org unit selector, sort each set of children by the display label (defaults to shortname). Fixes issues with the org server sortTree function and adds a unit test to test the repaired sort function. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP1830973 Angular 8 updates Update package.json versions and perform the angular 7 to angular 8 migration steps. Update some configs to match supported options in newer versions of typescript and tslint. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1840050 Org select sanity checks on selected value Avoid use of org-select 'selected' value when it's not defined/null. Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>