Galen Charlton [Thu, 11 Nov 2021 16:21:11 +0000 (11:21 -0500)]
LP#1949910: serialize deleting items from item bucket
This patch serializes the fetching and fleshing of items to delete
when the delete-from-item-bucket action is invoked, thereby
avoiding possible drone starvation from open-ils.search. It
also throws up the progress dialog for good measure while
the deletion occurs.
To test
-------
[1] Set up an item bucket with 25-50 items.
[2] From the item bucket intervace, invoke the action to delete
all of the items.
[3] Note that the open-ils.search.asset.copy.fleshed2.retrieve calls,
one for each item, are all made simultaneously. Assuming stock
max_children settings, this will cause open-ils.search to log
that some requests are hitting the backlog.
[4] Apply the patch and refresh the item bucket page, then repeat
step 2 (it doesn't matter for this purpose that the items have
already been deleted). This time, the open-ils.search API calls
are made serially and a progress bar is displayed while the
deletion takes place. Verify that no requests hit the backlog.
Terran McCanna [Fri, 18 Jun 2021 22:12:08 +0000 (18:12 -0400)]
LP1904754 Former precat still displays precat info
This fixes a display issue where the precat title and author
were still displaying once the record was no longer a precat,
which effectively duplicated the title and author.
Dan Briem [Fri, 9 Apr 2021 22:19:02 +0000 (18:19 -0400)]
LP#1918362 Unchanged workstation settings applied on every checkin
* Stop attempting to save the Update Inventory setting on every
checkin - incorrect prefix & redundant (it's a modifier now)
* Stop saving the Strict Barcode setting on every checkin,
renewal, and checkout
* Save Strict Barcode on user interaction with its checkbox
To test:
1. confirm Strict Barcode and Do Inventory Update settings still
apply and are "sticky" on the Circulation->Checkin interface
2. confirm Strict Barcode still applies and is "sticky" on the
Circulation->Renew Items and Circulation->Checkout interfaces
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Garry Collum [Thu, 18 Mar 2021 19:56:04 +0000 (15:56 -0400)]
LP1917944-Hold Pickup Library sometimes Empty
Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.
To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.
To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
select * from actor.usr_setting;
3. Update the setting.
update actor.usr_setting set value = '""' where id = <the id number>;
13. Address on Library Info page (was only showing mailing address -
now shows physical/billing address and shows mailing address only if
different from billing address)
Chris Sharp [Tue, 23 Mar 2021 23:03:32 +0000 (19:03 -0400)]
LP#1921057 - Expand reporter.demographic to include detailed age breakdown
Add "age_division" column to reporter.demographic. Expose the new
column to the reporter as "Detailed Age Division" resulting in the following
options:
Child 0-5 Years Old
Child 6-12 Years Old
Teen 13-17 Years Old
Adult 18-25 Years Old
Adult 50-59 Years Old
Adult 50-59 Years Old
Adult 60-69 Years Old
Adult 70+
If no DOB is present, say so.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Terran McCanna [Mon, 1 Mar 2021 15:41:04 +0000 (10:41 -0500)]
PINES Customization to Curbside Pickup
Currently, the curbside module only allows you to view items
to be staged and items that are staged 2 time slots ahead. This is
hardcoded in the perlmod and really should be org unit settings, but
for now, this adjusts that number to 10 slots ahead as a temporary
workaround.
Terran McCanna [Tue, 2 Mar 2021 19:21:24 +0000 (14:21 -0500)]
PINES Workaround for broken place hold links
This is a temporary workaround for the broken Cancel / Continue /
Back to Search buttons in the OPAC. This workaround can be removed
when a fix for https://bugs.launchpad.net/evergreen/+bug/1917513
is developed.
Terran McCanna [Thu, 25 Feb 2021 14:58:23 +0000 (09:58 -0500)]
LP 1916904 Bootstrap OPAC: Call number on Search Results Page
This adds the call number to the search results page when
"Show More Details" is not selected. (This brings back the same
behavior as the pre-bootstrap OPAC.)
Terran McCanna [Fri, 22 Jan 2021 18:00:06 +0000 (13:00 -0500)]
PINES Workaround for Broken Splash Page Search Box
With the change from 3.4 to 3.6, the search box on /eg/staff/splash
broke for multiple word searches. This workaround redirects the
old staff page to the Angular staff page.
Terran McCanna [Fri, 19 Feb 2021 00:37:35 +0000 (19:37 -0500)]
LP1916085 Bootstrap OPAC - Pagination on copy table
This adjusts some of the display logic in the Bootstrap OPAC
copy table pagination that had been causing the Next / Prev and
Show Fewer Copies links to be hidden when they shouldn't be.
Bill Erickson [Tue, 9 Feb 2021 16:10:41 +0000 (11:10 -0500)]
LP1908743 Hold pickup lib does not require have-users; repairs
To match the TPAC, only disable org units where can_have_vols is false
in the hold pickup library selector (plus those explicitly disabled via
setting).
Also fixes a thinko in the settings retrieval code.
Jason Boyer [Mon, 8 Feb 2021 19:20:32 +0000 (14:20 -0500)]
LP1914116: Apply html filter to mkurl() output
Because of the way that mkurl() generates its query parameters they're
generally escaped correctly, but nowhere do we run the output of mkurl()
through the html filter to correctly handle ampersands. Rather than adding
"|html" to every invocation of mkurl, it's just added to the macro directly.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Garry Collum <gcollum@gmail.com>
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib
In the Angular staff catalog, disable org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied, plus those that have false values for can-have-users or
can-have-vols.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Bill Erickson [Thu, 28 Jan 2021 15:32:11 +0000 (10:32 -0500)]
LP1913338 Catalog search form visibility stickiness
On pages in the Angular staff catalog where the search form is collapsed
by default, users may now also manually expand and re-collapse the form.
The last used choice will be sticky via new workstation setting.
Bill Erickson [Mon, 1 Feb 2021 15:54:18 +0000 (10:54 -0500)]
LP1913811 Items out notice summary API batching
Tweak the open-ils.actor.user.itemsout.notices API to accept an array of
circulation IDs so the call can be batched from the client. Similarly
modify the AngJS client to request the notice summaries in batch.
Further improves the notices API by removing an unneeded join and a
minor security fix to verify perms based on the in-database user ID
instead of the ID provided by the caller (w/ the note that the API only
returns numbers, not user data).
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Terran McCanna [Wed, 3 Feb 2021 15:31:58 +0000 (10:31 -0500)]
PINES fix for old catalog hold email display
Problem: If a staff member uses the old/traditional catalog
through the 3.6 staff client to place a hold, the staff member's
email address displays rather than the patron. It still saved
correctly, just displayed wrong.
Fix: This blocks the display of the email address on the holds
page when using the staff client. It still displays to patrons
using the OPAC.
Jason Boyer [Thu, 21 Jan 2021 16:08:36 +0000 (11:08 -0500)]
LP1687545: Force TT CGI plugin to use ampersands in query strings
Change our already-forked version of TemplateToolkit::Plugin::CGI
to use "old" style urls which became the new / only style after
CGI.pm was deprecated. This causes the query_strings property to
consistently use ampersands to separate query parameters.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib
In the Angular staff catalog, hide org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied.
Bill Erickson [Mon, 11 Jan 2021 17:06:21 +0000 (12:06 -0500)]
LP1911031 Staff catalog honors pickup lib change
Manually modifying the pickup library in the staff catalog holds
placement form now results in using the selected pickup library.
Previously, the change was ignored by the form.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib
In the Angular staff catalog, hide org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied.
Terran McCanna [Mon, 11 Jan 2021 21:57:44 +0000 (16:57 -0500)]
PINES Self-Check: Fix for Pay Fines Button
The 'Pay Fines' button was appearing in some scenarios, even
though it's not possible to pay fines through the self-check
at this time. This completely removes that button.
Reject requests to SharedWorker resources when shared workers are not
supported. The caller is required to handle the rejection in whatever
way makes sense for the calling code.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Force the SharedWorker code to run before org settings cache requests
are attempted so that we can tell before the lovefield request is made
wether or not a connection will be successfull. In other words, we may
not know if cannotConnect is true yet, so force that logic to run first.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Display electronic resource links (MARC 856's) in the Angular staff
catalog. The extraction logic, which matches the TPAC, has been put
into its own API.
projects / evergreen / pines.git / log