Tiffany Little [Mon, 9 Jan 2023 17:41:21 +0000 (12:41 -0500)]
LP1953181 Fix combobox div and funds spacing
Removes input-prepend that was causing other comboboxes to be shrunk, and moves the year selector closer to the Library dropdown so it's not floating out by itself.
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Jeff Davis [Tue, 15 Nov 2022 23:11:49 +0000 (15:11 -0800)]
LP#1996651: treat empty string as null for preferred name/alias in wide_hold_data
This prevents the patron name from appearing blank in the hold shelf
"User Display Name" or "User Alias or Display Name" columns when the
alias or preferred name fields are empty strings.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Bill Erickson [Mon, 8 Aug 2022 18:04:55 +0000 (14:04 -0400)]
LP1915440 Clear Hopeless Date on Capture
Clear the hold hopeless date when a copy is captured for the hold.
One way to make this happen for testing:
. Configure the Missing copy status as holdable=true hopeless_prone=true
. Place hold with only 1 viable copy.
. Mark said copy as missing -- this stamps a hopeless_date on the hold.
. Check the copy in. This results in a capture + hopeless hold.
Terran McCanna [Thu, 5 Aug 2021 22:36:17 +0000 (18:36 -0400)]
Quipu Online Account Renewal - Squashed
Online Renewal - Start of working branch
- Creates placeholders for new English & Spanish pages
- Adds ability for those pages to load
- Create div on My Account main page & prefs page to hold renewal message or button
- Adds code to check whether or not patron is eligible to renew online or not:
* patron has not already had one temporary renewal
* patron account is still active
* patron account expiration date is no more than 30 days in the future
* patron account is not barred
* patron account does not have a staff-added blocking alert
* patron does not owe any fines
* patron is not in collections (even if patron pays fines, staff still need
to remove collections note)
* patron is in one of these perm groups: Patron (2), Friend (14), GLS (56),
Homebound (53), Trustee (22), Quipu (64), Digital Only (60)
* patron has a valid billing address
* patron has a valid day phone
NOTE: New standing penalty needs to be created called PATRON_TEMP_RENEWAL.
It should display a staff alert and have the label "Patron was given a 30-day temporary account renewal. Please archive this message after the account is fully renewed." It should not create any type of block on its own. The ID of
the new standing penalty needs to be updated in the Account.pm file.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Progress on writing quipu into to db
Still to do:
* Actor.pm - failing on standing penalties line 597
* sub update_addresses - creating separate addresses works if mailing & billing are different,
but it is not checking the right checkbox
* writing new home ou is failing on terran-test, but should work on pines data
* after update, opac page doesn't refresh
* if this is a temporary (30 day) renewal, need to pass message to quipu telling patron to come to the library
* if temp renewal, need to add alert to patron account to inform staff to get proof of identity to do full renewal
* need to test voter registration survey on pines test server since I don't have that on my test server
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Show Updated Expire Date
Without this, the page loads the initial patron expiration date
and continues to show the button to renew the account.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Document which patron groups are eligible in code
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Now saving and responding okay
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
add column to permission.grp_tree to account for e-renew
Online Renewal - tweak SQL
- Parentheses on first SQL generated error.
- Set erenew default to FALSE instead of TRUE.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - See & update permission group setting through staff client
Galen Charlton [Thu, 5 May 2022 16:44:26 +0000 (12:44 -0400)]
LP#1971745: work around issue that can cause large hold shelf lists to fail
This patch addresses an issue where hold shelf lists with
more than ~350 rows can fail to be retrieved. It works by
making the open-ils.circ.hold.wide_hash.stream method fetch
the holds from an open-ils.storage method in one fell swoop,
rather than both streaming the list from open-ils.storage and
streaming it back to the client that invoked the open-ils.circ
method.
I suspect that this is working around a subtle OpenSRF bug when
bidirectional streaming is in play, but I'm not positive.
To test
-------
[1] Set up an environment with hundreds or thousands of holds on
a shelf at an OU.
[2] Attempt to display the holds shelf list.
[3] It may fail; if it doesn't, try with even larger number of holds
or by setting up a test system that has ejabberd s2s going on
to service requests.
[4] Apply the patch and repeat step 2. This time, the holds shelf
list should be consistently retrieved. There will also be a
user-visible change: the spinner on the AngularJS holds shelf page
will pause for a few seconds, then start advancing.
Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.
Modified KPAC login code to redirect to KPAC after logging in
Signed-off-by: Adam Bowling <abowling@emeralddata.net> Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/kpac/parts/header.tt2
Fix for too-large header sizes causing display issues in KPAC
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Fix for KPAC holdings display issue.
Updated link to old library map to new library locator map in KPAC.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Improvements to KPAC list display, especially adding
display of list annotations that were not shown.
Removed added content from the KPAC for now since it doesn't
display properly. Possibly add back in later if we can get
the NoveList content to pull in right.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC changes in preparation for upgrade:
1. Biggest change was to move the library selector box to the main
search panel instead of on the side - had to modify quite a few files
in order to make this work and pass the values correctly.
2. Also changed the feature icons to use links instead of search terms
to allow more control over search limits and sorting and to see if
caching the searches would improve response speed.
3. A number of smaller UI changes.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC - Hold results not displaying item title and throwing log error
I believe the path comparison operator in the 'load' subroutine has
a flaw in logic caused by a path-naming problem. The path-matching
function recognizes the kpac/getit_results path as matching positively
for both the load_getit subroutine and the load_getit_results subroutine.
This patch reverses the order in which the matching occurs in an attempt
to resolve the conflict.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
I've redone all of the kpac category links so they no longer use
a link shortener. I also rearranged some of the links so that there
are more options on the home page.
Updates to KPAC Features (addition of TumbleBooks)
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Since we only have bits and pieces of Spanish translations for our
customized KPAC right now, removing the parts that would display in
Spanish if Spanish has been selected in the OPAC. In the future when
all parts of the KPAC have been translated and graphic buttons have
been switched to text buttons that can be translated, we will then
need to go back in and re-add the language markup to allow the
translations to occur.
Bill Erickson [Tue, 7 Jul 2020 14:41:36 +0000 (10:41 -0400)]
Quipu Ecard Registration - Squashed for EG 3.10
KCLS Quipu integration bits
Notes:
1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
bibliocommons and should be removed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu eCard Integration for PINES
Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu Customizations
Move library card application link to top menu instead of bottom menu,
cleaned up a lot of whitespace issues and old commented out text,
added CSS controls for parts of the Quipu form.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Self-Registration Form
Edited both ecard.tt2 and register.tt2 to add quipu form javascript
and add intro text.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Ecard Form Update
Added CSS to intro text to hide unless Quipu's code tells it to display.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: Quipu changes for Bootstrap OPAC
This commit just modifies the front end registration page and CSS,
not the perl changes.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: fix Quipu ecard for bootstrap
Quipu - Adjust iframe height
The iframe was cutting off the form causing a double scroll
bar in the browser. This increases the height so that additional
scrolling is not needed.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES Customization: Quipu Spanish Form
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu: check on full DOB, skip address checking
Bill Erickson [Tue, 7 Jul 2020 14:41:36 +0000 (10:41 -0400)]
Quipu Ecard Registration - Squashed for EG 3.10
KCLS Quipu integration bits
Notes:
1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
bibliocommons and should be removed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu eCard Integration for PINES
Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu Customizations
Move library card application link to top menu instead of bottom menu,
cleaned up a lot of whitespace issues and old commented out text,
added CSS controls for parts of the Quipu form.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Self-Registration Form
Edited both ecard.tt2 and register.tt2 to add quipu form javascript
and add intro text.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Ecard Form Update
Added CSS to intro text to hide unless Quipu's code tells it to display.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: Quipu changes for Bootstrap OPAC
This commit just modifies the front end registration page and CSS,
not the perl changes.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: fix Quipu ecard for bootstrap
Quipu - Adjust iframe height
The iframe was cutting off the form causing a double scroll
bar in the browser. This increases the height so that additional
scrolling is not needed.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES Customization: Quipu Spanish Form
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu: check on full DOB, skip address checking
Bill Erickson [Tue, 7 Jul 2020 14:41:36 +0000 (10:41 -0400)]
Quipu Ecard Registration - Squashed for EG 3.10
KCLS Quipu integration bits
Notes:
1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
bibliocommons and should be removed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu eCard Integration for PINES
Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu Customizations
Move library card application link to top menu instead of bottom menu,
cleaned up a lot of whitespace issues and old commented out text,
added CSS controls for parts of the Quipu form.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Self-Registration Form
Edited both ecard.tt2 and register.tt2 to add quipu form javascript
and add intro text.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Ecard Form Update
Added CSS to intro text to hide unless Quipu's code tells it to display.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: Quipu changes for Bootstrap OPAC
This commit just modifies the front end registration page and CSS,
not the perl changes.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: fix Quipu ecard for bootstrap
Quipu - Adjust iframe height
The iframe was cutting off the form causing a double scroll
bar in the browser. This increases the height so that additional
scrolling is not needed.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES Customization: Quipu Spanish Form
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu: check on full DOB, skip address checking
Bill Erickson [Tue, 7 Jul 2020 14:41:36 +0000 (10:41 -0400)]
Quipu Ecard Registration - Squashed for EG 3.10
KCLS Quipu integration bits
Notes:
1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
bibliocommons and should be removed.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu eCard Integration for PINES
Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Quipu Customizations
Move library card application link to top menu instead of bottom menu,
cleaned up a lot of whitespace issues and old commented out text,
added CSS controls for parts of the Quipu form.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Self-Registration Form
Edited both ecard.tt2 and register.tt2 to add quipu form javascript
and add intro text.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu Ecard Form Update
Added CSS to intro text to hide unless Quipu's code tells it to display.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: Quipu changes for Bootstrap OPAC
This commit just modifies the front end registration page and CSS,
not the perl changes.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: fix Quipu ecard for bootstrap
Quipu - Adjust iframe height
The iframe was cutting off the form causing a double scroll
bar in the browser. This increases the height so that additional
scrolling is not needed.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES Customization: Quipu Spanish Form
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Quipu: check on full DOB, skip address checking
Enable ability for carousel to automatically advance every 2 seconds.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
OPAC: restore books image for carousels
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
LP1929872 Open Carousel as a Result List
This adds a new link in the carousel block that will open the
contents of that carousel in a result list format so that a patron
can see everything at once.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Carousel - moving logic to open carousel as a list into new API
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1929872 Make carousel title into link
(instead of having a new link under the title)
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
LP1929872 Fixing link
PINES OPAC Carousel CSS
Adds additional CSS for iframe usage that overrides the basic
OPAC usage CSS.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES - Add list icon next to carousel title
Chris Sharp [Wed, 1 Apr 2015 17:16:03 +0000 (13:16 -0400)]
PINES Custom Self-Check for 3.10 Upgrade#
branding the built-in selfcheck interface for PINES
These are modifications to the Evergreen self-check interface to:
1. Fix bugs with printing holds and fines.
2. Improve page layout overall, and with consideration for
1024x768 resolution monitors that a lot of libraries use.
3. Hide hold status from view on holds table.
4. Hide buttons/fields from screen when user is not logged in.
Change base.xul/base.js to support a "cookie path" option to limit what paths
will use the login cookie, then tell the selfcheck interface to use it.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Self-Check changes in preparation for upgrade:
Changed wording on some of the on-screen directions.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Restoring selfcheck.js to stock version
PINES Customization: Self-check text changes
Modified login text to make it more user friendly.
Added note to screen referring people to online catalog if they
wish to perform functions not available in self-check such as
paying fines and handling renewals.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES fix for self-check missing code
This adds back code that is in master and was in rel_3_6_1, but was
missing in rel_3_8_0.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES Customization to Self-check Wording
Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded. Instead, explicitly
check that the setting is "True".
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Customization of self-check interface so that username, password,
and barcode text banners appear in different colors in an effort
to make it clearer to patrons that they are being asked for a
different type of information.
Note that that this also tweaks the password check because the old
format was different from current master and no longer working correctly.
Terran McCanna [Fri, 12 Nov 2021 22:10:51 +0000 (17:10 -0500)]
PINES Custom - Make buttons on hold cancel dialogs consistent
This makes the order and wording of the AngularJS and Angular cancel hold
options consistent between the patron account and the hopeless holds interface.