]> git.evergreen-ils.org Git - contrib/Conifer.git/log
contrib/Conifer.git
4 years agoUpdate translation for LU/USudbury login form rel_3_1_2_mergery_tpac
Dan Scott [Mon, 14 Oct 2019 15:37:21 +0000 (11:37 -0400)]
Update translation for LU/USudbury login form

Signed-off-by: Dan Scott <dan@coffeecode.net>
4 years agoLink between Laurentian and USudbury from login forms
Dan Scott [Mon, 14 Oct 2019 15:37:07 +0000 (11:37 -0400)]
Link between Laurentian and USudbury from login forms

Increase the chance that users will be able to log into their accounts.

Signed-off-by: Dan Scott <dan@coffeecode.net>
4 years agoBasic Matomo Analytics support
Dan Scott [Wed, 3 Jul 2019 18:19:42 +0000 (14:19 -0400)]
Basic Matomo Analytics support

After you have set up a Matomo Analytics server, you can track web analytics by
customizing templates/opac/parts/config.tt2 to identify your Matomo server URL
and the ID of the site you are tracking.

Signed-off-by: Dan Scott <dan@coffeecode.net>
5 years agoACQ: default to selected line items instead of all line items
Dan Scott [Tue, 12 Jun 2018 17:20:04 +0000 (13:20 -0400)]
ACQ: default to selected line items instead of all line items

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoFix MIME types for various SuperCat feeds
Dan Scott [Mon, 11 Jun 2018 18:27:57 +0000 (14:27 -0400)]
Fix MIME types for various SuperCat feeds

Zotero depends on valid MIME types as a way of identifying content retrieved
via unAPI. Passing 'application/xml' instead of 'application/marcxml' or
'application/xml+mods' doesn't enable Zotero (or other applications) to
properly distinguish the content.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoMore French translation goodness
Dan Scott [Sat, 2 Jun 2018 01:28:41 +0000 (18:28 -0700)]
More French translation goodness

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoRestore patron search opt_in_override API
Dan Scott [Sat, 2 Jun 2018 06:03:30 +0000 (02:03 -0400)]
Restore patron search opt_in_override API

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoTweak wikidata paths for contributors
Dan Scott [Thu, 31 May 2018 20:31:52 +0000 (16:31 -0400)]
Tweak wikidata paths for contributors

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoFirst pass at Algoma U tpac skin for rel_2_7
Robin Isard [Fri, 3 Aug 2012 19:59:57 +0000 (15:59 -0400)]
First pass at Algoma U tpac skin for rel_2_7

This was done in a hurry and simply handles the esential links, logos and branding.

 *changed the main logo on the homepate
 *changed the header links to reflect new library website
 *added footer links
 *added config file based on lul's to enable OpenURL

In addition to adding the same graphical header so that the OPAC
more closely resembles the new Wishart website, this change
incorporates several smaller fixes:
    * replace the AlgomaU "small university/big education" logo
      with the small AlgomaU wordmark
    * center the logo via CSS, not <center>
    * fix vertical centering of the "your account log in" text --
      needs margins only left & right, not on all 4 sides
    * replace border on the user/pass input boxen so that they
      are visible once again.

Forbid holds on items that are currently available

5 years agoUniversity of Sudbury basic skin
Dan Scott [Mon, 27 Aug 2012 15:56:22 +0000 (11:56 -0400)]
University of Sudbury basic skin

Logos and one link; not even touching colours yet.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd TPAC UHearst colours, logos, and links
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add TPAC UHearst colours, logos, and links

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd SJCG TPAC skin
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add SJCG TPAC skin

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoBasic Laurentian University branding: colours and logos
Dan Scott [Tue, 31 Jul 2012 18:53:48 +0000 (14:53 -0400)]
Basic Laurentian University branding: colours and logos

Required some wrestling with the default stylesheet but otherwise we
appear to be good.

Phone notifications for holds do not happen. Hide any mention of phone
numbers or widgets for changing phone numbers.

We also do not want to enable users to update their username, password, or
email address.

Override style.css in a separate stylesheet

One more HTTP request, but much simpler tracking of HEAD stylesheet
changes.

Customize login form for Laurentian LDAP login

Set ou_email_host via a hidden form variable.

Provide more rational inline help for OSUL login form.

Link to the OSUL password reset form on login failure

Avoid the "place holds on available" lists hole by ripping out the option
entirely, naturally.

Turn on Google Book Previews

Hide the display of 659 fields in Laurentian records. They appear to
have been used for some sort of identifiers, not genres, and are
meaningless to users.

Remove the "Stay logged in" checkbox until we uncover the actual problem
with logging in via LDAP and persistence.

Enable Google Analytics in Laurentian skin

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd NOSM TPAC skin: colours, logos, links
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add NOSM TPAC skin: colours, logos, links

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd a simple, long-overdue theme for Huntington
Dan Scott [Tue, 22 Jan 2013 17:51:51 +0000 (12:51 -0500)]
Add a simple, long-overdue theme for Huntington

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDisable metarecords; merge config.tt2 changes
Dan Scott [Wed, 17 Dec 2014 20:53:42 +0000 (15:53 -0500)]
Disable metarecords; merge config.tt2 changes

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd HRSRH skin: logo, colours, links
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add HRSRH skin: logo, colours, links

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoConifer-wide config settings
Dan Scott [Fri, 20 Apr 2018 17:59:07 +0000 (13:59 -0400)]
Conifer-wide config settings

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd CFOF minimal skin
Dan Scott [Fri, 10 Feb 2017 20:50:52 +0000 (15:50 -0500)]
Add CFOF minimal skin

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoBasic TPAC Boreal branding: colours and logo and links
Dan Scott [Tue, 31 Jul 2012 18:53:48 +0000 (14:53 -0400)]
Basic TPAC Boreal branding: colours and logo and links

Link from logo to College Boreal itself
Remove "Tembec" from name, hide old OPAC link
Change links to union catalogue for Boreal tpac skin

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoRemove display of patron birthdate, internet access level, etc
Dan Scott [Mon, 30 May 2011 17:14:29 +0000 (13:14 -0400)]
Remove display of patron birthdate, internet access level, etc

These fields in the staff client are either not applicable or
potentially privacy-invasive or both. If the data somehow does
get into the system, we don't want it to show up on the staff
client anyway - and we don't want annoying warnings about unset
dates of birth, etc.

This is the hardcore way of doing things, we really should make
it yet another configuration setting. Oh well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoQuick hack to default to 2019 for acquisitions
Dan Scott [Thu, 8 Sep 2016 17:22:59 +0000 (13:22 -0400)]
Quick hack to default to 2019 for acquisitions

Having a financial year that doesn't run from January to December can be
annoying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDefault the Dojo OU selector to the current WS value
Dan Scott [Wed, 23 Dec 2015 20:18:31 +0000 (15:18 -0500)]
Default the Dojo OU selector to the current WS value

Because this.orgDefaultsToWs does not appear to be set, even though
po/create.js tries to set it, we want a sane default anyway.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoDo not show Consortial counts. Because annoying.
Dan Scott [Thu, 11 Dec 2014 22:05:27 +0000 (17:05 -0500)]
Do not show Consortial counts. Because annoying.

Probably could/should do this via org hiding?

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoIntegrate Wikidata card for music
Dan Scott [Tue, 23 May 2017 03:26:28 +0000 (23:26 -0400)]
Integrate Wikidata card for music

Wikidata music infocard with Wikipedia description

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd production moveto interfaces
Dan Scott [Fri, 20 Apr 2018 16:24:57 +0000 (12:24 -0400)]
Add production moveto interfaces

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoScript to generate nginx & apache configs
Dan Scott [Sun, 16 Jul 2017 21:07:45 +0000 (14:07 -0700)]
Script to generate nginx & apache configs

Given a set of hostnames, generate the appropriate nginx proxy and apache
config files. Also spit out a certbot command to generate a letsencrypt
certificate based on those hostnames.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoFix encoding issues in HTML report files
Dan Scott [Tue, 17 Nov 2015 17:11:19 +0000 (12:11 -0500)]
Fix encoding issues in HTML report files

Opening the files without the utf-8 encoding pragma resulted in
corrupted UTF8 output.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoTreat a Polish l as an ASCII l in full-text search
Dan Scott [Tue, 11 Nov 2014 16:53:24 +0000 (11:53 -0500)]
Treat a Polish l as an ASCII l in full-text search

Is this code path even hit these days? Would have expected
naco_normalize to be poking around here if that was the case...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoLDAP authentication enablement for OSUL
Dan Scott [Mon, 27 Aug 2012 22:38:51 +0000 (18:38 -0400)]
LDAP authentication enablement for OSUL

We use the local-part of the email address to authenticate against the LDAP
server.

In the VirtualHost sections of Apache, we can use SetEnv to force the
physical_loc to match the org unit ID(s) specified in opensrf.xml; for
example:

SetEnv physical_loc 103

At Laurentian, all usernames will be lowercase.  This will prevent mismatches
like the user entering "dscott" and the database having the value "DScott" (in
that we're going to force all of the Laurentian user names in the database to
lower case).

Add an ou_host_name parameter for TPAC login forms

If set, and the incoming username does not already include an '@' symbol
(a very simple attempt to detect if we're already dealing with an email
address), then append '@' + the ou_host_name value to the username for
authentication purposes.

The rationale is that in a large consortium, you might want to enable
users to log in with short usernames (like 'fred'), but you also want to
avoid conflicts between short usernames at different organizational
units. Thus, create the users with the email equivalent of their
usernames, like 'fred@br1.example.com' and 'fred@br4.example.com', and
let the templates for the TPAC in br1 and br4 contain a hidden input
field to append the appropriate email hostname.

Truth be told, this is probably most appropriate for a large consortium
containing two or more academic institutions that hope to use LDAP
authentication rather than native authentication, and therefore have
LDAP CNs that map to email addresses of CN@hostname that can then be
mapped to actor.usr.usrname (and actor.usr.email, of course).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoGeneric patron barcode generation (OpenSRF and DB)
Dan Scott [Thu, 10 Jan 2013 19:17:33 +0000 (14:17 -0500)]
Generic patron barcode generation (OpenSRF and DB)

Laurentian University needed the ability to generate barcodes as part of
its LDAP integration work, and the first generation (so to speak) of the
was specific to LU - including hard-coded prefixes and database
functions that include the "lu" name.

This commit makes the functionality much more generic and thus more
likely to be able to be adopted by other institutions. The principle
components are:

Database functions:

evergreen.actor_generate_barcode([prefix TEXT]) - returns a 14-digit
  barcode from the evergreen.actor_barcode_seq sequence with a prefix of
  'AUTOBC' or the specific prefix of up to 6 characters. If the
  resulting barcode is all digits, then the 14th character will be a
  mod10 check digit; otherwise the 14th digit will be '0'.

evergreen.actor_update_barcode(usr_id INTEGER[, prefix TEXT]) -
  generates a new barcode for the specified user, with the optional
  barcode prefix.

evergreen.mod10(barcode TEXT) - given a barcode, generates a mod10
  check digit and returns the barcode with the appended check digit

OpenSRF method:

open-ils.actor.generate_patron_barcode([usr_id INT[, prefix TEXT]]) -
  generates a new barcode for the patron

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd and use a patron search that overrides opt-in invisibility
Dan Scott [Wed, 14 Sep 2011 20:02:14 +0000 (16:02 -0400)]
Add and use a patron search that overrides opt-in invisibility

Something like this is required for API calls that need to operate
against a number of libraries in a given instance that are using opt-in;
otherwise, attempts to search for users will fail and you may end up
creating near-duplicates etc.

The implementation adds an
open-ils.actor.search.patron.advanced.opt_in_override method to
open-ils.actor, which, if invoked, checks to see if the caller has the
OPT_IN_OVERRIDE permission. If so, then the crazy_search ignores the
normal opt-in limits and searches all pertinent users in the database.

As a global permission, OPT_IN_OVERRIDE is a blunt instrument. Others
might want to put together a more refined version that uses OU depths to
define boundaries.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoAdd Conifer MARC templates
Dan Scott [Fri, 20 Apr 2018 16:00:47 +0000 (12:00 -0400)]
Add Conifer MARC templates

Signed-off-by: Dan Scott <dscott@laurentian.ca>
5 years agoTranslation updates - po files
Dan Wells [Sun, 27 May 2018 14:10:01 +0000 (10:10 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoTranslation updates - newpot
Dan Wells [Sun, 27 May 2018 14:06:57 +0000 (10:06 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDocs: Release notes entry for lp1732975
Kathy Lussier [Fri, 25 May 2018 21:12:59 +0000 (17:12 -0400)]
Docs: Release notes entry for lp1732975

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agolp1732975 Parts Column Not Populated
Kyle Huckins [Wed, 2 May 2018 17:47:04 +0000 (17:47 +0000)]
lp1732975 Parts Column Not Populated

- Retrieve Parts information in egItem

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Add release note for bug 1707063 to 3.0 notes
Kathy Lussier [Fri, 25 May 2018 20:49:26 +0000 (16:49 -0400)]
Docs: Add release note for bug 1707063 to 3.0 notes

I missed the 3.0 notes in the earlier commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Add release note for bug 1707063
Kathy Lussier [Fri, 25 May 2018 20:44:26 +0000 (16:44 -0400)]
Docs: Add release note for bug 1707063

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1707063: Naive ng-class test for last-column-modified
Mike Rylander [Mon, 29 Jan 2018 21:37:15 +0000 (16:37 -0500)]
LP#1707063: Naive ng-class test for last-column-modified

Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Add release notes entry for lp1766379
Kathy Lussier [Fri, 25 May 2018 20:23:05 +0000 (16:23 -0400)]
Docs: Add release notes entry for lp1766379

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1766379: add spaces between terms in author link to prevent a broken search query
Jeff Davis [Wed, 16 May 2018 18:31:43 +0000 (11:31 -0700)]
LP#1766379: add spaces between terms in author link to prevent a broken search query

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: adding to 3.1.2 release notes
Jane Sandberg [Fri, 25 May 2018 20:23:40 +0000 (13:23 -0700)]
Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: correcting description of a bugfix
Jane Sandberg [Fri, 25 May 2018 20:14:12 +0000 (13:14 -0700)]
Docs: correcting description of a bugfix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: adding to 3.0.8 release notes
Jane Sandberg [Fri, 25 May 2018 19:53:28 +0000 (12:53 -0700)]
Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1750887: Copy Objects when Saving Copy Templates
Jason Boyer [Wed, 21 Feb 2018 18:59:44 +0000 (13:59 -0500)]
LP1750887: Copy Objects when Saving Copy Templates

Copy the callnumbers and statcats objects when saving
copy templates to prevent accidental and confusing
editing of in-memory copies.

cesardv: changed tabs to spaces.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1771422 Reset transiting hold copy status fix
Bill Erickson [Tue, 15 May 2018 20:12:12 +0000 (16:12 -0400)]
LP#1771422 Reset transiting hold copy status fix

Avoid modifying the copy status in the hold-reset API when it's passing
the copy off to the transit API for canceling the transit.  Let the
transit API handle the status instead.

This fixes a bug where resetting a transiting hold, and canceling its
transit, would leave the targeted copy in "in transit" status instead of
"canceled transit".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1750630: use proper quoting to un-break Transit List print template
Lynn Floyd [Mon, 7 May 2018 17:43:01 +0000 (10:43 -0700)]
LP#1750630: use proper quoting to un-break Transit List print template

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1528909: Patron search clickable barcodes
Bill Erickson [Tue, 22 May 2018 15:18:01 +0000 (11:18 -0400)]
LP#1528909: Patron search clickable barcodes

Patron barcodes in the patron search grid are now click-able, making it
possible to quickly open multiple patrons in new tabs from patron search
by control-clicking (or middle-clicking) the barcode links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1721148: In-house use shows copy status
Bill Erickson [Mon, 21 May 2018 18:22:32 +0000 (14:22 -0400)]
LP#1721148: In-house use shows copy status

Adds a Copy Status column to the In-House use checkout grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLp#1760859: Add Missing Images to Tranist and Hold Slips
Jeanette Lundgren [Mon, 14 May 2018 17:26:45 +0000 (13:26 -0400)]
Lp#1760859: Add Missing Images to Tranist and Hold Slips

Added new truck transit.png image for web client holds/transit dialog

Added holds.png img tag to t_hold_shelf_dialog.tt2

Added transit.png img tag to t_transit_dialog.tt2

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1759352: improve webstaff fix checkout specific due date UX
Cesar Velez [Fri, 30 Mar 2018 15:32:45 +0000 (11:32 -0400)]
LP#1759352: improve webstaff fix checkout specific due date UX

The Date Options dropdown UI added as a result of bug 1717025
hides the state of the "checkboxes" for custom due date and
the datepicker wasn't disabled when custom due date was disabled.
This addresses these UX issues, to that the user has visual feedback
as to the state of that option.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1751126: Make print holds shelf list aware of clear mode.
Jason Stephenson [Tue, 10 Apr 2018 14:51:24 +0000 (10:51 -0400)]
LP#1751126: Make print holds shelf list aware of clear mode.

We change the Print Full List button on the holds shelf view to be
aware of whether clear mode is active.  If clear mode is active, then
the list of holds to clear is printed.  If not, then the full holds
shelf list is printed.

This commit does not change the label of the print full list button.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1772417: (follow-up) improve I18N of the bucket title string
Galen Charlton [Fri, 25 May 2018 18:25:44 +0000 (14:25 -0400)]
LP#1772417: (follow-up) improve I18N of the bucket title string

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1772417: Adding the bucket ID to the user bucket display
Jane Sandberg [Mon, 21 May 2018 16:28:39 +0000 (09:28 -0700)]
LP1772417: Adding the bucket ID to the user bucket display

To test:
1) Open a patron bucket.  Note that the bucket ID is not listed
in the bucket information section at the top of this screen.
2) Apply this commit.
3) Open the same patron bucket.  Note that the bucket ID is
listed in the bucket information section

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1752753: Guard against invalid timezone
Jeff Davis [Fri, 2 Mar 2018 00:55:46 +0000 (16:55 -0800)]
LP#1752753: Guard against invalid timezone

If the lib.timezone org setting is not a valid timezone, attempting to
use it can result in an internal server error in the OPAC.  Let's handle
the error with try/catch instead.

To test
-------
1. In Library Settings Editor, edit the "Library time zone" setting for
   Example Branch 1, setting the value to something that's not the name
   of a time zone (like "invalid" or "UTC-07:00").
2. In the OPAC, retrieve a record with holdings at Example Branch 1.
    You will get an Internal Server Error.
3. Edit the library setting to use a valid timezone name, like
   "America/Vancouver".
4. Retrieve the same record again. This time, the record will display
   properly.
5. Apply the patch and repeat steps 1 and 2; this time, there should
   be no internal server error.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoStamping upgrade script
Mike Rylander [Fri, 25 May 2018 18:13:22 +0000 (14:13 -0400)]
Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1768992: Add missing copy alert permissions
Jeff Davis [Thu, 3 May 2018 22:02:07 +0000 (15:02 -0700)]
LP#1768992: Add missing copy alert permissions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1693035 Login timeout honors workstation org
Bill Erickson [Tue, 17 Oct 2017 16:40:11 +0000 (12:40 -0400)]
LP#1693035 Login timeout honors workstation org

Use the org unit linked to the provided workstation to collect the
login timeout org unit setting value during login.  Previously, all
checks defaulted to the global org unit.

This patch solidifies the precedence order for OUS lookups during login
like so:

1. Workstation org unit.
2. API org unit value.
3. Users' home org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1746815: Fix sticky hold url param
Cesar Velez [Mon, 5 Feb 2018 22:45:22 +0000 (17:45 -0500)]
LP#1746815: Fix sticky hold url param

Renamed the hold_id url param from "id" to "hid" and prevent it from
sticking in url's where it not needed.

To test
-------
[1] Log in to the public catalog as a patron that has at least
    two hold requests.
[2] Go to the My Account holds tab and edit one of the holds.
[3] Rather than submit a change, click on the holds tab again.
[4] Note that /only/ the hold you were edit displays, and that the
    'id' URL parameter persists as you navigate through the public
    catalog.
[5] Apply the patch and repeat steps 1-3. This time, you should
    see all of the holds.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1772017: Correctly Extract Cast from Records
Jason Boyer [Fri, 18 May 2018 13:12:37 +0000 (09:12 -0400)]
LP1772017: Correctly Extract Cast from Records

authors.tt2 has been using field 508 for cast display but
the correct field is 511 when ind1=1.

Testing note:

In the Concerto data set, the title "The rum diary" is a good test
record, as it has both a 508 field and a 511.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoDocs: Adding to 3.1.2 release notes
Jane Sandberg [Fri, 25 May 2018 15:57:06 +0000 (08:57 -0700)]
Docs: Adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: adding to 3.0.8 release notes
Jane Sandberg [Fri, 25 May 2018 15:50:53 +0000 (08:50 -0700)]
Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#1753005: Avoid copy alert error for call numbers with no copies
Mike Rylander [Wed, 25 Apr 2018 16:32:15 +0000 (12:32 -0400)]
LP#1753005: Avoid copy alert error for call numbers with no copies

When displaying the Holdings View tab for a bib in the web staff client,
if a volume record has no copies, a Javascript error gets thrown.

Item-less volumes still end up in svc.copies at this point, so at the
moment it is necessary to check whether copy_alerts actually exists.
Some renaming might also be in order to clarify that svc.copies doesn't
necessarily contain /only/ fleshed acp records.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoLP#1755220: Return value checking in offline session fetch
Mike Rylander [Fri, 4 May 2018 13:58:53 +0000 (09:58 -0400)]
LP#1755220: Return value checking in offline session fetch

We need to make sure that we receive the correct shape of data (array) rather
than that we simply got anything when fetching sessions.  In the case of an
expired session token, we'll receive an ILS Event object informing us of the
expiration where we'd normally see a list of sessions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1745240: Hold Alias Missing from Hold Shelf Slip
Garry Collum [Wed, 23 May 2018 23:47:56 +0000 (19:47 -0400)]
LP#1745240: Hold Alias Missing from Hold Shelf Slip

A patron's hold alias can be printed in the hold shelf slip using the variable patron.alias.  This patch just adds 'patron.alias' to the list of available options displayed at the top of the template. Also adds a colon before the patron's name fields for consistency.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1745232 - Bill History Receipt doesn't have Finish Date
Garry Collum [Thu, 24 May 2018 02:17:38 +0000 (22:17 -0400)]
LP#1745232 - Bill History Receipt doesn't have Finish Date

Adds xact.finish and xact.summary.last_payment to the example data.  Also adds xact.summary.last_payment_ts to the template body to indicate when the last payment was made.  Also adds a list of variables that can be used in the template in the template's description.

To test -
1. apply the patch
2. find a patron with billings, or add some billings to a patron record.
3. make payments on some of the billings using various methods.
4. go to billing history and print the history list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1743782 Copy Status not available in Check-In Screen
gcollum [Sun, 20 May 2018 17:18:18 +0000 (13:18 -0400)]
LP#1743782 Copy Status not available in Check-In Screen

Makes the status an available column to display in the Check-In screen.

To test:
1. Apply patch.
2. Go to check-in and display 'Status' as a column in the table.
3. Check-in various items that may be checked-out, catch a hold, not checked out, etc.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1765731 - restore CN suffix and preffix in Holds Pull List
Cesar Velez [Thu, 19 Apr 2018 21:25:59 +0000 (17:25 -0400)]
LP#1765731 - restore CN suffix and preffix in Holds Pull List

Overly gung-ho removal of "redundant" fields/columns in bug
1728147 removed call number prefix and suffix as available columns
in the hold pull list grid in the web staff client; this will
restore them there.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoDocs: Adding to and reorganizing the 3.1.2 release notes
Jane Sandberg [Wed, 23 May 2018 22:52:56 +0000 (15:52 -0700)]
Docs: Adding to and reorganizing the 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: Adding to and reorganizing the 3.0.8 release notes
Jane Sandberg [Wed, 23 May 2018 22:48:02 +0000 (15:48 -0700)]
Docs: Adding to and reorganizing the 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#1765444: improve how MARC editor fetches fixed field metadata
Galen Charlton [Thu, 19 Apr 2018 15:44:42 +0000 (11:44 -0400)]
LP#1765444: improve how MARC editor fetches fixed field metadata

This patch fixes a problem where the web staff MARC editor would
make repeated and redundant calls to two Evergreen methods to fetch
data about fixed field positions and values if that metadata was
not already cached by local storage or Hatch.

In particular, this patch caches and returns the data retrieval
promises, ensuring that only one set of FF position and value
requests are made.

Prior to this patch, each eg-marc-edit-fixed-field directive, of which
there are 64, could end up invoking those methods when initializing
the editor for a record type that had not been previously seen.

To test
-------
[1] Clear all FFPosTable_* and FFValueTable_* keys from local storage
    (or Hatch).
[2] Retrieve a bib record in the web staff client. Note that up to
    64 calls each are made of open-ils.cat.biblio.fixed_field_values.by_rec_type
    and open-ils.fielder.cmfpm.atomic.
[3] Apply the patch and repeat steps #1 and #2.
[4] This time, note that only one call each are made.
[5] Verify that the fixed field inputs continue to work as expected.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1770478: Offline org unit tree can break
Mike Rylander [Tue, 15 May 2018 21:21:00 +0000 (17:21 -0400)]
LP#1770478: Offline org unit tree can break

A thinko in the org tree reconstruction for offline mode caused the tree to be
broken in some situations, when the orgs were not ordered strictly by ID in
the list stored in the browser's IndexedDB storage.  This commit removes that
requirement, and allows trees of any ID and storage ordering to be
reconstituted.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agolp1759327 Populate Copy Templates Floating Dropdown
Kyle Huckins [Tue, 1 May 2018 18:28:36 +0000 (18:28 +0000)]
lp1759327 Populate Copy Templates Floating Dropdown

- Add update watcher and call itemSvc.get_floating_groups within
egVolTemplate directive to properly populate dropdown when accessing
volcopy editor from local administration.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP#1749996: add option to remove floating in web client copy editor
Jeff Davis [Tue, 24 Apr 2018 21:00:07 +0000 (14:00 -0700)]
LP#1749996: add option to remove floating in web client copy editor

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agolp1760997 Holds Pull List Blank Fields
Kyle Huckins [Wed, 16 May 2018 17:00:26 +0000 (17:00 +0000)]
lp1760997 Holds Pull List Blank Fields

- Requires field data to be loaded into holds pull list grid
initially.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoLP1749994 Disable payment button pending payment amount
gcollum [Sat, 19 May 2018 00:10:49 +0000 (20:10 -0400)]
LP1749994 Disable payment button pending payment amount

Apply payment button on patron bills screen should be inactive if Payment
Received is blank

Adds a test to see if there is a value in Payment Received input box. The
Apply Payment button doesn't activate unless a billing or billings is
selected and a numerical value is in Payment Received.

To test.
1. Add some billings to a patron's account.
2. Click some of the billings to select them. Notice that the Apply Payment
   button is active.
3. Apply patch
4. Select some of the billings.  The Apply Payment button is not active.
5. Enter some values into Payment Received.  If values other than numbers
   are entered the Apply Payment button is not activated.  If numbers are
   added the button is activated.
6. Uncheck all of the billings to see that the activated button deactivates,
   if no billings are checked.

Signed-off-by: gcollum <gcollum@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1639022 Webstaff convert change to credit
Bill Erickson [Wed, 16 May 2018 21:24:05 +0000 (17:24 -0400)]
LP#1639022 Webstaff convert change to credit

Add support for converting change to patron credit in the patron bills
interface, consistent with the XUL feature.  When the
'circ.disable_patron_credit' org unit setting is applied, the option is
hidden.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Laura Sachjen <sachjenl@branchdistrictlibrary.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: updating 3.1.2 release notes
Jane Sandberg [Wed, 23 May 2018 01:00:31 +0000 (18:00 -0700)]
Docs: updating 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: updating 3.0.8 release notes
Jane Sandberg [Wed, 23 May 2018 00:55:03 +0000 (17:55 -0700)]
Docs: updating 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#14973322: (follow-up) allow profile-only patron searches
Galen Charlton [Mon, 30 Apr 2018 21:03:26 +0000 (17:03 -0400)]
LP#14973322: (follow-up) allow profile-only patron searches

This patch removes the implicit requirement introduced by the previous
patch that a field other than profile be used in the patron search.

For performance reasons, it might be good to mark permission.grp_descendants()
as stable.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP14973322: Search for Users by Profile
Jason Boyer [Fri, 20 Apr 2018 18:49:25 +0000 (14:49 -0400)]
LP14973322: Search for Users by Profile

Stop treating profile like a text value, instead
include users in the selected profiles and descendants.

To test
-------
[0] Search for users by last name (and / or first) and do not
    select a profile, take note of results
[1] Select the top of your permission group tree (Users, likely) and
    search again, results should be the same.
[2] Select a group further down the tree (Circulators, Administrators,
    Patrons, etc.) and repeat the search, there should only be results
    from that group and its descendants.
[3] Finally, select a group with no child groups. Results will only be
    that specific group.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoLP#1497322: add Perl live_t regression and unit tests for patron searching
Galen Charlton [Mon, 30 Apr 2018 20:14:52 +0000 (16:14 -0400)]
LP#1497322: add Perl live_t regression and unit tests for patron searching

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
5 years agoUpdate upgrade instructions
Dan Wells [Wed, 18 Apr 2018 22:12:19 +0000 (18:12 -0400)]
Update upgrade instructions

Bump version numbers, plus a few minor tweaks.

Eventually we probably need to start building the docs from tags, and
let the main branch use placeholders.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoDocs: Update "Receipt Template Editor" for Web Client
Lynn Floyd [Mon, 30 Apr 2018 22:45:41 +0000 (18:45 -0400)]
Docs: Update "Receipt Template Editor" for Web Client

Completely rewritten chapter. Many thanks to Terran McCanna, as much
was borrowed from her wiki pages.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: Fix two minor typos
Remington Steed [Thu, 17 May 2018 14:24:37 +0000 (10:24 -0400)]
Docs: Fix two minor typos

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: Update Long-overdue docs for web client
Remington Steed [Tue, 15 May 2018 13:59:13 +0000 (09:59 -0400)]
Docs: Update Long-overdue docs for web client

This commit completes LP #1325704 by documenting the setting which
controls which tabs the long-overdue circ can appear on.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: adding to 3.1.2 release notes
Jane Sandberg [Thu, 17 May 2018 11:47:36 +0000 (04:47 -0700)]
Docs: adding to 3.1.2 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: adding to 3.0.8 release notes
Jane Sandberg [Thu, 17 May 2018 11:35:55 +0000 (04:35 -0700)]
Docs: adding to 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP#1756912: Stamping upgrade script for add preferred lib to unapi feeds
Kathy Lussier [Tue, 15 May 2018 21:21:53 +0000 (17:21 -0400)]
LP#1756912: Stamping upgrade script for add preferred lib to unapi feeds

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1756912: restore display of copy counts for preferred library
Galen Charlton [Wed, 21 Mar 2018 16:03:27 +0000 (12:03 -0400)]
LP#1756912: restore display of copy counts for preferred library

This patch fixes a regression introduced by the patches for bug 1698206
and restores the display of copy counts for the preferred library (when set)
on the public catalog results and record details pages.

To test
-------
[1] Log into the public catalog as a user and set a preferred library.
[2] Perform a catalog search at a system that is other than the
    preferred library set in step 1. Repeat the search with
    "Groups Formats and Editions" checked.
[3] Note that in both cases, the copy counts displayed in search results and
    the record details pages do not include a line for the preferred
    library.
[4] Apply the patch and repeat step 2. This time, the preferred library
    count should be included in the display.

The substance of this patch (with the exception of the pgTAP tests)
follows an approach suggested by Bob Wicksall <bwicksall@pls-net.org>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1738893: Release notes entry for batch edit stat cat fix
Kathy Lussier [Tue, 15 May 2018 19:47:56 +0000 (15:47 -0400)]
LP#1738893: Release notes entry for batch edit stat cat fix

Adding release notes entry since the initial maintenance release notes
have already been done.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1738893-allow saving required statcats in multi record vol-copy edit
Cesar Velez [Mon, 30 Apr 2018 19:12:53 +0000 (15:12 -0400)]
LP#1738893-allow saving required statcats in multi record vol-copy edit

This change allows the user to set a required stat cat for multiple
record copies in the Volcopy editor.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1771371: Pin to AngularJS 1.6
Jason Stephenson [Tue, 15 May 2018 15:00:21 +0000 (11:00 -0400)]
LP#1771371: Pin to AngularJS 1.6

Folowup commit to pin all Angular entries in package.json to 1.6.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoLP#1771371: Pin to AngularJS 1.6
Kathy Lussier [Tue, 15 May 2018 14:34:58 +0000 (10:34 -0400)]
LP#1771371: Pin to AngularJS 1.6

Fixes a problem where we were pulling AngularJS 1.7.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
5 years agoDocs: Updated Long Overdue items section for web client
Katie G. Martin [Wed, 2 May 2018 15:21:10 +0000 (10:21 -0500)]
Docs: Updated Long Overdue items section for web client

Updated section as per launchpad bug #1325704.

- Updated screenshots.
- Changed name of "Lost, Claimed Returned, Long Overdue, Has Unpaid
  Billings" to "Other/Special Circulations".
- Added tip pointing to the docs chapter on the library settings editor.
- Changed a setting code to its equivalent display name.

Signed-off-by: Katie G. Martin <bcl@blaircountylibraries.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 years agoDocs: adding docs contributor to release notes
Jane Sandberg [Mon, 14 May 2018 00:14:18 +0000 (17:14 -0700)]
Docs: adding docs contributor to release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: starting release notes for 3.1.2
Jane Sandberg [Mon, 14 May 2018 00:12:23 +0000 (17:12 -0700)]
Docs: starting release notes for 3.1.2

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: starting 3.0.8 release notes
Jane Sandberg [Mon, 14 May 2018 00:01:10 +0000 (17:01 -0700)]
Docs: starting 3.0.8 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoDocs: Update Patron Search to add DOB
Katie G. Martin [Mon, 30 Apr 2018 20:36:56 +0000 (15:36 -0500)]
Docs: Update Patron Search to add DOB

Patron Search now includes DOB y/m/d -- this adds those fields to the
list of searches and adds tips for search syntax for DOB.

Updated advanced search screenshot to include the DOB search fields.

Corrected and simplified sentence about the "include inactive" checkbox.

Signed-off-by: Katie G. Martin <bcl@blaircountylibraries.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>