From f427b846731e8016ef2b7fc5f322db232ea86e95 Mon Sep 17 00:00:00 2001 From: scottmk Date: Sat, 12 Sep 2009 18:19:35 +0000 Subject: [PATCH] In apacheGetParamValues() and apacheGetFirstParamValue(): applied const qualifier to nkey. Also: changed the ensuing NULL tests to look at nkey instead of key, since key has already been verified as non-NULL. Actually it looks like nkey is guaranteed to be non-NULL as well, but that depends on the correct functioning of osrfStringArray; so I left the NULL test, as revised, in place. git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1780 9efc2488-bf62-4759-914b-345cdb29e865 --- src/gateway/apachetools.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gateway/apachetools.c b/src/gateway/apachetools.c index 617ed0b..ca41832 100644 --- a/src/gateway/apachetools.c +++ b/src/gateway/apachetools.c @@ -132,8 +132,8 @@ osrfStringArray* apacheGetParamValues(osrfStringArray* params, char* key) { osrfLogDebug(OSRF_LOG_MARK, "Fetching URL values for key %s", key); int i; for( i = 0; i < params->size; i++ ) { - char* nkey = osrfStringArrayGetString(params, i++); - if(key && !strcmp(nkey, key)) + const char* nkey = osrfStringArrayGetString(params, i++); + if(nkey && !strcmp(nkey, key)) osrfStringArrayAdd(sarray, osrfStringArrayGetString(params, i)); } return sarray; @@ -146,8 +146,8 @@ char* apacheGetFirstParamValue(osrfStringArray* params, char* key) { int i; osrfLogDebug(OSRF_LOG_MARK, "Fetching first URL value for key %s", key); for( i = 0; i < params->size; i++ ) { - char* nkey = osrfStringArrayGetString(params, i++); - if(key && !strcmp(nkey, key)) + const char* nkey = osrfStringArrayGetString(params, i++); + if(nkey && !strcmp(nkey, key)) return strdup(osrfStringArrayGetString(params, i)); } -- 2.43.2