always use respond_complete to finish a request, whether there is a final message...

[OpenSRF.git] / src / perl / lib / OpenSRF / AppSession.pm

diff --git a/src/perl/lib/OpenSRF/AppSession.pm b/src/perl/lib/OpenSRF/AppSession.pm
index 1bcfa5c..c8ee269 100644 (file)
--- a/src/perl/lib/OpenSRF/AppSession.pm
+++ b/src/perl/lib/OpenSRF/AppSession.pm
@@ -1017,21 +1017,22 @@ sub respond_complete {
        my $msg = shift;
        return unless ($self and $self->session and !$self->complete);
 
-       my $response;
-       if (ref($msg) && UNIVERSAL::isa($msg, 'OpenSRF::DomainObject::oilsResult')) {
-               $response = $msg;
-       } else {
-               $response = new OpenSRF::DomainObject::oilsResult;
-               $response->content($msg);
-       }
-
-    push @{$self->{current_chunk}}, $response;
+    if (defined($msg)) {
+       my $response;
+           if (ref($msg) && UNIVERSAL::isa($msg, 'OpenSRF::DomainObject::oilsResult')) {
+                   $response = $msg;
+       } else {
+               $response = new OpenSRF::DomainObject::oilsResult;
+                   $response->content($msg);
+       }
+
+        push @{$self->{current_chunk}}, $response;
+    }
 
        my $stat = OpenSRF::DomainObject::oilsConnectStatus->new(
                statusCode => STATUS_COMPLETE(),
                status => 'Request Complete' );
 
-
        $self->session->send( ( map { ('RESULT', $_) } @{$self->{current_chunk}} ), 'STATUS' => $stat, $self->threadTrace);
        $self->complete(1);
 }