1 commit 9a3ef18779c1421f533347ad2e9326ae8d1d7cdc
2 Author: Galen Charlton <gmc@equinoxinitiative.org>
3 Date: Fri Jun 7 17:03:45 2019 -0400
5 update versions for 3.1.1
7 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
10 2 2 src/perl/lib/OpenSRF.pm
11 1 1 src/python/setup.py
14 commit 76d8a71df79a227b6e18b94b0fa571b47c7f940e
15 Author: Galen Charlton <gmc@equinoxinitiative.org>
16 Date: Fri Jun 7 17:01:43 2019 -0400
18 update release notes for OpenSRF 3.1.1
20 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
22 43 0 doc/RELEASE_NOTES.txt
24 commit 28b5d6d8ac25bc350ac3ea64466e7a422c6fa28e
25 Author: John Merriam <jmerriam@biblio.org>
26 Date: Wed Apr 10 11:06:14 2019 -0400
28 LP#1824184: Change potentially slow log statements to subroutines
30 The OpenSRF code was searched for potentially slow logging statements at
31 log level info or above. We then changed those logging statements to be
32 delayed execution subroutines. This is in reaction to LP1823338 where a
33 slow debug logging statement was slowing down SIP checkins even though
34 debug logging was not turned on.
36 Here is some pseudocode that shows what is being done here:
38 $log->debug("Some text " . $some->slow_method);
42 $log->debug(sub{return "Some text " . $some->slow_method });
44 With this change, an unnamed sub is passed to the OpenSRF logger module
45 and it will not be executed unless the global logging level is set to
46 debug or higher (the slow_method will not be called unless it is needed
47 for that logging level).
50 If/when this is committed, please use delayed execution subroutines for
51 any logging statements that could be slow in the future. It is recommend
52 that any logging statements that do not consist entirely of quoted text
53 and/or already available scalar variables use delayed execution
59 [1] This patch reduced the duration of open-ils.storage.actor.user.total_owed
60 calls on a test system from an average of 0.13 seconds to an overage
62 [2] It didn't materially affect the duration of calls to
63 open-ils.actor.user.opac.vital_stats.
64 [3] This make sense: open-ils.storage has far more generated methods
66 [4] There are enough instances in Evergreen of using method_lookup to find
67 routines in open-ils.storage that the speed improvement may well be
68 perceptible to humans, not just SIP sorters.
70 Signed-off-by: John Merriam <jmerriam@biblio.org>
71 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
73 7 7 src/perl/lib/OpenSRF/AppSession.pm
74 9 9 src/perl/lib/OpenSRF/Application.pm
75 4 4 src/perl/lib/OpenSRF/DomainObject/oilsMessage.pm
76 2 2 src/perl/lib/OpenSRF/EX.pm
77 3 3 src/perl/lib/OpenSRF/MultiSession.pm
78 9 9 src/perl/lib/OpenSRF/Server.pm
79 1 1 src/perl/lib/OpenSRF/Transport.pm
80 1 1 src/perl/lib/OpenSRF/Transport/SlimJabber/Client.pm
82 commit 840fadcf0eee864dbedde9750346d4835af13f6b
83 Author: Galen Charlton <gmc@equinoxinitiative.org>
84 Date: Fri Jun 7 11:30:42 2019 -0400
86 LP#1824181: add test cases
90 [1] Verify that 'make check' (or prove src/perl/t/09-Utils-Logger.t)
93 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
95 10 1 src/perl/t/09-Utils-Logger.t
97 commit 37dcdcab5a97e06259a859a1721f243978f35a66
98 Author: John Merriam <jmerriam@biblio.org>
99 Date: Wed Apr 10 09:51:54 2019 -0400
101 LP#1824181: Allow 1st arg to logger to be string or subroutine
103 This simple change allows the $msg passed to _log_message in Logger.pm
104 to be either a regular string or a delayed exec subroutine. This is in
105 reaction to LP1823338 where a slow debug logging statement was slowing
106 down SIP checkins even though debug logging was not turned on.
108 With this change you can take this:
110 $log->debug("Available methods\n\t".join("\n\t", keys %{ $_METHODS[$proto] }), INTERNAL);
112 and change it to this:
114 $log->debug(sub{return "Available methods\n\t".join("\n\t", keys %{ $_METHODS[$proto] }) }, INTERNAL);
116 and then that slow debug logging line will not be executed unless
117 debug logging is turned on.
119 Signed-off-by: John Merriam <jmerriam@biblio.org>
120 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
122 3 0 src/perl/lib/OpenSRF/Utils/Logger.pm
124 commit 1eff7ee443beda4037a3edb8e2cd6caa37ee6d85
125 Author: Jason Stephenson <jason@sigio.com>
126 Date: Fri Dec 14 15:35:49 2018 -0500
128 Lp 1808580: Remove Installation Support for Ubuntu 14.04
130 Remove references to Ubuntu 14.04 from the README and the
131 Makefile.install prerequisites.
133 Signed-off-by: Jason Stephenson <jason@sigio.com>
134 Signed-off-by: Ben Shum <ben@evergreener.net>
137 2 14 src/extras/Makefile.install