1 commit ae7d4165ffbcfb35f98700c061e02714b9f3ebee
2 Author: Galen Charlton <gmc@equinoxinitiative.org>
3 Date: Mon May 7 19:30:24 2018 -0400
5 update version numbers for OpenSRF 3.0.1
7 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
10 2 2 src/perl/lib/OpenSRF.pm
11 1 1 src/python/setup.py
14 commit b5c03e9036a58acfe3099730d98666af7578472e
15 Author: Galen Charlton <gmc@equinoxinitiative.org>
16 Date: Mon May 7 19:25:45 2018 -0400
18 update release notes for OpenSRF 3.0.1
20 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
22 37 1 doc/RELEASE_NOTES.txt
24 commit b704d6ad373ed581b4f8caa2bd156161a0aa1bbd
25 Author: Galen Charlton <gmc@equinoxinitiative.org>
26 Date: Mon May 7 16:03:16 2018 -0400
28 LP#1243841: quiet a misleading indentation warning
30 Adjusts a spaces-vs-tabs issue to fix the following compilation
33 osrf_prefork.c: In function ‘check_children’:
34 osrf_prefork.c:1067:5: warning: this ‘if’ clause does not
35 guard... [-Wmisleading-indentation]
36 if( select_ret <= 0 ) // we're done here
38 osrf_prefork.c:1072:2: note: ...this statement, but the latter is
39 misleadingly indented as if it is guarded by the ‘if’
40 cur_child = forker->first_child;
43 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
45 1 1 src/libopensrf/osrf_prefork.c
47 commit 62a29dafa4b978d3bc6f4ef8d2dddebe1b319ebb
48 Author: Jason Stephenson <jason@sigio.com>
49 Date: Tue Nov 7 16:39:39 2017 -0500
51 LP#1243841 - Quiet remaining Make install warnings.
53 We silence the following warnings:
55 apachetools.c:179:15: warning: initialization discards 'const' qualifier
56 from pointer target type [enabled by default]
58 apachetools.c:181:8: warning: assignment discards 'const' qualifier from
59 pointer target type [enabled by default]
61 apachetools.c:183:8: warning: assignment discards 'const' qualifier from
62 pointer target type [enabled by default]
64 ./osrf_websocket_translator.c:541:9: warning: return makes integer from
65 pointer without a cast [enabled by default]
67 ./osrf_http_translator.c:300:25: warning: passing argument 1 of 'free'
68 discards 'const' qualifier from pointer target type [enabled by default]
70 Signed-off-by: Jason Stephenson <jason@sigio.com>
71 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
73 1 1 src/gateway/apachetools.c
74 1 1 src/gateway/osrf_http_translator.c
75 1 1 src/gateway/osrf_websocket_translator.c
77 commit 35c7bb1b81bd41d99ad0a0756bf669a13e6ef63b
78 Author: Jason Stephenson <jason@sigio.com>
79 Date: Tue Nov 7 15:58:05 2017 -0500
81 LP#1243841 - Quiet additional Make warnings and some code cleanup.
83 We make the following warnings go away:
85 osrf_legacy_json.c:607:6: warning: variable ‘fourth_dash’ set but
86 not used [-Wunused-but-set-variable]
88 osrf_legacy_json.c:836:5: warning: passing argument 3 of ‘makeNode’
89 discards ‘const’ qualifier from pointer target type [enabled by
92 utils.c:133:2: warning: format not a string literal and no format
93 arguments [-Wformat-security]
95 We also cleanup the while block nested in a do while block around line
96 63 of osrf_cache.c to be more readable by adding braces and breaking
99 Signed-off-by: Jason Stephenson <jason@sigio.com>
100 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
102 3 1 src/libopensrf/osrf_cache.c
103 4 6 src/libopensrf/osrf_legacy_json.c
104 6 3 src/libopensrf/utils.c
106 commit 4dadb76c5b7e73615de4a1ff923aa46b77b95330
107 Author: Chris Sharp <csharp@georgialibraries.org>
108 Date: Tue Sep 19 21:25:12 2017 -0400
110 LP#1243841 - Quiet wrong format warnings during make install.
112 During make install, the compiler warns that %d expects an int when the
113 actual value is a long int. Changing %d to %ld fixes the issue.
115 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
116 Signed-off-by: Jason Stephenson <jason@sigio.com>
117 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
119 3 3 src/gateway/osrf_websocket_translator.c
121 commit c298ab7017627c3502a1b185e2d5871dd0b671ee
122 Author: Chris Sharp <csharp@georgialibraries.org>
123 Date: Tue Sep 19 20:46:28 2017 -0400
125 LP#1243841 - Quiet unused return value warning in srfsh.c
127 Using the technique described here: https://stackoverflow.com/a/13999461.
129 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
130 Signed-off-by: Jason Stephenson <jason@sigio.com>
131 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
133 1 1 src/srfsh/srfsh.c
135 commit 3994a17e604f32dc184e9f01afac1b3c573b9927
136 Author: Chris Sharp <csharp@georgialibraries.org>
137 Date: Tue Sep 19 20:37:13 2017 -0400
139 LP#1243841 - Quiet unused return value warnings.
141 Using advice given here: https://stackoverflow.com/a/13999461, "The
142 only good (if ugly) way to suppress these is to convert the return
143 value into something that the compiler agrees that you can ignore."
145 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
146 Signed-off-by: Jason Stephenson <jason@sigio.com>
147 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
149 4 4 src/libopensrf/utils.c
151 commit f50772c5726b1655d67bfefaaa5cd7d4d8892b47
152 Author: Chris Sharp <csharp@georgialibraries.org>
153 Date: Tue Sep 19 18:10:00 2017 -0400
155 LP#1243841 - Wrap truth test using "=" in an extra set of parens.
157 Referring to https://stackoverflow.com/questions/5476759/compiler-warning-suggest-parentheses-around-assignment-used-as-truth-value,
158 it is recommended to wrap variable assignments that are used as a truth
159 test within an extra set of parentheses.
161 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
162 Signed-off-by: Jason Stephenson <jason@sigio.com>
163 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
165 1 1 src/libopensrf/osrf_cache.c
167 commit 2f7688068af65cbe44c460daf0835b25344e6cca
168 Author: Jason Stephenson <jason@sigio.com>
169 Date: Sun Feb 18 12:12:13 2018 -0500
171 LP1340982: Ignore both 'comment' and '#comment' nodes in Settings Parse.
173 Modify the XML2perl helper function in OpenSRF::Utils::SettingsParser
174 to ignore comment nodes that have names of comment and #comment.
176 To reproduce the bug:
178 1. Stop OpenSRF services.
180 2. Add a XML comment, any text betwen <!-- and -->, in the list of
181 MARC templates in the opensrf.xml file.
183 3. Restart OpenSRF services.
185 4. In the staff client, go to Cataloging->Create New MARC Record.
187 5. In the list of templates, you will #comment where you added the
188 comment. (NOTE: I only tested with 1 comment. Things may get worse
189 with more than 1 comment.)
191 6. There will be an error like the following in the
192 open-ils.cat_stderr.log if you attempt to choose the #comment entry:
194 Caught error from 'run' method: Exception: OpenSRF::EX::ERROR
195 2018-02-18T11:24:30 OpenSRF::Application
196 /usr/local/share/perl/5.22.1/OpenSRF/Application.pm:240 System
197 ERROR: Unable to open MARC template file: HASH(0x2249928) :
201 1. Leave the comments in the opensrf.xml file from before.
203 2. Apply this commit, do make and make install for OpenSRF.
205 3. Just to make sure, do make and make install for Evergreen.
207 4. Repeat steps 3 and 4 from above.
209 5. You should NOT see any templates named #comment.
211 Signed-off-by: Jason Stephenson <jason@sigio.com>
212 Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
214 1 1 src/perl/lib/OpenSRF/Utils/SettingsParser.pm
216 commit 24a14a104c2a216664ab52311eb9f90955b75e31
217 Author: Bill Erickson <berickxx@gmail.com>
218 Date: Tue Apr 10 15:06:56 2018 -0400
220 LP#1762815 Empty client TZ defaults to server TZ (Perl)
222 Fixes an issue in the Perl client time zone handling that resulted in
223 the server defaulting to UTC time instead of the server time zone when
224 no time zone value was received from the client.
226 Signed-off-by: Bill Erickson <berickxx@gmail.com>
227 Signed-off-by: Jason Stephenson <jason@sigio.com>
229 1 0 src/perl/lib/OpenSRF/DomainObject/oilsMessage.pm
231 commit 0c7f94abf5911cdf042c1162705e721a4fd2899f
232 Author: Bill Erickson <berickxx@gmail.com>
233 Date: Wed Jan 24 15:16:14 2018 -0500
235 LP#1744158 Websocket proc exits on ejabberd disconnect
237 Any errors relaying websocket messages to OpenSRF now result in the WS
238 client being disconnected, allowing the WS process to exit. This
239 prevents the WS gateway from accepting requests it cannot process and
240 allows the client to connect to a new WS process.
242 Signed-off-by: Bill Erickson <berickxx@gmail.com>
243 Signed-off-by: Jason Stephenson <jason@sigio.com>
245 17 4 src/gateway/osrf_websocket_translator.c
247 commit 0cb4209fa03091b62df2793a7b273e0c981798d3
248 Author: Bill Erickson <berickxx@gmail.com>
249 Date: Wed Jan 31 13:07:41 2018 -0500
251 LP#1746577 Websocket responder exits on jabber disconnect
253 Regularly check for Jabber socket disconnects in the websocket gateway
254 "responder" thread (that relays messages from opensrf to the WS client)
255 and force a client disconnect when a broken jabber socket is detected.
257 Signed-off-by: Bill Erickson <berickxx@gmail.com>
258 Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
259 Signed-off-by: Jason Stephenson <jason@sigio.com>
261 18 2 src/gateway/osrf_websocket_translator.c