ChopChop is dead, long live ChopChop. It was never fully baked, nor was it secure, nor does it compile cleanly with -Wall, nor does it provide any useful examples for working with opensrf, etc. Time to clear out. So long, chopchop. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Log redaction for sensitive input values, Perl side This commit attempts to do the same as the C log redaction fix, but now at the Perl level. The Perl configuration code was a little more crufty than the C side, so an additional feature was added to Config.pm to support the new 'shared' section. At some point we should consider a ground-up rewrite of Config.pm, as the code seems to suffer some from its INI file roots. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dan@coffeecode.net>
Log redaction for sensitive input values, C side Some service/methods deal with sensitive information (passwords, financial, etc.). All input values (e.g. gateway method params) are currently logged in the activity log regardless of your log level. This commit will allow you to redact the params of any method which matches a configurable set of left-anchored string values. This commit adds the initial config, and covers redaction of method parameters sent through the gateway, the translator, and more general OpenSRF C applications. Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Dan Scott <dan@coffeecode.net>
Nagios Example Plugin for monitoring services Does not check that all drones in a brick are fully up, just that the entire brick will respond to each service, even if only one drone happens to be running the listener properly (and said listener is responding). Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dan@coffeecode.net>
Updated buildbot.cfg for current build environments * Drop Ubuntu 8.04 from the list of build environments. * OpenSRF: drop rel_1_6, add rel_2_1 * Evergreen: drop rel_1_6_1, add rel_2_2 * Adjust for buildbot 0.86 API changes to avoid deprecation * Improve PEP8 compliance Signed-off-by: Dan Scott <dan@coffeecode.net>
OpenSRF Validator Service Add a new Validator service, and EmailAddress validators. The service runs a chain of one or more validators, each one being fed the normalized output of the previous one. The return from each validator should be a hash of valid (0 or 1), the new normalized output (the untouched input if invalid or nothing needed to be changed), and if invalid an error string. Optionally, a validator can also include an "additionals" hash of extra information to be included in the final response. The complete list of validators included is: OpenSRF::Application::Validator::Base The base validator. Always returns valid. OpenSRF::Application::Validator::Invalid Always returns invalid for testing purposes. OpenSRF::Application::Validator::EmailAddress::Regex Does a very basic regular expression check on email addresses. OpenSRF::Application::Validator::EmailAddress::DNS Uses Net::DNS to look up the domain on an email address Signed-off-by: Thomas Berezansky <tsbere@mvlc.org> Signed-off-by: Dan Scott <dscott@laurentian.ca>
Warn when sending very large messages Depending on configuration, messages of a certain size sent through a Jabber server will cause the jabber server to disconnect the client. This change allows admins to configure a message size warning threshold. When a message meets or exceeds the size threshold, a warning is issued to the logs with the message size (in bytes) and the message recipient. It does not prevent the message from being delivered. It's purely informational. Use 1 800 000 as the default threhold. Signed-off-by: Bill Erickson <berick@esilibrary.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Change "Scheduler" to "SingleBranchScheduler" per 0.8.4 In buildbot 0.8.4, the Scheduler becomes a SingleBranchScheduler to make way for other kinds of Schedulers: see http://buildbot.net/buildbot/docs/current/SingleBranchScheduler.html Signed-off-by: Dan Scott <dscott@laurentian.ca>
Move the buildbot workdirs to a non-volatile directory /tmp/ is a good directory for throwing temporary things, but not so good for things you want to keep around for a relatively long time. Especially on Ubuntu, which has a default policy of deleting files in /tmp/ on reboot - meaning that the git repos that form the basis of the repository have all of their files wiped - greatly confusing the buildbot, which tries to run 'git reset --head' in an empty directory and fails miserably in that situation. So - ensure that WORKDIR is set to something that exists and which will exist for the duration of your CI server, and you'll be all right. Signed-off-by: Dan Scott <dan@coffeecode.net>
Turn on email and IRC notification about build breaks Buildbot can notify us when a build breaks via email and IRC. Now that everything is green on testing.evergreen-ils.org, let's turn that capability on. As configured, we should only be notified when a build goes from success to failure, the first time; and then again, when a build goes from failure to success. Email notification should go to "interested users" - all of the email addresses in the collected signed-off-by / author tags in the commits for a given build. Signed-off-by: Dan Scott <dan@coffeecode.net>
Specify explicit branches for each builder, lazy-style SVNPoller was able to rely on change filters to look at every commit to the repository and hand them off to the scheduler accordingly; GitPoller, however, looks at one branch per poller, so we need to instantiate one poller per branch of interest. This gives us an opportunity to refactor our approach to be more programmatic. Signed-off-by: Dan Scott <dan@coffeecode.net>
Add a workdir for each GitPoller source repository Not 100% sure, but with two GitPollers using the same working directory, I suspect that there was a conflict between the underlying repos as to which commit was the newest. Give each of them an explicit working directory in the attempt to avoid this. Signed-off-by: Dan Scott <dan@coffeecode.net>
Teach Buildbot to poll the new git repos We're now using GitPoller to check for commits to the branches of interest in Evergreen and OpenSRF on the default interval of 10 minutes. Also, some syntax cleanups following the last refactoring. Signed-off-by: Dan Scott <dan@coffeecode.net>