From eac43ead53e9da0238a9013e7bec38569b9828ef Mon Sep 17 00:00:00 2001 From: Mike Rylander Date: Fri, 7 Jul 2017 15:34:57 -0400 Subject: [PATCH] LP#1702978: memcache Remove method used in a variadic way Related to the OpenSRF branch on this same bug, the prevents Evergreen from using a to-be-non-variadic memcache method in that way. This prevents issues for memcache keys that contain a %. Signed-off-by: Mike Rylander Signed-off-by: Cesar Velez Signed-off-by: Jason Stephenson --- Open-ILS/src/c-apps/oils_auth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/c-apps/oils_auth.c b/Open-ILS/src/c-apps/oils_auth.c index b87d1ca6a1..1836b025b8 100644 --- a/Open-ILS/src/c-apps/oils_auth.c +++ b/Open-ILS/src/c-apps/oils_auth.c @@ -452,7 +452,9 @@ static int oilsAuthVerifyPassword( const osrfMethodContext* ctx, int user_id, int verified = 0; // We won't be needing the seed again, remove it - osrfCacheRemove("%s%s%s", OILS_AUTH_CACHE_PRFX, identifier, nonce); + char* key = va_list_to_string("%s%s%s", OILS_AUTH_CACHE_PRFX, identifier, nonce ); /**/ + osrfCacheRemove(key); + free(key); // Ask the DB to verify the user's password. // Here, the password is md5(md5(password) + salt) -- 2.43.2