From e5ba0eddecddb398f7b8f4f980b5dd0f126024b8 Mon Sep 17 00:00:00 2001 From: Jason Boyer Date: Mon, 3 Dec 2018 08:11:29 -0500 Subject: [PATCH] LP1806394: Placing Holds in Item Buckets A missing return prevents a list of item ids from being built so no holds can be placed from item buckets. This branch returns the return to its proper place. To test ------- [1] Add some items to an item bucket, ensuring that they are all holdable. [2] From the item bucket interface, select the items and choose the Request Selected Items action. [3] Confirm placing the requests. [4] Note that the requests are not actually created. [5] Apply the patch and repeat steps #1-#4. This time, the requests should be placed. Signed-off-by: Jason Boyer Signed-off-by: Rogan Hamby Signed-off-by: Millissa Macomber Signed-off-by: Galen Charlton --- Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js b/Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js index f39346ef35..70eb084fd4 100644 --- a/Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js +++ b/Open-ILS/web/js/ui/default/staff/cat/bucket/copy/app.js @@ -611,7 +611,7 @@ function($scope, $q , $routeParams , $timeout , $window , $uibModal , bucketSvc $scope.requestItems = function() { var copy_list = $scope.gridControls.selectedItems().map( function (i) { - i.id; + return i.id; } ); -- 2.43.2