From de6feb37440ece9344405975d4f655a967dd1b76 Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@equinoxOLI.org>
Date: Tue, 9 Nov 2021 10:24:04 -0500
Subject: [PATCH] LP#1855780: adjustments to cloning

- set the owning OU to null in the clone
- reduce console noise when cloning environment entries

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
---
 .../staff/admin/local/triggers/triggers.component.html    | 1 +
 .../app/staff/admin/local/triggers/triggers.component.ts  | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.html
index 170dcb295a..cb6a70198a 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.html
@@ -10,6 +10,7 @@
 <eg-fm-record-editor #eventDialog idlClass="atevdef"
     [fieldOptions]="{message_template:{customTemplate:{template:textAreaTemplate}},template:{customTemplate:{template:textAreaTemplate}}}"
     fieldOrder="owner,name,hook,active,delay,delay_field,group_field,reactor,validator,repeat_delay,id,cleanup_failure,granularity,max_delay,message_library_path,message_template,message_title,message_usr_path,opt_in_setting,usr_field,retention_interval,cleanup_success,template"
+    [remainOpenOnError]="true"
     hiddenFields="id">
 </eg-fm-record-editor>
 <eg-fm-record-editor #hookDialog idlClass="ath"></eg-fm-record-editor>        
diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.ts b/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.ts
index 84acf4e5fe..d7183a2c06 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/triggers/triggers.component.ts
@@ -253,6 +253,7 @@ export class TriggersComponent implements OnInit {
 
     doClone(eventDef, env_list) {
         eventDef.id(null);
+        eventDef.owner(null);
         this.eventDialog.mode = 'create';
         this.eventDialog.recordId = null;
         this.eventDialog.record = eventDef;
@@ -281,11 +282,10 @@ export class TriggersComponent implements OnInit {
             env.id(null);
         });
         this.pcrud.create(env_list).toPromise().then(
-            ok => {
-                console.debug(ok);
-            },
+            ok => { },
             err => {
-                console.debug(err);
+                this.cloneFailedString.current()
+                    .then(str => this.toast.danger(str));
             }
         );
     }
-- 
2.43.2