From d1689d088e62192a6a1210f96923b4bbc6a06c2d Mon Sep 17 00:00:00 2001
From: Dan Scott <dscott@laurentian.ca>
Date: Wed, 18 Sep 2013 13:55:40 -0400
Subject: [PATCH] Improve rdetail action formatting when no cover art

When there is no cover art, the format label gets the actions hung oddly
to the right in the record detail view. Just wrap the whole block in a
div and float that instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
---
 Open-ILS/src/templates/opac/css/style.css.tt2 |  6 +-
 .../templates/opac/parts/record/summary.tt2   | 78 ++++++++++---------
 2 files changed, 41 insertions(+), 43 deletions(-)

diff --git a/Open-ILS/src/templates/opac/css/style.css.tt2 b/Open-ILS/src/templates/opac/css/style.css.tt2
index fae9f8d8d0..da6e392aea 100644
--- a/Open-ILS/src/templates/opac/css/style.css.tt2
+++ b/Open-ILS/src/templates/opac/css/style.css.tt2
@@ -1889,17 +1889,13 @@ a.preflib_change {
         position: relative;                                                                                                                           
         width: 300px;
     }
-    #rdetail_format_label {
+    #format_actions {
         float: left;
     }
     .rdetail_aux_utils {
         padding: 0px;
         border: none;
     }
-    div#rdetail_actions_div {
-        float: left;
-        background: [% css_colors.background %];
-    }
     .result_metadata {
         width: inherit;
     }
diff --git a/Open-ILS/src/templates/opac/parts/record/summary.tt2 b/Open-ILS/src/templates/opac/parts/record/summary.tt2
index 2e0e2222a0..6d78327e35 100644
--- a/Open-ILS/src/templates/opac/parts/record/summary.tt2
+++ b/Open-ILS/src/templates/opac/parts/record/summary.tt2
@@ -32,47 +32,49 @@
         [% END %]
         <br />
     </div>
-    [%- IF attrs.format_label %]
-    <div id="rdetail_format_label">
-        [%- attrs.format_label -%]
-    </div>
-    [%- END %]
-    <div id="rdetail_actions_div">
-        [%- search_ou = ctx.search_ou;
-            IF ctx.place_unfillable ||
-                ( attrs.marc_xml.findnodes('//*[local-name()="holdings" and @has_holdable="true"]').size > 0
-                    && (ctx.holds_block.enabled != 'true' || attrs.org_copy_counts.$search_ou.available == 0)
-                )
-         %]
-        <div class="rdetail_aux_utils place_hold">
-            <a href="[% mkurl(ctx.opac_root _ '/place_hold', 
-                {hold_target => ctx.bre_id, hold_type => 'T', hold_source_page => mkurl()}, stop_parms) %]" 
-            class="no-dec"><img src="[% ctx.media_prefix %]/images/green_check.png" alt="[% l('place hold') %]" /><span 
-            class="place_hold">[% l('Place Hold') %]</span></a>
+    <div id="format_actions">
+        [%- IF attrs.format_label %]
+        <div id="rdetail_format_label">
+            [%- attrs.format_label -%]
         </div>
-        [%- END -%]
-        <div class="rdetail_aux_utils toggle_list">
-        [%  IF ctx.user;
-            INCLUDE "opac/parts/bookbag_actions.tt2";
-        %]
-        [%  ELSE;
-            operation = ctx.mylist.grep(ctx.bre_id).size ? "delete" : "add";
-            label = (operation == "add") ? l("Add to my list") : l("Remove from my list"); 
-        %]
-            <a href="[% mkurl(ctx.opac_root _ '/mylist/' _ operation, {record => ctx.bre_id}, stop_parms) %]" class="no-dec">
+        [%- END %]
+        <div id="rdetail_actions_div">
+            [%- search_ou = ctx.search_ou;
+                IF ctx.place_unfillable ||
+                    ( attrs.marc_xml.findnodes('//*[local-name()="holdings" and @has_holdable="true"]').size > 0
+                        && (ctx.holds_block.enabled != 'true' || attrs.org_copy_counts.$search_ou.available == 0)
+                    )
+             %]
+            <div class="rdetail_aux_utils place_hold">
+                <a href="[% mkurl(ctx.opac_root _ '/place_hold', 
+                    {hold_target => ctx.bre_id, hold_type => 'T', hold_source_page => mkurl()}, stop_parms) %]" 
+                class="no-dec"><img src="[% ctx.media_prefix %]/images/green_check.png" alt="[% l('place hold') %]" /><span 
+                class="place_hold">[% l('Place Hold') %]</span></a>
+            </div>
+            [%- END -%]
+            <div class="rdetail_aux_utils toggle_list">
+            [%  IF ctx.user;
+                INCLUDE "opac/parts/bookbag_actions.tt2";
+            %]
+            [%  ELSE;
+                operation = ctx.mylist.grep(ctx.bre_id).size ? "delete" : "add";
+                label = (operation == "add") ? l("Add to my list") : l("Remove from my list"); 
+            %]
+                <a href="[% mkurl(ctx.opac_root _ '/mylist/' _ operation, {record => ctx.bre_id}, stop_parms) %]" class="no-dec">
+                    <img src="[% ctx.media_prefix %]/images/clipboard.png" alt="" />
+                    [% label %]
+                </a>
+            [% END %]
+            </div>
+            <div class="rdetail_aux_utils">
                 <img src="[% ctx.media_prefix %]/images/clipboard.png" alt="" />
-                [% label %]
-            </a>
-        [% END %]
+                <a href="[% mkurl(ctx.opac_root _ '/record/print/' _ ctx.bre_id) %]" class="no-dec">[% l('Print') %]</a> /
+                <a href="[% mkurl(ctx.opac_root _ '/record/email/' _ ctx.bre_id) %]" class="no-dec">[% l('Email') %]</a>
+            </div>
+            [%- IF ctx.refworks.enabled == 'true' %]
+                [%- INCLUDE 'opac/parts/record/refworks.tt2' %]
+            [%- END %]
         </div>
-        <div class="rdetail_aux_utils">
-            <img src="[% ctx.media_prefix %]/images/clipboard.png" alt="" />
-            <a href="[% mkurl(ctx.opac_root _ '/record/print/' _ ctx.bre_id) %]" class="no-dec">[% l('Print') %]</a> /
-            <a href="[% mkurl(ctx.opac_root _ '/record/email/' _ ctx.bre_id) %]" class="no-dec">[% l('Email') %]</a>
-        </div>
-        [%- IF ctx.refworks.enabled == 'true' %]
-            [%- INCLUDE 'opac/parts/record/refworks.tt2' %]
-        [%- END %]
     </div>
 </div>
 
-- 
2.43.2