From b9553988c847196b72ddaac0271f330a7b6b765e Mon Sep 17 00:00:00 2001
From: dbwells <dbwells@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Tue, 16 Nov 2010 21:16:05 +0000
Subject: [PATCH] Remove deprecated 'all_dists' option for make_predictions(),
 pass along _build_unit events.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18760 dcc99617-32d9-48b4-a31d-7c20da2025e4
---
 .../perlmods/OpenILS/Application/Serial.pm    | 35 ++++++++++---------
 .../default/serial/subscription/issuance.js   |  2 +-
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Serial.pm b/Open-ILS/src/perlmods/OpenILS/Application/Serial.pm
index adcbe4862f..2405debaab 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Serial.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Serial.pm
@@ -668,27 +668,23 @@ sub make_predictions {
 
     my $editor = OpenILS::Utils::CStoreEditor->new();
     my $ssub_id = $args->{ssub_id};
-    my $all_dists = $args->{all_dists}; #TODO: this option supports test-level code, will be removed (i.e. always 'true')
     my $mfhd = MFHD->new(MARC::Record->new());
 
     my $ssub = $editor->retrieve_serial_subscription([$ssub_id]);
     my $scaps = $editor->search_serial_caption_and_pattern({ subscription => $ssub_id, active => 't'});
-    my $sdists = $editor->search_serial_distribution( [{ subscription => $ssub->id }, {  flesh => 1,
-              flesh_fields => {sdist => [ qw/ streams / ]}, $all_dists ? () : (limit => 1) }] ); #TODO: 'deleted' support?
+    my $sdists = $editor->search_serial_distribution( [{ subscription => $ssub->id }, { flesh => 1, flesh_fields => {sdist => [ qw/ streams / ]} }] ); #TODO: 'deleted' support?
 
-    if ($all_dists) {
-        my $total_streams = 0;
-        foreach (@$sdists) {
-            $total_streams += scalar(@{$_->streams});
-        }
-        if ($total_streams < 1) {
-            $editor->disconnect;
-            # XXX TODO new event type
-            return new OpenILS::Event(
-                "BAD_PARAMS", note =>
-                    "There are no streams to direct items. Can't predict."
-            );
-        }
+    my $total_streams = 0;
+    foreach (@$sdists) {
+        $total_streams += scalar(@{$_->streams});
+    }
+    if ($total_streams < 1) {
+        $editor->disconnect;
+        # XXX TODO new event type
+        return new OpenILS::Event(
+            "BAD_PARAMS", note =>
+                "There are no streams to direct items. Can't predict."
+        );
     }
 
     unless (@$scaps) {
@@ -990,7 +986,12 @@ sub unitize_items {
             my $unit;
             my $sdists = $editor->search_serial_distribution([{"+sstr" => {"id" => $stream_id}}, { "join" => {"sstr" => {}} }]);
             $unit = _build_unit($editor, $sdists->[0], $mode, 0, $barcodes->{$item->id});
-            # TODO: catch events from _build_unit
+            # if _build_unit fails, $unit is an event, so return it
+            if ($U->event_code($unit)) {
+                $editor->rollback;
+                $unit->{"note"} = "Item ID: " . $item->id;
+                return $unit;
+            }
             my $evt =  _create_sunit($editor, $unit);
             return $evt if $evt;
             if ($unit_id == -2) {
diff --git a/Open-ILS/web/js/ui/default/serial/subscription/issuance.js b/Open-ILS/web/js/ui/default/serial/subscription/issuance.js
index a0cc670073..d715fb471a 100644
--- a/Open-ILS/web/js/ui/default/serial/subscription/issuance.js
+++ b/Open-ILS/web/js/ui/default/serial/subscription/issuance.js
@@ -59,7 +59,7 @@ function prepare_prediction_dialog() {
 }
 
 function generate_predictions(fields) {
-    var args = {"ssub_id": sub.id(), "all_dists": true};
+    var args = {"ssub_id": sub.id()};
 
     if (fields.end_how == "date") {
         args.end_date = sub.end_date();
-- 
2.43.2