From aebfcb20799b9893723aadee121d5b3f3f4b4c89 Mon Sep 17 00:00:00 2001
From: Galen Charlton <gmc@esilibrary.com>
Date: Tue, 26 Mar 2013 11:20:18 -0400
Subject: [PATCH] LP#1160343: remove unused open-ils.circ settings

The circ_modifier and billing_types lists in the
open-ils.circ section of opensrf.xml are no longer
used.  This commit removes them from the opensrf.xml
example config.  It also removes the method
open-ils.circ.billing_type.retrieve.all, which has
not be used by any other code once in-DB billing types
were introduced.

Any external clients that used the method that was
removed should instead use
open-ils.circ.billing_type.ranged.retrieve.all.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
---
 Open-ILS/examples/opensrf.xml.example         | 58 -------------------
 .../perlmods/lib/OpenILS/Application/Circ.pm  | 10 ----
 2 files changed, 68 deletions(-)

diff --git a/Open-ILS/examples/opensrf.xml.example b/Open-ILS/examples/opensrf.xml.example
index 91243b1d08..7e69ff474a 100644
--- a/Open-ILS/examples/opensrf.xml.example
+++ b/Open-ILS/examples/opensrf.xml.example
@@ -816,64 +816,6 @@ vim:et:ts=4:sw=4:
                         <circ_permit_hold>circ/circ_permit_hold.js</circ_permit_hold>
                     </scripts>               
 
-                    <circ_modifiers>
-                        <mod>art</mod>
-                        <mod>atlas</mod>
-                        <mod>audiobook</mod>
-                        <mod>av</mod>
-                        <mod>new-av</mod>
-                        <mod>bestseller</mod>
-                        <mod>bestsellernh</mod>
-                        <mod>book</mod>
-                        <mod>cd</mod>
-                        <mod>dvd</mod>
-                        <mod>dvd-long</mod>
-                        <mod>e-book</mod>
-                        <mod>equipment</mod>
-                        <mod>filmstrip</mod>
-                        <mod>kit</mod>
-                        <mod>magazine</mod>
-                        <mod>map</mod>
-                        <mod>microform</mod>
-                        <mod>music</mod>
-                        <mod>record</mod>
-                        <mod>software</mod>
-                        <mod>softwrlong</mod>
-                        <mod>equip-long</mod>
-                        <mod>talking book</mod>
-                        <mod>toy</mod>
-                        <mod>video</mod>
-                        <mod>video-long</mod>
-                    </circ_modifiers>
-
-                    <billing_types>
-                        <type>Miscellaneous</type>
-                        <type>Overdue materials</type>
-                        <type>Fee for placing a hold</type>
-                        <type>Fee for checking out a book</type>
-                        <type>Fee for library card</type>
-                        <type>Miscellaneous charges</type>
-                        <type>Lost materials</type>
-                        <type>Damaged material</type>
-                        <type>Overdue Reserves charge</type>
-                        <type>Recall overdue</type>
-                        <type>Fee for processing lost library materials</type>
-                        <type>Fee for sending patron bills to collection agency</type>
-                        <type>Fee for interlibrary loan</type>
-                        <type>Fee for copies</type>
-                        <type>Money advanced to pay for telephone use</type>
-                        <type>Deposit fee</type>
-                        <type>Fee for disk</type>
-                        <type>Fee for faxing</type>
-                        <type>Fee for laminating</type>
-                        <type>Fee for room cleaning</type>
-                        <type>Deposit returned; fee refund</type>
-                        <type>Sale items</type>
-                        <type>Fee for lost card</type>
-                        <type>Long overdue items</type>
-                        <type>Lost/Replacement Cassette</type>
-                        <type>Returned Check</type>
-                    </billing_types>
                 </app_settings>
             </open-ils.circ>
 
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
index 5c2a754a9b..5549fec4a5 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
@@ -79,16 +79,6 @@ sub fetch_circ_mods {
     return $mods;
 }
 
-__PACKAGE__->register_method(
-	method => 'fetch_bill_types',
-	api_name => 'open-ils.circ.billing_type.retrieve.all');
-sub fetch_bill_types {
-	my $conf = OpenSRF::Utils::SettingsClient->new;
-	return $conf->config_value(
-		'apps', 'open-ils.circ', 'app_settings', 'billing_types', 'type' );
-}
-
-
 __PACKAGE__->register_method(
     method => 'ranged_billing_types',
     api_name => 'open-ils.circ.billing_type.ranged.retrieve.all');
-- 
2.43.2