From ae5108d5badc77c1a2ba594e836919ca70ecd9c7 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Mon, 23 May 2016 12:29:04 -0400 Subject: [PATCH] LP#1373578: fix translatability of hold placement errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch fixes a circumstance where ->maketext() could be passed an empty string, causing it to emit the PO file header text rather than a desired string. To test ------- [1] Configure Evergreen to use a TPAC localization (e.g., the Czech translation). [2] Enable the "Has Local Copy Alert" library setting. [3] In the OPAC, change locale and attempt to place a hold that would trigger the alert saying that there's already a local copy available. [4] Note that the alert reads as "Project-Id-Version: evergreen Report-Msgid-Bugs-To: ..." [5] Apply the patch. [6] Try step 3; this time the alert will be translated correctly, e.g., "Ve vaší domovské knihovně je již dostupný exemplář." Signed-off-by: Galen Charlton Signed-off-by: Ben Shum --- Open-ILS/src/templates/opac/parts/place_hold_result.tt2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/templates/opac/parts/place_hold_result.tt2 b/Open-ILS/src/templates/opac/parts/place_hold_result.tt2 index 5cf09c1100..50c20ddc54 100644 --- a/Open-ILS/src/templates/opac/parts/place_hold_result.tt2 +++ b/Open-ILS/src/templates/opac/parts/place_hold_result.tt2 @@ -90,7 +90,7 @@ l("All available copies are temporarily unavailable at your pickup library. Placing this hold could result in longer wait times.") : FAIL_PART_MSG_MAP.$fail_part_key || EVENT_MSG_MAP.$event_key || - l(hdata.hold_failed_event.desc) || + (hdata.hold_failed_event.desc ? l(hdata.hold_failed_event.desc) : '') || hdata.hold_failed_event.payload.fail_part || hdata.hold_failed_event.textcode || (hdata.hold_local_alert ? -- 2.43.2