From ab83912bc132bdd07df5ae240579480f6c433ace Mon Sep 17 00:00:00 2001
From: Mike Risher <mrisher@catalyte.io>
Date: Fri, 19 Jun 2020 20:00:04 +0000
Subject: [PATCH] lp1801947 eg-help-popover accessibility

Modify the eg-help-popover directive so that it can be invoked via
a keyboard action.

Signed-off-by: Mike Risher <mrisher@catalyte.io>

 Changes to be committed:
	modified:   Open-ILS/src/templates/staff/css/style.css.tt2
	modified:   Open-ILS/src/templates/staff/share/t_help_popover.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
---
 Open-ILS/src/templates/staff/css/style.css.tt2        |  3 +++
 Open-ILS/src/templates/staff/share/t_help_popover.tt2 | 10 ++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/Open-ILS/src/templates/staff/css/style.css.tt2 b/Open-ILS/src/templates/staff/css/style.css.tt2
index 684cf3d843..02c949ba72 100644
--- a/Open-ILS/src/templates/staff/css/style.css.tt2
+++ b/Open-ILS/src/templates/staff/css/style.css.tt2
@@ -202,6 +202,9 @@ table.list tr.selected td { /* deprecated? */
    e.g., a item alert */
 .acknowledged { text-decoration: line-through; }
 
+/* eg-help-popover directive doesn't need a border around its <button> */
+.no-border.glyphicon-question-sign { border-color: #fff; }
+
 /* bootstrap alerts are heavily padded.  use this to reduce */
 .alert-less-pad {padding: 5px;}
 
diff --git a/Open-ILS/src/templates/staff/share/t_help_popover.tt2 b/Open-ILS/src/templates/staff/share/t_help_popover.tt2
index c07ee2041a..6ce1e4ace0 100644
--- a/Open-ILS/src/templates/staff/share/t_help_popover.tt2
+++ b/Open-ILS/src/templates/staff/share/t_help_popover.tt2
@@ -1,12 +1,14 @@
-<span class="glyphicon glyphicon-question-sign"
+<button class="glyphicon glyphicon-question-sign no-border"
       uib-popover="{{helpText}}"
       popover-trigger="click"
       popover-placement="auto"
+      i18n-aria-label aria-label="Help"
       ng-if="!helpLink || helpLink.length == 0"
-></span>
-<span class="glyphicon glyphicon-question-sign"
+></button>
+<button class="glyphicon glyphicon-question-sign no-border"
       uib-popover-html="helpHtml"
       popover-trigger="click"
       popover-placement="auto"
+      i18n-aria-label aria-label="Help"
       ng-if="helpLink.length > 0"
-></span>
+></button>
-- 
2.43.2