From aa59cf9a3a851e0affc201ed260bd44dfd277a25 Mon Sep 17 00:00:00 2001 From: dbs Date: Mon, 10 Dec 2007 19:41:48 +0000 Subject: [PATCH] Add a test for incorrect driver in /reporter/; bug found by Ben Ostrowsky. Test for /reporter/ in xpath including delimiters, instead of just "reporter". git-svn-id: svn://svn.open-ils.org/ILS/trunk@8189 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/src/support-scripts/settings-tester.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/support-scripts/settings-tester.pl b/Open-ILS/src/support-scripts/settings-tester.pl index aa7c02ccda..fe00d50a99 100755 --- a/Open-ILS/src/support-scripts/settings-tester.pl +++ b/Open-ILS/src/support-scripts/settings-tester.pl @@ -153,14 +153,17 @@ foreach my $driver_node (@drivers) { $language = $lang_nodes[0]->findvalue("child::text()"); } if ($driver eq "pgsql") { - if ($language eq "C") { + if ($driver_xpath =~ m#/reporter/#) { + $result = "* ERROR: reporter application must use driver 'Pg', but '$driver' is defined\n"; + warn $result; + } elsif ($language eq "C") { $result = "* OK: $driver language is $language in $lang_xpath\n"; } else { $result = "* ERROR: $driver language is $language in $lang_xpath\n"; warn $result; } } elsif ($driver eq "Pg") { - if ($driver_xpath =~ /reporter/) { + if ($driver_xpath =~ m#/reporter/#) { $result = "* OK: $driver language is undefined for reporter base configuration\n"; } elsif ($language eq "perl") { $result = "* OK: $driver language is $language in $lang_xpath\n"; -- 2.43.2