From a325b02227ff6e107581f90e615bc7a8299c41a1 Mon Sep 17 00:00:00 2001 From: erickson Date: Mon, 2 Mar 2009 22:45:01 +0000 Subject: [PATCH] repairing var name typos/thinkos found with use strict git-svn-id: svn://svn.open-ils.org/ILS/trunk@12360 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- .../src/perlmods/OpenILS/Application/Trigger.pm | 4 ++-- .../OpenILS/Application/Trigger/EventGroup.pm | 13 +++++++------ .../OpenILS/Application/Trigger/ModRunner.pm | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm index 71be4e5412..c3be021dd2 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger.pm @@ -172,13 +172,13 @@ sub grouped_events { for my $e_id ( @$events ) { my $e = OpenILS::Application::Trigger::Event->new($e_id); if ($e->validate->valid) { - if (my $group = $event->event->event_def->group_field) { + if (my $group = $e->event->event_def->group_field) { # split the grouping link steps my @steps = split '.', $group; # find the grouping object - my $node = $event->target; + my $node = $e->target; $node = $node->$_() for ( @steps ); # get the pkey value for the grouping object on this event diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm index 3547b9e4d4..b2f3d0c53a 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/EventGroup.pm @@ -184,6 +184,7 @@ sub update_state { $self->editor->xact_begin || return undef; my @oks; + my $ok; for my $event ( @{ $self->events } ) { my $e = $self->editor->retrieve_action_trigger_event( $event->id ); $e->start_time( 'now' ) unless $e->start_time; @@ -223,16 +224,16 @@ sub build_environment { my $self = shift; my $env = $self->environment; - $$evn{target} = []; - $$evn{event} = []; + $$env{target} = []; + $$env{event} = []; for my $e ( @{ $self->events } ) { - for my $evn_part ( keys %{ $e->environment } ) { + for my $env_part ( keys %{ $e->environment } ) { if ($env_part eq 'target') { - push @{ $$evn{target} }, $e->environment->{target}; + push @{ $$env{target} }, $e->environment->{target}; } elsif ($env_part eq 'event') { - push @{ $$evn{event} }, $e->environment->{event}; + push @{ $$env{event} }, $e->environment->{event}; } else { - $$evn{$evn_part} = $e->environment->{$evn_part}; + $$env{$env_part} = $e->environment->{$env_part}; } } } diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm index 7cab0b1b0e..747da7abc1 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Trigger/ModRunner.pm @@ -57,7 +57,7 @@ sub load { my $loaded = $m->use; if (!$loaded) { - $builtin_m = $self->prefix . "::$m"; + my $builtin_m = $self->prefix . "::$m"; $loaded = $builtin_m->use; if (!$loaded) { -- 2.43.2