From 97fc9f4806179c4eef42a1d5febc317dcb611a7d Mon Sep 17 00:00:00 2001
From: senator <lebbeous@esilibrary.com>
Date: Fri, 25 Feb 2011 11:42:30 -0500
Subject: [PATCH] refining advanced search now preserves qtype/contains/query
 combos.  also,

also, show something better for empty search results
---
 .../web/css/skin/default/opac/semiauto.css    |  1 -
 Open-ILS/web/css/skin/default/opac/style.css  |  3 ++
 .../opac/parts/advanced/global_row.tt2        | 29 +++++++++++--------
 ...stypes_selector.tt2 => qtype_selector.tt2} | 12 ++++----
 .../default/opac/parts/result/lowhits.tt2     |  9 ++++--
 .../default/opac/parts/searchbar.tt2          |  2 +-
 6 files changed, 33 insertions(+), 23 deletions(-)
 rename Open-ILS/web/templates/default/opac/parts/{stypes_selector.tt2 => qtype_selector.tt2} (58%)

diff --git a/Open-ILS/web/css/skin/default/opac/semiauto.css b/Open-ILS/web/css/skin/default/opac/semiauto.css
index 68edb5e686..f652eaa2e9 100644
--- a/Open-ILS/web/css/skin/default/opac/semiauto.css
+++ b/Open-ILS/web/css/skin/default/opac/semiauto.css
@@ -27,7 +27,6 @@
 .opac-auto-039 { float: left; font-weight: bold; padding-top: 5px; }
 .opac-auto-040 { float: left; padding: 5px 0px 0px 10px; }
 .left-corner { float: left; width: 163px; height: 30px; background: url('/images/utils-corner-mid.png') repeat-x top; }
-.opac-auto-043 { float: left; width: 300px; margin-top: 20px; }
 .float-right { float: right; }
 .opac-auto-045 { float: right; margin-right: 17px; }
 .opac-auto-046 { float: right; width: 214px; }
diff --git a/Open-ILS/web/css/skin/default/opac/style.css b/Open-ILS/web/css/skin/default/opac/style.css
index 0366017eb2..6780de35f0 100644
--- a/Open-ILS/web/css/skin/default/opac/style.css
+++ b/Open-ILS/web/css/skin/default/opac/style.css
@@ -714,6 +714,8 @@ div.select-wrapper:hover {
 	padding-bottom:5px;
 }
 
+#zero_search_hits div { float:left;width:300px;margin-top:20px; }
+
 #zero_search_hits p {
 	margin-top:0;
 }
@@ -937,3 +939,4 @@ div.select-wrapper:hover {
 #adv_search_refine {
     padding-left: 5em; background-color: #d7d7d7; margin: 2ex 0;
 }
+.row-remover { position: relative; top: 1px; vertical-align: middle; }
diff --git a/Open-ILS/web/templates/default/opac/parts/advanced/global_row.tt2 b/Open-ILS/web/templates/default/opac/parts/advanced/global_row.tt2
index f55321867a..afa97ffeb8 100644
--- a/Open-ILS/web/templates/default/opac/parts/advanced/global_row.tt2
+++ b/Open-ILS/web/templates/default/opac/parts/advanced/global_row.tt2
@@ -1,21 +1,26 @@
-<tr id="adv_global_row" type='input'>
+[%
+    contains = CGI.param('contains');
+    queries = CGI.param('query');
+    qtypes = CGI.param('qtype') || ['keyword'];
+    FOR qtype IN qtypes;
+        c = contains.shift;
+        q = queries.shift; %]
+<tr[% IF loop.first %] id="adv_global_row"[% END %]>
     <td align='left' width='100%' nowrap='nowrap'>
-        <!-- select the search class -->
         <span class="opac-auto-078">
-            [% INCLUDE "default/opac/parts/stypes_selector.tt2" %]
+            [% INCLUDE "default/opac/parts/qtype_selector.tt2"
+                query_type=qtype %]
         </span>
-        <!-- select how to treat the text -->
         <select name='contains' style='margin-right: 7px;'>
-            <option value='contains'>[% l("Contains") %]</option>
-            <option value='nocontains'>[% l("Does not contain") %]</option>
-            <option value='exact'>[% l("Matches Exactly") %]</option>
+            <option value='contains'[% c == 'contains' ? ' selected="selected"' : '' %]>[% l("Contains") %]</option>
+            <option value='nocontains'[% c == 'nocontains' ? ' selected="selected"' : '' %]>[% l("Does not contain") %]</option>
+            <option value='exact'[% c == 'exact' ? ' selected="selected"' : '' %]>[% l("Matches Exactly") %]</option>
         </select>
-        <!-- search term -->
-        <input type='text' size='18' name='query' />
-        <!-- Remove this row -->
-        <a href="javascript:;"
-            style="position:relative;top:1px; vertical-align: middle;"
+        <input type='text' size='18' name='query' value="[% q | html %]" />
+        <a href="javascript:;" class="row-remover"
             title="[% l('Remove row') %]" alt="[% l('Remove row') %]"
             onclick='var row = this.parentNode.parentNode;var tbody = row.parentNode; if( tbody.getElementsByTagName("tr").length > 2 ) row.parentNode.removeChild(row);'><img src="[% ctx.media_prefix %]/images/adv_row_close_btn.png" /></a>
     </td>
 </tr>
+[%      i = i + 1;
+    END %]
diff --git a/Open-ILS/web/templates/default/opac/parts/stypes_selector.tt2 b/Open-ILS/web/templates/default/opac/parts/qtype_selector.tt2
similarity index 58%
rename from Open-ILS/web/templates/default/opac/parts/stypes_selector.tt2
rename to Open-ILS/web/templates/default/opac/parts/qtype_selector.tt2
index b139791e05..8c31f0d4f4 100644
--- a/Open-ILS/web/templates/default/opac/parts/stypes_selector.tt2
+++ b/Open-ILS/web/templates/default/opac/parts/qtype_selector.tt2
@@ -1,4 +1,4 @@
-[%  search_classes = [
+[%  query_types = [
     {value => "keyword", label => l("Keyword")},
     {value => "title", label => l("Title")},
     {value => "author", label => l("Author")},
@@ -7,10 +7,10 @@
     {value => "id|bibcn", label => l("Call Number")}
 ] %]
 <select name="qtype">
-    [%  search_class = CGI.param('qtype');
-        FOR sc IN search_classes -%]
-    <option value='[% sc.value %]'[%
-        search_class == sc.value ? ' selected="selected"' : ''
-    %]>[% sc.label %]</option>
+    [%  query_type = query_type || CGI.param('qtype');
+        FOR qt IN query_types -%]
+    <option value='[% qt.value %]'[%
+        query_type == qt.value ? ' selected="selected"' : ''
+    %]>[% qt.label %]</option>
     [% END -%]
 </select>
diff --git a/Open-ILS/web/templates/default/opac/parts/result/lowhits.tt2 b/Open-ILS/web/templates/default/opac/parts/result/lowhits.tt2
index 1afe8b0f17..9393c49a00 100644
--- a/Open-ILS/web/templates/default/opac/parts/result/lowhits.tt2
+++ b/Open-ILS/web/templates/default/opac/parts/result/lowhits.tt2
@@ -1,8 +1,11 @@
 <div id='result_low_hits'>
     <div id="zero_search_hits">
-        <div style="float:left;width:300px;margin-top:20px;">
-            <p>Sorry, no entries were found for
-                <q id="zero_hits_term">[% query | html %]</q><br />
+        <div>
+            <p>[% l('Sorry, no entries were found for') %]
+                [% IF is_advanced; l('your search'); ELSE %]
+                <q>[% CGI.param('query') | html %]</q>
+                [% END %]
+                <br />
                 <span id="zero_hits_label1" class="hide_me">Did you mean
                     <strong><a id="spell_check_link" href="javascript:;"></a></strong>?</span>
             </p>
diff --git a/Open-ILS/web/templates/default/opac/parts/searchbar.tt2 b/Open-ILS/web/templates/default/opac/parts/searchbar.tt2
index 7a83aeaf55..8e9d7877ea 100644
--- a/Open-ILS/web/templates/default/opac/parts/searchbar.tt2
+++ b/Open-ILS/web/templates/default/opac/parts/searchbar.tt2
@@ -18,7 +18,7 @@
                 <input type="hidden" name="_adv" value="1" />
             [% ELSE %]
             <td>
-            [% INCLUDE "default/opac/parts/stypes_selector.tt2" %]
+            [% INCLUDE "default/opac/parts/qtype_selector.tt2" %]
             </td>
             <td>
             [% END %]
-- 
2.43.2