From 976ff32f7759921d6b05edc3c6359ae385309ca7 Mon Sep 17 00:00:00 2001 From: Jason Boyer Date: Tue, 15 Sep 2020 15:37:09 -0400 Subject: [PATCH] LP1895660: Search/Authority.pm Argument "" isn't numeric in numeric ne (!=) One of the "fun" things about perl and its type system is that it uses different operators to compare strings vs comparing numbers... Signed-off-by: Jason Boyer Signed-off-by: Jane Sandberg Signed-off-by: Galen Charlton --- .../src/perlmods/lib/OpenILS/Application/Search/Authority.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm index 277891248d..93b1ab1fed 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Authority.pm @@ -76,7 +76,7 @@ sub search_authority_by_simple_normalize_heading { my $e = new_editor(); my $norm_heading = $e->json_query($norm_heading_query)->[0]->{'authority.simple_normalize_heading'}; - unless (defined($norm_heading) && $norm_heading != '') { + unless (defined($norm_heading) && $norm_heading ne '') { return OpenILS::Event->new('BAD_PARAMS', note => 'Heading normalized to null or empty string'); } -- 2.43.2