From 897d8eb924182571bcbca179b707dc3444fc7228 Mon Sep 17 00:00:00 2001 From: erickson Date: Fri, 3 Mar 2006 17:57:15 +0000 Subject: [PATCH] did some debugging.. made buildOPACLink safer WRT array params git-svn-id: svn://svn.open-ils.org/ILS/trunk@3248 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/web/opac/common/js/opac_utils.js | 4 ++-- Open-ILS/web/opac/skin/default/js/cn_browse.js | 7 +------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/Open-ILS/web/opac/common/js/opac_utils.js b/Open-ILS/web/opac/common/js/opac_utils.js index 9315cedd88..22544d2091 100644 --- a/Open-ILS/web/opac/common/js/opac_utils.js +++ b/Open-ILS/web/opac/common/js/opac_utils.js @@ -198,8 +198,8 @@ function buildOPACLink(args, slim, ssl) { if(x == PARAM_DEPTH && v == 0) continue; if(x == PARAM_COUNT && v == 10) continue; if(x == PARAM_FORM && v == 'all' ) continue; - if( instanceOf(v, Array) ) { - for( var i = 0; i != v.length; i++ ) { + if( instanceOf(v, Array) && v.length ) { + for( var i = 0; i < v.length; i++ ) { string += "&" + x + "=" + encodeURIComponent(v[i]); } } else { diff --git a/Open-ILS/web/opac/skin/default/js/cn_browse.js b/Open-ILS/web/opac/skin/default/js/cn_browse.js index 78c1a0aeb4..7a8843648a 100644 --- a/Open-ILS/web/opac/skin/default/js/cn_browse.js +++ b/Open-ILS/web/opac/skin/default/js/cn_browse.js @@ -125,12 +125,6 @@ function _cnBrowseDraw( list ) { var record = list[idx][2]; var id = list[idx][3]; - /* - if( label != cnBrowseCurrent ) { - removeCSSClass( td, 'cn_browse_home_cn' ); - } - */ - if( idx == 0 ) { cnBrowseTopCn = label; cnBrowseTopId = id; } cnBrowseBottomCn = label; cnBrowseBottomId = id; @@ -164,6 +158,7 @@ function _cnBrowseDraw( list ) { function cnBrowseDrawTitle(r) { var mods = r.getResultObject(); + buildTitleDetailLink(mods, r.title_td); buildSearchLink(STYPE_AUTHOR, mods.author(), r.author_td); r.pic_td.setAttribute("src", buildISBNSrc(cleanISBN(mods.isbn()))); -- 2.43.2