From 881b4669725e84df992f0ad5ffff82a61ab401e7 Mon Sep 17 00:00:00 2001 From: Bill Erickson Date: Wed, 15 Feb 2012 17:07:24 -0500 Subject: [PATCH] Update pickup lib from holds shelf status test repair When determining whether a hold is getting updated while already on the holds shelf, it's important to also treat hold status 5 as an on-shelf status. Status 5 comes into play when the circ.hold_shelf_status_delay org unit setting is activated and acts as a virtual status indicating the item is physically en route to the shelf. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander --- Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm index 6808522f5c..9271c5de84 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm @@ -966,7 +966,7 @@ sub update_hold_impl { $transit->dest($hold->pickup_lib); $e->update_action_hold_transit_copy($transit) or return $e->die_event; - } elsif($hold_status == 4 or $hold_status == 8) { # on holds shelf + } elsif($hold_status == 4 or $hold_status == 5 or $hold_status == 8) { # on holds shelf return $e->die_event unless $e->allowed('UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF', $orig_hold->pickup_lib); return $e->die_event unless $e->allowed('UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF', $hold->pickup_lib); -- 2.43.2