From 82029a3cf00a9cc05de4db03041a46a822ef0f32 Mon Sep 17 00:00:00 2001 From: gmc Date: Tue, 11 Jan 2011 23:18:21 +0000 Subject: [PATCH] allow deletion of incomplete invoice LIs Fix silent failure when attempting to delete a LI whose type or cost was not set; dojo.string.subtitute does not like replacement values to be null. Signed-off-by: Galen Charlton git-svn-id: svn://svn.open-ils.org/ILS/trunk@19160 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- Open-ILS/web/js/ui/default/acq/invoice/view.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Open-ILS/web/js/ui/default/acq/invoice/view.js b/Open-ILS/web/js/ui/default/acq/invoice/view.js index 281189f928..38465b99e8 100644 --- a/Open-ILS/web/js/ui/default/acq/invoice/view.js +++ b/Open-ILS/web/js/ui/default/acq/invoice/view.js @@ -385,8 +385,8 @@ function addInvoiceItem(item) { var cost = widgetRegistry.acqii[item.id()].cost_billed.getFormattedValue(); var msg = dojo.string.substitute( localeStrings.INVOICE_CONFIRM_ITEM_DELETE, [ - cost, - widgetRegistry.acqii[item.id()].inv_item_type.getFormattedValue() + cost || 0, + widgetRegistry.acqii[item.id()].inv_item_type.getFormattedValue() || '' ] ); if(!confirm(msg)) return; -- 2.43.2