From 73e3fabad58499050ca07f9aeb52238201690125 Mon Sep 17 00:00:00 2001 From: erickson Date: Fri, 18 Nov 2005 20:08:36 +0000 Subject: [PATCH] did some robustification git-svn-id: svn://svn.open-ils.org/ILS/trunk@2087 dcc99617-32d9-48b4-a31d-7c20da2025e4 --- .../src/perlmods/OpenILS/Application/Search/AddedContent.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Search/AddedContent.pm b/Open-ILS/src/perlmods/OpenILS/Application/Search/AddedContent.pm index 2066cc7d11..c5a263fc2b 100644 --- a/Open-ILS/src/perlmods/OpenILS/Application/Search/AddedContent.pm +++ b/Open-ILS/src/perlmods/OpenILS/Application/Search/AddedContent.pm @@ -36,6 +36,7 @@ sub initialize { # If not data is retrieved (or timeout occurs), undef is returned sub retrieve_added_content { my( $type, $isbn, $summary ) = @_; + return undef unless ( $isbn && $isbn ne "" ); my $func = "fnDetailByItemKey"; if($summary) { $func = "fnContentByItemKey"; } @@ -80,6 +81,7 @@ __PACKAGE__->register_method( sub summary { my( $self, $client, $isbn ) = @_; my $data = retrieve_added_content( "member", $isbn, 1 ); + return {} unless $data; my $doc = XML::LibXML->new->parse_string($data); my $summary = {}; return $summary unless $doc; @@ -116,6 +118,7 @@ sub reviews { my( $self, $client, $isbn ) = @_; my $data = retrieve_added_content( "review", $isbn ); + return undef unless $data; my $doc = XML::LibXML->new->parse_string($data); my $ret = []; @@ -161,8 +164,8 @@ sub toc { my( $self, $client, $isbn ) = @_; my $data = retrieve_added_content( "toc", $isbn ); + return undef unless $data; my $doc = XML::LibXML->new->parse_string($data); - my $ret = {}; my @nodes = $doc->findnodes("//*[local-name()='TOCText']")->get_nodelist(); -- 2.43.2