From 4bea26e2721cd0cb52f2a4a6f7b570e98a83b720 Mon Sep 17 00:00:00 2001
From: Cesar Velez <cesar.velez@equinoxinitiative.org>
Date: Thu, 24 Aug 2017 17:17:11 -0400
Subject: [PATCH] LP#1710512 - OPAC js strings need to be i18n-izable

Adds a way to translate displayed string messages, in OPAC
JS source code alerts and other outputs. This is done by having
js.tt2 include i18n-strings.tt2 which contains an explosed/global
JS blob variable called eg_opac_i18n. This is intended to work
in similar fashion as base_js.tt2 in the webstaff ng client.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---
 Open-ILS/src/templates/opac/i18n_strings.tt2        | 9 +++++++++
 Open-ILS/src/templates/opac/parts/js.tt2            | 2 +-
 Open-ILS/web/js/ui/default/opac/holds-validation.js | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 Open-ILS/src/templates/opac/i18n_strings.tt2

diff --git a/Open-ILS/src/templates/opac/i18n_strings.tt2 b/Open-ILS/src/templates/opac/i18n_strings.tt2
new file mode 100644
index 0000000000..d92c2b5f63
--- /dev/null
+++ b/Open-ILS/src/templates/opac/i18n_strings.tt2
@@ -0,0 +1,9 @@
+<!--
+This file allows us to bring TT2 i18n'ized strings
+to js source files, via js blob.
+-->
+<script>
+    var eg_opac_i18n = {};
+
+    eg_opac_i18n.EG_MISSING_REQUIRED_INPUT = "[% l('Please fill out all required fields') %]";
+</script>
diff --git a/Open-ILS/src/templates/opac/parts/js.tt2 b/Open-ILS/src/templates/opac/parts/js.tt2
index e581b07ead..d4c588fd0c 100644
--- a/Open-ILS/src/templates/opac/parts/js.tt2
+++ b/Open-ILS/src/templates/opac/parts/js.tt2
@@ -1,6 +1,6 @@
 <!-- JS imports, etc.  -->
 <script type="text/javascript" src="[% ctx.media_prefix %]/js/ui/default/opac/simple.js[% ctx.cache_key %]"></script>
-
+[% INCLUDE "opac/i18n_strings.tt2" %]
 <!-- DOB validation for Patron Registration in OPAC -->
 <script type="text/javascript">
     function dobValidate(input) {
diff --git a/Open-ILS/web/js/ui/default/opac/holds-validation.js b/Open-ILS/web/js/ui/default/opac/holds-validation.js
index 842366c50e..ef3c4cd616 100644
--- a/Open-ILS/web/js/ui/default/opac/holds-validation.js
+++ b/Open-ILS/web/js/ui/default/opac/holds-validation.js
@@ -66,7 +66,7 @@ function validateHoldForm() {
     {
         return true;
     } else {
-        alert ("Please complete hold notification method info.");
+        alert(eg_opac_i18n.EG_MISSING_REQUIRED_INPUT);
         res.culpritNames.forEach(function(n){
             document.getElementsByName(n)[0].style.backgroundColor  = "yellow";
         });
-- 
2.43.2