From 4a54354018903f3554a5badfa7e4dcccf456ee56 Mon Sep 17 00:00:00 2001 From: Dan Briem Date: Fri, 5 Jul 2019 19:34:13 -0400 Subject: [PATCH] LP#1805895 Bucket grid configuration updates do not save Some saved columns stick, but others are ignored. Issue affects eg-grid[s] that use the auto-fields attr to load all columns on idl-class attr. This is because saved columns are whitelisted against the initial column config before the auto fields are loaded. Patch adds $scope.handleAutoFields() to egCore.hatch.getItem. This happens after the eg-grid-fields transclude (no collisions) but before the saved columns are whitelisted. The original call remains to handle cases where there is no persist-key or saved config. Test: 1. Go to Circulation->User Buckets 2. Add the Is Deleted column to the grid 3. Save columns and refresh (note Is Deleted is not visible) 4. Apply patch and repeat steps 1-3 (note Is Deleted is now visible) Signed-off-by: Dan Briem Signed-off-by: Galen Charlton Signed-off-by: Jason Boyer --- Open-ILS/web/js/ui/default/staff/services/grid.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js index 732ec59bfe..8421cc11a2 100644 --- a/Open-ILS/web/js/ui/default/staff/services/grid.js +++ b/Open-ILS/web/js/ui/default/staff/services/grid.js @@ -498,6 +498,9 @@ angular.module('egGridMod', .then(function(conf) { if (!conf) return; + // load all column options before validating saved columns + $scope.handleAutoFields(); + var columns = grid.columnsProvider.columns; var new_cols = []; -- 2.43.2