From 3a2e51f8b637cd3b3020767728dd6cf889fb2922 Mon Sep 17 00:00:00 2001 From: Mike Rylander Date: Wed, 10 Jun 2020 15:29:16 -0400 Subject: [PATCH] LP#1882937: Comment and dead-code cleanup Adjust comments in Storage::Driver::Pg to remove references to Class::DBI::Replication, which we did not end up using. Also remove a commented-out sub that purported to make use of a function that did not exist in the home-grown multi-db implementation. NOTE: While unused, the multi-db implementation in Storage::Driver::Pg intelligently decides when to use a read-only secondary based on the existence of a transaction or the "write-iness" state controlled by the caller, and does not require separate main (or primary) and secondary db lists. Signed-off-by: Mike Rylander --- .../OpenILS/Application/Storage/Driver/Pg.pm | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm index f556456dce..9050ca31e6 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg.pm @@ -1,12 +1,11 @@ -{ # The driver package itself just needs a db_Main method (or db_standbys if - #Class::DBI::Replication is in use) for Class::DBI to call. +{ # The driver package itself just needs a db_Main method. # # Any other fixups can go in here too... Also, the drivers should subclass the # DBI driver that they are wrapping, or provide a 'quote()' method that calls # the DBD::xxx::quote() method on FTI's behalf. # - # The dirver MUST be a subclass of Class::DBI(::Replication) and + # The dirver MUST be a subclass of Class::DBI and # OpenILS::Application::Storage. #------------------------------------------------------------------------------- package OpenILS::Application::Storage::Driver::Pg; @@ -139,18 +138,6 @@ return $self->db_Main->quote(@_) } -# sub tsearch2_trigger { -# my $self = shift; -# return unless ($self->value); -# $self->index_vector( -# $self->db_standbys->selectrow_array( -# "SELECT to_tsvector('default',?);", -# {}, -# $self->value -# ) -# ); -# } - my $_xact_session; my $_audit_session; -- 2.43.2