From 22536d162f757feaa2fe055d1d6c0b0878dd29ae Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Wed, 15 Jun 2016 20:16:52 -0400 Subject: [PATCH] LP#1592891: tweak tests This patch wraps the standing penalty checks in evals so that if they crash, the test script can carry on -- and make it to the point where it cleans up the standing penalties it adds. Signed-off-by: Galen Charlton --- .../18-lp1592891_sip_standing_penalties.t | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/Open-ILS/src/perlmods/live_t/18-lp1592891_sip_standing_penalties.t b/Open-ILS/src/perlmods/live_t/18-lp1592891_sip_standing_penalties.t index 7791cd3df0..bf695bce55 100644 --- a/Open-ILS/src/perlmods/live_t/18-lp1592891_sip_standing_penalties.t +++ b/Open-ILS/src/perlmods/live_t/18-lp1592891_sip_standing_penalties.t @@ -92,13 +92,27 @@ sub patron_sip_test { sub patron_sip_too_many_overdue_test { my $patron_id = shift; my $patron = OpenILS::SIP::Patron->new(usr => $patron_id, authtoken => $script->authtoken); - return $patron->too_many_overdue; + my $rv; + eval { $rv = $patron->too_many_overdue }; + if ($@) { + diag('$patron->too_many_overdue crashed: ' . $@); + return; + } else { + return $rv; + } } sub patron_sip_excessive_fines_test { my $patron_id = shift; my $patron = OpenILS::SIP::Patron->new(usr => $patron_id, authtoken => $script->authtoken); - return $patron->excessive_fines; + my $rv; + eval { $rv = $patron->excessive_fines }; + if ($@) { + diag('$patron->excessive_fines crashed: ' . $@); + return; + } else { + return $rv; + } } # In concerto, we need to register a workstation. -- 2.43.2