Evergreen.git
3 months agoBumping version numbers, adding Upgrade Script and Changelog tags/rel_3_2_6
Dan Wells [Tue, 21 May 2019 14:43:16 +0000 (10:43 -0400)]
Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoCustomize upgrade notes for 3.2.6
Dan Wells [Thu, 28 Feb 2019 21:31:37 +0000 (16:31 -0500)]
Customize upgrade notes for 3.2.6

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoTranslation updates - po files
Dan Wells [Tue, 21 May 2019 14:19:46 +0000 (10:19 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoBump OpenILS.pm version
Dan Wells [Tue, 21 May 2019 14:15:36 +0000 (10:15 -0400)]
Bump OpenILS.pm version

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoRecent newpot rethink and redo
Dan Wells [Mon, 20 May 2019 16:34:17 +0000 (12:34 -0400)]
Recent newpot rethink and redo

The newpot build command has a tendancy to cause more harm than good in
certain cases.  Basically, if run with a translation-toolkit of 2.0+
after originally using 1.x, you end up with different POT formatting
which in turn breaks existing translations for those strings.

I talked this over with Ben Shum, and he advised we simply stop doing
POT updates in point releases for now.  I agree, and this reversal is
my attempt to stop the bleeding.  It tries to remove any unneeded POT
changes from recent history, while also keeping completely new strings
that have already snuck in.

This reverts commit a37154508d8fc078b5d9bae5ada105a534c13ecd.
This re-does commit 4e0b9d31cdbda3c356b22778b361ae4e60375255.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoDocs: Fix list formatting in 3.2 release notes
Remington Steed [Mon, 20 May 2019 13:27:58 +0000 (09:27 -0400)]
Docs: Fix list formatting in 3.2 release notes

An AsciiDoc list needs a blank line before it. Otherwise, it is just
part of the paragraph.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 months agoDocs: Add bugfix release notes for 3.2.6
Remington Steed [Fri, 17 May 2019 19:41:52 +0000 (15:41 -0400)]
Docs: Add bugfix release notes for 3.2.6

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 months agoLP1813633 TCN search can find deleted records
Bill Erickson [Tue, 14 May 2019 17:03:35 +0000 (13:03 -0400)]
LP1813633 TCN search can find deleted records

As with the XUL client, when performing a bib record TCN search
(Cataloging -> Retrieve Record By TCN), first look for non-deleted
records with the requested TCN.  When none are found, perform a
secondary search for deleted records with the requested TCN.

To test in concerto:

[1] Navigate to Cataloging -> Retrieve Record By TCN
[2] Search for TCN value "10", which is deleted by default in Concerto.
[3] Confirm the deleted record is loaded.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
4 months agoLP#1788680 prevent copy template apply failure on null stat cats
Jeff Davis [Fri, 8 Jun 2018 19:09:54 +0000 (12:09 -0700)]
LP#1788680 prevent copy template apply failure on null stat cats

Under some circumstances, the current code can result in a JS failure:

Cannot read property 'filter' of undefined

When this happens, the copy template may apply partially or not at all.
This change simply makes sure cp.stat_cat_entries() exists before
attempting to filter it.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
4 months agoLP1806394: Placing Holds in Item Buckets
Jason Boyer [Mon, 3 Dec 2018 13:11:29 +0000 (08:11 -0500)]
LP1806394: Placing Holds in Item Buckets

A missing return prevents a list of item ids from
being built so no holds can be placed from item
buckets. This branch returns the return to its
proper place.

To test
-------
[1] Add some items to an item bucket, ensuring that they are
    all holdable.
[2] From the item bucket interface, select the items and choose
    the Request Selected Items action.
[3] Confirm placing the requests.
[4] Note that the requests are not actually created.
[5] Apply the patch and repeat steps #1-#4. This time, the requests
    should be placed.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Millissa Macomber <millissam@burlingtonwa.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1826890: set page title for Statistical Popularity Badges admin page
Galen Charlton [Mon, 29 Apr 2019 14:56:14 +0000 (10:56 -0400)]
LP#1826890: set page title for Statistical Popularity Badges admin page

To test
-------
[1] In the browser client, navigate to Local Administration -> Statistical
    Popularity Badges
[2] Note that the web browser's tab header doesn't display a title for the
    page, just the URL.
[3] Apply the patch and reload the page. This time, a page title should
    be dispayed in the browser's tab header.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1792188: Record -> View Holds fails to refresh on Next/Prev record
Mike Rylander [Fri, 14 Sep 2018 13:52:03 +0000 (09:52 -0400)]
LP#1792188: Record -> View Holds fails to refresh on Next/Prev record

Here we clean up and add back a call to refresh the holds list when navigating
between records in a result set.

To test
-------
[1] In the web staff client, perform a catalog search, bring up a record,
    and change to the View Holds tab.
[2] Click the "Next" button to navigate to the next hold. Note that
    the list of holds doesn't change.
[3] Apply the patch, refresh, and repeat steps #1 and #2. This time,
    the list of holds should get updated as you navigate between
    records in the results list.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: John Yorio <jyorio@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1803729 action_trigger_aggregator.pl help indicates the wrong bash argument for...
blake [Fri, 16 Nov 2018 15:37:31 +0000 (09:37 -0600)]
LP1803729 action_trigger_aggregator.pl help indicates the wrong bash argument for remote-acct

Fixed the help message action_trigger_aggregator.pl to agree with the code

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1782014 Fix grid path for Title in patron items out
Remington Steed [Wed, 10 Apr 2019 20:32:13 +0000 (16:32 -0400)]
LP#1782014 Fix grid path for Title in patron items out

When the Items Out grid was updated to use display fields, the
displayed title was updated (along with the fleshed data in the
javascript) but the grid "path" was not. This commit fixes the path,
which fixes title sorting. (Title sorting broke because the
simple_record.title was no longer being fleshed in via the JS code, so
the grid was attempting to sort on an empty value.)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 months agoLp 1752968: Select content when focusing on the barcode field.
Jason Stephenson [Tue, 18 Dec 2018 14:26:11 +0000 (09:26 -0500)]
Lp 1752968: Select content when focusing on the barcode field.

To reproduce the reported behavior:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field does not have cursor focus.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field does
     not have focus and the content is not selected.

To test this branch:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field has cursor focus, i.e. the cursor is in
    the field and blinking.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field has
     cursor focus and the content is selected/highlighted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
4 months agoLp 1752968: Focus Barcode Field in Volumes/Copy Editor
Jason Stephenson [Mon, 17 Dec 2018 16:08:47 +0000 (11:08 -0500)]
Lp 1752968: Focus Barcode Field in Volumes/Copy Editor

Always focus the barcode field when adding or editing volumes or
copies.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
4 months agoLP 1333893: Keep Empty Bib on Volume Transfer
Jason Stephenson [Thu, 11 Oct 2018 12:50:30 +0000 (08:50 -0400)]
LP 1333893: Keep Empty Bib on Volume Transfer

Volume transfer did not honor the cat.bib_keep_on_empty organizational
unit setting when removing empty bib records.  This commit changes it
so that tranfer honors the setting in the same manner that deleting
copies and volumes does.

To test this fix, set cat.bib_keep_on_empty for your workstation
org. unit to true, and then transfer all of the volumes from one bib
record to another.  The empty bib record should not get deleted.

You can also test with the setting on false to make sure that the
empty bib gets deleted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Beth Willis <willis@noblenet.org>
4 months agoLP#1814943: (follow-up) remove ersatz ctx.page_type line
Galen Charlton [Mon, 29 Apr 2019 14:49:19 +0000 (10:49 -0400)]
LP#1814943: (follow-up) remove ersatz ctx.page_type line

Guessing that the original bug was due to "page_type" being
entered when "page_title" was meant.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1814943 Closed Dates Editor Tab Missing Title
McCanna [Wed, 6 Feb 2019 18:52:48 +0000 (13:52 -0500)]
LP#1814943 Closed Dates Editor Tab Missing Title

Small fix to add missing page title.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1823387: avoid double slashes in booking URLs, which will not work with recent...
Jeff Davis [Fri, 5 Apr 2019 18:08:55 +0000 (11:08 -0700)]
LP#1823387: avoid double slashes in booking URLs, which will not work with recent versions of Apache

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1642036 Group member detail grid query repair
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair

Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 months agoLP#1778940: stamp schema update
Galen Charlton [Wed, 24 Apr 2019 19:41:49 +0000 (15:41 -0400)]
LP#1778940: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP#1778940: (follow-up) create indexes concurrently during upgrade
Galen Charlton [Wed, 24 Apr 2019 19:37:06 +0000 (15:37 -0400)]
LP#1778940: (follow-up) create indexes concurrently during upgrade

This reduces potential for locking when run in a production
database, particularly if done outside of a full version upgrade.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 months agoLP1778940: Add Indexes to ate.*_output
Jason Boyer [Thu, 28 Jun 2018 18:36:27 +0000 (14:36 -0400)]
LP1778940: Add Indexes to ate.*_output

When there are many rows in action_trigger.event_output
simply ensuring referencial integrity can take an
unacceptably long time as Postgres has to make sure
that the output being deleted isn't referenced in
any of these 3 fields. Adding these indexes keeps
these checks always fast.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 months agodocs: LP1258628: screenshots & updates to actiontriggers.adoc
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc

Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 months agoDocs: correcting inaccurate statement in action trigger docs
Jane Sandberg [Thu, 11 Oct 2018 01:37:59 +0000 (18:37 -0700)]
Docs: correcting inaccurate statement in action trigger docs

5 months agoDocs: adding info about testing action triggers
Jane Sandberg [Mon, 8 Oct 2018 21:42:30 +0000 (14:42 -0700)]
Docs: adding info about testing action triggers

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 months agoDocs: adding action/triggers to staff client admin docs
Jane Sandberg [Mon, 8 Oct 2018 21:37:30 +0000 (14:37 -0700)]
Docs: adding action/triggers to staff client admin docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 months agoLP1821196: Remove arrow function from item status
Jane Sandberg [Thu, 21 Mar 2019 16:11:51 +0000 (09:11 -0700)]
LP1821196: Remove arrow function from item status

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 months agoForward-port 3.2.5 upgrade script
Dan Wells [Thu, 28 Mar 2019 15:35:34 +0000 (11:35 -0400)]
Forward-port 3.2.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoDocs: Revise 3.2.5 bugfix release notes
Remington Steed [Tue, 26 Mar 2019 20:15:11 +0000 (16:15 -0400)]
Docs: Revise 3.2.5 bugfix release notes

This commit adds release notes for recently pushed fixes to the new
Angular pieces of the web client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 months agoTranslation updates - po files
Dan Wells [Tue, 26 Mar 2019 16:28:53 +0000 (12:28 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoTranslation updates - newpot
Dan Wells [Tue, 26 Mar 2019 16:08:27 +0000 (12:08 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1821067 Angular i18n uses XMB; cs-CZ examples
Bill Erickson [Wed, 20 Mar 2019 18:38:44 +0000 (14:38 -0400)]
LP1821067 Angular i18n uses XMB; cs-CZ examples

Includes documentation updates and cs-CZ example using export cs-CZ .xtb
translation bundle.

Also remove xmliffmerge configuration options since we are not using
xliff files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1821067 Angular Czech translation bundle
Bill Erickson [Wed, 20 Mar 2019 18:38:14 +0000 (14:38 -0400)]
LP1821067 Angular Czech translation bundle

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1821409 Ang admin editor clears fields on new
Bill Erickson [Fri, 22 Mar 2019 20:41:12 +0000 (13:41 -0700)]
LP1821409 Ang admin editor clears fields on new

The Angular admin pages re-use an FmEditor component for creating and
updating objects.  When creating a new object after editing an existing
object, reset the editor so it won't load the previously edited object.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1807461 Admin page avoid errors on dialog dismissal
Bill Erickson [Wed, 23 Jan 2019 22:30:26 +0000 (17:30 -0500)]
LP1807461 Admin page avoid errors on dialog dismissal

Add support to the base DialogComponent class for passing information to
the caller via the reject handler about whether a dialog was dismissed
via user interface interaction (body click, esc key, cross click, cancel
button) or for some other reason, presumably an error.

Teach the generic admin page to avoid toasting errors when an edit or
create dialog is dismissed via UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1807458 Eg2 grid Edit option lint repairs
Bill Erickson [Wed, 23 Jan 2019 21:13:52 +0000 (16:13 -0500)]
LP1807458 Eg2 grid Edit option lint repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP#1807461 FM-editor show danger toasts when create/update fails
Bill Erickson [Mon, 10 Dec 2018 20:06:23 +0000 (15:06 -0500)]
LP#1807461 FM-editor show danger toasts when create/update fails

Display a danger toast when update or create attempts fail in the
Angular fieldmapper editor dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP#1807458 Angular admin grid Edit Selected option
Bill Erickson [Mon, 10 Dec 2018 18:09:36 +0000 (13:09 -0500)]
LP#1807458 Angular admin grid Edit Selected option

Adds a new "Edit Selected" action to the "Actions for Selected Items"
menu in the general purpose admin grid.  This only visibly affects the
ACQ admin grids at time of writing, but applies to all auto-generated
admin grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agodocs: Statcat updates
abneiman [Tue, 19 Feb 2019 22:22:04 +0000 (17:22 -0500)]
docs: Statcat updates

Signed-off-by: abneiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 months agoDocs: Add bugfix release notes for 3.2.5
Remington Steed [Wed, 20 Mar 2019 15:57:02 +0000 (11:57 -0400)]
Docs: Add bugfix release notes for 3.2.5

For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.2.5. I'm not sure what the criteria were
for pervious point release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 months agoDocs: Add bugfix release notes for 3.1.11
Remington Steed [Wed, 20 Mar 2019 16:16:54 +0000 (12:16 -0400)]
Docs: Add bugfix release notes for 3.1.11

For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.1.11. Not sure if this is the same as past
point release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
5 months agoLP1776736 Record merge marc edit repairs
Bill Erickson [Thu, 14 Mar 2019 16:03:58 +0000 (12:03 -0400)]
LP1776736 Record merge marc edit repairs

1. Fixes issues where edits to MARC records would fail to save during
   merge.

2. Provide options to select flat or non-flat text editor in edit mode
   for record merges.

3. Allow record editor action buttons/selectors to flow down
   horizontally when they don't fit in a narrow space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 months agoLP1749502 - Holds Pull List Print Order
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order

- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
5 months agoLP 1749502: Add Call Number Prefix & Suffix to pull list print template.
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.

We add the call number prefix and suffix as separate columns to the
holds pull list print template.  We also add the suffix to the end of
the orderBy so that we also sort by the suffix.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
5 months agolp1749502 Prefix patch
Kyle Huckins [Tue, 29 May 2018 16:06:59 +0000 (16:06 +0000)]
lp1749502 Prefix patch

- Ensure prefix information is properly set

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
5 months agolp1749502 Holds Pull List Print Order
Kyle Huckins [Thu, 17 May 2018 21:08:27 +0000 (21:08 +0000)]
lp1749502 Holds Pull List Print Order

- Ensure copy shelf location position is available for each hold on
holds shelf.
- Add _copy_location_position to hold_data while printing.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
6 months agoLP1739293 Record merged edit-in-place avoid wrap
Bill Erickson [Tue, 5 Mar 2019 16:53:09 +0000 (11:53 -0500)]
LP1739293 Record merged edit-in-place avoid wrap

When using the inline editor, prevent text wrapping and instead allow
the text to overflow x and y and use scrolls to navigate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 months agoLP1739293 Record merge fits container
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container

Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen.  A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 months agoLP1739293 Record merge horizontal; optional holdings
Bill Erickson [Fri, 8 Feb 2019 16:25:10 +0000 (11:25 -0500)]
LP1739293 Record merge horizontal; optional holdings

* Tile bib records horizontally in record bucket => merge records
  interface.

* Add a "Toggle Holdings View" button for displaying holdings and leave
  holdings un-displayed by default.

* Duplicate the Merge and Cancel buttons along the top of the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 months agoLP 1819796: Fix method call on undefined value in generate_fines
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines

The below message repeats in the open-ils.storage_stderr.log:

Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.

This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.

Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1793196 Fix console error when none selected
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected

If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1793196 Volume batch editor offers MARC call numbers
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers

Provide call numbers extracted from the MARC record as options in the
volume batch editor.  Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.

Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1665534: Make pickup library in bib record holds view sticky
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1808006 - Sitemap generator fix to allow shortname parameter.
Steven Callender [Tue, 11 Dec 2018 18:18:27 +0000 (13:18 -0500)]
LP1808006 - Sitemap generator fix to allow shortname parameter.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP1798628: Copy alert counts in Holdings
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings

Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1778571 Fix logic error converting JS bool to DB bool
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool

Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.

To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
   new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
    still checked. (That's bug #2.)

To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
  - At step 5, the new note correctly has the "Public Note" checkbox
    checked.
  - At step 11, the edited note correctly has the "Public Note" checkbox
    unchecked.

NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1759238: stamping upgrade script
Chris Sharp [Fri, 8 Mar 2019 19:19:02 +0000 (14:19 -0500)]
LP#1759238: stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1759238: Add upgrade script to fix typo for Physical Description in DB
Ben Shum [Tue, 1 May 2018 14:38:39 +0000 (10:38 -0400)]
LP#1759238: Add upgrade script to fix typo for Physical Description in DB

This upgrade script will check and update the typo if it is present in
an existing installation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP#1769238: fix typo in 950.data.seed-values.sql for Physical Description
Ben Shum [Tue, 1 May 2018 14:29:25 +0000 (10:29 -0400)]
LP#1769238: fix typo in 950.data.seed-values.sql for Physical Description

Instead of "Physical Description", "Physical Descrption" is used by mistake.
Fix the seed data and all related PO files for translation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Conflicts:
build/i18n/po/db.seed/cs-CZ.po

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLp 712490: Stamping UPgrade Script
Jason Stephenson [Fri, 8 Mar 2019 18:54:35 +0000 (13:54 -0500)]
Lp 712490: Stamping UPgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP#712490 Vandelay replace/merge PGTAP tests
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP#712490 Vandelay merge-based field replacement
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement

Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data.  The key benefit is that subfields retain their order
in affected MARC fields.  As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP1794588 Web client edit single call number changes all when multiple items attached
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached

This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update

Previously, if a volume label was edited, all items attached to that
volume would be essentially affected.  Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched.  If no copies are
being edited along with a volume, then the volume itself is edited.

Auto-merging of volumes may still happen in all of these scenarios.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agolp1802662 - Splash Page Icon Links
Sam Link [Thu, 13 Dec 2018 16:06:55 +0000 (11:06 -0500)]
lp1802662 - Splash Page Icon Links

Moved the image icons on splash.component.html and t_splash.tt2 inside
the anchor links to the associated pages.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP#1818576 Offline Noncataloged Checkout Preview
Terran McCanna [Tue, 5 Mar 2019 17:34:49 +0000 (12:34 -0500)]
LP#1818576 Offline Noncataloged Checkout Preview

This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP#1812389: make Group Penalty Threshold admin page accessible again
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again

As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.

To test
-------
[1] From Administration | Local Administration, go to Group Penalty
    Thresholds. Note that the embedded Conify admin interface
    is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
    should appear.
[3] Verify that the Permission Group Tree Entries interface remains
    accessible from Local Administration.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1734775: Show multiple items in Item Status
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status

The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1721109: Update item status when holdings are edited
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited

To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time.  Note that
there is a new status column, and that an icon appears for
all the rows that you have changed.  Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoLP #1705497 Replaces functionality in web client from legacy
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 months agoDocs: Fixing broken link
Jane Sandberg [Thu, 7 Mar 2019 15:14:50 +0000 (07:14 -0800)]
Docs: Fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoLP#1800178 Holdings View should also sort by part
Remington Steed [Fri, 26 Oct 2018 15:28:32 +0000 (11:28 -0400)]
LP#1800178 Holdings View should also sort by part

The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1818153 Stamping DB upgrade - WS user activity
Bill Erickson [Tue, 5 Mar 2019 17:21:00 +0000 (12:21 -0500)]
LP1818153 Stamping DB upgrade - WS user activity

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP1818153 Log user activity for websocket login/verify
Bill Erickson [Thu, 28 Feb 2019 22:20:31 +0000 (17:20 -0500)]
LP1818153 Log user activity for websocket login/verify

Adds support for logging additional user activity types:

 * websocket v1 login (apache2-websockets)
 * websocket v2 login (websocketd)
 * websocket v1 verify
 * websocket v2 verify
 * generic login (any ingress)
 * generic verify (any ingress)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 months agoLP#1746360 Add Deleted Column to Record Bucket
Terran McCanna [Tue, 5 Mar 2019 15:50:59 +0000 (10:50 -0500)]
LP#1746360 Add Deleted Column to Record Bucket

This adds the Deleted column to the Record Bucket view.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 months agoLP#1667497 - Define $params{depth} to avoid uninitialized warning.
Josh Stompro [Mon, 4 Mar 2019 14:57:02 +0000 (08:57 -0600)]
LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoForward-port 3.2.4 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:26 +0000 (15:59 -0500)]
Forward-port 3.2.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoTranslation updates - po files
Dan Wells [Tue, 26 Feb 2019 18:15:52 +0000 (13:15 -0500)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoTranslation updates - newpot
Dan Wells [Tue, 26 Feb 2019 18:13:13 +0000 (13:13 -0500)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoDocs: Adding release notes for 3.2.4
Jane Sandberg [Fri, 22 Feb 2019 21:15:56 +0000 (13:15 -0800)]
Docs: Adding release notes for 3.2.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoDocs: adding release notes for 3.1.10
Jane Sandberg [Fri, 22 Feb 2019 20:30:14 +0000 (12:30 -0800)]
Docs: adding release notes for 3.1.10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 months agoLP#1784893 Reporter - External Documentation Links
McCanna [Fri, 15 Feb 2019 18:29:21 +0000 (13:29 -0500)]
LP#1784893 Reporter - External Documentation Links

Removed old xulG logic which was not working in
the web client. Link now opens in new browser tab.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 months agoLP1813647 Titles for Angular admin and splash page
Bill Erickson [Tue, 29 Jan 2019 18:01:18 +0000 (13:01 -0500)]
LP1813647 Titles for Angular admin and splash page

Add page titles for auto-generated admin pages, workstation admin, and
the root splash page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP1813647 Angular page title component & sandbox example
Bill Erickson [Tue, 29 Jan 2019 16:15:38 +0000 (11:15 -0500)]
LP1813647 Angular page title component & sandbox example

Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.

Each title may have a prefix and/or a suffix.  If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 months agoLP#1802594: (follow-up) avoid a regression on "Copy" => "Item"
Galen Charlton [Mon, 18 Feb 2019 19:17:29 +0000 (14:17 -0500)]
LP#1802594: (follow-up) avoid a regression on "Copy" => "Item"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1802594 - Splash Page Image Alt Text
Sam Link [Wed, 12 Dec 2018 16:35:20 +0000 (11:35 -0500)]
LP1802594 - Splash Page Image Alt Text

Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLp 1813290: Fix IAMBROWSER check in ac lineitem table.
Jason Stephenson [Sat, 9 Feb 2019 20:45:50 +0000 (15:45 -0500)]
Lp 1813290: Fix IAMBROWSER check in ac lineitem table.

Looks like commit e9a9875d added a check for IAMBROWSER that missed
the window.  This commit adds the window.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1796225: Only auto-focus search on the home page
Jane Sandberg [Sat, 6 Oct 2018 12:52:09 +0000 (05:52 -0700)]
LP1796225: Only auto-focus search on the home page

For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.

To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages.  Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages.  Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog.  Notice that the
cursor still leaps to the search bar on this page only.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP1799963: Adjust fix to Staff Default Adv Search
Jason Boyer [Mon, 3 Dec 2018 18:23:39 +0000 (13:23 -0500)]
LP1799963: Adjust fix to Staff Default Adv Search

By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1799963 - fix catalog advanced search type default
Cesar Velez [Thu, 25 Oct 2018 21:54:42 +0000 (17:54 -0400)]
LP#1799963 - fix catalog advanced search type default

Since eg.search.adv_pane is now a server stored WS setting
it needed to be fetched with the proper way in order to work.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1806709: stamp schema update
Galen Charlton [Mon, 18 Feb 2019 18:37:00 +0000 (13:37 -0500)]
LP#1806709: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLp 1806709: Add circ.patron.billhistory_xacts persist key to database.
Jason Stephenson [Wed, 5 Dec 2018 19:55:30 +0000 (14:55 -0500)]
Lp 1806709: Add circ.patron.billhistory_xacts persist key to database.

We add the eg.grid.circ.patron.billhistory_xacts persist key to
config.workstation_setting_type in the database.

This is a follow-on to the LP1739606: Allow saving Billing History
xacts grid commit and should be applied to master and rel_3_2.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 months agoLP#1726568: expose circ lib and owning lib fields to spine/pocket labels
Galen Charlton [Thu, 15 Nov 2018 14:59:44 +0000 (09:59 -0500)]
LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
6 months agoLP#1752665: suppress located URIs in holdings view
Jeff Davis [Tue, 21 Aug 2018 20:01:06 +0000 (13:01 -0700)]
LP#1752665: suppress located URIs in holdings view

To test:

[1] Locate or create a bibliographic record that has at least
    one located URI (e.g., an 856 with a $9 containing an org
    unit code)
[2] View the record in the Holdings View in the web staff interface,
    with the 'Show empty call numbers' (or volumes) option
    selected.
[3] Note that rows are displayed with a call number label of '##URI##';
    these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
    should not display.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 months agoLP#1801984 Upgrading Angular 6 to Angular 7
Bill Erickson [Tue, 6 Nov 2018 19:08:42 +0000 (14:08 -0500)]
LP#1801984 Upgrading Angular 6 to Angular 7

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLP1783421 - Make Copy Alerts permission not global
James Fournie [Thu, 17 Jan 2019 21:23:12 +0000 (13:23 -0800)]
LP1783421 - Make Copy Alerts permission not global

For some reason copy alerts require global permissions.  Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.

Signed-off-by: James Fournie <jfournie@vcc.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 months agoLP1808268 eg2 grid action disableOnRows sanity check
Bill Erickson [Wed, 23 Jan 2019 17:09:18 +0000 (12:09 -0500)]
LP1808268 eg2 grid action disableOnRows sanity check

The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values.  This commit changes it to
a more generic if() test to cover null/undefined.  Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.

Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 months agoLP#1808268 eg2 grid rename action disable option
Bill Erickson [Mon, 17 Dec 2018 15:56:36 +0000 (10:56 -0500)]
LP#1808268 eg2 grid rename action disable option

Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
7 months agoLP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2
Jane Sandberg [Fri, 14 Dec 2018 04:50:15 +0000 (20:50 -0800)]
LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2

To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2.  Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>