Jane Sandberg [Wed, 1 Mar 2023 12:58:07 +0000 (04:58 -0800)]
LP1983628: Add editor for item notes
Test plan:
1. Open your favorite bib record in the staff catalog
2. On the item table tab, find a barcode and click "Edit"
3. Press the Item Notes button.
4. Add a note with a title and value.
5. Press Apply Changes
6. Press Apply All and Save
7. Press the Item Notes button again.
8. Without this commit, you will not have a way to edit
these notes. With this commit, you will have an edit
button.
9. Confirm that you can Back out of the editor without
making changes
10. Confirm that you can make changes and they persist.
This commit also adds a test to confirm that this fm-editor
won't inadvertently fetch every single row in asset.copy
(as a linked field).
Signed-off-by: Jane Sandberg <js7389@princeton.edu> Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Stephanie Leary [Tue, 16 May 2023 19:06:51 +0000 (19:06 +0000)]
LP2019894 Fix stacked buttons in fund details modal
Corrects the alignment of the "Create Allocation" and "Transfer Money"
buttons in the Fund Details modal (Acquisitions Administration > Fund
Administration).
This commit uses database functions to precompute the normalized and
tokenized tsquery required for highlighting before it is returned to the
user, and disallows highlight-time compilation of the highlight map.
The primary purpose of this is to avoid the chance for user input to
find its way directly into SQL statements, but an additional benefit is
that it becomes much simpler for high level application code to make use
of Display Field highlighting in non-search contexts.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Mike Rylander [Fri, 12 Oct 2018 18:43:26 +0000 (14:43 -0400)]
LP#1775958: Rework pullup mechanism to flatten more nested queries
The bulk of this commit reworks the query tree pullup logic, which is
responsible for simplifying the query tree that is used to generate the
SQL query for search. In particular, we now do a better job of finding
opportunities to merge adjacent parts of the query that have the same
requested_class (pre-dealiasing) in the face of boolean OR operators,
explicit grouping, and alternating requested_class values. The result
is fewer joins in the SQL, which should speed up all but the most
trivial searches, and generally help protect the database from mis- or
mal-constructed queries. We also now use CTEs to separate branches of
the logical search tree into descrete subqueries, which helps reduce
the total core query JOINs, and provides the planner with more options
for join order.
This also does away with the conversion of a negated atom into an
"un-phrase". Instead, we just detect and handle those directly as atoms
with a prefix, as appropriate. This allows single negated words to be
used directly in the core tsquery construct, rather than having them
require a separate join and special where clause.
Additionally, this commit handles phrases differently at both the QP and
SQL level, making use of Postgres's phrase support in modern versions
and simplifying how they're handled within the base parse tree
structure.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
This commit implements a new global flag: opac.login_redirect_domains
When this flag is enabled, redirection from login via redirect_to will
be restricted to local URLs. For local URLs, they must either start
with a / (provide an absolute path) or the hostname in the URL must
match the current hostname and have a scheme of http, https, ftp, or
ftps.
The value for the global flag can be set to a list of comma-separated
domain names. Redirection to these domains, and subdomains/hosts
thereof, will also be allowed. For all non-local URLs allowed by the
global flag value, the scheme must be one of http, https, ftp, or ftps.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Galen Charlton [Wed, 10 May 2023 19:45:05 +0000 (15:45 -0400)]
LP#2019150: link to AngularJS Patron Requests interface
Due to a presumed timing issue in 2018, the AngularJS patron purchase
request interface created in bug 1774277 was never linked to from the
Angular navbar (only the AngularJS one).
This patch fixes this.
To test
-------
[1] Apply the patch.
[2] From the Angular menu, go to Acquisitions -> Patron Requests
and verify that it loads the AngularJS interface rather
than the legacy Dojo one.
Jason Boyer [Fri, 12 May 2023 17:44:14 +0000 (13:44 -0400)]
LP1915326: Followup to Silence Offline / Shared Worker Errors
The user agent string hasn't been 'PhantomJS' for quite some time, so look for
'Headless' and add that to the Firefox launcher. Also redirect requests for
offline-db-worker.js to the current directory.
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Several tests of egOrg started failing when Lovefield
was added as a dependency. This patch fixes them by
ensuring that Lovefield is loaded.
To test
-------
[1] Go to Open-ILS/web/js/ui/default/staff and run
`npm run test`. Note that six tests fail because
'lf' is undefined.
[2] Apply the patch and repeat step 1. This time, all
of the tests should pass.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Tue, 7 Feb 2023 19:33:07 +0000 (11:33 -0800)]
LP#1778567: don't return cached list/tree before updating
The absorbList function can be used to append items to an existing
cached list (and ditto for absorbTree), so we shouldn't start off by
returning the cached version.
Thanks to James Fournie for catching this.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Wed, 3 May 2023 17:39:41 +0000 (17:39 +0000)]
LP2002363 Aria labels for catalog search +/- buttons
Adds aria-label to the staff catalog search row plus/minus buttons. The
labels match the title attributes on the buttons, to allow dictation
users to identify the phrases that should be spoken to select the
buttons.
Jane Sandberg [Mon, 6 Mar 2023 00:57:50 +0000 (16:57 -0800)]
LP1808016: improve error handling by open-ils.pcrud
This patch ensures that requests to open-ils.pcrud return
an error code (before the request completion code) when
a permissions or constraint check fails.
To test
-------
[1] Make an invalid request, e.g., by attempting to create a claim
type whose owner is not set in the Acquisitions Claiming admin
interface.
[2] Note that the user interface reports that the action succeeds
(although the new claim type is not actually created).
[3] Apply the patch and repeat step 1. This time, the admin interface
shoudl report that the creation failed.
Jane Sandberg [Wed, 1 Mar 2023 17:37:32 +0000 (09:37 -0800)]
LP2008918: default modal background color
To test:
1) Open the holdings editor in the angular staff catalog
2) right click on an item
3) select Add/Manage Item notes
4) Note that you can't see the text at the top of the modal, nor can you see the close button
5) Apply this patch and repeat steps 1-3
6) Note that the modal header is a darker color, so the text and close button are again visible.
Galen Charlton [Wed, 10 May 2023 14:21:35 +0000 (10:21 -0400)]
LP#2019032: restore functionality of two line item actions
The "Add Brief Record" and "Load Bibs and Items" actions in the
Angular line item manager stopped working after the upgrade
to Angular 15. It turns out that the routerLink values associated
with those two actions were always incorrect, but for some
reason Angular 12's router worked around the error. Angular 15
does not, hence this patch.
To test
-------
[1] Navigate to a pending purchase order.
[2] Attempt the "Add Brief Record" and "Load Bibs and Items" items
from the Actions drop-down. Note that the request forms
do not display and the purchase order title becomes
"Purchase Order #NaN (pending)".
[3] Apply the patch and repeat step 2. This time, the two
actions should bring up the correct forms.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org> Signed-off-by: Jeff Godin <jgodin@tadl.org>
Dan Briem [Sat, 4 Mar 2023 21:10:44 +0000 (21:10 +0000)]
LP#1901072 Menus Don't Recognize Max Recent Patrons Setting
On the Angular menu, both Retrieve Last Patron and Recent Patrons
links appear under Circulation, regardless of what the "Number of
Retrievable Recent Patrons" setting is set to.
On both the AngularJS and Angular menus, both links appear under
Circulation (Experimental).
On the Angular menu, Circulation->Retrieve Recent Patrons links
to the Angular interface instead of the AngularJS interface.
To test this fix:
1. Set Enable Angular Circulation Menu setting to True
2. Set Number of Retrievable Recent Patrons setting to 0
- Retrieve Last Patron and Recent Patrons links don't appear
3. Set to 1 or unset (default fallback is 1)
- Retrieve Last Patron link appears only
4. Set to greather than 1
- both links appear
- Circulation->Retrieve Recent Patrons loads the AngJS interface
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Susan Morrison <smorrison@georgialibraries.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Stephanie Leary [Mon, 8 May 2023 22:37:27 +0000 (22:37 +0000)]
LP2015137 Tab order for admin splash link tables
Replaces row/column logic with CSS columns in the link table component
used in settings screens. This allows the user to tab through the
settings in alphabetical order, rather than the three-across groupings
that previously broke up similarly named settings.
Galen Charlton [Wed, 29 Mar 2023 16:09:32 +0000 (12:09 -0400)]
LP#2013223: quiet browser console noise from some AngularJS grids
This patch quells console error noise from certain AngularJS grids.
To test
-------
[1] Go to the AngularJS Renew Items, Holds Shelf, or patron holds list
pages.
[2] Note that the brower console has a lot of "TypeError: action.handler is undefined"
error messages.
[3] Apply the patch and repeat step 1. This time, the "action.handler"
errors should be gone.
Galen Charlton [Fri, 31 Mar 2023 22:11:36 +0000 (18:11 -0400)]
LP#1920826: ensure that some DB updates missed in 3.6.0 are included
This patch fixes a situation where an Evergreen database that had
been been upgraded to 3.6.0 at some point in its past using the
3.5.1-3.6.0 DB update script may be missing some DB revisions.
To test
-------
[1] Locate a test database that had been upgraded to 3.6.0 at some point
and is missing some or all of DB revisions 1236-1240.
[2] Run the DB update in this patch.
[3] Verify that the DB revisions are in place and that the following
bugs are resolved:
Tiffany Little [Thu, 26 Jan 2023 14:18:01 +0000 (09:18 -0500)]
LP2003946 LI ID in Search jumps to item detail page
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org> Signed-off-by: Christine Morgan <cmorgan@noblenet.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Fri, 3 Mar 2023 23:55:43 +0000 (15:55 -0800)]
LP1972917: fix circ modifier column in course materials grid
To test:
1. Add a circulation modifier to your system if it doesn't
already have some.
2. In Local Admin > Course Materials > Edit Course > Course
Materials, turn on the circ modifier column in the grid.
3. Associate an item with the course using its barcode.
Make sure you have selected a circulation modifier and
checked the circulation modifier box.
4. Press the "Add Material" button.
5. Note that the circulation modifier column says
"[Object object]"
6. Apply this patch and repeat steps 2-4.
7. Note that the column now has the name of the circulation
modifier.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com> Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Beth Willis <willis@noblenet.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Michele Morgan [Wed, 1 Mar 2023 17:18:09 +0000 (12:18 -0500)]
LP2001728 - Don't display circ_staff for opac and autorenewals
Item Status Circ History List: Displays the placeholder <OPAC Renewal>
or <Auto-renewal> instead of the patron information in the Check Out
Staff field.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Gina Monti <gmonti@biblio.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Dan Briem [Thu, 16 Mar 2023 18:21:03 +0000 (14:21 -0400)]
LP#2004052 Hold Shelf Actions Menu Includes Irrelevant Actions
Removes Activate, Suspend, Set Top of Queue, Un-Set Top of Queue,
Set Desired Item Quality, Transfer to Marked Title from the
actions menu on the Holds Shelf grid.
Signed-off-by: Dan Briem <dbriem@wlsmail.org> Signed-off-by: Galen Charlton <gmc@equinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Thu, 4 May 2023 18:13:42 +0000 (11:13 -0700)]
LP#2018534: treat year as numeric when retrieving item circs by year
The open-ils.pcrud.search.circbyyr API uses EXTRACT to extract the year
from circulation timestamps. In recent versions of Postgres, the return
type for EXTRACT was changed from double precision to numeric (thanks to
Jason Boyer for noticing this!); for obscure reasons, this causes pcrud
to return the year as a string instead of a number. So, let's get the
staff client to force those values to be numbers before doing math with
them.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Stephanie Leary [Wed, 3 May 2023 17:18:59 +0000 (17:18 +0000)]
LP2018208 Empty alt for result record images, icons
Adds empty alt attributes for jacket images and format icons that are
immediately followed by equivalent text representations, and are
therefore redundant for screen reader users.
Teach batch penalty processing script to accept penalty subsets,
allow alternate context location based on each patron home library,
and allow has/does-not-have penalty command line options to look up
custom system penalties by name.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 12 Jul 2022 15:10:07 +0000 (11:10 -0400)]
LP1944986 Has / No-Has Penalty filters
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Bill Erickson [Mon, 11 Jul 2022 20:42:20 +0000 (16:42 -0400)]
LP1944986 Patron penalty batch updater script
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Allow processing of penalty subsets, and the option of patron home
context rather than staff workstation location context.
Adjust Collections API to make use of the custom penalty versions
where applicable.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
This development creates a set of Library Settings that a staff
member with appropriate permissions can use to set a custom value
for a stock penalty according to the following workflow:
-- Create a new penalty in Standing Penalties
-- Set the desired penalty threshold in Group Penalty Thresholds
-- Use the Library Setting to associate your new penalty with a
stock system penalty and organizational unit context.
The custom penalty will be automatically applied in place of the
stock penalty at the specified org units, when the patrons'
account meets the penalty criteria.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jason Etheridge [Thu, 12 Jan 2023 06:16:29 +0000 (01:16 -0500)]
LP1965446 Option to Disable Title-Level Holds on Bib Records with Parts
This feature adds one global flag and one library setting, respectively:
* circ.holds.api_require_monographic_part_when_present
Holds: Require Monographic Part When Present for hold check.
* circ.holds.ui_require_monographic_part_when_present
Require Monographic Part when Present
Normally the selection of a monographic part during hold placement is optional if there is at least one copy
on the bib without a monographic part. A true value for this setting for any involved owning library for the
bib or for the global flag will require part selection even under this condition. This essentially removes
the All/Any Parts option from the part selection drop-down, for both versions of the public catalog (TPAC and
BOOPAC), and for the Angular staff catalog interface.
At the API level, we consider just the global flag and will throw a TITLE_HOLD_WHEN_MONOGRAPHIC_PART_REQUIRED
event for a title hold request when there are items with monographic parts on the bib. It is possible for
the library settings and the global flag to differ, but the global flag will catch every instance of hold
placement including those by third party callers, SIP, etc.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Ruth Frasur <rfrasur@library.in.gov> Signed-off-by: Jennifer Weston <jennifer.weston@equinoxoli.org> Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Wed, 3 May 2023 14:50:04 +0000 (10:50 -0400)]
LP#1901932: (follow-up) update dataset for upcoming 3.11-beta release
As it happens, very little actually changed, though a significant
chunk of make_concerto_from_evergreen_db.pl's output was not checked
it because it consisted purely of differences in timestamp columns
due to time zone differences.
Galen Charlton [Wed, 3 May 2023 14:35:28 +0000 (10:35 -0400)]
LP#1901932: (follow-up) update help in make_release
This patch clarifies the usage of make_release during
updates of Enhanced Concerto and makes it clear that
such updates are considered experimental for now.
. Adding better ECD output for master branch
. Much improved enhanced generator script
. Introducing make_release changes to incorporate the upgrade of the ECD.
Introducing a new concerto dataset. Loadable via eg_db_config.
Including the perl script and full documentation on this dataset
How to re-create it, etc.
This commit adds a new VIEW_HOLD_PULL_LIST permission. In order to view
a library's holds pull list, you need to have the new permission at that
library.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Josh Stompro <stompro@stompro.org> Signed-off-by: Gina Monti <gmonti@biblio.org>
Squashed commits:
* middle
* billing total in smartpay last_chance equivalent
* fix xact propagation
* remove some logging in middle layer
* increase timeout for cached object and hope it exceeds smartpay session expiry
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Jason Etheridge [Wed, 12 Apr 2023 12:09:42 +0000 (08:09 -0400)]
lp1857911 follow-up tweaks
* AdminPage component -> Return button if page was invoked with gridFilters
* AdminPage component -> options to hide delete and edit actions
* Stat cat admin pages -> disable edit and delete for stat cat entries to match behavior of legacy interfaces, until we discuss
something better
* AdminPage component -> stock delete confirmation for AdminPage component
* Stat cat admin pages -> custom delete confirmation prompts for stat cats
* AdminPage component -> sticky org selector options for org fields in fmEditor
* AdminPage component -> option for new record org fields to follow context org
* Stat cat admin pages -> enable org field follows context org featuer
* orgFamilySelect -> persistKey support
* Stat cat admin pages -> use a persistKey for main org selector
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Etheridge [Wed, 14 Dec 2022 05:57:25 +0000 (00:57 -0500)]
lp1857911 angularized stat cat admin interfaces
* for stat cats and stat cat entries in the IDL, make sure we have pcrud controller enabled and pcrud permissions set. Also set config_field for "entries" so that the AdminPage component can link them out to their own admin pages
* item and patron stat cat admin pages
* lp1857911 release notes
Leverages the BasicAdminPage component, with some tweaks.
Changes to the BasicAdminPage and AdminPage components all default to off, so should not affect existing interfaces:
* add an option to hide the Clear Filters action from subordinate admin pages (when you follow config fields)
* add an option to propagate recordLabel to the fmEditor component, and also use said label within the admin page
* add an option to propagate orgDefaultAllowed to the fmEditor component
For the stat cat and entry admin pages specifically, we leverage these to:
* hide Clear Filters so that we don't let the user get into a situation where they try to create a new stat cat entry but have a blank and unsettable stat cat field (because we mark that field as read-only in the fmEditor)
* default the Owner field for new stat cats and entries to the workstation library
* use Item and Patron instead of Asset and Actor in various labels (at least until we're ready to make that change wholesale in the IDL)
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org> Signed-off-by: Jane Sandberg <js7389@princeton.edu>
projects / Evergreen.git / log