]> git.evergreen-ils.org Git - Evergreen.git/log
Evergreen.git
11 years agoBumping version numbers, adding Upgrade Script and Changelog tags/rel_2_3_rc1
Bill Erickson [Tue, 4 Sep 2012 18:59:30 +0000 (14:59 -0400)]
Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoGracefully handle reporter class with no labels
Bill Erickson [Tue, 4 Sep 2012 18:43:27 +0000 (14:43 -0400)]
Gracefully handle reporter class with no labels

LP 1045964 -- unable to clone report template

The template interface was failing while rendering the reporter sources
drop-down when a reporter source (IDL class) had no label.  This adds a
sanity check around that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoFix Merge All Records in Bucket action
Thomas Berezansky [Tue, 4 Sep 2012 17:23:37 +0000 (13:23 -0400)]
Fix Merge All Records in Bucket action

A xul file was not being prefixed with oils://remote

Note: This is a quick fix. Ideally we move the url to constants.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoDefine a few strings missing from cat.properties
Dan Scott [Tue, 4 Sep 2012 17:46:41 +0000 (13:46 -0400)]
Define a few strings missing from cat.properties

By the power of build/i18n/test/check_properties.py ...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoImporting translations for 2.3.rc1
Bill Erickson [Fri, 31 Aug 2012 22:46:27 +0000 (18:46 -0400)]
Importing translations for 2.3.rc1

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoDo the SQL upgrade dance for list pubdate in CSV
Dan Scott [Sun, 2 Sep 2012 02:59:21 +0000 (22:59 -0400)]
Do the SQL upgrade dance for list pubdate in CSV

With a slight tweak to base the upgrade off of the event definition name
instead of the ID; possibly more resilient.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd pub date to CSV output.
Jason Stephenson [Fri, 27 Jul 2012 13:25:05 +0000 (09:25 -0400)]
Add pub date to CSV output.

Change the template for the ContainerCSV reactor to add the publication
date (MARC 260$c) in the csv output in the same position that the previous
commit adds it to the html output.

Add an upgrade script to update the existing template for the ContainerCSV
reactor in action_trigger.event_definition.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTPAC: Add the ability to set a different default locale
Dan Scott [Sat, 4 Aug 2012 14:10:48 +0000 (10:10 -0400)]
TPAC: Add the ability to set a different default locale

Installations with multiple sites might desire different default locales
for their skins. This adds the Apache config directive
"OILSWebDefaultLocale", which enables you to set the default locale on a
global and a per-skin basis.

Note that this prevents the browser Accept-language header from having
any effect; sadly that header is not often used in real life.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Conflicts:
Open-ILS/examples/apache/eg_vhost.conf

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTPAC: Make call number browse record links retain search lib
Dan Scott [Mon, 13 Aug 2012 20:50:33 +0000 (16:50 -0400)]
TPAC: Make call number browse record links retain search lib

In addition to maintaining scope for the call number browse search
results, we also need to maintain the scope for the links for the call
number records in the results themselves (for example, the "retrieve
this record" link, or the "search for this author" link).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoDocumentation: remove file reference to line items since section was moved to another...
Robert Soulliere [Thu, 30 Aug 2012 18:52:08 +0000 (14:52 -0400)]
Documentation: remove file reference to line items since section was moved to another file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: Add sections for new features in Acquisitions
Robert Soulliere [Thu, 30 Aug 2012 18:40:00 +0000 (14:40 -0400)]
Documentation: Add sections for new features in Acquisitions

From: http://www.esilibrary.com/esi/availableDocs.php
RS added some index terms to start beefing up our index for the docs.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoChanged the thawing of a hold to first update the hold record and then re-target.
Steven Callender [Tue, 10 Jul 2012 19:43:59 +0000 (15:43 -0400)]
Changed the thawing of a hold to first update the hold record and then re-target.

When thawing a hold, originaly we were first re-targeting before actually saving the hold record. On items with large quantities, sometimes the hold would timeout on targetig before getting a chance to actually save. This patch moves things around to first save the hold record before attempting to retarget.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoAcq: In general search, make value widgets for OU-linked fields right again
Lebbeous Fogle-Weekley [Thu, 30 Aug 2012 16:42:01 +0000 (12:42 -0400)]
Acq: In general search, make value widgets for OU-linked fields right again

They always used to be OU selector dropdowns until a thinko in 55a82b5.
This restores them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoAcq: Fix General Search for Lineitem Attribute-based fields
Lebbeous Fogle-Weekley [Thu, 30 Aug 2012 16:20:13 +0000 (12:20 -0400)]
Acq: Fix General Search for Lineitem Attribute-based fields

Reported by Ben Shum and Kathy Lussier, the Acq General Search interface
was broken in that you couldn't use any of the search fields under
Lineitem Attribute.  This error was indeed introduced by recent commit
55a82b5 as Ben determined, but simply reverting that commit left other
things broken.

This commit actually targets the problem and seems to fix it in my
testing.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoAcq: New lineitems added to existing POs should inherit provider
Lebbeous Fogle-Weekley [Tue, 28 Aug 2012 20:09:00 +0000 (16:09 -0400)]
Acq: New lineitems added to existing POs should inherit provider

Jeremy Miller of the Albany Public Library in Albany, OR, reports that
through the interface at
    Actions For This Record -> View/Place Orders
in the staff client, when you add a lineitem to an existing PO, the new
lineitem has a null value in the "provider" field, instead of inheriting
the expected value from the PO.

This causes problems for some Acquisitions workflows.

The feature containing the bug appeared in 2.2, and this fix for it can be
backported that far.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoACQ support for two-step vandelay imports
Bill Erickson [Wed, 2 May 2012 13:55:06 +0000 (09:55 -0400)]
ACQ support for two-step vandelay imports

If a lineitm is loaded into a queue via ACQ+Vandelay and a later attempt
is made to load the record into the catalog via ACQ+Vandelay, the
attempt will fail, because ACQ+Vandelay treats all
not-yet-fully-imported lineitems as new to vandelay.  This change
inspects lineitems at vandelay processing time to determine if they are
already linked to a VL record or if a new one is needed.  It also
removes the requirement that a queue be provided when all records in
process are already linked to a VL record (which already lives in a
queue).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoAdd kpac to 2.3 release notes
Bill Erickson [Fri, 24 Aug 2012 17:27:24 +0000 (13:27 -0400)]
Add kpac to 2.3 release notes

This is a snippet from the main kpac documentation in
docs/opac/kids_opac.txt, added to make sure it's represented in the
release notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoFix sorting when printing from FlattenerGrid-based interfaces
Lebbeous Fogle-Weekley [Mon, 13 Aug 2012 15:47:48 +0000 (11:47 -0400)]
Fix sorting when printing from FlattenerGrid-based interfaces

This particularly affects the Simplified Hold Pull List.  The printed
verison of your data is supposed to reflect the same sort order that has
been selected in the visual interface, and now it does.

Buggy handling of the different avenues of sorting the grid (clicking column
headers, using the column-picker/multicolumn-sort dialog, default sort order)
had broken the flow of the data needed to build the right sort clause for
some situations.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoFix epub complaint about image with extra colon
Dan Scott [Fri, 24 Aug 2012 03:02:42 +0000 (23:02 -0400)]
Fix epub complaint about image with extra colon

The "+" operators are typically only used to embed an image within an
ordered or unordered list to avoid breaking the indentation level or
numbering; here, we were using the "+" operators between regular
paragraphs, which doesn't make much sense. What made less sense was the
processing result, which bizarrely added an extra colon to the front of
the image path, leading to a (naturally) missing image and processing
error.

The fix is just to throw the image tag in between the paragraphs with no
special "+" operators; just blank lines.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoDocument how to create a TPAC/KPAC search box
Dan Scott [Fri, 24 Aug 2012 01:12:40 +0000 (21:12 -0400)]
Document how to create a TPAC/KPAC search box

Now that we're in the land of the TPAC, it's time to ensure that
everyone can update their simple search boxes so that they no longer
point at the JSPAC and point at the TPAC or Kid's OPAC instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoResolve doc PDF transform error
Dan Scott [Fri, 24 Aug 2012 01:14:02 +0000 (21:14 -0400)]
Resolve doc PDF transform error

The doc build gets angry when a target that does not exist is linked
from somewhere else in the docs. So, make the target exist.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoDocumentation: Add documentation for setting maximum checkout by copy location.
Sally Fortin [Thu, 23 Aug 2012 18:21:39 +0000 (14:21 -0400)]
Documentation: Add documentation for setting maximum checkout by copy location.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentaton: Add documentation on patron border color enhancements for 2.3.
Sally Fortin [Thu, 23 Aug 2012 17:40:51 +0000 (13:40 -0400)]
Documentaton: Add documentation on patron border color enhancements for 2.3.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: update upgrade instructions to 2.3.beta2.
Robert Soulliere [Thu, 23 Aug 2012 17:07:24 +0000 (13:07 -0400)]
Documentation: update upgrade instructions to 2.3.beta2.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoAdd 2.1.2-2.1.3 database schema upgrade script
Dan Scott [Thu, 23 Aug 2012 13:43:18 +0000 (09:43 -0400)]
Add 2.1.2-2.1.3 database schema upgrade script

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMake the ContainerCSV reactor output more than 10 records.
Jason Stephenson [Thu, 26 Jul 2012 17:45:06 +0000 (13:45 -0400)]
Make the ContainerCSV reactor output more than 10 records.

Call AppUtils->bib_container_items_via_search with an args hashref
that hard codes the search limit to 1,000 records instead of using
the biblio.multiclass search default of 10.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMake item_barcode_shortcut load user bookbags in EGCatLoader::Search.
Jason Stephenson [Wed, 25 Jul 2012 15:03:01 +0000 (11:03 -0400)]
Make item_barcode_shortcut load user bookbags in EGCatLoader::Search.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMake sure that bookbag information loads in MARC expert search.
Jason Stephenson [Wed, 25 Jul 2012 20:41:44 +0000 (16:41 -0400)]
Make sure that bookbag information loads in MARC expert search.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAllow some buttons in Import via Z39.50 to wrap lines
Dan Scott [Tue, 7 Aug 2012 20:39:37 +0000 (16:39 -0400)]
Allow some buttons in Import via Z39.50 to wrap lines

Some of our technicians with 4:3 ratio monitors and a reasonable
font-size are unable to see the "Import Record" button on the Import via
Z39.50 screen, because the buttons in that row are laid out in a single,
non-wrapping row, and there is no affordance for scrolling over to the
side.

Simply changing the containing "hbox" element to a "description" element
allows enough of the buttons to overflow to resolve the problem in our
experience.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoFix LP949249, Edit, then Create button creates a new item in all cases
Steven Chan [Wed, 25 Jul 2012 23:12:19 +0000 (16:12 -0700)]
Fix LP949249, Edit, then Create button creates a new item in all cases

This fix also resolves the following:
* https://bugs.launchpad.net/evergreen/+bug/806585,
Item Attributes saved on Close
* https://bugs.launchpad.net/evergreen/+bug/644753,
check for duplicate barcode during a create session in copy/volume editor

1. The Copy Editor screen is launched from the Volume Copy Creator,
which is launched from the Holdings Maintenance screen. If the default
interface is set, CE is shown in a separate window; if the 'unified'
interface is set, CE is embedded in the same window as VCC. Upon the
user clicking Save or Close in the Copy Editor, the intent is to create
a new item record or not, respectively.  However, it happens that a new
record is always created, because VCC instructs CE to let VCC update the
item, which will occur whether the user has clicked either button.

To fix 1, if the default interface is set, we reconfigure CE to update
the item or not, depending on the button clicked; otherwise, in the
unified interface, we allow VCC to update the item or not.

2. Upon updating the item, if the barcode is a duplicate, the ensuing
sequence of events is problematic: a database-level alert message is
shown, Copy Editor is closed, and Volume Copy Creator is closed, thus
forcing the user to re-formulate the request from Holdings Maintenance.

To fix 2, we show a higher-level alert message to the user. If the
default interface is set, we stay within CE, reconfigure the barcode to
be an input field, and focus the user on it; otherwise, in the unified
interface, we return the user to an area of the screen where the barcode
field is available. In either case, the user can re-enter a barcode
value and re-submit without losing any values previously entered into CE.

3. We also take the opportunity to enhance the coding performance of
Copy Editor, by delegating the handling of the button and key clicks to
the parent groupbox element. Previously, the event handler was attached
to several child elements, which is not performant.

Conflicts fix:

Open-ILS/xul/staff_client/server/cat/copy_editor.js

Signed-off-by: Ben Shum <bshum@biblio.org>
11 years ago2.2.1 -> 2.2.2 upgrade script
Lebbeous Fogle-Weekley [Wed, 22 Aug 2012 18:49:02 +0000 (14:49 -0400)]
2.2.1 -> 2.2.2 upgrade script

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years ago2.2.0 -> 2.2.1 upgrade script never actually went into master or rel_2_2
Lebbeous Fogle-Weekley [Wed, 22 Aug 2012 16:20:22 +0000 (12:20 -0400)]
2.2.0 -> 2.2.1 upgrade script never actually went into master or rel_2_2

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoRemove an extra ternary op
Thomas Berezansky [Thu, 12 Jul 2012 15:42:21 +0000 (11:42 -0400)]
Remove an extra ternary op

And adjust the comment to make more sense. There is no higher level filter
that prevents copy holds on parted items, so there is no filter for them to
"slip through".

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoAllow copy-ish holds to target, even for part-copies, if they somehow slip through...
Mike Rylander [Wed, 13 Jun 2012 13:37:54 +0000 (09:37 -0400)]
Allow copy-ish holds to target, even for part-copies, if they somehow slip through the UI pre-checks

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoTPAC: remove some unused CSS
Bill Erickson [Fri, 4 May 2012 14:04:32 +0000 (10:04 -0400)]
TPAC: remove some unused CSS

Remove CSS referring to images that are no longer in the repository.

See also https://bugs.launchpad.net/evergreen/+bug/956023

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoTTPAC image directory cleanup
Michael Peters [Thu, 15 Mar 2012 13:49:06 +0000 (09:49 -0400)]
TTPAC image directory cleanup

There are a significant number of images remaining in TTPAC
that are no longer used, leftover from KCLS, etc.

This branch does a little cleanup on the image directory
and nets us about a 200KB savings overall.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoTPac: Show email address when placing hold
Thomas Berezansky [Fri, 17 Aug 2012 20:20:35 +0000 (16:20 -0400)]
TPac: Show email address when placing hold

Both for staff and patron benefit.

Also, we disable the checkbox if there is no email address on file.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoTPAC: Move "Export to RefWorks" into utility area
Dan Scott [Wed, 15 Aug 2012 11:18:53 +0000 (07:18 -0400)]
TPAC: Move "Export to RefWorks" into utility area

When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
11 years agoImporting translations for 2.3.beta2, Part II
Bill Erickson [Wed, 22 Aug 2012 12:59:52 +0000 (08:59 -0400)]
Importing translations for 2.3.beta2, Part II

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoImporting translations for 2.3.beta2
Bill Erickson [Wed, 22 Aug 2012 12:45:54 +0000 (08:45 -0400)]
Importing translations for 2.3.beta2

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoProtect against installs with no locales
Dan Scott [Tue, 21 Aug 2012 21:23:26 +0000 (17:23 -0400)]
Protect against installs with no locales

Installs from source outside of tarballs may not have a built locale,
which would result in a make error and an aborted install. Protect
against that by checking for the existence of the locale install
directory before trying to copy the files into place.

In the weird case that Open-ILS/src/data/locale has been generated but
there are no files in it, protect against erroring out via the judicious
application of the - flag.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoTPAC: Standardize i18n file installation
Dan Scott [Mon, 20 Aug 2012 18:11:50 +0000 (14:11 -0400)]
TPAC: Standardize i18n file installation

Make TPAC i18n files act like any other i18n file. In short:

1. When in build/i18n, a 'make LOCALE=fr-CA install' will copy
   the i18n file into the Open-ILS/src/data/locale directory.
2. In the build root, a 'make install' will copy all files from
   Open-ILS/src/data/locale into (by default) the
   /openils/var/data/locale directory.

This also means that when tarballs are created, all of the locales will
get packaged appropriately.

This commit also updates eg_vhost.conf to provide working out-of-the-box
examples for any installed locales, by using the names of the actual
PO files, and adds some contextual comments to explain how the
configuration directives work.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoACQ return-to-[search/invoice] buttons repair
Bill Erickson [Fri, 17 Aug 2012 21:15:25 +0000 (17:15 -0400)]
ACQ return-to-[search/invoice] buttons repair

With changes in place to support newer version of xulrunner, several
buttons no longer work in the staff client.  These include:

Return to Search in PO and Selection List pages
Return to Invoice in PO and Selection List pages
Return in lineitem worksheet page

This fix avoids using document.referrer (which is no longer available)
with an explicit 'source' CGI parameter, which contains the path and
params of the source page.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoTPAC i18n: Turn UA locales into Evergreen locales
Dan Scott [Fri, 17 Aug 2012 19:06:59 +0000 (15:06 -0400)]
TPAC i18n: Turn UA locales into Evergreen locales

We need to convert the likes of fr_ca into fr-CA to be able to pull the
appropriate localized values from the database via CStoreEditor.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoMake tpac cache locale-aware
Bill Erickson [Fri, 17 Aug 2012 14:11:50 +0000 (10:11 -0400)]
Make tpac cache locale-aware

Add a locale level to the TPAC object cache.  Each component of the
cache now looks like $cache{$component}{$locale}{stuff...}

e.g. $cache{list}{en_ca}{aout} = [...] # en_ca-fetched org unit types

The calling code in the templates requires no changes (abstraction
FTW).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoSet the default CStoreEditor locale on page load
Bill Erickson [Fri, 17 Aug 2012 14:10:55 +0000 (10:10 -0400)]
Set the default CStoreEditor locale on page load

Ech CStoreEditor request will use the locale of the current
page as the default opensrf session locale.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoCStoreEditor default session locale
Bill Erickson [Fri, 17 Aug 2012 14:08:16 +0000 (10:08 -0400)]
CStoreEditor default session locale

Adds a new package-level variable:

$OpenILS::Utils::CStoreEditor::default_locale

If set, this value is used as the session_locale for new opensrf client
sessions.  If unset, the session_locale remains untouched by
CStoreEditor.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTPAC: size_bigger, not size-bigger
Dan Scott [Fri, 17 Aug 2012 19:16:45 +0000 (15:16 -0400)]
TPAC: size_bigger, not size-bigger

Amusingly, TT2 attempts to treat "bigger" as a value to subtract from
"size". Cute. But we don't want the messages in the Apache log.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoTPAC: Autosuggest focus() throws a JS error
Dan Scott [Mon, 30 Jul 2012 15:30:50 +0000 (11:30 -0400)]
TPAC: Autosuggest focus() throws a JS error

On page load, the Dojo autosuggest code tries to set focus to the
element with the ID "search_box" - which is fine, except when the page
does not have said ID. Therefore, test for the existence of the ID
before setting focus to it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
11 years agoUse XUL_REMOTE_BROWSER constant in reporter
Thomas Berezansky [Fri, 17 Aug 2012 17:00:36 +0000 (13:00 -0400)]
Use XUL_REMOTE_BROWSER constant in reporter

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoDocumentation: Add one paragraph to Auto Override Patron Hold Events.
Sally Fortin [Fri, 17 Aug 2012 12:22:17 +0000 (08:22 -0400)]
Documentation: Add one paragraph to  Auto Override Patron Hold Events.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: add Auto Override Patron Hold Events documentation from ESI.
Sally Fortin [Fri, 17 Aug 2012 12:16:05 +0000 (08:16 -0400)]
Documentation: add Auto Override Patron Hold Events documentation from ESI.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoTPAC locale picker: use POST instead of GET
Dan Scott [Sat, 4 Aug 2012 14:26:25 +0000 (10:26 -0400)]
TPAC locale picker: use POST instead of GET

Users could (deliberately or not) change another's language
preferences by sharing links with the "set_eg_locale" GET param given
the locale picker's current behaviour. By switching to a POST param, we
prevent this result from accidentally occurring.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
11 years agoFix thinkos in EDI Invoicing
Lebbeous Fogle-Weekley [Thu, 16 Aug 2012 19:38:59 +0000 (15:38 -0400)]
Fix thinkos in EDI Invoicing

The lesson of the day is, test the code you actually commit, not just
the bits and pieces.  Thanks to Bill Erickson on this.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoStamping upgrade script for copy editor field hiding permission
Mike Rylander [Thu, 16 Aug 2012 19:11:29 +0000 (15:11 -0400)]
Stamping upgrade script for copy editor field hiding permission

Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoUpdate permission name to match existing ones
Thomas Berezansky [Thu, 16 Aug 2012 18:58:01 +0000 (14:58 -0400)]
Update permission name to match existing ones

To be consistent with our previous naming scheme for these.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoProvide permission for copy editor field hiding
Mike Rylander [Thu, 16 Aug 2012 17:45:23 +0000 (13:45 -0400)]
Provide permission for copy editor field hiding

We can adjust what fields are available in the copy editor in 2.2+, but that
requires the general UPDATE_ORG_SETTING permission.  The YAOUS-specific
permission here allows more granular control, so that staff can be given the
ability to adjust only that one OU setting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
11 years agoHide OPAC-invisible holdings from SRU/Z39.50
Dan Scott [Mon, 16 Jul 2012 17:27:54 +0000 (13:27 -0400)]
Hide OPAC-invisible holdings from SRU/Z39.50

The basic_holdings Supercat method filtered out deleted call numbers and
copies, but didn't filter out copies based on the OPAC visibility status
of copy location / status / the copy itself. This has undesired results
when third-party services request copies via SRU or Z39.50 and expose
copies that should not be visible to the public.

We wrap all of the visibility and deletedness checks for a given copy up
into a subroutine so that we can avoid repeating ourselves in the
basic_holdings logic. Also, if we missed a test, we can add it in one
handy place :)

(Thanks to Galen Charlton for finding two missing tests: circ lib
visibility and owning lib visibility!)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
11 years agoTPAC: Centralize font size definitions
Dan Scott [Mon, 13 Aug 2012 16:32:26 +0000 (12:32 -0400)]
TPAC: Centralize font size definitions

The TPAC CSS had a mix of absolute and proportional font size
definitions, making it impossible to define a single base size and have
the layout adjust appropriately, as well as making it difficult to tweak
sizes to, say, eliminate the distinction between 11px and 12px text.

Accordingly, create a separate TT2 file to define standard font sizes,
define one base font size, and then use proportional percentage-based
size definitions for a set of standard font sizes. This way, a site
could easily adjust the base font size to 15px and the rest of the
layout should automatically adjust, and/or revert to using absolute font
sizes for different categories if they prefer.

Note that I did simplify some of the categories of font sizes, as the
distinction between 111% and 110% was probably not evident to most
humans at most font sizes, and even the distinction between 120% and
125% would be 14.4px vs. 15px given a base size of 12px - which
different user agents could render differently anyway.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoDocumentation: Add triggered events and holds management docs from ESI.
Sally Fortin [Thu, 16 Aug 2012 14:27:50 +0000 (10:27 -0400)]
Documentation: Add triggered events and holds management docs from ESI.

Content and images from http://www.esilibrary.com/esi/availableDocs.php.
Also fixed some formatting issues for previous committed documentation.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: Add sections to Local System Administration from ESI
Sally Fortin [Thu, 16 Aug 2012 13:25:16 +0000 (09:25 -0400)]
Documentation: Add sections to Local System Administration from ESI

Content and images from http://www.esilibrary.com/esi/availableDocs.php

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoSimplified Hold Pull List: Fix broken filters
Lebbeous Fogle-Weekley [Fri, 10 Aug 2012 22:14:23 +0000 (18:14 -0400)]
Simplified Hold Pull List: Fix broken filters

Only two filterable fields were available, and at least
one didn't even work.

Now we have a few more, and they seem to all work for me in testing.

This problem was reported to me by Thomas Berezansky.

While we're at it, also make sure the list of shelving locations in that
filter dropdown is sorted alphabetically.  This was Kathy Lussier's
request.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
11 years agoJoin subqueries as OR'd groups in QueryParser
Thomas Berezansky [Tue, 14 Aug 2012 17:31:27 +0000 (13:31 -0400)]
Join subqueries as OR'd groups in QueryParser

This makes filter_group_entry(1,2,3) build an OR'd set of the resulting
queries instead of just tacking them onto each other as ANDs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoExpose ability to use filter groups in TPac
Thomas Berezansky [Fri, 3 Aug 2012 15:34:05 +0000 (11:34 -0400)]
Expose ability to use filter groups in TPac

Via config options for basic and advanced search.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoStage 2: Staff Client
Thomas Berezansky [Fri, 10 Aug 2012 14:44:47 +0000 (10:44 -0400)]
Stage 2: Staff Client

Robustify the oils protocol:

1 - In the event of a problem URL, abort with about:blank.

This prevents a segfault!

2 - In the event of the TPac, or KPac, wrap the channel we return.

The wrapper helps with redirects, but if applied to XMLHttpRequests will
cause full breakage.

Without the wrapper redirects end up setting URLs to https://host/...

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoStage 1: Perl
Thomas Berezansky [Wed, 8 Aug 2012 00:15:24 +0000 (20:15 -0400)]
Stage 1: Perl

Attempt to ensure that we always write to oils://remote when needed.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTrying to update patron CSS color fails here, so don't try
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 20:45:24 +0000 (16:45 -0400)]
Trying to update patron CSS color fails here, so don't try

After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
    TypeError: patron.display is undefined.

We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
    ...penalties[i].standing_penalty().name is not a function.

Which probably has something to do with unfleshed data.  Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoCheck for filled hold on transit checkin
Thomas Berezansky [Tue, 31 Jul 2012 19:35:21 +0000 (15:35 -0400)]
Check for filled hold on transit checkin

"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoSuperCat fixes - Child Init
Thomas Berezansky [Tue, 10 Apr 2012 13:10:46 +0000 (09:10 -0400)]
SuperCat fixes - Child Init

Sometimes it seems that child_init has not run properly for supercat.

This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoSilence warnings in search results for holdable copies
Dan Scott [Sat, 4 Aug 2012 15:04:17 +0000 (11:04 -0400)]
Silence warnings in search results for holdable copies

Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoTPAC: Silence two uninit variable warnings
Dan Scott [Sat, 4 Aug 2012 14:43:31 +0000 (10:43 -0400)]
TPAC: Silence two uninit variable warnings

These warnings were being thrown on every TPAC page request, slowly
filling the logs:

Use of uninitialized value $set_locale in string eq at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm line 159.

Use of uninitialized value in pattern match (m//) at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader.pm line 250.

Banish them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoTPAC: Give login boxes a border
Dan Scott [Mon, 13 Aug 2012 17:53:22 +0000 (13:53 -0400)]
TPAC: Give login boxes a border

For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoTPAC - Fix footer on hold history page
Ben Shum [Mon, 6 Aug 2012 15:11:54 +0000 (11:11 -0400)]
TPAC - Fix footer on hold history page

The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.

Adding the ending tag repairs the display of the footer to match all
the other pages.

Credit to Melissa Lefebvre for noticing this discrepancy.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoChange grammar for lost and missing failure messages
Melissa Lefebvre [Tue, 14 Aug 2012 16:58:18 +0000 (12:58 -0400)]
Change grammar for lost and missing failure messages

Update to the lost and missing failure wording to make it
gramatically correct.  Removed the word "has" from both
messages.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoPhysical Location Fixes/Enhancements
Thomas Berezansky [Tue, 14 Aug 2012 14:50:11 +0000 (10:50 -0400)]
Physical Location Fixes/Enhancements

Teach the physical location retrieval function about using an ENV var.

This allows a subdomain to force a specific physical location, say by adding
to their apache config:

SetEnv physical_loc 4

Rewriterules could also be used for more dynamic configuration.

Also, as a fix:

Have preferred library use the stored physical location instead of assuming
that CGI has the setting all the time.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
11 years agoTPAC - fix pickup locations for edit holds
Ben Shum [Tue, 7 Aug 2012 17:48:31 +0000 (13:48 -0400)]
TPAC - fix pickup locations for edit holds

When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.

This patch adds a check for 'can_have_vols_only' to the edit holds
screen.

Credit to Melissa Lefebvre for finally nailing down the source of
the issue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoDefault to current fiscal year in ACQ order upload
Bill Erickson [Fri, 10 Aug 2012 18:59:50 +0000 (14:59 -0400)]
Default to current fiscal year in ACQ order upload

* Adds a new API call to determine the current fiscal year for a given
  org unit:  open-ils.acq.org_unit.current_fiscal_year

* Use open-ils.acq.org_unit.current_fiscal_year to populate the correct
  fiscal year in the ACQ order upload selector.

This addresses part 2 of LP 1031927

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoEnable pcrud access to fiscal year / fiscal calendar
Bill Erickson [Fri, 10 Aug 2012 18:59:29 +0000 (14:59 -0400)]
Enable pcrud access to fiscal year / fiscal calendar

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoFiscal year selector in ACQ order record upload
Bill Erickson [Fri, 10 Aug 2012 18:06:36 +0000 (14:06 -0400)]
Fiscal year selector in ACQ order record upload

* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
  uploading orders to different fiscal years.

This partially resolves LP 1031927 by allowing manual selection of the
correct fiscal year.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoChange "Reset form" to "Clear Form"
Ben Shum [Mon, 13 Aug 2012 22:08:53 +0000 (18:08 -0400)]
Change "Reset form" to "Clear Form"

As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTPAC: Reset Form and New Search should clear queries
Dan Scott [Wed, 8 Aug 2012 19:08:24 +0000 (15:08 -0400)]
TPAC: Reset Form and New Search should clear queries

Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.

Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.

Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoTPAC - add library scoping to shelf browser
Ben Shum [Sun, 12 Aug 2012 07:25:49 +0000 (03:25 -0400)]
TPAC - add library scoping to shelf browser

The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.

Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.

Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMake opac/results.tt2 remember facet when sorting, etc.
Jason Stephenson [Wed, 25 Jul 2012 17:43:38 +0000 (13:43 -0400)]
Make opac/results.tt2 remember facet when sorting, etc.

Add a hidden field in the search form and set its value to the value
of the CGI 'facet' param if the facet parameter is set.  This appears
to work for multiple facets.  Clearing a facet is as simple as clicking
on the gray-backgounded facet name.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTPAC - fix alignment of "You are now browsing..." in shelf browser
Ben Shum [Thu, 9 Aug 2012 16:27:57 +0000 (12:27 -0400)]
TPAC - fix alignment of "You are now browsing..." in shelf browser

The "You are now browsing..." message does not align to the center of the
page. Changing the <div> to a <p> seems to properly align the text.

Along the way, we should remove the extra <span> and <strong> (the strong
is redundant with the css being inherited by color_4 class) and make the
new single line message more i18n-friendly for future translations.

Credit to Michael Peters for noticing the problem and thanks to Dan Scott,
Lebbeous Fogle-Weekley, and Thomas Berezansky for help via IRC for the
i18n-bits.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoFix TPAC shelf browser's previous link
Thomas Berezansky [Sun, 12 Aug 2012 19:16:01 +0000 (15:16 -0400)]
Fix TPAC shelf browser's previous link

Line fix suggested by Thomas Berezansky.

The cnoffset was strictly checking for values that start with a digit.
But negative numbers start with a "-" instead. Once this check was
changed, the previous link will continue to move further into negative
offsets.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoDocumentation: Fix some issues which caused a2x epub processing to choke.
Robert Soulliere [Fri, 10 Aug 2012 17:03:58 +0000 (13:03 -0400)]
Documentation: Fix some issues which caused a2x epub processing to choke.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: add a missing image.
Robert Soulliere [Fri, 10 Aug 2012 16:24:13 +0000 (12:24 -0400)]
Documentation: add a missing image.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: remove line break characters from file.
Robert Soulliere [Fri, 10 Aug 2012 14:04:59 +0000 (10:04 -0400)]
Documentation: remove line break characters from file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: Add kids catalog documentation from ESI site.
Sally Fortin [Fri, 10 Aug 2012 13:59:04 +0000 (09:59 -0400)]
Documentation: Add kids catalog documentation from ESI site.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoAuthorities: Fix broken UI due to new XUL/Dojo/regressions
Dan Scott [Thu, 9 Aug 2012 22:25:00 +0000 (18:25 -0400)]
Authorities: Fix broken UI due to new XUL/Dojo/regressions

New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.

In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.

Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoSet a sane initial MFHD Editor size
Dan Scott [Thu, 9 Aug 2012 20:31:44 +0000 (16:31 -0400)]
Set a sane initial MFHD Editor size

For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4

This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.

Finally, we allow the new window to be resizable according to the user's
preference.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoSimplified Hold Pull List: Fix several sorting bugs
Lebbeous Fogle-Weekley [Wed, 8 Aug 2012 17:50:33 +0000 (13:50 -0400)]
Simplified Hold Pull List: Fix several sorting bugs

First of all, sorting on most columns was broken due to a bug in the way
that the flattener methods of the open-ils.fielder service were
constructing their SQL JOINs.  We were coming up with way too many
joins, and then losing track of which JOIN's alias to refer to when
building the ORDER BY clause later.  This is fixed.

Secondly, the shelving location column now sorts automatically by the
shelving location *ordering* values, when avaiable.  These are the
values that you set up in the drag-and-drop staff client interface
titled "Copy Location Order."  When these values are not set for the org
unit whose pull list you're viewing, the sorting will fall back to
alphabetical.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
11 years agoDocumentation: Update upgrade instruction to 2.3.beta1 and include all docs that...
Robert Soulliere [Thu, 9 Aug 2012 19:17:48 +0000 (15:17 -0400)]
Documentation: Update upgrade instruction to 2.3.beta1 and include all docs that were in 2.2.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoDocumentation: Remove a space causing an error during PDF processing.
Robert Soulliere [Wed, 8 Aug 2012 14:45:33 +0000 (10:45 -0400)]
Documentation: Remove a space causing an error during PDF processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
11 years agoTPAC: Remove explicit width on "View my list" button
Dan Scott [Sat, 4 Aug 2012 15:24:15 +0000 (11:24 -0400)]
TPAC: Remove explicit width on "View my list" button

.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:

1. If the font-size of the base style is increased, then the text will
   likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
   "Afficher ma liste" ends up wrapping onto a second line, which makes
   the button bar look weird.

Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
11 years agoRemove extra xulG redefines
Thomas Berezansky [Tue, 7 Aug 2012 18:29:37 +0000 (14:29 -0400)]
Remove extra xulG redefines

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoFix timestamp typo
Thomas Berezansky [Tue, 7 Aug 2012 18:19:56 +0000 (14:19 -0400)]
Fix timestamp typo

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoRedirect to OILS in staff client
Thomas Berezansky [Mon, 6 Aug 2012 16:48:19 +0000 (12:48 -0400)]
Redirect to OILS in staff client

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
11 years agoAdd dependencies for Fedora
Dan Scott [Fri, 3 Aug 2012 14:59:33 +0000 (10:59 -0400)]
Add dependencies for Fedora

Noted by Net Wolf on the mailing list, some core dependencies were
missing from the Fedora Makefile.install installer. As some of them have
recently been packaged for Fedora 17, add them to the package
collection; others are still unpackaged, so leave them there.

Note: the packages are not available on Fedora 16, but that has a
limited remaining shelf life anyway, so consider this a shift to
supporting only the latest stable version of Fedora.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
11 years agoImport updated translations from Launchpad; stage 2
Bill Erickson [Fri, 3 Aug 2012 14:02:29 +0000 (10:02 -0400)]
Import updated translations from Launchpad; stage 2

Signed-off-by: Bill Erickson <berick@esilibrary.com>