Galen Charlton [Wed, 22 Feb 2017 15:09:54 +0000 (10:09 -0500)]
LP#1666933: note that the minimum supported Pg version is 9.3
Before final release of 2.12.0, we should update the installation
instructions to note that apt.postgresql.org is available
for Debian-based distros that don't package 9.3 directly.
- remove a duplicate call to metabib.remap_metarecord_for_bib()
- ensure that the 'ebook_api' config.settings_group row is added
before adding YAOUS types that depend on it
Kathy Lussier [Wed, 22 Feb 2017 14:32:29 +0000 (09:32 -0500)]
Docs: Additions to the 2.12 release notes
We missed the release notes for some new features. I also updated a couple and
removed some release note entries from 2.11 that were still hanging around in
the release note directories.
As bshum did for e-book records, let's move MR records down to the end of the
script to avoid breaking tests. Also, made some tweaks to bibs_mr.sql so that
it would import bibs correctly.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
When this feature is enabled, Evergreen will use the open-ils.ebook_api
service to look up title and patron information from specified vendor
APIs and display that information in the TPAC. (The service should be
configured using org settings before being enabled in config.tt2.)
This frontend is essentially a JS layer over top of the OPAC, with some
light use of Dojo since we're already using it, plus a few additions to
TT2 templates. The JS layer uses OpenSRF JS bindings to talk to the
backend service, which in turn makes the appropriate calls to the
third-party API. Session IDs and (if logged in) patron information are
stored in cookies, which are cleared when the patron logs out.
The user will see the following changes:
- On search results and record summary, for any records from a known
e-book vendor, Evergreen will automatically look up holdings info from
the vendor API. If detailed information on formats and available
"copies" is provided by the API (e.g. for OverDrive), that information
is displayed in a table within the record; if only basic availability
info is available (e.g. for OneClickdigital), a line is added to each
record indicating whether the title is available. (Eventually, "Place
Hold" or "Check Out" links will be added to allow patrons to
checkout/hold titles without leaving the TPAC.)
- When the user is logged in, the dashboard will show a count of e-book
checkouts and holds for all enabled e-book vendors, as will the
account summary. This is separate from the "main" checkouts/holds
display, since checkouts/holds on titles from third-party vendors are
unrelated to checkouts/holds in Evergreen.
- When the user is logged in, additional tabs will be available in My
Account for displaying detailed information on the patron's ebook
checkouts and holds. (Eventually, functionality will be added to My
Account allowing the user to download or renew titles, suspend or
cancel holds, etc.)
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jeff Davis [Tue, 7 Feb 2017 23:11:59 +0000 (15:11 -0800)]
LP#1541559: ebook API sample MARC records for test module
This commit adds a small number of MARC records to the existing sample
data. Each record contains a scoped URI in the 856 field. The records
are intended to be usable with the OpenILS::Application::EbookAPI::Test
module.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
This commit introduces a new service, open-ils.ebook_api, for
integration of third-party APIs from vendors like OverDrive and
OneClickdigital.
The design of the service is somewhat similar to Evergreen's added
content module. Common functionality and API calls are defined in the
main Perl module, OpenILS::Application::EbookAPI, while vendor-specific
details like endpoint URLs are broken out into separate "handler"
submodules for each vendor API. (The actual mechanics of HTTP
requests/responses are handled by the new OpenILS::Utils::HTTPClient
module.)
An example handler module, OpenILS::Application::EbookAPI::Test, is
included with this commit, along with some live tests which depend on
the test module. It can be considered a reference implementation for
future vendor-specific handlers.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
These new definitions index the entire heading as a unit,
so a heading like this:
=650 \0$aCats$zUnited States$vCorrespondence.
will end up in the subject/topic_browse index as a single
entry for
Cats -- United States -- Correspondence
rather than separate browse entries for "Cats" as a subject/topic,
and "United States" as a subject/geographic.
Since the new *_browse indexes are meant to replace the browse
functions of the existing subject/topic, subject/geographic, and
subject/temporal indexes, the browse flag is turned off for the
older definitions.
This patch intentionally does not include an entry for subject/name_browse,
as additional coding would be required to get the display form of the
heading to be punctuated correctly.
To test
-------
[1] After applying the patch, perform subject browses in the
OPAC and staff interfaces and verify that fully composed
headings from bib records are now displayed as browse entries.
Jason Etheridge [Mon, 13 Feb 2017 16:49:58 +0000 (11:49 -0500)]
webstaff: Book Items Now from Item Status
We can't do what we did with Make Items Bookable, consolidating the items into
one call and invoking a single interface; we get "Can't book multiple resource
types at once". For now, we disable the 'Book Item Now' menu entry if multiple
items are selected.
Galen Charlton [Mon, 13 Feb 2017 15:44:07 +0000 (10:44 -0500)]
tweak Booking administration pagse
- remove admin/booking/conify/* routes in favor of
admin/server/booking/* routes that already existed;
as part of this, remove redudant admin EmbedBookingCtl
controller
- alphabetize the entries on the Booking Administration splash
page
- remove Booking links from the Server Administration splash
page
Galen Charlton [Wed, 8 Feb 2017 22:04:07 +0000 (17:04 -0500)]
webstaff: rework line item sub-actions menu
Since Chrome doesn't generate click events for the act of
selecting an <option>, change to dispatching line item
sub-actions based on change events on the <select>.
Galen Charlton [Wed, 8 Feb 2017 18:21:35 +0000 (13:21 -0500)]
webstaff: fix highlighting of line item
Tweak the layout of the line item table so that returning
to it from the copy view causes only the border of the
line item information box to be highlighted, not both the
border and a random segment of the contents.
Galen Charlton [Tue, 7 Feb 2017 20:45:35 +0000 (15:45 -0500)]
webstaff: using egEmbedFrame escape opens new window at frame's current location
... as opposed to whatever URL was originally embedded.
For example, if you doing a PO search, then open the frame in a
new window, the results of the search are displayed in that window
rather than an empty search form.
Galen Charlton [Mon, 6 Feb 2017 21:42:35 +0000 (16:42 -0500)]
improve linking out of acquisitions upload page
- cat/catalog/vandelay route no longer drops
query parameters, permitting direct linking to import
queues (e.g., /eg/staff/cat/catalog/vandelay?qtype=bib&qid=367)
- acq/legacy/:noun/:verb/:record now a valid acq route
- purchase order MARC loading now generates usable links
back to PO, selection list, and/or import queue
Jakub Kotrla [Wed, 15 Feb 2017 22:41:09 +0000 (23:41 +0100)]
LP#1624366 Evergreen integration with obalkyknih.cz (Czech AC provider)
By default is AC disabled. Fixed summary.tt2 to be based on latest
version -
http://git.evergreen-ils.org/?p=Evergreen.git;a=tree;f=Open-ILS/src/templates/opac/parts/record;h=bc962e52a84aaf95ffc5f1fa407c2ffc3d54dec4;hb=HEAD.
Signed-off-by: Jakub Kotrla <jakub@kotrla.net> Signed-off-by: Jason Stephenson <jason@sigio.com>
Michele Morgan [Tue, 7 Feb 2017 18:21:48 +0000 (13:21 -0500)]
LP#1661754 - Prevent staff users from marking a Long Overdue item Lost
Prevents circulations that are already Lost or Long Overdue from being
marked Lost or Long Overdue. Avoiding patrons being billed twice for the
same item.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
There was a missing closing tag for the second stylesheet that caused an error
with the heading. Fixed that, and then made some whitespace adjustments.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Update live tests to match latest concerto data changes and to avoid
testing against data that is modified by tests that run before the
targeter test when running the full test suite.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Tue, 14 Feb 2017 15:53:54 +0000 (10:53 -0500)]
LP#1662902: do not re-download EDI files that failed parsing
Avoid fetching and creating edi_message entries for EDI messages that
the system cannot parse.
In the event parsing failed due to a temporary condition (e.g. Ruby
translator was not running), messages can be reprocessed by either
deleting the offending edi_message row or setting its status to 'retry'.
See previous commit ("LP#1662902: do not re-download EDI files that
failed processing") for a more detailed explanation.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 9 Feb 2017 17:24:35 +0000 (12:24 -0500)]
LP#1662902: do not re-download EDI files that failed processing
At present, the EDI fetcher ignores files (as determined by file
name and EDI account details) that were already successfully
processed. With this patch, ones that failed processing (e.g.,
acq.edi_message.state = 'proc_error') previously are ignored
as well.
This is because most processing errors reflect conditions that
require some sort of manual intervention on the part of the materials
vendor or the Evergreen user; having edi_fetcher.pl simply redownload
and attempt to process the file has no effect other than causing
the acq.edi_message table to grow.
With this patch, the appearance of rows in acq.edi_message whose
state is 'proc_error' should be taken as a signal to the Evergreen
admin to investigate and resolve whatever issue caused the
message to not be processed; after doing that, removing the
acq.edi_message rows will allow the file to be downloaded again
(assuming it's still available on the file server).
To test
-------
[1] Arrange to create or simulate an EDI message that failed
processing.
[2] Run edi_fetcher.pl to have it attempt to download the
failed message in step #1; verify that the file is
/not/ downloaded again and that no additonal acq.edi_message
rows are created for it.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 10 Feb 2017 16:54:39 +0000 (11:54 -0500)]
LP#1117808: release notes for New Access points for MARC Overlay
Test plan for the feature:
[1] Define one or more merge profiles in the MARC import/export
interface.
[2] Verify that the Default Merge Profile (Z39.50 and Record Buckets)
library setting type exists, and that if you set it to a value
for the workstation library, that it the merge profile selectors in the
record bucket merge and Z39.50 overlay interfaces default to
the specified value.
[3] In the web staff client, create a record bucket containing at least
two or more similar bibliographic records. From Bucket View,
select at least two records and select Merge Selected
Records from the actions menu.
[4] Verify that:
* There is a widget for selecting a merge profile
* That after choosing a lead record, that the lead record
view reflects the results of the merge.
* That the results of the merge are updated whenever you:
* choose a different merge profile
* choose a different lead record
* remove a record from consideration
* That the lead record's MARC is updated upon clicking the
'Merge' button in the dialog.
[5] In the web staff client, mark a bib record for overlay, then
go to the Z39.50 search interface and perform a search. Select
a record and click the Overlay button, then verify that:
* There is a widget for selecting a merge profile
* That the results of the merge are updated whenever you:
* choose a different merge profile
* That after closing the dialog, that the overlaid record
reflects the result of the merge profile.
[6] Verify that upon exiting and returning to the record bucket
merge or Z39.50 overlay interfaces, that the last selected
merge profile is pre-selected.
Development of this feature was performed by the Equinox Open
Library Initiative and sponsored by the BC Libraries Cooperative.
Galen Charlton [Fri, 23 Dec 2016 09:46:47 +0000 (04:46 -0500)]
LP#1117808: teach Z39.50 import about merge profiles
This patch adds a widget to the Z39.50 overlay dialog to
allow the user to select a MARC merge profile to use during
the merge. For the purpose of applying the merge profile,
the incoming record from the Z39.50 server is treated as
the target of the merge, as the user is assumed to be picking
a Z39.50 record that is "better" overall but may need to be
supplement with fields from the incumbent record.
As before, the user can choose to edit the incoming record, but
note that the version that is edited is the /original/ version of
the Z39.50 record, with any changes due to the merge profile being
applied after the edit.
Merge profiles that have a 'preserve' specification are excluded
from selection, as such profiles have the effect of swapping what
is considered the lead record for the purpose of the MARC merge
This patch also tweaks the dialog to use the egRecordBreaker directive
to display the incumbent record, as that permits easier copy-and-pasting
if the user chooses to edit the Z39.50 record.
Galen Charlton [Fri, 23 Dec 2016 06:38:27 +0000 (01:38 -0500)]
LP#1117808: teach record bucket merge about merge profiles
This patch adds a widget to the record bucket merge dialog
to allow the user to select a MARC merge profile to use
during the merge.
After the user has chosen a lead record, the result of the merge
is displayed in the left-hand pane, and is updated whenever the user
- changes the selected merge profile
- swaps in a different lead record
- removes a subordinate record from consideration
As before, the user can choose to edit the lead record, but note that
the version that is edited is the /original/ version of the
lead record, with any changes due to the merge profile
being applied after the edit.
Since there can be more than one subordinate record in play, the
result of the merge is calculated by merging the first subordinate
record into the lead record, then in the second subordinate record,
and so forth.
Merge profiles that have a 'preserve' specification are excluded
from selection, as such profiles have the effect of swapping what
is considered the lead record for the purpose of the MARC merge.
This directive supplies a select widget that draws its
values from a table specified by an IDL class code. It
is meant to be used for tables containing a reasonably
small number of rows (i.e., dozens at most, not hundreds
or thousands).
The following attributes are available:
idl-class : Code of IDL class to draw from, e.g., "vmp".
ng-model : Model to bind the current selected value to.
filter : JSON query filter to apply conditions on the set
of rows to be used. (optional)
sticky-setting : Local storage key to persist the last value
that was selected by the user. (optional)
ou-setting : Name of library setting to use to set the default
selected value. If sticky-setting is used, any
previously-selected value will override the default
specified by the OU setting. (optional)
The list of values from the source table displayed in the select
widget are those that meet all of the following conditions:
- primary key is not null
- filter conditions (if supplied)
- logged-in user has PCRUD permissions to view the value
The option value is taken from the column in the source table
specified by the oils_persist:primary IDL attribute, while
the displayed label is taken from the column that has the
reporter:selector="name" IDL attribute.
Galen Charlton [Wed, 30 Nov 2016 17:06:18 +0000 (12:06 -0500)]
LP#1117808: new methods for calculating MARC merges
This patch adds three new middle-layer methods for calculating
the result of MARC merges.
open-ils.cat.merge.marc.per_profile:
Calculate the result of merging one or more MARC records
per the specified merge profile
@param auth The login session key
@param merge_profile ID of the record merge profile
@param records Array of two or more MARCXML records to be
merged. If two are supplied, the first
is treated as the record to be overlaid,
and the the incoming record that will
overlay the first. If more than two are
supplied, the first is treated as the
record to be overlaid, and each following
record in turn will be merged into that
record.
@return MARCXML string of the results of the merge
open-ils.cat.merge.biblio.per_profile:
Calculate the result of merging one or more bib records
per the specified merge profile
@param auth The login session key
@param merge_profile ID of the record merge profile
@param records Array of two or more bib record IDs of
the bibs to be merged.
@return MARCXML string of the results of the merge
open-ils.cat.merge.authority.per_profile:
Calculate the result of merging one or more authority records
per the specified merge profile
@param auth The login session key
@param merge_profile ID of the record merge profile
@param records Array of two or more bib record IDs of
the bibs to be merged.
@return MARCXML string of the results of the merge
Galen Charlton [Wed, 30 Nov 2016 14:49:10 +0000 (09:49 -0500)]
LP#1117808: new Pg function to calculate MARC record merges
This patch adds a new stored function, vandelay.merge_record_xml_using_profile(),
that when passed two MARCXML strings and the ID of a merge profile.
returns the MARCXML string representing the results of the record merge.
This is meant for situations where we want to know the results
of a merge, but not immediately overlay a record in the database.
Kathy Lussier [Sat, 11 Feb 2017 02:31:50 +0000 (21:31 -0500)]
LP#1494748: Decrease the input size on Firefox by a smidge
The larger scale works for the input works well in Chrome, but came across as
too large in blurry in Firefox. Decreasing the Firefox size by a smidge so
that they still appear larger but don't become blurry. Firefox only seemed to
recognize the last transform, regardless of prefix, so I moved the one intended
for Firefox lower in the CSS list.
Jason Boyer [Fri, 3 Feb 2017 21:10:23 +0000 (16:10 -0500)]
LP1517137: Add Permissions Missing From Stock Data
Add many perissions that are either checked in code
or specified in fm_IDL.xml that are missing in the
stock data. Permissions added manually are adjusted
and those already in the expected locations are
left alone.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Use the batch-by-org AOUS lookup function to fetch settings with one
cstore call across a wide set of org units. This reduces the number of
cstore calls required, significantly in some cases, for single-use hold
targeter instances (like placement time targeting, checkin retargeting).
Specifically, in cases where a hold has targetable copies at multiple
circ libs, only one cstore call is needed for each of the
circ.holds.org_unit_target_weight and
circ.holds.target_when_closed settings, as opposed to one cstore call
for each per circ lib.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Use the CStoreEditor linked to the ::Single (child) targeter object when
possible to fetch org unit setting values.
In cases where settings for many org units have to be retrieved at once,
the settings lookups can take long enough that the in-transaction editor
on the child targeter can timeout. Using the child's editor directly
for the lookups will prevent this timeout and make the lookups a little
bit faster, since a new connect will not be required for each lookup.
This timeout scenario can occur with settings like
circ.holds.max_org_unit_target_loops and
circ.holds.target_when_closed, when there is wide variety of targetable
copies, because each have to be fetched once per target-able copy circ lib.
A secondary optimization would be a batch org setting lookup that
batches on org unit instead of setting name.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Allow the caller to pass a list of hold ID's (consistent with the
current hold targeter). This resolves the issue where the checkin
process attempts to retarget a set of holds via a single targeter call.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Pickup and requesting org unit IDs were passed in the wrong order to
the copy permit test. This resulted in some items, particularly age
protected copies, appearing on the holds pull list even though they were
not (yet) permitted for hold capture at a remoted library.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Identify holds to process by which metarecord the hold is (ultimately)
linked to within the main holds query instead of via a secondary filter.
This avoids the overhead of starting a new batch of hold targeters,
where each process has to fetch all possible holds, then filter down to
those targetable within the current parallel slot. In thise case, each
process only retrieves the holds it plans to process.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
1. Batch of tests for concerto hold 1 / title hold
2. Batch of tests for concerto hold 265 / metarecord hold with
holdable_formats restriction.
3. --skip-viable test
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Tue, 7 Jun 2016 21:32:14 +0000 (17:32 -0400)]
LP#1596595 Hold targeter refactoring and optimization.
* New open-ils.hold-targeter service
* Ports hold targeter code to a Perl utility function, communicating w/
the DB via cstore instead of storage.
* Adds a new global flag 'circ.holds.retarget_interval' for configuring
the hold retarget interval in the database.
* Adds a new DB function to regenerating hold copy maps to make map
deletion and creation more efficient.
* Adds an option for targeting holds in newest to oldest order.
* Caches all org unit settings per targeter run.
* Adds support for "skip_viable" option. This tells the hold targeter
to avoid modifying any holds that target viable copies. AKA "fix
broken" mode.
For example, you might run in skip_viable mode with a retarget
interval of 24hr once a day to repair non-viable holds, then also run
the targeter in regular mode once a day with a retarget interval of 48
hours to give staff 2 days to process viable holds.
* Hold target loops logic changes:
** Org units with fewer target attempts are prioritized during loop
processing. So, instead of segregating org units into 2 categetories,
those attempted in the current loop and those not attempted, sort those
not attempted by the number number of times they have been attempted.
Within each grouping, prioritize by target weight/proximity as before.
** All org units that have been attempted less than the max configured
amount are on the table for targeting, not just those that have been
targeted less than the current loop max. If no orgs with
less-than-current-max attempts are found, try orgs that match the
current max (but are still less than the configured max).
** When activated, target looping treats the pickup lib like any
other org unit. If a targeted copy at the pickup lib remains
un-captured, at re-target time, a copy at a different branch is
chosen (if one is available) even if other copies at the pickup
lib are targetable.
* Parallel targeting support baked into service.
Teach the targeter to process a subset of holds based on the number of
parallel targeters at play and the parallel targeting slot each targeter
instance occupies.
As with the existing hold targeter, group holds by their metarecord to
avoid multiple targeter processes targeting the same sets of potential
copies.
* Logging / code refactoring and clean up.
* New hold_targeter_v2.pl script for batch hold targeting. Existing
targeter remains for backwards-compat.
hold_targeter_v2.pl options:
--verbose
Print process counts
--parallel <parallel-process-count>
Number of parallel hold processors to run. This overrides any
value found in opensrf.xml
--target-all
Target all active holds, regardless of when they were last targeted.
--skip-viable
Avoid modifying holds that currently target viable copies.
In other words, only (re)target holds in a non-viable state.
--retarget-interval
Override the 'circ.holds.retarget_interval' global_flag value.
--parallel-init-sleep
Time to wait between starting each parallel instance. Useful for
avoiding dog-piling the DB.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Unprivileged users can retrieve organizational unit setting values
for setting types lacking a "view" permission. When the feature adding
Stripe credit card processing was added, the upgrade script neglected to
add the VIEW_CREDIT_CARD_PROCESSING permission to the organizational unit
setting type (which was included in 0396.data.org-setting-payflowpro.sql).
Fresh installs are not affected, but anyone who upgraded through 0863.data.stripe-payments.sql
(included in the 2.5.3-2.6.0-upgrade-db.sql version upgrade script) and is
using Stripe credit card processing should run this script.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
projects / Evergreen.git / log