Show warning message to user when an unknown barcode is scanned in the
copy bucket pending list UI. Also, after a barcode failure occurs, select
the barcode text (instead of clearing it) so it can be seen and easily
replaced, consistent with the item status UI.
After successful scan, clear and re-focus the barcode input box.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Thu, 14 Sep 2017 22:09:08 +0000 (18:09 -0400)]
LP#1712637 Patron edit hold pickup location repairs
1. Allow setting the hold pickup location independant of the home
library.
2. Disable org units in the pickup lib selector that are not viable hold
pickup locations (can_have_vols=f)
3. Consistent w/ the XUL client, allow a patron to be created without
selecting a default pickup location.
To test:
[1] Register a new patron and confirm pickup location is initialy unset.
[2] Confirm pickup lib options are viable pickup locations.
[3] Apply a pickup location different from the home library and confirm
the home library selector remains unchanged.
[4] Confirm saving the patron applies the expected pickup location value.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
LP#1708951: fix tabbing in webstaff catalog app for Firefox
This patch works around an issue where Firefox appears to require
that the iframe for the embedded OPAC not have a null catalog_url
value. It also fixes an issue where navigating to the OPAC View tab
after retrieving the record with a different default view set would
cause it to jump back to that default view... the first time.
To test:
[1] In the web staff client, retrieve a bib record and set the default
view to a tab other than 'OPAC View'.
[2] Retrieve another bib by TCN or ID. Note that although the default tab
will briefly display, the page will jump over to the OPAC view and
display an empty record.
[3] Apply the patch and repeat step 2. This time, it should display the
record with the current default view.
[4] Select the 'OPAC View' tab and verify that it loads the record details
page.
LP#1716475: Add label for mobile carrier select menu
Replace the empty string with a label in the SMS carrier select menu due to
issues that arose when putting an empty string in the translation file. It
also is good usability.
Signed-off-by: Kathy Lussier <klussier@masslnc.org> Signed-off-by: Ben Shum <ben@evergreener.net>
Cesar Velez [Fri, 11 Aug 2017 21:52:13 +0000 (17:52 -0400)]
LP#1599894 - OPAC disable Add to MyList when doing metabib search
Since adding a result to MyList yields to a random title
(due to bad id) being added to temp. lists, disable MyList if
metabib search is on, i.e "Group formats and editions"
checkbox is checked.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Support default values for boolean user opt-in settings during patron
registration. A default value of True, true, T, or t (or really
anything starting with a 't') is treated as true. Any other value
(including null) means false.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Cesar Velez [Tue, 27 Jun 2017 19:06:48 +0000 (15:06 -0400)]
LP#1695029-Webstaff Fix Patron Registration page never loading
It looks like there was a variable mistype causing the page
to not load, but the setting that the lp bug mentions wasn't being
properly bound and needed to be wrapped to a boolean.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Cesar Velez [Thu, 24 Aug 2017 21:17:11 +0000 (17:17 -0400)]
LP#1710512 - OPAC js strings need to be i18n-izable
Adds a way to translate displayed string messages, in OPAC
JS source code alerts and other outputs. This is done by having
js.tt2 include i18n-strings.tt2 which contains an explosed/global
JS blob variable called eg_opac_i18n. This is intended to work
in similar fashion as base_js.tt2 in the webstaff ng client.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/parts/js.tt2
Skye Howard [Thu, 17 Aug 2017 21:52:08 +0000 (21:52 +0000)]
LP#1629298: Web Client Checkout Fails For Barcodes With Spaces
Web Client checkout trims spaces from patron barcodes differently than xul client checkout
The web client was not removing the whitespaces before checking barcode searches
this commit includes a step where the whitespaces are removed.
Signed off by Skye Howard <showard@catalyte.io>
Signed off by Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
McCanna [Fri, 25 Aug 2017 13:53:14 +0000 (09:53 -0400)]
LP#1712840 Ebook tabs always visible in My Account
Corrects a problem in My Account where the ebook tabs
on the checkouts and holds pages were always visible
regardless of whether the ebook_api.enabled value was
set to true or false.
Transfer checkout history rows to the destination user during patron
merge.
To Test:
1. Enable circ history tracking for 2 users, ideally 2 with same
last name for easy searching.
2. Check out items to both patrons.
3. Load the 2 patrons in the patron search UI and merge one into the other.
4. action.usr_circ_history rows previously linked to the deleted patron
will now be linked to the active/lead patron.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Boyer [Thu, 24 Aug 2017 21:34:02 +0000 (17:34 -0400)]
LP1712922: Exclude Deleted ACPL in Vol/Copy Editor
Just what it says on the tin. When loading the list of ACPL
in the editor only retrieve the non-deleted locations.
Tester's note: there's no database contraint that strictly
prevents a copy from linking to a deleted location, so for
items like that, the copy location selector will be blank. This
is an uncommon situation, but Evergreen admins can identify
such items by running the following query:
select acp.id, acp.barcode, acpl.name
from asset.copy acp
join asset.copy_location acpl on (acpl.id = acp.location)
where not acp.deleted
and acpl.deleted
order by acp.id;
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Michele Morgan [Wed, 9 Aug 2017 15:36:20 +0000 (11:36 -0400)]
LP 1708728 - Fix Stripe penny errors introduced by perl int() function
Fixes the issue where payment amounts sent to Stripe can be one cent less
than the actual Evergreen payment due to use of the perl int() function.
To test
-------
A Stripe account is required to view transactions on the Stripe side.
To enable test payments, Stripe testing API keys need to be entered
in the Evergreen ou settings:
- Add a bill to a patron record with the following amounts: $8.20
- Login to the opac as the patron and pay the bill.
- View the transaction on the Stripe side and see that it is one cent
less than the paid bill in Evergreen.
- Apply the patch.
- Repeat the steps above.
- On the Stripe side, see that the Stripe amount and Evergreen amount
now match.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Wed, 23 Aug 2017 19:22:28 +0000 (15:22 -0400)]
LP#1708485: (follow-up) improve dest_courier_code support
This patch ensures that dest_courier_code is added to
the printer context; it also displays the courier code (if set)
on the transit modal and mentions dest_courier_code in the
inline documentation for transit and hold slips.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/cat/item/app.js
Dan Scott [Tue, 15 Aug 2017 14:19:22 +0000 (10:19 -0400)]
LP#1710747: Absolute URL for media_prefix in templates
If OILSWebMediaPrefix is set in the Apache configuration, then
the ctx.media_prefix TT2 template variable uses that value as the
hostname; otherwise it is null, resulting in many relative URLs for
images, CSS, and JavaScript files.
Normally this is not a problem, but the Open Graph image property
requires a full absolute URL rather than the relative URL that would
previously result on the record summary page in the absence of the
OILSWebMediaPrefix variable having been set in the Apache config.
This patch tweaks the EGWeb handler to fall back to the base hostname in
the absence of the OILSWebMediaPrefix variable, thus ensuring that all
uses of ctx.media_prefix result in an absolute URL.
Test Plan:
Pre-patch - Visit a record summary page in the catalog. View the source of the
page. In the head section, find the og:image meta property. The content will
display a relative URL to the record's book jacket cover image.
Post-patch - When viewing the source of the page, og:image will display the
full URL.
Signed-off-by: Dan Scott <dscott@laurentian.ca> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Dan Scott [Wed, 12 Jul 2017 14:07:23 +0000 (10:07 -0400)]
LP#1703678 Display foreign item location and status
We were using copy_info instead of the foreign item's data to try to display
location and status of foreign items. As copy_info had not been initialized,
it displayed nothing. Use the foreign item data instead for location and
status.
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Ben Shum [Mon, 17 Apr 2017 21:20:25 +0000 (17:20 -0400)]
LP#1681864: Add pocommentclean for db.seed cleanup prior to updatepo
By adding a segment to run pocommentclean against the db.seed locale file
prior to doing updatepo against the file from the PO template, we clear
any unwanted old and outdated comment IDs prior to applying clean newly
synchronized comment IDs from the PO template.
Signed-off-by: Ben Shum <ben@evergreener.net> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Cesar Velez [Tue, 8 Aug 2017 20:13:15 +0000 (16:13 -0400)]
LP#1624443 - TPAC 500 error after adding duplicate title to Temp List
Credit to gmcharlt, prevents the my list (temporary list) page from
crashing when a user has added a title to the list more than once.
This can happen if they add a title then login, then redo search and
add same title. Per Galen, it looks like an issue with
OpenSRF::MultiSession parallel record retrieval causing some kind of
race condition when there are duplicate entries in the list.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Chris Sharp [Fri, 7 Jul 2017 17:04:35 +0000 (13:04 -0400)]
LP#1702968 - Add missing error string - mark item damaged.
When marking an item damaged for a circulation that has been
archived/aged, the patron receives an error that the string
associated with staff.cat.util.mark_item_damaged.item_no_linked_patron
is not there. This branch adds it.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Fri, 4 Aug 2017 15:54:15 +0000 (11:54 -0400)]
LP#1463166 Apply funds from view/place orders and search
Activate the copy-specific fund selectors for lineitems accessed from
the View/Place orders and MARC Federated Search interfaces. Prior to
this, fund selectors existed, but could not accept values until after a
PO was created for a given lineitem.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1463166 Fix Batch update of Funds in Selection Lists
Selection lists are currently unable to batch update funds. The problem
stems from the fact that the Fund selection list is not populated in the
copy rows. New code used to limit the number of funds, in the dropdown
list, to those funds available to the user was added for purchase
orders. However, these changes were not added to Selection Lists. This
code adds the new call to initBatchUpdater to the selection list code.
Cesar Velez [Tue, 23 May 2017 13:58:39 +0000 (09:58 -0400)]
LP#1669534 - OPAC hold request should not default to first SMS carrier
Added empty <option> tag to address this and related form validation issues.
To test
-------
[0] Ensure that SMS messaging is enabled.
[1] Apply the patch and go to the place hold form in the public
catalog. Verify that no mobile carrier is selected.
[2] Set the default SMS carrier and number for the user account
and go back to the place hold form. Verify that the user's
default carrier and number appear in the form.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1706365: cursor for record menu items should be a pointer
When using the Mark For menu on the bib record page, the
cursor becomes an i-beam while hovering over the menu items instead of the
expected pointer. This commit adds an empty href attribute to the a tag for menu
items so that a pointer displays instead.
Test plan:
Log into the web client and retrieve a record. Click the 'Mark For' menu on the
record page. Pre-patch, as you scroll through the menu items, the cursor will
turn into an i-beam, indicating that text can be selected. Post-patch, the
cursor will be the expected pointer that typically displays for links.
Galen Charlton [Mon, 7 Aug 2017 15:15:57 +0000 (11:15 -0400)]
LP#1694529: tweak wording of collision alert message
And here's a test plan for the patch series as a whole:
[1] In the web staff client, retrieve a patron that has some
loans. In a separate window, open the patron editor
for that same patron.
[2] In the first window, mark one of the patron's loans
as either claims returned or claims never checked out.
[3] In the second window, make a change and attempt to save
the record. You should see a alert dialog saying that
the record could not be saved.
Bill Erickson [Thu, 29 Jun 2017 21:53:56 +0000 (17:53 -0400)]
LP#1694529 Patron editor friendly xact ID collision alert
Display a friendly alert dialog message to staff when attempting to save
a patron record that has been externally modified during editing. This
is an improvement over the existing debug alert with JSON data.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Quoth the Perl docs: "An experimental feature added in Perl 5.14 allowed each,
keys, push, pop, shift, splice, unshift, and values to be called with a scalar
argument. This experiment is considered unsuccessful, and has been removed.
The postderef feature may meet your needs better."
The specific instance here was probably just a typo or thinko the did the
right thing on Perls "of a certain age" ... so, we fix that here, now.
To test:
[1] Upon applying the patch, verify that Perl 5.24+ will successfully
compile metabib.pm, that the open-ils.storage service will
start up, and that catalog searches continue to work.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1706148 - Hide "Hold is behind Circ Desk" checkbox in XUL patron registration.
When the library setting for "Behind Desk Pickup Supported" is not enabled then
the checkbox for "Hold is behind Circ Desk" should be hidden.
Test Plan - before fix:
1. Check to make sure that the "Behind Desk Pickup Supported" library setting is
unset or false.
2. Open the patron registration screen in the XUL staff client and see that the
user settings checkbox for "Hold is behind Circ Desk" exists.
After Fix Applied:
1. Check to make sure that the "Behind Desk Pickup Supported" library setting is
unset or false.
2. Open the patron registration screen in the XUL staff client and see that the
user settings checkbox for "Hold is behind Circ Desk" no longer is shown.
3. Change the library setting in question to True.
4. Reload/reopen the patron registration screen and see that the checkbox now
is visible.
Signed-off-by: Josh Stompro <stomproj@larl.org> Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Cesar Velez [Fri, 14 Jul 2017 17:25:44 +0000 (13:25 -0400)]
LP#1695062 - webstaff Make non-freetext required stat cats actually required
In the Patron registration form this custom drop down needed to
have an ng-class attribute with the proper
object expression in order to do add class ng-invalid if the
stat cat was required and not there.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Adds a small nosound.wav file which may be used by administrators to
silence a specific alert for all users on the server.
To test:
[1] mkdir -p /openils/var/web/audio/notifications/success/patron/
[2] cd /openils/var/web/audio/notifications/success/patron/
[3] ln -s ../../nosound.wav by_search.wav
[4] Perform a patron search in the browser client and confirm no sound
is played upon successful search.
If patron searches have recently been performed, step 4 may require a
cache clear, a different tab, browser restart, eye of newt.
Jason Boyer [Fri, 7 Jul 2017 14:24:35 +0000 (10:24 -0400)]
LP1702911: Correct Barcode State in Add Item
When adding an item from the MARC editor the barcode
state was incorrect because the empty_barcode flag
is set on the copy and then not changed after
assigning a barcode. At that point the only way to
alter the flag is modifying the barcode in the UI,
which the user likely would not think to do. This
causes the Save buttons to remain disabled.
To test pre patch:
Open a record in the MARC editor, check Add Item
Add a call number label and barcode above, click Save
In the vol/copy editor, try as you might, you can't save. :(
To test post-patch:
Open a record in the MARC editor, check Add Item
Add a call number label and barcode above, click Save
In the vol/copy editor, the Save buttons will already be enabled
(barring required stat cats, etc.)
Cesar Velez [Wed, 28 Jun 2017 21:52:22 +0000 (17:52 -0400)]
LP#1691264 - WebStaff Add stickiness to Patron Search Org-level selector
When searching for users within the patron app, the org-unit selector
dropdown would stay cached to the last used value, but reloading the
PAtron sarch view would reset that. This adds stick-setting attribute
to that custom dropdown and LocalStorage via key eg.circ.patron.search.ou
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop> Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Josh Stompro [Mon, 30 Jan 2017 14:21:40 +0000 (08:21 -0600)]
LP#1312837 - Item Status - Alternate View - Holds/Transit tab: Transit and Hold
information does not refresh
When switching between copies that have different transit and hold information,
the data in the hold/transit tab doesn't get cleared when there isn't a new hold
or transit to clear it.
Test Plan:
Acquire the barcodes for 3 copies, one that is available, on that is in transit
and one that is captured for a hold.
Before Change:
1. Open item status alternate view and switch to hold/copy tab. Note that the
labels default to saying that the item is in transit and captured for a
hold before any barcodes are scanned.
2. Enter the available item and note that the labels changed to not in transit
, not captured.
3. Scan in the In Transit for Captured item and note that the labels don't
change when they should.
4. Scan in the available item and note that the hold or transit data isn't
cleared.
After Change:
1. Enter the barcodes for the 3 copies with different statuses and note that
the Holds/Transit information now updates correctly.
Mike Rylander [Tue, 14 Feb 2017 20:59:53 +0000 (15:59 -0500)]
LP#1664715: Hold ratio template ignores some copies
The relatively new report template "Hold/Copy Ratio per Bib and Pickup Library
(and Descendants)" only includes copies that are at locations that are
actually pickup libraries of holds. For instance, if you have two branches (A
and B) in a system, each with 10 copies attached to a bib, but a hold only at
branch A, the ratio calculated at the system level sees 10 copies rather than
twenty. This has the effect of inflating the hold side of the hold/copy ratio.
The SQL definition is adjusted here to count copies across the entire branch
of the org tree per bib, rather than through a join that restricts to those
branches that are pickup libraries for a relevant hold.
Upgrade note: Report templates using the Hold/Copy Ratio at Pickup Library
and Descendants data source will need to be re-created to benefit from this
bug fix.
LP#1705731: background batch MARC edits now report status less verbosely
Rather than repeatedly inserting and fetching potentially
very large arrays of per-record status statements from the
anon cache, batch MARC edits that are run in the background
now report counts.
This patch changes how open-ils.cat.container.template_overlay.background
populates the anonymous cache; note that streaming status updates
if calling open-ils.cat.container.template_overlay instead are
*not* changed.
To test
-------
[1] Set up a MARC Batch Edit run using a reasonably large bucket
as a source records.
[2] Verify that progress is reported correctly during the run.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Cesar Velez [Thu, 29 Jun 2017 17:27:40 +0000 (13:27 -0400)]
LP#1668314 - Webstaff make marcEditor's flateditor checkbox sticky
Just followed the same pattern of using $watch and localstorage
to store a boolean for FlatEditor checkbox. Made $scope.flatEditor
be an object wrapping an isEnabled :bool to avoid *future* ng-if
parent scope issues that could (potentially) occur.
Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Adjust to zero was not actually adjusting to zero on negative balances
in at least some cases. This patch corrects that behavior.
Test plan:
[1] Generate multiple overdue billings on an overdue circ.
[2] Apply a payment (cash or forgive) to resolve the overdue billings.
[3] Checkin the item using backdated checkin or amnesty mode, such that
the overdue billings are automatically voided, resulting in a
negative balance.
[4] Adjust to zero. A single new manual adjustment billing is created,
reinstating one overdue billing, and then the adjust-to-zero process
exits. The negative balance has been reduced by the amount of one
overdue billing, rather than being fully adjusted to zero.
[5] Apply the patch and restart services.
[6] Repeat steps 1-3 with a new circulation.
[7] Adjust to zero. This time, the balance should be correctly adjusted
to zero, instead of exiting prematurely with an outstanding
negative balance.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Cesar Velez [Mon, 10 Jul 2017 20:47:26 +0000 (16:47 -0400)]
LP#1702756 - WebStaff fix for bug that was introduced by 997e2772
While addressing LP#1696495 fixed the bug of user settings caching
improperly between patron edits, it caused an issue when the regctl
was loaded for registering a new patron. This corrects that.
The copy details table was styled to not wrap, which sometimes pushed table
contents off the page, particularly when some of the copies are conjoined
items. This commit removes the style that was preventing wrapping.
Test plan:
Load record 15 in the Concerto dataset. Before the patch is loaded, you'll
see that some of the content in the copy details table is pushed off the
screen and requires horizontal scrolling. Post-patch, all of the copy
details will display on screen without horizontal scrolling. In addition
to the change in the Conjoined Items, you also might see some text wrapping
in the Shelving Location and Status columns.
Jason Boyer [Fri, 14 Jul 2017 19:01:09 +0000 (15:01 -0400)]
LP1704463: Item Status Fields Correction
The Loan Duration and Fine Level fields were
being incorrectly pulled from unrelated fields
on the most recent circ rather than the item.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Chris Sharp <csharp@georgialibraries.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Avoid 'grunt test' failure "Unknown provider: $routeProvider" resulting
from $routeProvider references in startup.js (egCoreMod) without first
loading the ngRoute module.
$routeProvider is not needed by the original patch.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Mike Rylander <mrylander@gmail.com>
When trying to utilize the Recall functionality, Evergreen would fail to update
targeted circulations (truncate the due date, etc.) In the logs, we would have
an error like this:
[] open-ils.storage [ERR ::action.pm:1597:] Processing of hold failed:
Can't locate object method "workstation" via package "action::circulation" at
/usr/local/share/perl/5.14.2/OpenILS/Application/Storage/CDBI.pm line 181.
We first tried adding the workstation column to Storage/CDBI/action.pm, but a
similar message would then appear instead: Can't locate object method
"checkin_workstation"
This sidesteps the problem entirely.
Thanks to Mike for the solution!
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Dan Scott [Fri, 26 Jul 2013 04:05:49 +0000 (00:05 -0400)]
LP#1205190: TPAC: Improve style.css to reduce warnings
* Improve specificity: use background-image (for gradients) or
background-color (for color) instead of just background, because we
are only specifying the image or color, and not the rest of the
background properties.
* Declare the background-color first, followed by the background-images;
these will only override if recognized by the browser.
* Declare the standard (unprefixed) CSS linear-gradient last to prevent
prefixed browser quirk versions from overriding the standardized form.
* Remove the -moz- prefix from -moz-border-radius as that has not been
supported by Gecko since Firefox 13.0; just plain border-radius now.
* Fix bad selector ##rdetail_extras_expand (only one #, please).
Signed-off-by: Dan Scott <dan@coffeecode.net> Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Pasi Kallinen [Thu, 1 Aug 2013 08:21:17 +0000 (11:21 +0300)]
LP#1205190: quiet some CSS Mozilla extensions warnings.
* -moz-dialog-text is actually -moz-dialogtext
* -moz-outline is deprecated, use outline
* -moz-border-radius has been removed, use border-radius
* -moz-border-radius-topleft (etc) are now border-top-left-radius
* Fix some other CSS errors.
Jason Etheridge [Mon, 26 Jun 2017 12:11:28 +0000 (08:11 -0400)]
lp1678152 webstaff fix Add Copies & Volumes
Changes open-ils.cat.asset.volume.fleshed.batch.update,
AssetCommon::create_volume, and Cat::Merge::merge_volumes
to handle auto-volume merges during volume creation.
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org> Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 2 Jun 2017 17:13:50 +0000 (13:13 -0400)]
LP#1208875: follow-up to standardize extract fields
This patch removes the proposed custom methods for extracting
title, author, and record format in favor of tweaking
->fetch_user_circ_history to invoke unapi.bre and adjusting
the template to use get_marc_attrs. Also, nowadays
->fetch_user_circ_history can flesh what we need it to without
having to rely on the existance of an action.circulation row,
which won't be present if the circ was aged but was otherwise
retained in the user circ history.
The result is slower than the previous approach, but still
retains the core idea of getting A/T out of the equation, and remains
much faster than the A/T approach.
Dropping use of unapi.bre would speed things up a bit more, as it
was added only to match the addition of the record format column
in the CSV output. Drop the column, and we no longer need to worry
about MVFs.
There would also be opportunities to improve caching further. Bib
display fields, when it comes, will likely help even more, as it
would mean being able to drop a lot of the XML parsing currently used.
This patch also adjusts misc_util.tt2 so that including it doesn't
result in an unwanted blank line.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
LP 1208875: Fix circ history CSV download for many circulations.
We no longer retrieve a user's circ history for download via
action/trigger and instead build the CSV data right in the TPAC.
The reason for this change is that action/trigger imposes just
too much of a delay between initiating the retrieval and getting
the data, particulary for patrons who have a large number of
circulation history entries, for certain values of large.
The new code uses the CStoreEditor to make JSON queries to retrieve
only the information needed for CSV. Testing revealed that using
the existing fetch_user_circs method in EGCatLoader/Account.pm was
still too slow for the more extreme patrons. The new code also
caches most of the retrieved bibliographic data. Testing revealed
that most patrons get multiple checkouts of the same things, or
multiple parts of a multiple part television series. Caching the
bib data for these records has shaved several seconds off retrieval
time in testing.
This branch makes use of a new, MVF, view when retrieving format
information. It is thus unsuitable as-is for backport before
2.6.
Along the way, we have accreted a generically reusable CSV filter
for Template Toolkit. That could be useful not only in other
parts of Evergreen, but in other projects.
Finally, this commit leaves the old action/trigger code in the
database. Right now, it makes a good reference if anyone wants
to study what has been changed. It can be removed later, if so
desired.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
projects / Evergreen.git / log