Garry Collum [Fri, 18 May 2018 23:57:42 +0000 (19:57 -0400)]
LP1766982 - CSV downloads contain the string 'null' for null values.
Adds a check for null and undefined in the getItemTextContent function
in grid.js which is called by both the code to download grid data as
CSV and for printing grids.
To test
1. Place holds on a couple of titles, one of which has no author. In the
test data TCN 226, The Crow, has no author data.
2. Pull up the Holds Pull List.
3. Download Full CSV - to download the CSV file and view it in a
spreadsheet or text editor looking specifically at the Author column.
4. Print Full Grid - to view the data in a printout, since this function
also affects printing.
5. Go back to the Holds Pull List and click on one of the barcodes under
the Current Copy column.
6. Click on the List View.
7. Download Full CSV - open the resulting file to inspect the
Alert Message data.
8. Apply patch and repeat steps 2-7.
Josh Stompro [Wed, 27 Feb 2019 21:07:43 +0000 (15:07 -0600)]
LP#1798187 - Support CRLF and LF format for item status import files
Testing Plan:
Before patch, try to import a file in CRLF end of line format that includes
leading and trailing spaces, empty lines, lines of just spaces or
barcodes with spaces. The import will fail to load those items and will
stop processing when it hits certain situations.
After patch, try to import a file in CRLF EOL format that includes barcodes
with trailing spaces, leading spaces, barcodes with spaces, and/or
empty lines. The import will load all barcodes.
Bill Erickson [Wed, 17 Apr 2019 14:51:45 +0000 (10:51 -0400)]
LP1683385 AngJS grid avoid dupe auto-fields
When generating grid fields from an IDL class in the AngJS grid, avoid
adding any fields that match fields already defined in the markup.
An example of such a grid is the Pending Item Buckets page.
To test
-------
[1] Go to Item Buckets and add an item to the Pending Items page.
[2] Note that in the column picker there are two barcode fields,
one that hyperlinks the item and one that does not.
[3] Apply the patch and repeat steps 1-2.
[4] This time, there is only one barcode column (the one that
hyperlinks the results).
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Wed, 29 May 2019 18:03:38 +0000 (14:03 -0400)]
LP1830424 Implement Angular "retrieve last bib record"
Repair the Angular navbar menu entry for "Retrieve Last Bib Record" by
replacing the copy/paste'd ng-click handler with an Angular (click)
handler and local implementation.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 24 May 2019 18:04:33 +0000 (14:04 -0400)]
LP#1796903: (follow-up) disabled the calendar button when the text input is disabled
Disabling the calendar button when the datepicker is disabled allows
ChromeVox (at least) to skip past a button that cannot be invoked
until (like is possible in the checkout page) the picker is enabled.
Jane Sandberg [Tue, 9 Oct 2018 14:37:56 +0000 (07:37 -0700)]
LP1796903: Make date picker calendar button more accessible
To test:
1) After applying this commit, navigate to a place in the Web client
that includes a date picker (such as the checkin screen).
2) Hover over the calendar button with your mouse and confirm that a
tooltip appears.
3) Verify that the button element has an aria-label attribute.
4) Verify that the button element has an aria-pressed attribute that
is false when the date picker is closed; true when it is open.
5) Use a screen reader (like NVDA or ChromeVox). Verify that when you
tab over to the date picker, the user is informed of the aria-label
and aria-pressed values
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
lp1836229 Disable Edit buttons in Merge Records when Editing
- Apply disabled attribute to Edit buttons rather than just the class,
preventing users from clicking buttons that appear disabled in the Merge UI.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/staff/cat/bucket/record/t_merge_records.tt2
LP#1777207: teach egGrid how to prepend rows more efficiently
The checkin and checkout grids in the AngularJS client have
been doing full grid refreshes when adding a checkin or
checkout to their respective grids. While this does not
result in re-fetching data for the loans that were already
processed, as more entries get added to the grid the time
it takes to do a full digest of the grid contents during a
egGrid.collect() (which empties the list of displayed rows,
then refills it), gets progressively longer. Grids that have
only ~40 entries have been observed to take several seconds
purely on the AngularJS rendering phase.
This patch teaches egGrid a new prepend() method that
takes the first element from the underlying data source and
unshifts it onto the list of displayed grid rows, saving much
rendering time. The prepend() method will also force the
grid offset back to 0 if it isn't already. Note that if
an item that would be added via prepend() might duplicate an
existing row entry, prepend() will do a full collect() instead.
If the data source has sort options set, the prepend() will
remove them. For arrayNotifier-based data sources, as are used
in the checkin and checkout grids, this means that if the user
sorts the contents of the grid, then does a circ transaction,
the new transaction will still appear at the top of the list.
Due to the way arrayNotifier currently works, the remaining
entries will retain their previous ordering.
As an implementation note, prepend() is likely going to work
/only/ for arrayNotifier grid data sources.
To test
-------
[1] In the checkin grid, check in a large number of items.
Note that the time it takes to each each item gets
progressively longer.
[2] Apply the patch and repeat step 1. This time, the time
for each checkin should not significantly vary.
[3] Verify that column sorting works as expected.
[4] Upon sorting the grid, do more checkins and note that
the new transactions show up at the top.
[5] Verify that the checkout grid continues to behave as expected.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
LP#1777207: have eg-grid generate DOM nodes only for visible columns
This patch changes an ng-show to an ng-if to generate DOM nodes
for grid cells only for visible columns. Prior to this patch, all
grid cells were generated, but the ones that corresponded to hidden
columns would simply be set as hidden.
By not generating the cells unless they're meant to be visible, grid
refreshes for wide grids (like the checkin table) render much more
quickly for a couple reasons:
- simply that there are fewer DOM nodes to process
- probably more importantly, fewer AngularJS watches get
created
To test
-------
[1] In the checkin grid, check in a large number of items, then
observe/profile timing as you change the number of visible rows.
[2] Apply the patch and repeat step 1. This time, the grid
refreshe should be measurably (and visibly) faster.
[3] Test other AngularJS grids and verify that grid display and
grid actions are normal.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Fri, 24 May 2019 15:06:04 +0000 (11:06 -0400)]
LP#1830394: remove console noise from the holdings editor
This patch removes browser console noise that occurs (among other
places) when moving a working item to the completed list in
the holdings editor
TypeError: "$scope.working.MultiMap[keys[i]] is undefined"
hasMulti https://evergreen.example.org/js/ui/default/staff/cat/volcopy/app.js:1203
...
To test
-------
[1] Open the holdings editor to add or edit an item, then open the
browser debug console.
[2] Make a change and move the item from working to complete. Note
that the error message above shows up repeated in the
console log.
[3] Apply the patch and repeat steps 1 and 2. This time, the errors
should not appear.
This setting was added to the database with the 'eg.' prefix, but in
the code it was not used. The end effect was that the setting likely
worked, but was not saved in the way expected.
This makes the setting name in the code match the DB.
Signed-off-by: Dan Wells <dbw2@calvin.edu> Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Mike Risher [Mon, 10 Jun 2019 18:11:38 +0000 (11:11 -0700)]
lp1770217 Items Out count shouldn't increment on renew
Determine if this item is currently out to the patron and is being
checked out again. If so, be sure not to increment "Items Out" count.
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified: web/js/ui/default/staff/circ/patron/checkout.js
modified: web/js/ui/default/staff/circ/services/circ.js
LP#1812900: fix retention of saved defaults in holdings editor
Because the $watch on the statistical category default OU filter
in the holdings editor can fire before the form is fully initialized,
saved defaults (i.e., the cat.copy.defaults workstation setting)
could get overwritten with the hard-coded default value for that, er,
set of defaults.
This patch ensures that that $watch saves the defaults only when the
value of the default stat cat OU filter has changed.
To test
-------
[1] Use the holdings editor on an item. Change to the defaults
tab and check or uncheck checkboxes such as "Use checkdigit"
and "Print Item Labels on Save and Exit"
[2] Refresh the page or open the holdings editor on a different item.
Note that the settings from step #1 are not retained.
[3] Apply the patch.
[4] Repeat steps #1 and #2. This time, the settings should be retained.
[5] Set the Default Filter Library in the same tab and refresh. Verify
that the OU you chose is retained.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: John Amundson <jsamundson@cwmars.org> Signed-off-by: Janet Schrader <jschrader@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Add a title attribute to the top-right menu in the AngularJS form of the
navbar.
Signed-off-by: Sam Link <slink@LIBPC002> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval
It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason. When this happens,
the user sees an Internal Server Error. The underlying cause is the
following Perl error:
Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.
This commit rearranges the code around that line to avoid this
particular undefined value reference error.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Fri, 24 May 2019 17:16:00 +0000 (17:16 +0000)]
lp1789257 Items Out Monograph Part Column
Retrieve and display the label of all monograph parts for
copy listed in the Items Out table
To test
-------
[1] Apply the patch.
[2] Check out an item that has one or more monograph parts
linked to it.
[3] Verify that the Monograph Part column is available in the
Items Out grid and displays the part label(s). An example
of an item in the Concerto set that has a part is
CONC70001420.
Galen Charlton [Wed, 29 May 2019 21:39:19 +0000 (17:39 -0400)]
LP#1830972: update pin and add comments about keeping things in sync
This patch updates the angular/cli version to ^7.0.7 to match package.json
and adds comments about keeping the pin in sync between package.json
and Makefile.common.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Fri, 8 Mar 2019 15:38:43 +0000 (10:38 -0500)]
LP1748265 Hold fetch API sms_carrier option
Support a new "include_sms_carrier" option to the holds retrieve API so
the data may be fetched along with the hold instead after the fact in
the patron holds list, etc.
Garry Collum [Sun, 3 Jun 2018 19:54:25 +0000 (15:54 -0400)]
LP#1748265 SMS Carrier not an option in the patron's list of holds.
Adds SMS Carrier name as an option in the patron's list of holds.
To test:
1. Set 'Enable features that send SMS text messages' in the Library Settings to true.
2. Place a few holds for a patron, selecting text message notification.
3. Go to the patron's record and view their holds.
4. Display the 'Notifications SMS Carrier' column to view the carrier name.
Signed-off-by: Garry Collum <gcollum@gmail.com> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Garry Collum [Sat, 19 May 2018 21:00:40 +0000 (17:00 -0400)]
LP1772206 Tooltips missing from Patron Summary
Adds tooltips for home branch and Last Activity to emulate the XUL
client. The home branch tool tip displays the long OU name. The
last activity tooltip displays the last type of activity.
To test:
Home branch
1. Perform a patron search.
2. Click on one of the patrons in the results.
3. Hover over the home branch location in the patron summary.
Last Activity
4. Log into the opac with a patron account to some patron activity.
5. Bring up the patron in the staff client.
6. Hover over the last activity date.
Dan Pearl [Tue, 10 Apr 2018 18:45:47 +0000 (14:45 -0400)]
LP1760893 Add Holdings Part dropdown should list items in order
Without a defined sort, the Part dropdown when editing a holding simply
displays in database order. Let's be more deterministic about it.
In this case, while slightly surprising, consensus opinion was that
reverse order on label_sortkey provides the best overall usability.
This is obviously true on records with many parts, but can help in all
cases.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Per a suggestion from Jane Sandberg, the description now includes
an example of a time zone name with an underscore. Also, the database
update will no longer overwrite any custom description that the
Evergreen admin may have put in.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Remington Steed [Thu, 21 Feb 2019 19:54:19 +0000 (14:54 -0500)]
LP#1817332 Add example to lib.timezone setting description
This commit adds a few examples of acceptable lib.timezone values to the
setting description, with the goal of using examples of existing
Evergreen installations. It also includes a clickable link to the
extensive list on Wikipedia. Since the settings editor is displayed
within an iframe, the link needs a "target" to successfully trigger.
- ensures that the Boolean values get saved as 't' or 'f', as
the reporter builder doesn't recognize JSON true or false in
this context.
- pretty-prints the current filter value in the dialog
- removes a logging line
To test
-------
[1] Apply the patch.
[2] Create or clone one or more report templates and add Boolean
column filters. Change the filter value and verify that
it displays the current value and lets you change it.
[3] Run reports from the template(s) created in step 2 and
verify that the reports produce the expected results.
Jason Boyer [Tue, 29 Jan 2019 17:15:25 +0000 (12:15 -0500)]
LP1642337: Reporter Boolean Filters
The dialog controller doesn't appreciate getting
a bare boolean as a message, so if the current item
is a boolean call toString() on it before calling
the egConfirmDialog.
An <Unset> string is also added to the reporter
strings for further use, but if there are no
strong feelings re: using it, it can be dumped and
a '' used in its place.
Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Thu, 16 Nov 2017 20:56:51 +0000 (20:56 +0000)]
lp1642337 Boolean Filters in Reporter
- Add condition check to see if filter is boolean, and if so,
substitute a confirm dialog for the default prompt, repalcing
the text input with buttons for True/False values.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io> Signed-off-by: Jason Boyer <jboyer@library.in.gov> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org> Signed-off-by: Dawn Dale <ddale@georgialibraries.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Tue, 5 Mar 2019 22:07:21 +0000 (17:07 -0500)]
LP1816480 Angular grid ARIA improvements
Various navigation and "role" improvements to the Angular grid:
* Apply "grid", "row", "columnheader", and "gridcell" role attributes.
* Page-Down goes to next page
* Page-Up goes to previous page
* Shift-UpArrow extends selection one row up (spanning pages).
* Shift-DownArrow extends selection one row down (spanning pages).
* Shift-Arrow controls support reverse navigation for back-tracking to
de-select certain rows.
** E.g. shift-up 3 rows then shift-down 1 will leave 2 rows selected.
* Control-A now selects all rows in the page.
** For consistency with the select-all checkbox, only rows in the
current page are selected.
** Note we could add an option to extend the selection to all rows,
but it would require pre-fetching all of the data, simimar to
how grid printing pre-fetches.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
a. bellenir [Mon, 11 Mar 2019 17:39:00 +0000 (13:39 -0400)]
LP1775639: Refresh required to see Patron Credit
reload patron data when applying a payment
if the payment will change the patron's credit forward balance.
To test
-------
[1] Bill a patron, then make sure that the "Convert Change to Patron
Credit" checkbox is checked. Pay bill with more than the total
balance. Note that the Credit Available amount in the billing
summary does not change. Refresh the page.
[2] Bill a patron, then use the patron credit added in step 1 to
pay off the bill. Note that again, the Credit Available amount
does not change.
[3] Apply the patch and repeats steps 1 and 2. This time, the Credit
Available field should get updated.
Jane Sandberg [Wed, 17 Apr 2019 20:46:46 +0000 (16:46 -0400)]
LP1744386: Alphabetize stat cats in volcopy attr editor
To test:
1. Go to the volume copy editor. Confirm that the stat
cats do not display in order of owning library or stat cat
name.
2. Apply this commit.
3. Go to the volume copy editor. Confirm that the stat
cats now display in alphabetical order by owning library,
then stat cat name.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1440890: add vandelay_queue to the types of containers retrieved by batch edit
To test
-------
[1] Perform a batch bibliographic record import, then add the import
queue to a new bucket.
[2] In the web staff client, go to Cataloging | Batch Edit.
[3] Note that the bucket created in step 1 does _not_ appear in the
bucket selector on the batch edit page.
[4] In the web staff client, go to the record bucket and hit the
Batch edit button.
[5] Note that the bucket created in step 1 does _not_ appear in the
bucket selector on the batch edit page.
[6] Apply the patch and repeat steps 2-3. This time, the bucket
should appear in the selector.
[7] Repeat steps 4-5. This time, the bucket should appear in the selector
(and be the active choice).
Jane Sandberg [Thu, 6 Dec 2018 23:49:40 +0000 (15:49 -0800)]
LP1760599: Only show merge records action when multiple bucket records selected
To test:
1) Create a bucket.
2) Select one record from your bucket. Right-click on your record or click on the Actions drop-down.
3) Note that "Merge Selected Records" is clickable.
4) Apply this commit.
5) Repeat steps 2-3. Note that "Merge Selected Records" is no longer
clickable, unless you select two or more records.
Jason Boyer [Thu, 7 Feb 2019 18:48:13 +0000 (13:48 -0500)]
LP1790896: Receipt Errors with invalid emails
The attempt at belt-and-suspenders checking for a valid
email for use in the has_email template field sadly
causes the JS to trip over said suspenders if there is
a value in the field but it doesn't contain a '@'.
The raw return from "".match() (either an array or null)
is enough to do the right thing when converted into a
Boolean and doesn't cause the same problems.
To test
-------
[1] Set up a patron record with an invalid email address,
e.g., one that lacks the '@' character.
[2] Check out an item the patron, then from the Items Out
tab, print an item receipt.
[3] Note that nothing happens and an error is logged in the
browser console.
[4] Apply the patch and repeat step 2. This time, a receipt
should be generated.
Lp 1768987: Use FindBin in 24-sql-gettext-unique.t.
Use FindBin in the 24-sql-gettext-unique.t test file so that it can be
run from directories other than Open-ILS/src/perlmods.
To test
-------
[1] Apply the patch.
[2] From the root of the Evergreen checkout, run
prove Open-ILS/src/perlmods/t/24-sql-gettext-unique.t
[3] Verify that the tests pass.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Daniel Pearl [Wed, 12 Dec 2018 17:51:07 +0000 (12:51 -0500)]
LP#1029601: Prevent duplicate holds from double clicks
Double clicking on hold submit buttons causes multiple holds to be
generated. This commits adds code to disable the Submit button(s)
after the first click, so subsequent clicks don't "work" in unintended
ways.
Signed-off-by: Dan Pearl <dpearl@cwmars.org> Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Jason Stephenson <jason@sigio.com>
Remington Steed [Mon, 5 Nov 2018 18:55:25 +0000 (13:55 -0500)]
LP#1774707: Allow saving Group Member Details grid settings
For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Group Member Details grid (which is
within the patron record view).
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Michele Morgan <mmorgan@noblenet.org> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Dan Wells [Mon, 20 May 2019 16:34:17 +0000 (12:34 -0400)]
Recent newpot rethink and redo
The newpot build command has a tendancy to cause more harm than good in
certain cases. Basically, if run with a translation-toolkit of 2.0+
after originally using 1.x, you end up with different POT formatting
which in turn breaks existing translations for those strings.
I talked this over with Ben Shum, and he advised we simply stop doing
POT updates in point releases for now. I agree, and this reversal is
my attempt to stop the bleeding. It tries to remove any unneeded POT
changes from recent history, while also keeping completely new strings
that have already snuck in.
LP#1669120: Make scrollable dropdown height match column picker
To make scrollable dropdowns more usable, let's make them the same
height as the grid column picker dropdown. This is a quick, simple
improvement, and it follows precident with a frequently used feature
(column picker, which has no known complaints).
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 14 May 2019 17:03:35 +0000 (13:03 -0400)]
LP1813633 TCN search can find deleted records
As with the XUL client, when performing a bib record TCN search
(Cataloging -> Retrieve Record By TCN), first look for non-deleted
records with the requested TCN. When none are found, perform a
secondary search for deleted records with the requested TCN.
To test in concerto:
[1] Navigate to Cataloging -> Retrieve Record By TCN
[2] Search for TCN value "10", which is deleted by default in Concerto.
[3] Confirm the deleted record is loaded.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: Garry Collum <gcollum@gmail.com>
Jeff Davis [Fri, 8 Jun 2018 19:09:54 +0000 (12:09 -0700)]
LP#1788680 prevent copy template apply failure on null stat cats
Under some circumstances, the current code can result in a JS failure:
Cannot read property 'filter' of undefined
When this happens, the copy template may apply partially or not at all.
This change simply makes sure cp.stat_cat_entries() exists before
attempting to filter it.
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca> Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jason Boyer [Mon, 3 Dec 2018 13:11:29 +0000 (08:11 -0500)]
LP1806394: Placing Holds in Item Buckets
A missing return prevents a list of item ids from
being built so no holds can be placed from item
buckets. This branch returns the return to its
proper place.
To test
-------
[1] Add some items to an item bucket, ensuring that they are
all holdable.
[2] From the item bucket interface, select the items and choose
the Request Selected Items action.
[3] Confirm placing the requests.
[4] Note that the requests are not actually created.
[5] Apply the patch and repeat steps #1-#4. This time, the requests
should be placed.
LP#1826890: set page title for Statistical Popularity Badges admin page
To test
-------
[1] In the browser client, navigate to Local Administration -> Statistical
Popularity Badges
[2] Note that the web browser's tab header doesn't display a title for the
page, just the URL.
[3] Apply the patch and reload the page. This time, a page title should
be dispayed in the browser's tab header.
Mike Rylander [Fri, 14 Sep 2018 13:52:03 +0000 (09:52 -0400)]
LP#1792188: Record -> View Holds fails to refresh on Next/Prev record
Here we clean up and add back a call to refresh the holds list when navigating
between records in a result set.
To test
-------
[1] In the web staff client, perform a catalog search, bring up a record,
and change to the View Holds tab.
[2] Click the "Next" button to navigate to the next hold. Note that
the list of holds doesn't change.
[3] Apply the patch, refresh, and repeat steps #1 and #2. This time,
the list of holds should get updated as you navigate between
records in the results list.
Signed-off-by: Mike Rylander <mrylander@gmail.com> Signed-off-by: John Yorio <jyorio@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
LP#1782014 Fix grid path for Title in patron items out
When the Items Out grid was updated to use display fields, the
displayed title was updated (along with the fleshed data in the
javascript) but the grid "path" was not. This commit fixes the path,
which fixes title sorting. (Title sorting broke because the
simple_record.title was no longer being fleshed in via the JS code, so
the grid was attempting to sort on an empty value.)
Signed-off-by: Remington Steed <rjs7@calvin.edu> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Stephenson [Tue, 18 Dec 2018 14:26:11 +0000 (09:26 -0500)]
Lp 1752968: Select content when focusing on the barcode field.
To reproduce the reported behavior:
1. Find a title in the staff client catalog.
2. Click on Add Holdings.
3. See that the Barcode field does not have cursor focus.
4. Repeat step 1.
5. Click on edit next to one of the barcoded items in the list of
holdings.
6. Click Show Holdings Details and see that the Barcode field does
not have focus and the content is not selected.
To test this branch:
1. Find a title in the staff client catalog.
2. Click on Add Holdings.
3. See that the Barcode field has cursor focus, i.e. the cursor is in
the field and blinking.
4. Repeat step 1.
5. Click on edit next to one of the barcoded items in the list of
holdings.
6. Click Show Holdings Details and see that the Barcode field has
cursor focus and the content is selected/highlighted.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Volume transfer did not honor the cat.bib_keep_on_empty organizational
unit setting when removing empty bib records. This commit changes it
so that tranfer honors the setting in the same manner that deleting
copies and volumes does.
To test this fix, set cat.bib_keep_on_empty for your workstation
org. unit to true, and then transfer all of the volumes from one bib
record to another. The empty bib record should not get deleted.
You can also test with the setting on false to make sure that the
empty bib gets deleted.
Signed-off-by: Jason Stephenson <jason@sigio.com> Signed-off-by: Beth Willis <willis@noblenet.org>
Jeff Davis [Fri, 5 Apr 2019 18:08:55 +0000 (11:08 -0700)]
LP#1823387: avoid double slashes in booking URLs, which will not work with recent versions of Apache
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop> Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair
Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.
Signed-off-by: Bill Erickson <berickxx@gmail.com> Signed-off-by: John Amundson <jamundson@cwmars.org> Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Boyer [Thu, 28 Jun 2018 18:36:27 +0000 (14:36 -0400)]
LP1778940: Add Indexes to ate.*_output
When there are many rows in action_trigger.event_output
simply ensuring referencial integrity can take an
unacceptably long time as Postgres has to make sure
that the output being deleted isn't referenced in
any of these 3 fields. Adding these indexes keeps
these checks always fast.
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc
Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>