Evergreen.git
3 days agoLP1759343: Stamping upgrade: annotate payment setting rel_3_2
Jane Sandberg [Thu, 13 Jun 2019 20:57:14 +0000 (13:57 -0700)]
LP1759343: Stamping upgrade: annotate payment setting

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 days agoLP1759343 (follow-up): Add bill annotation setting to seed data
Jane Sandberg [Thu, 13 Jun 2019 18:33:20 +0000 (11:33 -0700)]
LP1759343 (follow-up): Add bill annotation setting to seed data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 days agoLP1759343: Bills Annotation Persistance
Jason Boyer [Fri, 18 Jan 2019 17:38:22 +0000 (12:38 -0500)]
LP1759343: Bills Annotation Persistance

Make the Annotate option on the patron Bills page
persistant and a workstation setting.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 days agoLP#1812900: fix retention of saved defaults in holdings editor
Galen Charlton [Fri, 19 Apr 2019 20:29:21 +0000 (16:29 -0400)]
LP#1812900: fix retention of saved defaults in holdings editor

Because the $watch on the statistical category default OU filter
in the holdings editor can fire before the form is fully initialized,
saved defaults (i.e., the cat.copy.defaults workstation setting)
could get overwritten with the hard-coded default value for that, er,
set of defaults.

This patch ensures that that $watch saves the defaults only when the
value of the default stat cat OU filter has changed.

To test
-------
[1] Use the holdings editor on an item. Change to the defaults
    tab and check or uncheck checkboxes such as "Use checkdigit"
    and "Print Item Labels on Save and Exit"
[2] Refresh the page or open the holdings editor on a different item.
    Note that the settings from step #1 are not retained.
[3] Apply the patch.
[4] Repeat steps #1 and #2. This time, the settings should be retained.
[5] Set the Default Filter Library in the same tab and refresh. Verify
    that the OU you chose is retained.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: John Amundson <jsamundson@cwmars.org>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 days agoLP#1796914: Right Navbar Menu Title
Sam Link [Thu, 13 Dec 2018 20:27:58 +0000 (15:27 -0500)]
LP#1796914: Right Navbar Menu Title

Add a title attribute to the top-right menu in the AngularJS form of the
navbar.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 weeks agoLP 115706: Avoid Internal Server Errors with Hold Count Retrieval
Jason Stephenson [Tue, 7 Aug 2018 14:02:10 +0000 (10:02 -0400)]
LP 115706: Avoid Internal Server Errors with Hold Count Retrieval

It can happen that the query to get a record's hold count can run too
long and timeout or fail for some other reason.  When this happens,
the user sees an Internal Server Error.  The underlying cause is the
following Perl error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line
4264.

This commit rearranges the code around that line to avoid this
particular undefined value reference error.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP#1789256 Monograph Part Column in Check Out
Kyle Huckins [Fri, 24 May 2019 19:55:44 +0000 (19:55 +0000)]
LP#1789256 Monograph Part Column in Check Out

Retrieve and display the label of all monograph parts for
copy listed in the Check Out table

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agolp1789257 Items Out Monograph Part Column
Kyle Huckins [Fri, 24 May 2019 17:16:00 +0000 (17:16 +0000)]
lp1789257 Items Out Monograph Part Column

Retrieve and display the label of all monograph parts for
copy listed in the Items Out table

To test
-------
[1] Apply the patch.
[2] Check out an item that has one or more monograph parts
    linked to it.
[3] Verify that the Monograph Part column is available in the
    Items Out grid and displays the part label(s). An example
    of an item in the Concerto set that has a part is
    CONC70001420.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP#1816180 Pending Patron - No Address Type
McCanna [Fri, 15 Feb 2019 19:55:59 +0000 (14:55 -0500)]
LP#1816180 Pending Patron - No Address Type

When registering a patron from Pending Patrons, inserts
default address type to match behavior of registering a
new patron from scratch.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP#1830972: update pin and add comments about keeping things in sync
Galen Charlton [Wed, 29 May 2019 21:39:19 +0000 (17:39 -0400)]
LP#1830972: update pin and add comments about keeping things in sync

This patch updates the angular/cli version to ^7.0.7 to match package.json
and adds comments about keeping the pin in sync between package.json
and Makefile.common.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 weeks agoDocs: LP1776913: Fixes references to Circulation Limit Sets in docs.
Geoff Sams [Mon, 4 Mar 2019 16:52:56 +0000 (10:52 -0600)]
Docs: LP1776913: Fixes references to Circulation Limit Sets in docs.

Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Lynn Floyd <lfloyd@andersonlibrary.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 weeks agoLP1776913: Corrects Local Administration menu to use correct form Circulation Limit...
Geoff Sams [Mon, 4 Mar 2019 16:41:13 +0000 (10:41 -0600)]
LP1776913: Corrects Local Administration menu to use correct form Circulation Limit Sets and Age Overdue Circulations to Lost.

Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Lynn Floyd <lfloyd@andersonlibrary.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 weeks agoLP1748265 Hold fetch API sms_carrier option
Bill Erickson [Fri, 8 Mar 2019 15:38:43 +0000 (10:38 -0500)]
LP1748265 Hold fetch API sms_carrier option

Support a new "include_sms_carrier" option to the holds retrieve API so
the data may be fetched along with the hold instead after the fact in
the patron holds list, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP#1748265 SMS Carrier not an option in the patron's list of holds.
Garry Collum [Sun, 3 Jun 2018 19:54:25 +0000 (15:54 -0400)]
LP#1748265 SMS Carrier not an option in the patron's list of holds.

Adds SMS Carrier name as an option in the patron's list of holds.

To test:
1. Set 'Enable features that send SMS text messages' in the Library Settings to true.
2. Place a few holds for a patron, selecting text message notification.
3. Go to the patron's record and view their holds.
4. Display the 'Notifications SMS Carrier' column to view the carrier name.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 weeks agoLP1772206 Tooltips missing from Patron Summary
Garry Collum [Sat, 19 May 2018 21:00:40 +0000 (17:00 -0400)]
LP1772206 Tooltips missing from Patron Summary

Adds tooltips for home branch and Last Activity to emulate the XUL
 client.  The home branch tool tip displays the long OU name.  The
last activity tooltip displays the last type of activity.

To test:

Home branch
1. Perform a patron search.
2. Click on one of the patrons in the results.
3. Hover over the home branch location in the patron summary.

Last Activity
4. Log into the opac with a patron account to some patron activity.
5. Bring up the patron in the staff client.
6. Hover over the last activity date.

7. Apply the patch and repeat 1-3 and 5-6.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1760893 Add Holdings Part dropdown should list items in order
Dan Pearl [Tue, 10 Apr 2018 18:45:47 +0000 (14:45 -0400)]
LP1760893 Add Holdings Part dropdown should list items in order

Without a defined sort, the Part dropdown when editing a holding simply
displays in database order.  Let's be more deterministic about it.

In this case, while slightly surprising, consensus opinion was that
reverse order on label_sortkey provides the best overall usability.
This is obviously true on records with many parts, but can help in all
cases.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 weeks agoLP#1772028 Add some FK violation functions just in case they are missing
Bill Ott [Fri, 18 May 2018 13:52:46 +0000 (09:52 -0400)]
LP#1772028 Add some FK violation functions just in case they are missing

Depending on your data, upgrade 1063 may not have created the functions
being re-applied in this upgrade script.  Let's make sure they are
there.

Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 weeks agoLP1817332 Stamping ugprade: timezone examples
Bill Erickson [Fri, 24 May 2019 19:06:24 +0000 (15:06 -0400)]
LP1817332 Stamping ugprade: timezone examples

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1817332: (follow-up) tweak description
Galen Charlton [Thu, 23 May 2019 15:17:44 +0000 (11:17 -0400)]
LP#1817332: (follow-up) tweak description

Per a suggestion from Jane Sandberg, the description now includes
an example of a time zone name with an underscore. Also, the database
update will no longer overwrite any custom description that the
Evergreen admin may have put in.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1817332 Add example to lib.timezone setting description
Remington Steed [Thu, 21 Feb 2019 19:54:19 +0000 (14:54 -0500)]
LP#1817332 Add example to lib.timezone setting description

This commit adds a few examples of acceptable lib.timezone values to the
setting description, with the goal of using examples of existing
Evergreen installations. It also includes a clickable link to the
extensive list on Wikipedia. Since the settings editor is displayed
within an iframe, the link needs a "target" to successfully trigger.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP1819181 Stamping upgrade: DoB example setting
Bill Erickson [Fri, 24 May 2019 18:52:58 +0000 (14:52 -0400)]
LP1819181 Stamping upgrade: DoB example setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP1819181: Example DOB for Patron Reg/Edit
Jason Boyer [Fri, 8 Mar 2019 16:03:38 +0000 (11:03 -0500)]
LP1819181: Example DOB for Patron Reg/Edit

Add the necessary coust entry for a patron dob example
and teach the registration controller to use it.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1642337: more tweaks to the patch series
Galen Charlton [Thu, 23 May 2019 14:32:44 +0000 (10:32 -0400)]
LP#1642337: more tweaks to the patch series

This patch makes the following changes:

- ensures that the Boolean values get saved as 't' or 'f', as
  the reporter builder doesn't recognize JSON true or false in
  this context.
- pretty-prints the current filter value in the dialog
- removes a logging line

To test
-------
[1] Apply the patch.
[2] Create or clone one or more report templates and add Boolean
    column filters. Change the filter value and verify that
    it displays the current value and lets you change it.
[3] Run reports from the template(s) created in step 2 and
    verify that the reports produce the expected results.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1642337: Reporter Boolean Filters
Jason Boyer [Tue, 29 Jan 2019 17:15:25 +0000 (12:15 -0500)]
LP1642337: Reporter Boolean Filters

The dialog controller doesn't appreciate getting
a bare boolean as a message, so if the current item
is a boolean call toString() on it before calling
the egConfirmDialog.

An <Unset> string is also added to the reporter
strings for further use, but if there are no
strong feelings re: using it, it can be dumped and
a '' used in its place.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agolp1642337 Boolean Filters in Reporter
Kyle Huckins [Thu, 16 Nov 2017 20:56:51 +0000 (20:56 +0000)]
lp1642337 Boolean Filters in Reporter

- Add condition check to see if filter is boolean, and if so,
substitute a confirm dialog for the default prompt, repalcing
the text input with buttons for True/False values.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoForward-port 3.2.6 upgrade script
Dan Wells [Fri, 24 May 2019 18:27:23 +0000 (14:27 -0400)]
Forward-port 3.2.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 weeks agoLP1816480 follow-up: add dependency missing from 3.2 branch
Jane Sandberg [Fri, 24 May 2019 17:10:07 +0000 (10:10 -0700)]
LP1816480 follow-up: add dependency missing from 3.2 branch

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP1816480 Angular grid ARIA improvements
Bill Erickson [Tue, 5 Mar 2019 22:07:21 +0000 (17:07 -0500)]
LP1816480 Angular grid ARIA improvements

Various navigation and "role" improvements to the Angular grid:

* Apply "grid", "row", "columnheader", and "gridcell" role attributes.
* Page-Down goes to next page
* Page-Up goes to previous page
* Shift-UpArrow extends selection one row up (spanning pages).
* Shift-DownArrow extends selection one row down (spanning pages).
* Shift-Arrow controls support reverse navigation for back-tracking to
  de-select certain rows.
** E.g. shift-up 3 rows then shift-down 1 will leave 2 rows selected.
* Control-A now selects all rows in the page.
** For consistency with the select-all checkbox, only rows in the
   current page are selected.
** Note we could add an option to extend the selection to all rows,
   but it would require pre-fetching all of the data, simimar to
   how grid printing pre-fetches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
3 weeks agoLP1775639: Refresh required to see Patron Credit
a. bellenir [Mon, 11 Mar 2019 17:39:00 +0000 (13:39 -0400)]
LP1775639: Refresh required to see Patron Credit

reload patron data when applying a payment
if the payment will change the patron's credit forward balance.

To test
-------
[1] Bill a patron, then make sure that the "Convert Change to Patron
    Credit" checkbox is checked. Pay bill with more than the total
    balance. Note that the Credit Available amount in the billing
    summary does not change. Refresh the page.
[2] Bill a patron, then use the patron credit added in step 1 to
    pay off the bill. Note that again, the Credit Available amount
    does not change.
[3] Apply the patch and repeats steps 1 and 2. This time, the Credit
    Available field should get updated.

Signed-off-by: a. bellenir <abelleni@grpl.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical
Suzanne Paterno [Tue, 9 Apr 2019 14:42:15 +0000 (10:42 -0400)]
LP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical

Statistical categories will be alphabetized first by library and then by category.

The entires within each category will also be alphabetized.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1744386: Alphabetize stat cats in volcopy attr editor
Jane Sandberg [Wed, 17 Apr 2019 20:46:46 +0000 (16:46 -0400)]
LP1744386: Alphabetize stat cats in volcopy attr editor

To test:
1. Go to the volume copy editor.  Confirm that the stat
cats do not display in order of owning library or stat cat
name.
2. Apply this commit.
3. Go to the volume copy editor.  Confirm that the stat
cats now display in alphabetical order by owning library,
then stat cat name.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP#1440890: add vandelay_queue to the types of containers retrieved by batch edit
Rogan Hamby [Fri, 19 Apr 2019 15:25:19 +0000 (11:25 -0400)]
LP#1440890: add vandelay_queue to the types of containers retrieved by batch edit

To test
-------
[1] Perform a batch bibliographic record import, then add the import
    queue to a new bucket.
[2] In the web staff client, go to Cataloging | Batch Edit.
[3] Note that the bucket created in step 1 does _not_ appear in the
    bucket selector on the batch edit page.
[4] In the web staff client, go to the record bucket and hit the
    Batch edit button.
[5] Note that the bucket created in step 1 does _not_ appear in the
    bucket selector on the batch edit page.
[6] Apply the patch and repeat steps 2-3. This time, the bucket
    should appear in the selector.
[7] Repeat steps 4-5. This time, the bucket should appear in the selector
    (and be the active choice).

Signed-off-by: Rogan Hamby <rhamby@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1760599: Only show merge records action when multiple bucket records selected
Jane Sandberg [Thu, 6 Dec 2018 23:49:40 +0000 (15:49 -0800)]
LP1760599: Only show merge records action when multiple bucket records selected

To test:
1) Create a bucket.
2) Select one record from your bucket. Right-click on your record or click on the Actions drop-down.
3) Note that "Merge Selected Records" is clickable.
4) Apply this commit.
5) Repeat steps 2-3.  Note that "Merge Selected Records" is no longer
clickable, unless you select two or more records.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1790896: Receipt Errors with invalid emails
Jason Boyer [Thu, 7 Feb 2019 18:48:13 +0000 (13:48 -0500)]
LP1790896: Receipt Errors with invalid emails

The attempt at belt-and-suspenders checking for a valid
email for use in the has_email template field sadly
causes the JS to trip over said suspenders if there is
a value in the field but it doesn't contain a '@'.

The raw return from "".match() (either an array or null)
is enough to do the right thing when converted into a
Boolean and doesn't cause the same problems.

To test
-------
[1] Set up a patron record with an invalid email address,
    e.g., one that lacks the '@' character.
[2] Check out an item the patron, then from the Items Out
    tab, print an item receipt.
[3] Note that nothing happens and an error is logged in the
    browser console.
[4] Apply the patch and repeat step 2. This time, a receipt
    should be generated.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLp 1768987: Use FindBin in 24-sql-gettext-unique.t.
Jason Stephenson [Thu, 3 May 2018 21:31:07 +0000 (17:31 -0400)]
Lp 1768987: Use FindBin in 24-sql-gettext-unique.t.

Use FindBin in the 24-sql-gettext-unique.t test file so that it can be
run from directories other than Open-ILS/src/perlmods.

To test
-------
[1] Apply the patch.
[2] From the root of the Evergreen checkout, run
    prove Open-ILS/src/perlmods/t/24-sql-gettext-unique.t
[3] Verify that the tests pass.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoDocs: Fix list formatting in 3.2 release notes
Remington Steed [Thu, 23 May 2019 17:42:27 +0000 (13:42 -0400)]
Docs: Fix list formatting in 3.2 release notes

Single list items that wrap across multiple lines accidentally start
each line with a bullet. This commit removes the extra bullets.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
3 weeks agoLP#1796942 Treat VISA SIP payments as credit card
Jeff Godin [Tue, 2 Oct 2018 12:32:54 +0000 (08:32 -0400)]
LP#1796942 Treat VISA SIP payments as credit card

Treat sip_payment_type 01 (VISA) as a credit_card_payment.

Previously, we only handled payment type 02 (credit card) and 01
fell through to be treated as a cash_payment.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1704819 Fine generator avoids int() rounding
Bill Erickson [Thu, 3 Aug 2017 19:01:34 +0000 (15:01 -0400)]
LP#1704819 Fine generator avoids int() rounding

Avoid using the Perl int() function for rounding in the fine generator,
since it can have unexpected outcomes.

For example:

$ perl -e 'print "230 = " . int(100 * 2.30) . "\n"'
230 = 229

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
3 weeks agoLP1693580 Authority create/update API repairs
Bill Erickson [Fri, 15 Mar 2019 15:29:07 +0000 (11:29 -0400)]
LP1693580 Authority create/update API repairs

Fixes issues with the authority record create and update open-ils.cat
API calls, where internal function calls were not passed the correct
values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
3 weeks agoLP1693580 Marc editor notify and API changes
Bill Erickson [Fri, 15 Mar 2019 15:29:59 +0000 (11:29 -0400)]
LP1693580 Marc editor notify and API changes

1. Indicate in the interface when a bib/auth MARC record edit failed or
succeeded.

2. Handle permission failures on MARC edit by displaying the permission
override dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
3 weeks agoLP#1029601: Prevent duplicate holds from double clicks
Daniel Pearl [Wed, 12 Dec 2018 17:51:07 +0000 (12:51 -0500)]
LP#1029601: Prevent duplicate holds from double clicks

Double clicking on hold submit buttons causes multiple holds to be
generated.  This commits adds code to disable the Submit button(s)
after the first click, so subsequent clicks don't "work" in unintended
ways.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 weeks agoLP#1774707 Quick fix-up: add missing comma
Dan Wells [Mon, 20 May 2019 21:15:09 +0000 (17:15 -0400)]
LP#1774707 Quick fix-up: add missing comma

We probably should move this on up with the others, but as a quick
fix...

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 weeks agolp1538678 MARC edit warning prompt translateable strings
Kyle Huckins [Mon, 20 May 2019 18:07:07 +0000 (18:07 +0000)]
lp1538678 MARC edit warning prompt translateable strings

- Define "There is unsaved data in this record." as a translateable string.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/marcedit_strings.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agolp1538678 Apply Warning Prompt when leaving dirty MARC editor
Kyle Huckins [Wed, 17 Apr 2019 22:55:49 +0000 (22:55 +0000)]
lp1538678 Apply Warning Prompt when leaving dirty MARC editor

- Check for unsaved user input when leaving the Create New
MARC Record UI, and warn if it exists.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   services/marcedit.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP1817601 MARC Flat Text Editor Monospace Font
Bill Erickson [Thu, 14 Mar 2019 21:02:31 +0000 (17:02 -0400)]
LP1817601 MARC Flat Text Editor Monospace Font

Use a fixed width font in the MARC flat text editor, consistent with the
fonts used for the non-flat-text editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
3 weeks agoLP1774707 Stamping DB update: group members grid
Bill Erickson [Mon, 20 May 2019 18:53:07 +0000 (14:53 -0400)]
LP1774707 Stamping DB update: group members grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1774707: Add Seed Data for worstation setting for group member details
Michele Morgan [Fri, 12 Apr 2019 20:10:00 +0000 (16:10 -0400)]
LP#1774707: Add Seed Data for worstation setting for group member details

Adds the config.workstation_setting_type for patron group member details
to seed data and includes an upgrade script.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoLP#1774707: Allow saving Group Member Details grid settings
Remington Steed [Mon, 5 Nov 2018 18:55:25 +0000 (13:55 -0500)]
LP#1774707: Allow saving Group Member Details grid settings

For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Group Member Details grid (which is
within the patron record view).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 weeks agoRecent newpot rethink and redo
Dan Wells [Mon, 20 May 2019 16:34:17 +0000 (12:34 -0400)]
Recent newpot rethink and redo

The newpot build command has a tendancy to cause more harm than good in
certain cases.  Basically, if run with a translation-toolkit of 2.0+
after originally using 1.x, you end up with different POT formatting
which in turn breaks existing translations for those strings.

I talked this over with Ben Shum, and he advised we simply stop doing
POT updates in point releases for now.  I agree, and this reversal is
my attempt to stop the bleeding.  It tries to remove any unneeded POT
changes from recent history, while also keeping completely new strings
that have already snuck in.

This reverts commit a37154508d8fc078b5d9bae5ada105a534c13ecd.
This re-does commit 4e0b9d31cdbda3c356b22778b361ae4e60375255.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 weeks agoLP#1669120: Make scrollable dropdown height match column picker
Remington Steed [Fri, 12 Apr 2019 13:18:35 +0000 (09:18 -0400)]
LP#1669120: Make scrollable dropdown height match column picker

To make scrollable dropdowns more usable, let's make them the same
height as the grid column picker dropdown. This is a quick, simple
improvement, and it follows precident with a frequently used feature
(column picker, which has no known complaints).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 weeks agoDocs: Fix list formatting in 3.2 release notes
Remington Steed [Mon, 20 May 2019 13:27:58 +0000 (09:27 -0400)]
Docs: Fix list formatting in 3.2 release notes

An AsciiDoc list needs a blank line before it. Otherwise, it is just
part of the paragraph.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 weeks agoDocs: Add bugfix release notes for 3.2.6
Remington Steed [Fri, 17 May 2019 19:41:52 +0000 (15:41 -0400)]
Docs: Add bugfix release notes for 3.2.6

Signed-off-by: Remington Steed <rjs7@calvin.edu>
4 weeks agoLP1813633 TCN search can find deleted records
Bill Erickson [Tue, 14 May 2019 17:03:35 +0000 (13:03 -0400)]
LP1813633 TCN search can find deleted records

As with the XUL client, when performing a bib record TCN search
(Cataloging -> Retrieve Record By TCN), first look for non-deleted
records with the requested TCN.  When none are found, perform a
secondary search for deleted records with the requested TCN.

To test in concerto:

[1] Navigate to Cataloging -> Retrieve Record By TCN
[2] Search for TCN value "10", which is deleted by default in Concerto.
[3] Confirm the deleted record is loaded.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
4 weeks agoLP#1788680 prevent copy template apply failure on null stat cats
Jeff Davis [Fri, 8 Jun 2018 19:09:54 +0000 (12:09 -0700)]
LP#1788680 prevent copy template apply failure on null stat cats

Under some circumstances, the current code can result in a JS failure:

Cannot read property 'filter' of undefined

When this happens, the copy template may apply partially or not at all.
This change simply makes sure cp.stat_cat_entries() exists before
attempting to filter it.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 weeks agoLP1806394: Placing Holds in Item Buckets
Jason Boyer [Mon, 3 Dec 2018 13:11:29 +0000 (08:11 -0500)]
LP1806394: Placing Holds in Item Buckets

A missing return prevents a list of item ids from
being built so no holds can be placed from item
buckets. This branch returns the return to its
proper place.

To test
-------
[1] Add some items to an item bucket, ensuring that they are
    all holdable.
[2] From the item bucket interface, select the items and choose
    the Request Selected Items action.
[3] Confirm placing the requests.
[4] Note that the requests are not actually created.
[5] Apply the patch and repeat steps #1-#4. This time, the requests
    should be placed.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Millissa Macomber <millissam@burlingtonwa.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1826890: set page title for Statistical Popularity Badges admin page
Galen Charlton [Mon, 29 Apr 2019 14:56:14 +0000 (10:56 -0400)]
LP#1826890: set page title for Statistical Popularity Badges admin page

To test
-------
[1] In the browser client, navigate to Local Administration -> Statistical
    Popularity Badges
[2] Note that the web browser's tab header doesn't display a title for the
    page, just the URL.
[3] Apply the patch and reload the page. This time, a page title should
    be dispayed in the browser's tab header.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP#1792188: Record -> View Holds fails to refresh on Next/Prev record
Mike Rylander [Fri, 14 Sep 2018 13:52:03 +0000 (09:52 -0400)]
LP#1792188: Record -> View Holds fails to refresh on Next/Prev record

Here we clean up and add back a call to refresh the holds list when navigating
between records in a result set.

To test
-------
[1] In the web staff client, perform a catalog search, bring up a record,
    and change to the View Holds tab.
[2] Click the "Next" button to navigate to the next hold. Note that
    the list of holds doesn't change.
[3] Apply the patch, refresh, and repeat steps #1 and #2. This time,
    the list of holds should get updated as you navigate between
    records in the results list.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: John Yorio <jyorio@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 weeks agoLP1803729 action_trigger_aggregator.pl help indicates the wrong bash argument for...
blake [Fri, 16 Nov 2018 15:37:31 +0000 (09:37 -0600)]
LP1803729 action_trigger_aggregator.pl help indicates the wrong bash argument for remote-acct

Fixed the help message action_trigger_aggregator.pl to agree with the code

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 weeks agoLP#1782014 Fix grid path for Title in patron items out
Remington Steed [Wed, 10 Apr 2019 20:32:13 +0000 (16:32 -0400)]
LP#1782014 Fix grid path for Title in patron items out

When the Items Out grid was updated to use display fields, the
displayed title was updated (along with the fleshed data in the
javascript) but the grid "path" was not. This commit fixes the path,
which fixes title sorting. (Title sorting broke because the
simple_record.title was no longer being fleshed in via the JS code, so
the grid was attempting to sort on an empty value.)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 weeks agoLp 1752968: Select content when focusing on the barcode field.
Jason Stephenson [Tue, 18 Dec 2018 14:26:11 +0000 (09:26 -0500)]
Lp 1752968: Select content when focusing on the barcode field.

To reproduce the reported behavior:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field does not have cursor focus.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field does
     not have focus and the content is not selected.

To test this branch:

 1. Find a title in the staff client catalog.
 2. Click on Add Holdings.
 3. See that the Barcode field has cursor focus, i.e. the cursor is in
    the field and blinking.
 4. Repeat step 1.
 5. Click on edit next to one of the barcoded items in the list of
    holdings.
 6. Click Show Holdings Details and see that the Barcode field has
     cursor focus and the content is selected/highlighted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
6 weeks agoLp 1752968: Focus Barcode Field in Volumes/Copy Editor
Jason Stephenson [Mon, 17 Dec 2018 16:08:47 +0000 (11:08 -0500)]
Lp 1752968: Focus Barcode Field in Volumes/Copy Editor

Always focus the barcode field when adding or editing volumes or
copies.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
6 weeks agoLP 1333893: Keep Empty Bib on Volume Transfer
Jason Stephenson [Thu, 11 Oct 2018 12:50:30 +0000 (08:50 -0400)]
LP 1333893: Keep Empty Bib on Volume Transfer

Volume transfer did not honor the cat.bib_keep_on_empty organizational
unit setting when removing empty bib records.  This commit changes it
so that tranfer honors the setting in the same manner that deleting
copies and volumes does.

To test this fix, set cat.bib_keep_on_empty for your workstation
org. unit to true, and then transfer all of the volumes from one bib
record to another.  The empty bib record should not get deleted.

You can also test with the setting on false to make sure that the
empty bib gets deleted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Beth Willis <willis@noblenet.org>
7 weeks agoLP#1814943: (follow-up) remove ersatz ctx.page_type line
Galen Charlton [Mon, 29 Apr 2019 14:49:19 +0000 (10:49 -0400)]
LP#1814943: (follow-up) remove ersatz ctx.page_type line

Guessing that the original bug was due to "page_type" being
entered when "page_title" was meant.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1814943 Closed Dates Editor Tab Missing Title
McCanna [Wed, 6 Feb 2019 18:52:48 +0000 (13:52 -0500)]
LP#1814943 Closed Dates Editor Tab Missing Title

Small fix to add missing page title.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1823387: avoid double slashes in booking URLs, which will not work with recent...
Jeff Davis [Fri, 5 Apr 2019 18:08:55 +0000 (11:08 -0700)]
LP#1823387: avoid double slashes in booking URLs, which will not work with recent versions of Apache

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP1642036 Group member detail grid query repair
Bill Erickson [Wed, 24 Apr 2019 13:19:40 +0000 (09:19 -0400)]
LP1642036 Group member detail grid query repair

Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
7 weeks agoLP#1778940: stamp schema update
Galen Charlton [Wed, 24 Apr 2019 19:41:49 +0000 (15:41 -0400)]
LP#1778940: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP#1778940: (follow-up) create indexes concurrently during upgrade
Galen Charlton [Wed, 24 Apr 2019 19:37:06 +0000 (15:37 -0400)]
LP#1778940: (follow-up) create indexes concurrently during upgrade

This reduces potential for locking when run in a production
database, particularly if done outside of a full version upgrade.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 weeks agoLP1778940: Add Indexes to ate.*_output
Jason Boyer [Thu, 28 Jun 2018 18:36:27 +0000 (14:36 -0400)]
LP1778940: Add Indexes to ate.*_output

When there are many rows in action_trigger.event_output
simply ensuring referencial integrity can take an
unacceptably long time as Postgres has to make sure
that the output being deleted isn't referenced in
any of these 3 fields. Adding these indexes keeps
these checks always fast.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
2 months agodocs: LP1258628: screenshots & updates to actiontriggers.adoc
abneiman [Wed, 12 Dec 2018 19:48:35 +0000 (14:48 -0500)]
docs: LP1258628: screenshots & updates to actiontriggers.adoc

Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoDocs: correcting inaccurate statement in action trigger docs
Jane Sandberg [Thu, 11 Oct 2018 01:37:59 +0000 (18:37 -0700)]
Docs: correcting inaccurate statement in action trigger docs

2 months agoDocs: adding info about testing action triggers
Jane Sandberg [Mon, 8 Oct 2018 21:42:30 +0000 (14:42 -0700)]
Docs: adding info about testing action triggers

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoDocs: adding action/triggers to staff client admin docs
Jane Sandberg [Mon, 8 Oct 2018 21:37:30 +0000 (14:37 -0700)]
Docs: adding action/triggers to staff client admin docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoLP1821196: Remove arrow function from item status
Jane Sandberg [Thu, 21 Mar 2019 16:11:51 +0000 (09:11 -0700)]
LP1821196: Remove arrow function from item status

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
2 months agoForward-port 3.2.5 upgrade script
Dan Wells [Thu, 28 Mar 2019 15:35:34 +0000 (11:35 -0400)]
Forward-port 3.2.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoDocs: Revise 3.2.5 bugfix release notes
Remington Steed [Tue, 26 Mar 2019 20:15:11 +0000 (16:15 -0400)]
Docs: Revise 3.2.5 bugfix release notes

This commit adds release notes for recently pushed fixes to the new
Angular pieces of the web client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 months agoTranslation updates - po files
Dan Wells [Tue, 26 Mar 2019 16:28:53 +0000 (12:28 -0400)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoTranslation updates - newpot
Dan Wells [Tue, 26 Mar 2019 16:08:27 +0000 (12:08 -0400)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1821067 Angular i18n uses XMB; cs-CZ examples
Bill Erickson [Wed, 20 Mar 2019 18:38:44 +0000 (14:38 -0400)]
LP1821067 Angular i18n uses XMB; cs-CZ examples

Includes documentation updates and cs-CZ example using export cs-CZ .xtb
translation bundle.

Also remove xmliffmerge configuration options since we are not using
xliff files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1821067 Angular Czech translation bundle
Bill Erickson [Wed, 20 Mar 2019 18:38:14 +0000 (14:38 -0400)]
LP1821067 Angular Czech translation bundle

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1821409 Ang admin editor clears fields on new
Bill Erickson [Fri, 22 Mar 2019 20:41:12 +0000 (13:41 -0700)]
LP1821409 Ang admin editor clears fields on new

The Angular admin pages re-use an FmEditor component for creating and
updating objects.  When creating a new object after editing an existing
object, reset the editor so it won't load the previously edited object.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1807461 Admin page avoid errors on dialog dismissal
Bill Erickson [Wed, 23 Jan 2019 22:30:26 +0000 (17:30 -0500)]
LP1807461 Admin page avoid errors on dialog dismissal

Add support to the base DialogComponent class for passing information to
the caller via the reject handler about whether a dialog was dismissed
via user interface interaction (body click, esc key, cross click, cancel
button) or for some other reason, presumably an error.

Teach the generic admin page to avoid toasting errors when an edit or
create dialog is dismissed via UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1807458 Eg2 grid Edit option lint repairs
Bill Erickson [Wed, 23 Jan 2019 21:13:52 +0000 (16:13 -0500)]
LP1807458 Eg2 grid Edit option lint repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP#1807461 FM-editor show danger toasts when create/update fails
Bill Erickson [Mon, 10 Dec 2018 20:06:23 +0000 (15:06 -0500)]
LP#1807461 FM-editor show danger toasts when create/update fails

Display a danger toast when update or create attempts fail in the
Angular fieldmapper editor dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP#1807458 Angular admin grid Edit Selected option
Bill Erickson [Mon, 10 Dec 2018 18:09:36 +0000 (13:09 -0500)]
LP#1807458 Angular admin grid Edit Selected option

Adds a new "Edit Selected" action to the "Actions for Selected Items"
menu in the general purpose admin grid.  This only visibly affects the
ACQ admin grids at time of writing, but applies to all auto-generated
admin grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agodocs: Statcat updates
abneiman [Tue, 19 Feb 2019 22:22:04 +0000 (17:22 -0500)]
docs: Statcat updates

Signed-off-by: abneiman <abneiman@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
2 months agoDocs: Add bugfix release notes for 3.2.5
Remington Steed [Wed, 20 Mar 2019 15:57:02 +0000 (11:57 -0400)]
Docs: Add bugfix release notes for 3.2.5

For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.2.5. I'm not sure what the criteria were
for pervious point release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 months agoDocs: Add bugfix release notes for 3.1.11
Remington Steed [Wed, 20 Mar 2019 16:16:54 +0000 (12:16 -0400)]
Docs: Add bugfix release notes for 3.1.11

For the acknowledgements section, I opted to include anyone who had
signed off on a commit in 3.1.11. Not sure if this is the same as past
point release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
2 months agoLP1776736 Record merge marc edit repairs
Bill Erickson [Thu, 14 Mar 2019 16:03:58 +0000 (12:03 -0400)]
LP1776736 Record merge marc edit repairs

1. Fixes issues where edits to MARC records would fail to save during
   merge.

2. Provide options to select flat or non-flat text editor in edit mode
   for record merges.

3. Allow record editor action buttons/selectors to flow down
   horizontally when they don't fit in a narrow space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
2 months agoLP1749502 - Holds Pull List Print Order
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order

- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
2 months agoLP 1749502: Add Call Number Prefix & Suffix to pull list print template.
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.

We add the call number prefix and suffix as separate columns to the
holds pull list print template.  We also add the suffix to the end of
the orderBy so that we also sort by the suffix.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
2 months agolp1749502 Prefix patch
Kyle Huckins [Tue, 29 May 2018 16:06:59 +0000 (16:06 +0000)]
lp1749502 Prefix patch

- Ensure prefix information is properly set

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
2 months agolp1749502 Holds Pull List Print Order
Kyle Huckins [Thu, 17 May 2018 21:08:27 +0000 (21:08 +0000)]
lp1749502 Holds Pull List Print Order

- Ensure copy shelf location position is available for each hold on
holds shelf.
- Add _copy_location_position to hold_data while printing.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
3 months agoLP1739293 Record merged edit-in-place avoid wrap
Bill Erickson [Tue, 5 Mar 2019 16:53:09 +0000 (11:53 -0500)]
LP1739293 Record merged edit-in-place avoid wrap

When using the inline editor, prevent text wrapping and instead allow
the text to overflow x and y and use scrolls to navigate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 months agoLP1739293 Record merge fits container
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container

Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen.  A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 months agoLP1739293 Record merge horizontal; optional holdings
Bill Erickson [Fri, 8 Feb 2019 16:25:10 +0000 (11:25 -0500)]
LP1739293 Record merge horizontal; optional holdings

* Tile bib records horizontally in record bucket => merge records
  interface.

* Add a "Toggle Holdings View" button for displaying holdings and leave
  holdings un-displayed by default.

* Duplicate the Merge and Cancel buttons along the top of the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
3 months agoLP 1819796: Fix method call on undefined value in generate_fines
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines

The below message repeats in the open-ils.storage_stderr.log:

Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.

This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.

Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoLP1793196 Fix console error when none selected
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected

If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoLP1793196 Volume batch editor offers MARC call numbers
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers

Provide call numbers extracted from the MARC record as options in the
volume batch editor.  Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.

Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
3 months agoLP1665534: Make pickup library in bib record holds view sticky
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>