Evergreen.git
9 years agoStamped upgrade script for "lp 823496: do not fail to index personal names that have...
Mike Rylander [Sat, 13 Aug 2011 01:07:41 +0000 (21:07 -0400)]
Stamped upgrade script for "lp 823496: do not fail to index personal names that have relators"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agolp 823496: don't fail to index personal names that have relators
Galen Charlton [Tue, 9 Aug 2011 19:30:56 +0000 (15:30 -0400)]
lp 823496: don't fail to index personal names that have relators

The default definition for the author|other index inadvertantly
excluded names from 600, 700, 720, and 800 fields that have
relator values ($e) or codes ($4).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoVandelay: capture one match per catalog record
Bill Erickson [Fri, 12 Aug 2011 21:03:11 +0000 (17:03 -0400)]
Vandelay: capture one match per catalog record

When searching for matches to existing catalog records
(biblio.record_entry's), Vandelay can in some cases result in multiple
like matches for the same record (with the same match score).  This
trims it down to 1 match per record.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdd some additional logging in SIP/Transaction/Feepayment.pm.
Jason Stephenson [Thu, 4 Aug 2011 20:02:15 +0000 (16:02 -0400)]
Add some additional logging in SIP/Transaction/Feepayment.pm.

This should help with debugging, etc.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd OILS_SIP_MSG_BILL_ERR for when an error occurs getting bills.
Jason Stephenson [Thu, 4 Aug 2011 16:31:49 +0000 (12:31 -0400)]
Add OILS_SIP_MSG_BILL_ERR for when an error occurs getting bills.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd event textcode as alternative to descr in FeePayment.pm.
Jason Stephenson [Thu, 14 Jul 2011 17:59:47 +0000 (13:59 -0400)]
Add event textcode as alternative to descr in FeePayment.pm.

Some events have no descr, it seems.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoBail from fee payment if no bills are found.
Jason Stephenson [Wed, 13 Jul 2011 22:28:26 +0000 (18:28 -0400)]
Bail from fee payment if no bills are found.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoAdd SIP2 fee payment, the 37/38 message/response pairs.
Jason Stephenson [Thu, 30 Jun 2011 15:48:28 +0000 (11:48 -0400)]
Add SIP2 fee payment, the 37/38 message/response pairs.

* Pay individual bill if a fee id is given by the SC.

* Pay multiple bills in batch so if one fails the whole transaction
  is aborted and a failure response is sent to the SC.

* Reject payments outright if the SC sends an overpayment.

* Add constants for bill not found and overpayment messages.

* Whole lotta logging goin' on (maybe too much).

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoDon't escape_html numbers in util/print.js
Thomas Berezansky [Fri, 12 Aug 2011 19:47:25 +0000 (15:47 -0400)]
Don't escape_html numbers in util/print.js

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoEscape HTML characters in template subs
Thomas Berezansky [Thu, 11 Aug 2011 01:37:54 +0000 (21:37 -0400)]
Escape HTML characters in template subs

This prevents injection of random HTML from various sources.

Like bad bib records, org unit settings, patron info, etc.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoUse openDialog to make go_print workaround vanish
Thomas Berezansky [Thu, 11 Aug 2011 01:03:46 +0000 (21:03 -0400)]
Use openDialog to make go_print workaround vanish

By passing params and the go_print function into openDialog we get
to ignore race conditions, as the window is created with the passed
in arguments.

Oh, and we can stop using js2JSON and such.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAdd openDialog to window class
Thomas Berezansky [Thu, 11 Aug 2011 01:02:51 +0000 (21:02 -0400)]
Add openDialog to window class

Uses window.openDialog instead of window.open.
https://developer.mozilla.org/en/DOM/window.openDialog

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoNo more lightpink for disabled copy editor
Jason Etheridge [Fri, 12 Aug 2011 20:04:43 +0000 (16:04 -0400)]
No more lightpink for disabled copy editor

Folks can still provide custom CSS against those class hooks if desired

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoin lieu of Ready Item Editor
Jason Etheridge [Thu, 11 Aug 2011 18:16:24 +0000 (14:16 -0400)]
in lieu of Ready Item Editor

We're trying to prevent folks from using the item attribute editor in the
unified interface when the volume pane is still updating its information
(i.e. building the copies to feed to the attribute editor), so that a
given editing widget isn't ripped out from under staff while its being
used.  This change removes the heavy-handed Ready Item Editor button and
instead tries to more gracefully manage the editor state based on change
and keypress events.  Also change the color scheme for a disabled editor
from red to light pink.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrade script for "For vandelay bib matching, make 020, 022, 024 tags case...
Mike Rylander [Fri, 12 Aug 2011 19:06:01 +0000 (15:06 -0400)]
Stamped upgrade script for "For vandelay bib matching, make 020, 022, 024 tags case-insensitive"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFor vandelay bib matching, make 020, 022, 024 tags case-insensitive
Lebbeous Fogle-Weekley [Fri, 12 Aug 2011 15:35:16 +0000 (11:35 -0400)]
For vandelay bib matching, make 020, 022, 024 tags case-insensitive

For user convenience.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoRemoved errant '-' causing sql syntax failure
Bill Erickson [Fri, 12 Aug 2011 12:40:31 +0000 (08:40 -0400)]
Removed errant '-' causing sql syntax failure

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTweak Override Dialog so that the text can wrap
Jason Etheridge [Wed, 10 Aug 2011 18:04:11 +0000 (14:04 -0400)]
Tweak Override Dialog so that the text can wrap

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoTweak wording for Checkout's Override Once feature
Jason Etheridge [Wed, 10 Aug 2011 18:03:37 +0000 (14:03 -0400)]
Tweak wording for Checkout's Override Once feature

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAdd note that overrides will stay for the session
Thomas Berezansky [Wed, 27 Jul 2011 21:14:43 +0000 (17:14 -0400)]
Add note that overrides will stay for the session

Same way other overrides get an additional note.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoAllow "override once per patron" at checkout
Thomas Berezansky [Mon, 18 Jul 2011 15:35:08 +0000 (11:35 -0400)]
Allow "override once per patron" at checkout

Specifically for patron-derived overrides:
PATRON_EXCEEDS_OVERDUE_COUNT
PATRON_BARRED
PATRON_EXCEEDS_CHECKOUT_COUNT
PATRON_EXCEEDS_FINES

This is done by:
Adding support for a list of "reported" overrides to util/network.js
Using that in Checkout to build an auto-override list for the current patron
Passing that list in at Checkout

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoStream records to ML for Vandelay queue export
Bill Erickson [Wed, 10 Aug 2011 14:23:32 +0000 (10:23 -0400)]
Stream records to ML for Vandelay queue export

Since queued records, with their marcxml blobs, are fairly large, avoid
fetching them atomically when possible.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoGranular invalid data detection for Vandelay item import
Bill Erickson [Mon, 8 Aug 2011 19:05:47 +0000 (15:05 -0400)]
Granular invalid data detection for Vandelay item import

When an import item contains any data for a field, the code now verifies
the data is valid for the selected field.  When the data is not valid,
we capture information on which field is invalid and what data was used
for the field (import_error, error_detail) so it can be reported in the
interface.

This adds new import_errors:

import.item.invalid.status
import.item.invalid.price
import.item.invalid.deposit_amount
import.item.invalid.owning_lib
import.item.invalid.circ_lib
import.item.invalid.copy_number
import.item.invalid.circ_as_type

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoShow copy status/location names in Vandelay items grid
Bill Erickson [Thu, 4 Aug 2011 22:14:00 +0000 (18:14 -0400)]
Show copy status/location names in Vandelay items grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoStamping upgrade scripts for LP#818740
Thomas Berezansky [Tue, 9 Aug 2011 18:14:18 +0000 (14:14 -0400)]
Stamping upgrade scripts for LP#818740

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoOrg setting for the result cap for Patron Search
Jason Etheridge [Sun, 31 Jul 2011 05:39:39 +0000 (01:39 -0400)]
Org setting for the result cap for Patron Search

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoFix stop sign page race condition with checkout
Jason Etheridge [Mon, 8 Aug 2011 18:06:57 +0000 (14:06 -0400)]
Fix stop sign page race condition with checkout

This would happen most often when retrieving multiple patrons at the same time
from patron search--the stop sign page would show but then get trampled by the
checkout interface, which normally loads first.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoTell OPAC to use checkin date, not stop_fines date
Thomas Berezansky [Mon, 25 Jul 2011 19:58:40 +0000 (15:58 -0400)]
Tell OPAC to use checkin date, not stop_fines date

The column is labeled "Date Returned", not "Date we stopped generating fines".

This does lead to "(fines accruing)" for an item that has hit max fines, or stopped fines for some other reason.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agousername login for web selfcheck
Jason Etheridge [Mon, 8 Aug 2011 19:22:34 +0000 (15:22 -0400)]
username login for web selfcheck

Changes the behavior for the patron-login component (after staff login) to match
the OPAC.  By default, it assumes you are logging in with a usrname, but if the
org unit setting 'opac.barcode_regex' is enabled and the incoming value matches,
then it gets treated as a library card barcode instead. If usrname is used, then
the card referenced by actor.usr.card is checked in lieu of a specified barcode.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoaction for marking items claimed never checked out
Jason Etheridge [Tue, 2 Aug 2011 03:07:24 +0000 (23:07 -0400)]
action for marking items claimed never checked out

Menu action in Patron Items Out for marking items as Claimed Never Checked Out.
Note that this action behaves differently than Claimed Returned, in that the
item is actually checked in and the transaction closed, and will not continue
to show up in Items Out for the patron.

If decide later to provide an option for making the two actions consistent,
there is code in the original working branch, collab/phasefx/claimed_never_cko,
which modifies the patron display and the .checked_out methods to look for
open CLAIMSNEVERCHECKEDOUT transactions.  Some cleanup would be needed to avoid
merge conflicts.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrade scripts for LP#797409
Mike Rylander [Tue, 9 Aug 2011 17:26:17 +0000 (13:26 -0400)]
Stamped upgrade scripts for LP#797409

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoIgn Reshelving->Available for status_changed_time
Jason Etheridge [Mon, 8 Aug 2011 13:07:40 +0000 (09:07 -0400)]
Ign Reshelving->Available for status_changed_time

This solves a complication when wanting to check status_changed_time against
offline xact_time when processing offline transactions.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoRobustify SKIP_ASSET_CHANGE functionality
Jason Etheridge [Thu, 4 Aug 2011 16:11:49 +0000 (12:11 -0400)]
Robustify SKIP_ASSET_CHANGE functionality

by skipping status_changed_time test if a barcode has been encountered in prior
offline transaction within a given session.  Also return the SKIP_ASSET_CHANGE
event for a given barcode if a prior test resulted in SKIP_ASSET_CHANGE

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoOffline checkin & renewal checks, & ou settings
Jason Etheridge [Thu, 4 Aug 2011 02:32:51 +0000 (22:32 -0400)]
Offline checkin & renewal checks, & ou settings

Augmented edoceo's patch for checking an offline checkout against an item's
Status Changed Time and throwing a SKIP_ASSET_CHANGED event if warranted as
follows:

1) include checkin and renewal transactions
2) add org unit settings for each, and a corresponding upgrade script
3) removed the description from the payload and created a dedicated ils_event

However, there are two issues affecting this functionality, even before my
meddling:

1) the Reshelving -> Available rollover updates an item's Status Changed Time,
   and can thus trigger this event
2) if an item is manipulated more than once in an offline session, then its
   Status Changed Time can be updated as the transactions are being processed,
   causing related transactions after the initial transaction to fail

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#797409: Offline Transaction - Option to Skip Old Records
Atom Edoceo [Tue, 2 Aug 2011 05:54:37 +0000 (22:54 -0700)]
LP#797409: Offline Transaction - Option to Skip Old Records

Skip Copy with later Status Change Time on offline checkout import
Requires the following option in offline-config.pl
  $main::config{skip_late} = 1;

Signed-off-by: David Busby <code@edoceo.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoWhoops. Do that availability test regard of whether hold_boundaries are used.
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 20:01:09 +0000 (16:01 -0400)]
Whoops. Do that availability test regard of whether hold_boundaries are used.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoIn a middle-layer method for returning holdable formats on a metarecord,
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 18:31:03 +0000 (14:31 -0400)]
In a middle-layer method for returning holdable formats on a metarecord,

Do a better test of copy holdability than we were doing previously.
We can't do a perfect test: we don't really know what patron we're doing
this for, and even if we did, from here it's nontrivial to figure out
whether we're doing indb holds or script-based, much less run the tests.

Still, we can test whether a copy's in a holdable status, a holdable
location, and is itself not explicitly marked unholdable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agomrpeters caught this; wrong variable fed to error dialog
Jason Etheridge [Fri, 5 Aug 2011 02:27:45 +0000 (22:27 -0400)]
mrpeters caught this; wrong variable fed to error dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoRepaired copy private/public note vandelay bug
Bill Erickson [Thu, 4 Aug 2011 20:46:54 +0000 (16:46 -0400)]
Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoRevert "remove the unfinished id_as_barcode functionality"
Thomas Berezansky [Thu, 4 Aug 2011 19:25:08 +0000 (15:25 -0400)]
Revert "remove the unfinished id_as_barcode functionality"

This reverts commit 5fa01d69f7374c0c8710db4a951edb80ed5ae733.

Bit too soon, actually. Staff client still uses the function to
verify credentials.

Maybe I skipped this the first time on purpose.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoremove the unfinished id_as_barcode functionality
Jason Etheridge [Sun, 31 Jul 2011 04:01:31 +0000 (00:01 -0400)]
remove the unfinished id_as_barcode functionality

remove the unfinished id_as_barcode setting for open-ils.actor and remove unused open-ils.actor.user.retrieve_id_by_barcode_or_username method

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoStamped upgrade script for ACQ_INVOICE_REOPEN permission addition
Mike Rylander [Thu, 4 Aug 2011 19:10:36 +0000 (15:10 -0400)]
Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUpgrade script for LP818311 branch.
Jason Stephenson [Thu, 4 Aug 2011 14:13:56 +0000 (10:13 -0400)]
Upgrade script for LP818311 branch.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoLP#818311: ACQ_INVOICE_REOPEN is missing
Michael Peters [Thu, 4 Aug 2011 12:59:15 +0000 (08:59 -0400)]
LP#818311:  ACQ_INVOICE_REOPEN is missing

This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFix i18n build
Dan Scott [Fri, 29 Jul 2011 20:09:58 +0000 (16:09 -0400)]
Fix i18n build

Two problems thrown at the i18n build:

  * $$ quoting is not understood by db-seed-i18n.py; simple approach is
    to use standard single-quote escaping of the single-quote in
    950.data.seed-values.sql (warning: this might lead to other problems
    with the regular expression in db-seed-i18n.py)
  * authority.js includes Unicode values (shock!) and so we must treat
    the incoming strings as unicode() instead of plain old str()

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFix staff client Clear Expired Hold Shelf action
Jason Etheridge [Wed, 3 Aug 2011 04:44:41 +0000 (00:44 -0400)]
Fix staff client Clear Expired Hold Shelf action

Accomodate an API change.  FIXME: See if can remove some of the redundant and/or
un-needed data being sent over the wire.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoOnly update MARC on full entry of fixed fields
Thomas Berezansky [Thu, 28 Jul 2011 15:04:36 +0000 (11:04 -0400)]
Only update MARC on full entry of fixed fields

AKA:
Lang is 3 characters long. Entering 1 character would cause focus to leave.
MARC would also update incorrectly.

This only triggers the update when the full 3 characters are entered.

This not only prevents issues with catalogers editing multi-character fixed
fields but also makes it less likely they accidentally corrupt the records.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoStamped upgrade script for schema.circ_holds_history_repairs
Mike Rylander [Thu, 4 Aug 2011 18:36:17 +0000 (14:36 -0400)]
Stamped upgrade script for schema.circ_holds_history_repairs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoRepair holds history func; sort circ history desc.
Bill Erickson [Thu, 4 Aug 2011 17:49:11 +0000 (13:49 -0400)]
Repair holds history func; sort circ history desc.

Update holds history to use oils_json_to_text instead of
oils_json_to_string, which does not exist.

Sort circ history newest to oldest by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:34 +0000 (16:42 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter

9 years agoCast needed
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:17 +0000 (16:42 -0400)]
Cast needed

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoStamped upgrade script for more_cache_visbility_breakage
Mike Rylander [Wed, 3 Aug 2011 17:46:24 +0000 (13:46 -0400)]
Stamped upgrade script for more_cache_visbility_breakage

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUnwrapped upgrade script
Thomas Berezansky [Mon, 25 Jul 2011 20:39:57 +0000 (16:39 -0400)]
Unwrapped upgrade script

for more_cache_visbility_breakage

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoExtraneous semicolons break SQL
Thomas Berezansky [Mon, 25 Jul 2011 20:39:07 +0000 (16:39 -0400)]
Extraneous semicolons break SQL

Remove them so that cache_copy_visibility can function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoFix overzealous template application
Jason Etheridge [Mon, 1 Aug 2011 06:10:15 +0000 (02:10 -0400)]
Fix overzealous template application

The idea was that we'd track templates if they were applied prior to copies
actually being specified in the unified interface, and then apply them "for
real" once copies were entered.  But these remembered templates kept applying
themselves whenever changes were made in the volume/copy creator portion of
the interface (possibly overriding tweaks made by staff).  So now we delete
the list of tracked templates once they're applied to actual copies.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agorobustify (and klunkify) unified volume copy creator
Jason Etheridge [Mon, 1 Aug 2011 05:40:22 +0000 (01:40 -0400)]
robustify (and klunkify) unified volume copy creator

Disable/style the Item Editor while changes in the volume/item pane are being
considered, and require an explicit press of a Ready Item Editor button to
enable the interface.  This reduces the chance of editing widgets in the item
editor from being ripped out from under you (for example, if you try to go
straight from editing a call number to editing an item attribute).

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agolp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for...
Jason Etheridge [Thu, 21 Jul 2011 19:25:28 +0000 (15:25 -0400)]
lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers

Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoThis adds a SAN box to the org unit editor's address editor pane.
James Fournie [Thu, 28 Jul 2011 19:08:18 +0000 (12:08 -0700)]
This adds a SAN box to the org unit editor's address editor pane.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 17:02:30 +0000 (13:02 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoDeleted a line the removed single quotes (') from search strings
Liam Whalen [Wed, 20 Jul 2011 16:49:27 +0000 (12:49 -0400)]
Deleted a line the removed single quotes (') from search strings

The multiclass_query function replaces single quotes with spaces (') ( ).
This causes a problem when toggling between Advanced and Basic search.
If a search is conducted with a ' in it, that quote appears in the
basic search box displayed above the results.  However, if the user
then clicks the 'Advanced' button to toggle to the advanced search
the single quote is missing from the search term.  By removing the line
$query =~ /s/'/ /go; from Biblio.pm this problem is resolved.

Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years ago2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types...
Mike Rylander [Wed, 3 Aug 2011 16:40:42 +0000 (12:40 -0400)]
2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 16:38:24 +0000 (12:38 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoA fix so that the last payment types will be cash_payment and check_payment rather...
Steven Callender [Thu, 28 Jul 2011 19:37:27 +0000 (19:37 +0000)]
A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoQuote container id param for safety
Mike Rylander [Wed, 3 Aug 2011 00:05:53 +0000 (20:05 -0400)]
Quote container id param for safety

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Wed, 3 Aug 2011 00:02:28 +0000 (20:02 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Wed, 3 Aug 2011 00:01:49 +0000 (20:01 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

9 years agoFixed some syntax errors, but getting no results when I'd expect some
Lebbeous Fogle-Weekley [Tue, 2 Aug 2011 21:34:10 +0000 (17:34 -0400)]
Fixed some syntax errors, but getting no results when I'd expect some

I searched with this

    container(bre,bookbag,12,$authtoken)

where $authtoken is substituted with an actual live authtoken for the
user that owns that container, and here is the example generated query
that returns no results:

  SELECT * FROM  search.query_parser_fts(
            4::INT,
            2::INT,
            $core_query_3553$SELECT  m.source AS id,
ARRAY_ACCUM(DISTINCT m.source) AS records,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rel,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rank,
FIRST(mrd.attrs->'date1') AS tie_break
FROM  metabib.metarecord_source_map m
JOIN metabib.record_attr mrd ON (m.source = mrd.id)

JOIN ( SELECT ci.target_biblio_record_entry AS container_item
        FROM  container.biblio_record_entry_bucket_item ci
              JOIN container.biblio_record_entry_bucket c ON (c.id = ci.bucket)

        WHERE c.btype = $_3553$bookbag$_3553$ AND c.id = 12
              AND (c.pub IS TRUE OR c.owner = 1)) container ON (container.container_item = mrd.id)

WHERE 1=1

AND (TRUE)
GROUP BY 1
ORDER BY 4 ASC NULLS LAST, 5 DESC NULLS LAST, 3 DESC
LIMIT 10000
$core_query_3553$::TEXT,
            $${}$$::INT[],
            $${}$$::INT[],
            NULL::INT,
            1000::INT,
            10000::INT,
            'f'::BOOL,
            't'::BOOL
        );

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoRemove craftsman skin.
Joseph Lewis [Tue, 2 Aug 2011 20:41:37 +0000 (14:41 -0600)]
Remove craftsman skin.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Via LP:
https://bugs.launchpad.net/evergreen/+bug/820010

And this email thread:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Tue, 2 Aug 2011 19:01:55 +0000 (15:01 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

9 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoAdd cointainer() and record_list() filters to QueryParser
Mike Rylander [Fri, 22 Jul 2011 19:10:23 +0000 (15:10 -0400)]
Add cointainer() and record_list() filters to QueryParser

The container() filter takes 3 or 4 positional params:
  - class (bre, acn, acp, au)
  - type  (bookbag, etc -- btype of the container)
  - id    (container id)
  - token (authtoken, optional, for checkin ownership of non-public containers)

The record_list() filter takes a list of record ids to restrict the search by.
These are bib ids by default, but are treated as metarecord ids in the presence
of the #metabib (aka #metarecord) modifier.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Tue, 2 Aug 2011 18:39:18 +0000 (14:39 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

9 years agolp758945: make receipt template macros repeatable
Galen Charlton [Tue, 2 Aug 2011 16:20:32 +0000 (12:20 -0400)]
lp758945: make receipt template macros repeatable

Patch from Jason Boyer to allow macros to be used
more than once in a section; prior to this patch, only
the first occurrence was replaced with the substitation
value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Thomas Berezansky [Tue, 2 Aug 2011 16:09:33 +0000 (12:09 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

9 years agoFormat an unordered list appropriately
Dan Scott [Sun, 24 Jul 2011 19:51:38 +0000 (15:51 -0400)]
Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoProvide Fedora-friendly instructions for the DBD libraries
Dan Scott [Thu, 21 Jul 2011 22:39:06 +0000 (18:39 -0400)]
Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoBring more of the wiki docs over to the README
Dan Scott [Thu, 21 Jul 2011 22:35:17 +0000 (18:35 -0400)]
Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoUpdate the README to include database installation instructions
Dan Scott [Thu, 21 Jul 2011 21:39:49 +0000 (17:39 -0400)]
Update the README to include database installation instructions

A long time ago, the database server was installed by default.
Nowadays, installing the database server is a separate step
reserved for whatever machine you want to devote to PostgreSQL.
Not that you can't put it on the same machine as the rest of
Evergreen and OpenSRF...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoFixed typo in vandelay UI
Bill Erickson [Tue, 2 Aug 2011 15:49:03 +0000 (11:49 -0400)]
Fixed typo in vandelay UI

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Bill Erickson [Tue, 2 Aug 2011 15:31:24 +0000 (11:31 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

9 years agoStamped upgrade script for user/miker/replace_field_fix
Bill Erickson [Tue, 2 Aug 2011 15:26:19 +0000 (11:26 -0400)]
Stamped upgrade script for user/miker/replace_field_fix

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoHave replace_field return input XML when no replace rule is provided
Mike Rylander [Tue, 2 Aug 2011 14:55:00 +0000 (10:55 -0400)]
Have replace_field return input XML when no replace rule is provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoMerge branch 'rec_attr_def_config_avoid_cxt_fetch'
Lebbeous Fogle-Weekley [Tue, 2 Aug 2011 15:28:01 +0000 (11:28 -0400)]
Merge branch 'rec_attr_def_config_avoid_cxt_fetch'

9 years agoAvoid xml_transform retrieval in record attr def editor
Bill Erickson [Mon, 1 Aug 2011 18:09:23 +0000 (14:09 -0400)]
Avoid xml_transform retrieval in record attr def editor

config.xml_transform stores large chunks of XML.  Fetching it angers
Ejabberd on my test system.  All we need is the name, so use the new
AutoFieldWidget.searchOptions param to do just that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoAdd the new patron retrieval to the toolbar
Thomas Berezansky [Tue, 2 Aug 2011 15:11:26 +0000 (11:11 -0400)]
Add the new patron retrieval to the toolbar

Specifically, in the little list of things that shows up when you use the arrow next to patron search.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoLabel tweaks re: Database ID vs Record ID, etc.
Jason Etheridge [Sun, 31 Jul 2011 04:42:05 +0000 (00:42 -0400)]
Label tweaks re: Database ID vs Record ID, etc.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoAdd "Retrieve patron via Database ID" menu entry
Jason Etheridge [Sun, 31 Jul 2011 04:33:31 +0000 (00:33 -0400)]
Add "Retrieve patron via Database ID" menu entry

Add "Retrieve patron via Database ID" menu entry to top-level Search menu

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agocalculate penalties when letting Mark Item Damaged add bills
Jason Etheridge [Thu, 14 Jul 2011 21:21:52 +0000 (17:21 -0400)]
calculate penalties when letting Mark Item Damaged add bills

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoFix oils_i18n_gettext id numbers
Thomas Berezansky [Tue, 2 Aug 2011 13:37:24 +0000 (09:37 -0400)]
Fix oils_i18n_gettext id numbers

config.metabib_field ids 29/30 had 28 for translation id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
9 years agoAutoFieldWidget support for augmenting pcrud search options
Bill Erickson [Mon, 1 Aug 2011 18:04:24 +0000 (14:04 -0400)]
AutoFieldWidget support for augmenting pcrud search options

Adds a new searchOptions attribute to AutoFieldWidget for specifying
additional parameters to pcrud when retrieving linked objects.  The
initial use case is for supporting a "select" list to allow
AutoFieldWidget to retrieve only the display column of a linked object
and not the whole object.

Example:

 // fetch 'remote_field_name' on the remote objects instead of
 // fetching the entire object

 myGrid.overrideWidgetArgs.some_field = {searchOptions :
 {"select":{"some_hint":["remote_field_name"]}}};

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agouse isNaN here, since NaN == NaN => false
Jason Etheridge [Sun, 31 Jul 2011 05:08:07 +0000 (01:08 -0400)]
use isNaN here, since NaN == NaN => false

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
9 years agoFix broken builds due to test that can't find its data
Dan Scott [Thu, 28 Jul 2011 19:49:12 +0000 (15:49 -0400)]
Fix broken builds due to test that can't find its data

LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
9 years agoMake users confirm they really want to delete lineitems from POs...
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 18:17:44 +0000 (14:17 -0400)]
Make users confirm they really want to delete lineitems from POs...

... when they've already been ordered. There's really no reason to ever
make such a deletion this that I can think of, but I use a confirm()
instead of stricter measures in case I'm missing something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
9 years agoStamped upgrade for user/dbs/oclcnumbers
Bill Erickson [Thu, 28 Jul 2011 16:34:28 +0000 (12:34 -0400)]
Stamped upgrade for user/dbs/oclcnumbers

Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoPrevent control numbers from duplicating
Dan Wells [Thu, 21 Jul 2011 16:14:02 +0000 (12:14 -0400)]
Prevent control numbers from duplicating

In maintain_control_numbers(), if you have more than one 001 or
003, and at least one is the correct one, you will end up
duplicating the correct number every time the record is saved.

For example, if the incoming record was record ID # 12345, and
the record contained:

001: 12345
001: ocm10202

... then after maintain_control_numbers() ran, the record would
contain:

001: 12345
001: 12345

Also, clean up some leftovers from the refactor I suggested in the
previous commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
9 years agoAdd an unwrapped upgrade script for OCLC-aware control numbers
Dan Scott [Thu, 21 Jul 2011 15:12:36 +0000 (11:12 -0400)]
Add an unwrapped upgrade script for OCLC-aware control numbers

The upgrade script creates the SCN and LCCN search indexes and
populates them using metabib.full_rec as a source; cheating, but
the normalized values will work for non-exact search purposes. Sites can
reingest all of their bibs if they want exact search to work.

Also, refactor maintain_control_numbers() using a suggestion by
Dan Wells to eliminate some duplicate code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoTreat OCLC numbers specially in maintain_control_numbers
Dan Scott [Thu, 21 Jul 2011 14:18:55 +0000 (10:18 -0400)]
Treat OCLC numbers specially in maintain_control_numbers

For some reason, many records that come with OCLC numbers in the 001
field are not populated with a 003 field. This resulted in the OCLC
number being thrown away entirely, rather than being moved into the 035,
as there was no corresponding control number identifier field.

However, given that we know that control numbers starting with "ocm" or
"ocn" are special OCLC numbers, we can generate the 035 accordingly even
in the absence of a 003. This update to maintain_control_numbers()
teaches it to do the right thing for OCLC numbers.

In addition, add an identifier search index so we can easily find
records by their system control numbers (035 $a subfields).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
9 years agoRevert "Add lccn field to the identifier search class"
Bill Erickson [Thu, 28 Jul 2011 16:28:23 +0000 (12:28 -0400)]
Revert "Add lccn field to the identifier search class"

This change will be absorbed when merging working/user/dbs/oclcnumbers,
which I will do pronto...

This reverts commit 94f69d21b6759dc43c151c7796dafee74083f62c.

9 years agoAdd lccn field to the identifier search class
Lebbeous Fogle-Weekley [Thu, 28 Jul 2011 16:09:01 +0000 (12:09 -0400)]
Add lccn field to the identifier search class

Facilitates easily searching by LCCN (010 ‡a).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>